deserializer 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16497e6608bbeeb126c16fbb2040022ef43c2a2e
-  data.tar.gz: de87e7fd93f070278c1b0e3672edbc4363be0560
+  metadata.gz: 016e23ff6b54642bf58daea3210e2ed45011170b
+  data.tar.gz: e897dd40e6b336374169440965eee92f2496e0a9
 SHA512:
-  metadata.gz: b0c1582c067f86f892705e7b7fd73f7ae42dc548354a22170c36b64868febc22a27cba2d306f0130f177062ceb84f548028900d7bb2a086c7be19ec953e7b0ae
-  data.tar.gz: 4883819b21807f2915d8887688786aa3f0aecdaa8c411b750e482e6db14ca8e2a68ea041848424a86a9253b6d885902a4db8e881b4ba43beed332b094226543d
+  metadata.gz: 66afd6278382e72c8f925be8c05b4fc330c9886714de2860a82915212a1a76df6c72d200c10e0c9c4fa16fdb4005c065f540b45f70328d9f6b12d777da4d239f
+  data.tar.gz: cbe4496605fa6a1b9b1f37caf0affadeade2d833df2e857ff6c30c5158a1e14a616100adc84e79cb25b0807b2d09b803d72d988af7fab1efa4163159fa874f62

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    deserializer (0.1.0)
+    deserializer (0.2.0)
 
 GEM
   remote: https://rubygems.org/

data/lib/deserializer/base.rb

@@ -8,14 +8,14 @@ module Deserializer
       def attributes(*attrs)
         self.attrs ||= {}
         attrs.each do |attr|
-          self.attrs[attr] = attr
+          self.attrs[attr] = {attr: attr, options: {}}
         end
       end
 
       def attribute(attr, options = {})
         self.attrs ||= {}
         key = options.fetch(:key, attr)
-        self.attrs[key] = attr
+        self.attrs[key] = {attr: attr, options: options}
       end
 
       def has_one( target, opts = {})
@@ -25,7 +25,7 @@ module Deserializer
           raise DeserializerError, class: self, message: "has_one associations need a deserilaizer" 
         end
 
-        self.attrs[target] = deserializer
+        self.attrs[target] = {attr: nil, deserializer: deserializer}
       end
 
       def has_many(*args)
@@ -56,10 +56,13 @@ module Deserializer
         next unless params.has_key? param_key
 
         # this checks if the object_key is a class that inherits from Deserializer
-        if object_key.is_a?(Class) && object_key < Deserializer::Base
-          deseralize_nested(param_key, object_key)
+        if object_key[:deserializer]
+          deseralize_nested(param_key, object_key[:deserializer])
         else
-          object[object_key] = params[param_key]
+          attribute = object_key[:attr]
+          options   = object_key[:options]
+
+          assign_value attribute, params[param_key], options
         end
       end
       object
@@ -94,5 +97,21 @@ module Deserializer
 
       deserializer.new( target, params[association] ).deserialize
     end
+
+    def assign_value( attribute, value, options = {} )
+      if options[:ignore_empty] && empty?(value)
+        return
+      # other options go here
+      else
+        self.object[attribute] = value
+      end
+    end
+
+    def empty?(value)
+      !value ||
+      value == "" ||
+      value == {} ||
+      value == []
+    end
   end
 end

data/lib/deserializer/version.rb

@@ -1,3 +1,3 @@
 module Deserializer
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

data/test/lib/{deserializers/deserializers.rb → deserializers.rb}

@@ -15,6 +15,14 @@ class VanillaHasOneDeserializer < Deserializer::Base
   
 end
 
+class EmptiableAttributeDeserializer < Deserializer::Base
+  attribute :emptiable, ignore_empty: true
+  attribute :nonemptiable, ignore_empty: false
+  
+  attribute :emptiable_with_key,  ignore_empty: true, key: :empty
+  attribute :nonemptiable_with_key,  ignore_empty: false, key: :non_empty
+end
+
 class HasOneWithTargetDeserializer < Deserializer::Base
   attribute   :internal, key: :external
 

data/test/unit/deserializer_test.rb

@@ -44,6 +44,30 @@ class DeserializerTest < Minitest::Test
     assert_equal 6, AttributeDeserializer.from_params( @params )[:user_id]
   end
 
+  def test_ignore_empty_option
+    d = EmptiableAttributeDeserializer
+    
+    assert_equal ({ emptiable: true }), d.from_params( emptiable: true )
+    assert_equal ({ nonemptiable: true }), d.from_params( nonemptiable: true )
+
+    [false, nil, "", [], {}].each do |empty_value|
+      assert_equal ({}), d.from_params( emptiable: empty_value )
+      assert_equal ({ nonemptiable: empty_value }), d.from_params( nonemptiable: empty_value )
+    end
+  end
+
+  def test_ignore_empty_with_key
+    d = EmptiableAttributeDeserializer
+    
+    assert_equal ({ emptiable_with_key: true }), d.from_params( empty: true )
+    assert_equal ({ nonemptiable_with_key: true }), d.from_params( non_empty: true )
+
+    [false, nil, "", [], {}].each do |value|
+      assert_equal ({}), d.from_params( key: value )
+      assert_equal ({ nonemptiable_with_key: value }), d.from_params( non_empty: value )
+    end
+  end
+
   def test_undefined_params_dont_come_through
     assert_equal nil, AttributeDeserializer.from_params( @params )[:i_shouldnt_be_here]
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: deserializer
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Greg Orlov
@@ -57,7 +57,7 @@ files:
 - lib/deserializer/base.rb
 - lib/deserializer/deserializer_error.rb
 - lib/deserializer/version.rb
-- test/lib/deserializers/deserializers.rb
+- test/lib/deserializers.rb
 - test/minitest_helper.rb
 - test/unit/deserializer_error_test.rb
 - test/unit/deserializer_test.rb
@@ -86,7 +86,7 @@ signing_key:
 specification_version: 4
 summary: deserialization
 test_files:
-- test/lib/deserializers/deserializers.rb
+- test/lib/deserializers.rb
 - test/minitest_helper.rb
 - test/unit/deserializer_error_test.rb
 - test/unit/deserializer_test.rb