derobo-ofdb 0.0.1 → 0.0.2

data/lib/ofdb.rb

@@ -4,9 +4,10 @@ require 'rubygems'
 require 'hpricot'
 
 require 'ofdb/string_extensions'
-require 'ofdb/movies'
+require 'ofdb/movie'
 require 'ofdb/search'
 
 module Ofdb
-  VERSION = '0.0.1'
+  #current Version of the module
+  VERSION = '0.0.2'
 end

data/lib/ofdb/movie.rb

@@ -3,10 +3,32 @@ module Ofdb
   #This Class is Lazy-Load, means that the Pages are only loaded when needed. Also the data mining
   #is only done when needed
   class Movie
+    #holds the title of this movie
     attr_reader :title
-    def initialize(name)
-      @name = name
-      @url = "http://www.ofdb.de/film/#{@name}"
+    #holds the "ofdb-id"
+    attr_reader :name
+    #holds the url of the poster
+    attr_reader :poster
+
+    # Takes a IMDB-ID and call a serch with Ofdb::Search
+    # If the serch returns exactly 1 Movie then this Movie is return, else nil
+    def Movie.build_from_imdb(id)
+      search = Ofdb::Search.new(id, true)
+      return search.movies.first if search.movies.size == 1
+      nil
+    end
+
+    # Take a link to a Ofdb-page of a Movie and builds the +Ofdb::Movie+
+    # The full link isn't require, e.g. for +"http://www.ofdb.de/film/1050,Pulp-Fiction"+ only
+    # +"1050,Pulp-Fiction"+ is required.
+    def initialize(ofdb_link)
+      if ofdb_link =~ /http:\/\/www.ofdb.de\/film/
+        @name = ofdb_link.gsub("http:\/\/www.ofdb.de\/film")
+        @url = ofdb_link
+      else
+        @name = ofdb_link
+        @url = "http://www.ofdb.de/film/#{@name}"
+      end
       @title = /\d,/.match(name).post_match.gsub("---","§§§").gsub("-", " ").gsub("§§§", " - ")
     end
 
@@ -32,10 +54,15 @@ module Ofdb
     #Returns a URL to the Poster
     def poster
       document.search('img[@src^="http://img.ofdb.de/film/"]').each do |x|
-        return x.get_attribute("src").to_s
+        return @poster = x.get_attribute("src").to_s
       end
     end
 
+    #Sets the poster to a URL
+    def poster=(poster)
+      @poster = poster
+    end
+
     #Returns a Array containg the Genres
     def genre
       get_viewphp("page=genre&Genre=").map {|x|  x.innerHTML }
@@ -54,9 +81,11 @@ module Ofdb
     private
     # Returns a new Hpricot document for parsing.
     def document
-      @document ||= Hpricot(Ofdb::Movie.find_by_id(@url))
+      @document ||= Hpricot(open(@url))
     end
 
+    # Returns a php snipped for a link to "view.php?..." as an Array
+    # The Result-Array is only filled with links matching the filter
     def get_viewphp(filter=nil)
       rsl = Array.new
       document.search('font.Daten a[@href^="view.php"').each do |x|
@@ -65,9 +94,6 @@ module Ofdb
       end
       rsl
     end
-
-    def self.find_by_id(url)
-      open(url)
-    end
+    
   end
 end

data/lib/ofdb/search.rb

@@ -1,9 +1,11 @@
 module Ofdb
   class Search
+    require 'cgi'
+    # holds the current search String
     attr_reader :query
     #Uses query as Searchstring
     #
-    #   search = Ofdb::Search.new("Das Leben des Brains")
+    #   search = Ofdb::Search.new("The Matrix")
     #
     # Ofdb::Search ist lazy loading.
     def initialize(query, is_imdb_id=false)
@@ -11,23 +13,23 @@ module Ofdb
       @query = query
     end
 
-    # Returns the Searchresults as Array of Hashes with
-    #* :link => Url in Ofdb.de of that movie
-    #* :title => String like: $Germantitle / $OrignialTitle ($Year)
-    #* :poster => Url of the Poster, nil if not found
+    # Returns the Result of the Search as an Array of Ofdb::Movie
     def movies
       @movies ||= parse_movies
     end
 
     private
+    # Returns the Hpricot::Document of the Website
     def document
       @document ||= Hpricot(Ofdb::Search.query(@query, @is_imdb))
     end
 
+    # Does the query an the ofdb.de an returns the results html
     def self.query(query, imdb=false)
       open("http://www.ofdb.de/view.php?page=suchergebnis&SText=#{CGI::escape(query)}#{"&Kat=IMDb" if imdb}")
     end
 
+    # extracts all the results
     def parse_movies
       return @movies if @movies
       @movies = Array.new
@@ -36,7 +38,9 @@ module Ofdb
         title = element.innerHTML.imdb_strip_tags
         poster = /images\/film\/.*"\sw/.match(element.get_attribute('onmouseover')).to_s.gsub("\" w","").gsub("images/film/", "")
         poster = nil if poster =="na.gif"
-        @movies << {:link => link, :title => title, :poster=>poster}
+        mov = Ofdb::Movie.new(link)
+        mov.poster = poster if poster
+        @movies << mov
       end
       @movies
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: derobo-ofdb
 version: !ruby/object:Gem::Version 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - deRobo