deprecool 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e52876064a919fd936c1ce856a936497321260b30bb28d4af9583f1c4f408b2f
-  data.tar.gz: e2f181b5779334b951ab52f209533608d565764a09d9633c22bcc282ff604b04
+  metadata.gz: 959b5cdb23ec0d5eef80f87185fb7a31a5646cf991cced0030d4d839fb835906
+  data.tar.gz: 87eac39b80c35af2e3bc868ab99b03d534f46f06e0f6ef6945381e5d00e8798b
 SHA512:
-  metadata.gz: 2054d49032593500337f9f406c298852b0fb11b03e745217c0ebdda4d5e26aa89ea06ed9d84855269a7c1079d38c09a6bb27fd5ac5a35b9138ac626f2fc0db72
-  data.tar.gz: f5014e5d52b173c5071f5622d892fc72783cbf61585cbed8d8a6845994ec704db0f3152055d2ae1074988b8be0331cac04134c73d797b6b8bc05c4dcdab7af34
+  metadata.gz: d6da4e681409697beeaad714e669ad6854000a66a9086a8bf593ded61016e3741beb5147d616a42d99c3e19b3d51ad886f432d056ba58db2e56a559b0188ae87
+  data.tar.gz: cd41a34a6787fb74f7985e9180893d46a765a19d369b90c09d23738a378ee645bce9d02109fda4e7806195f82bc94f9b0d2ac300ec6c69bf6d0ccb65c9e41e9a

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Deprecool
 
-## [0.1.0] - 2026-08-13
+## [0.1.2] - 2026-08-14
+
+- Add Finder for Rails's deprecation of `write_attribute(:id, value)`
+
+## [0.1.0], [0.1.1] - 2026-08-13
 
 - Initial Release

data/README.md

@@ -6,7 +6,8 @@ A helpful tool for any developer who has ever ignored a gem's warning and then r
 
 ## Usage
 
-Add to your Gemfile: `gem 'deprecool'`
+Add to your Gemfile: `gem 'deprecool'`, and `bundle install`
+
 Or directly `gem install deprecool`
 
 Then you can run `deprecool` in the command line to get:

data/lib/deprecool/finders/rails/v7.1.0/serializer_positional_class_argument.rb

@@ -25,11 +25,10 @@ module Deprecool
 
           def on_call_node(node)
             return unless node.name == :serialize
+            return unless arguments_are_length(node.arguments, 2)
+            return unless unwrap_arguments(node.arguments)[1].is_a?(Prism::ConstantReadNode)
 
-            arguments_array = unwrap_arguments(node.arguments)
-            return unless arguments_array && arguments_array[1]
-
-            add_offense(node, confidence: :high) if arguments_array[1].is_a?(Prism::ConstantReadNode)
+            add_offense(node, confidence: :high)
           end
         end
       end

data/lib/deprecool/finders/rails/v8.2.0/to_sql_binds.rb

@@ -7,7 +7,7 @@ module Deprecool
         class ToSqlBinds < Deprecool::Finder
           gem           :rails
           deprecated_in '8.2.0'
-          removed_in    '8.3.0'
+          removed_in    '9.0.0'
           title         'Passing "binds" into "to_sql" is deprecated'
           summary       'Since Rails 5.2, bind parameters live on the Arel AST ' \
                         'to_sql_and_binds no longer uses binds for SQL construction, ' \
@@ -26,9 +26,7 @@ module Deprecool
             # if a method called 'to_sql' is passed two arguments and the second is an
             # array that's probably good enough
             return unless node.name == :to_sql
-
-            arguments_array = unwrap_arguments(node.arguments)
-            return unless arguments_array && arguments_array[1]
+            return unless arguments_are_length(node.arguments, 2)
 
             add_offense(node, confidence: :high)
           end

data/lib/deprecool/finders/rails/v8.2.0/write_attribute_id.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+
+module Deprecool
+  module Finders
+    module Rails
+      module V8_2_0
+        class WriteAttributeId < Deprecool::Finder
+          gem           :rails
+          deprecated_in '8.2.0'
+          removed_in    '9.0.0'
+          title         'Using "write_attribute" for the primary key is deprecated'
+          summary       'Just like Rails 7.1\'s deprecation of calling "read_attribute(:id)", '\
+                        '"write_attribute(:id)" is now deprecated and will be removed in the next version of Rails. ' \
+                        'making :id refer only to the id column, not the primary key.'
+          suggestion    'Use "#id=" on a model whose primary key is not named "id"'
+          reference     'Original Rails Commit: https://github.com/rails/rails/commit/1a90632bbe62dae2626de7a058bc18c29f77aea6'
+          effort        :low
+
+          def on_call_node(node)
+            return unless node.name == :write_attribute
+            return unless arguments_are_length(node.arguments, 2)
+            return unless arguments_contain(node.arguments, "id", position: 0)
+
+            add_offense(node, confidence: :high)
+          end
+        end
+      end
+    end
+  end
+end

data/lib/deprecool/helpers/prism_helpers.rb

@@ -36,4 +36,28 @@ module PrismHelpers
 
     node.child_nodes
   end
+
+  def arguments_are_length(node, length)
+    return false unless node.is_a?(Prism::ArgumentsNode)
+
+    unwrap_arguments(node.arguments).length == length
+  end
+
+  def arguments_contain(node, value, position: -1, kwarg: nil)
+    return false unless node.is_a?(Prism::ArgumentsNode)
+
+    arguments = unwrap_arguments(node)
+
+    return (value_from_argument(arguments[position]) == value) if position >= 0
+
+    arguments.any? do |arg|
+      value_from_argument(arg) == value
+    end
+  end
+
+  def value_from_argument(node)
+    case node
+    when Prism::SymbolNode, Prism::StringNode then node.unescaped
+    end
+  end
 end

data/lib/deprecool/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Deprecool
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: deprecool
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Zac Radford
@@ -58,6 +58,7 @@ files:
 - lib/deprecool/finders/rails/v7.1.0/serializer_positional_class_argument.rb
 - lib/deprecool/finders/rails/v8.2.0/redis_cache_store_default_redis_options.rb
 - lib/deprecool/finders/rails/v8.2.0/to_sql_binds.rb
+- lib/deprecool/finders/rails/v8.2.0/write_attribute_id.rb
 - lib/deprecool/finders/ruby/v4.0.0/object_space_id2ref.rb
 - lib/deprecool/finders/ruby/v4.0.0/to_set_arguments.rb
 - lib/deprecool/helpers/prism_helpers.rb