deprecation_toolkit 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14622e99341958cb8876efa74036f9f90eb27c77f10e24e59b3261c62d5c8b31
-  data.tar.gz: ea63088375c2c5c1010b267f38bf1b8acbc0e363bdd3cf33d4c6d762e47704bb
+  metadata.gz: fde00ef2d6a1a6467342fbeee9f13a947a50674393038576f9070959d7e070f5
+  data.tar.gz: ef19a93dddd89dd5e310f51ef5905e1f15f4d9e582553f7d43c5392e58efa298
 SHA512:
-  metadata.gz: bf5adecd962fd27a18c223c5852552b52a601230827cd761488ae7d62a8a745f013a62fc57d6ffba2b67c989e9c6cfb9436f76046d5b3159e5ac48d9aeb9f191
-  data.tar.gz: e51874283d799826c161c52ce091597c60b1583521d8e63b57341c61064241710611dd41aa7d4adbd7db2ef17a26e5ac0c5adb41920f1b04ca8fd86a9add4153
+  metadata.gz: 40ef637cd030aed50b46fbc4f411481a1c77194cac39e2f51469559179963d466fe56c3d0612628b4f9b395c16648bb9d316c56e04878e7fd11110338c0d88a8
+  data.tar.gz: 6ca939bf15e3b43f5accf7e0e888403c1c8ef9c3ce8850e87260ff140550eeab94f4b31381a37f0de7a7cb024d8c43e94276573778f9d31f012fb34b3c595a92

data/.rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml

@@ -1,9 +1,8 @@
-# Recommended rubocop version: ~> 0.56.0
-
 AllCops:
   Exclude:
   - 'db/schema.rb'
   DisabledByDefault: true
+  StyleGuideBaseURL: https://shopify.github.io/ruby-style-guide/
 
 Layout/AccessModifierIndentation:
   EnforcedStyle: indent
@@ -102,7 +101,7 @@ Style/ClassCheck:
   - kind_of?
 
 Style/CommandLiteral:
-  EnforcedStyle: backticks
+  EnforcedStyle: percent_x
   SupportedStyles:
   - backticks
   - percent_x
@@ -259,6 +258,19 @@ Style/Next:
 Style/NonNilCheck:
   IncludeSemanticChanges: false
 
+Style/MethodCallWithArgsParentheses:
+  Enabled: true
+  IgnoreMacros: true
+  IgnoredMethods:
+  - require
+  - require_relative
+  - require_dependency
+  - yield
+  - raise
+  - puts
+  Exclude:
+  - Gemfile
+
 Style/MethodDefParentheses:
   EnforcedStyle: require_parentheses
   SupportedStyles:
@@ -1110,6 +1122,9 @@ Performance/RedundantMatch:
 Performance/RedundantSortBy:
   Enabled: true
 
+Performance/RegexpMatch:
+  Enabled: true
+
 Performance/ReverseEach:
   Enabled: true
 
@@ -1136,6 +1151,9 @@ Rails/HttpPositionalArguments:
   - spec/**/*
   - test/**/*
 
+Rails/InverseOf:
+  Enabled: true
+
 Rails/OutputSafety:
   Enabled: true
 

data/.rubocop.yml

@@ -3,3 +3,10 @@ inherit_from:
 
 AllCops:
   TargetRubyVersion: 2.3
+  Exclude:
+    - gemfiles/vendor/**/*
+
+Style/MethodCallWithArgsParentheses:
+  Exclude:
+    - Gemfile
+    - gemfiles/*

data/.travis.yml

@@ -12,5 +12,8 @@ gemfile:
   - gemfiles/activesupport_5.0.gemfile
   - gemfiles/activesupport_5.1.gemfile
   - gemfiles/activesupport_5.2.gemfile
+script:
+  - bundle exec rubocop --config .rubocop.yml
+  - bundle exec rake test
 notifications:
   email: false

data/CHANGELOG.md

@@ -2,6 +2,11 @@
 
 ## master (unreleased)
 
+## 1.2.1 (2019-01-09)
+
+### Bug fixes
+* [#34](https://github.com/Shopify/deprecation_toolkit/pull/34): Fixes SystemStackError with RubyGems v3 and Ruby 2.5+. (@dylanahsmith)
+
 ## 1.2.0 (2018-11-28)
 
 ### New features

data/Gemfile.lock

@@ -1,20 +1,20 @@
 PATH
   remote: .
   specs:
-    deprecation_toolkit (1.2.0)
+    deprecation_toolkit (1.2.1)
       activesupport (>= 4.2)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (5.2.1.1)
+    activesupport (5.2.2)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
       tzinfo (~> 1.1)
     ast (2.4.0)
-    concurrent-ruby (1.1.3)
-    i18n (1.1.1)
+    concurrent-ruby (1.1.4)
+    i18n (1.5.1)
       concurrent-ruby (~> 1.0)
     jaro_winkler (1.5.1)
     minitest (5.11.3)
@@ -43,11 +43,11 @@ PLATFORMS
   ruby
 
 DEPENDENCIES
-  bundler (~> 1.16)
+  bundler (>= 1.16)
   deprecation_toolkit!
   minitest (~> 5.0)
   rake
   rubocop
 
 BUNDLED WITH
-   1.17.1
+   1.17.3

data/Rakefile

@@ -10,4 +10,4 @@ Rake::TestTask.new(:test) do |t|
   t.test_files = FileList["test/**/*_test.rb"]
 end
 
-task default: :test
+task(default: :test)

data/deprecation_toolkit.gemspec

@@ -20,14 +20,14 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.3'
 
-  spec.files = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = %x(git ls-files -z).split("\x0").reject do |f|
     f.match(%r{^(test)/})
   end
   spec.require_paths = %w(lib)
 
-  spec.add_runtime_dependency 'activesupport', '>= 4.2'
+  spec.add_runtime_dependency('activesupport', '>= 4.2')
 
-  spec.add_development_dependency "bundler", "~> 1.16"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "minitest", "~> 5.0"
+  spec.add_development_dependency("bundler", ">= 1.16")
+  spec.add_development_dependency("rake", "~> 10.0")
+  spec.add_development_dependency("minitest", "~> 5.0")
 end

data/lib/deprecation_toolkit.rb

@@ -25,7 +25,7 @@ module DeprecationToolkit
     return if DeprecationSubscriber.already_attached?
 
     Configuration.attach_to.each do |gem_name|
-      DeprecationSubscriber.attach_to gem_name
+      DeprecationSubscriber.attach_to(gem_name)
     end
   end
 end

data/lib/deprecation_toolkit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeprecationToolkit
-  VERSION = "1.2.0"
+  VERSION = "1.2.1"
 end

data/lib/deprecation_toolkit/warning.rb

@@ -10,18 +10,7 @@ module DeprecationToolkit
   end
 end
 
-# Warning is a new feature in ruby 2.5
-module Warning
-  def warn(str)
-    if DeprecationToolkit::Warning.deprecation_triggered?(str)
-      ActiveSupport::Deprecation.warn(str)
-    else
-      super
-    end
-  end
-end
-
-# Support for version older < 2.5
+# Warning is a new feature in ruby 2.5, so support older versions
 # Note that the `Warning` module exists in Ruby 2.4 but has a bug https://bugs.ruby-lang.org/issues/12944
 if RUBY_VERSION < '2.5.0' && RUBY_ENGINE == 'ruby'
   module Kernel
@@ -44,4 +33,17 @@ if RUBY_VERSION < '2.5.0' && RUBY_ENGINE == 'ruby'
       Kernel.warn(messages)
     end
   end
+else
+  module DeprecationToolkit
+    module WarningPatch
+      def warn(str)
+        if DeprecationToolkit::Warning.deprecation_triggered?(str)
+          ActiveSupport::Deprecation.warn(str)
+        else
+          super
+        end
+      end
+    end
+  end
+  Warning.singleton_class.prepend(DeprecationToolkit::WarningPatch)
 end

data/lib/minitest/deprecation_toolkit_plugin.rb

@@ -4,7 +4,7 @@ module Minitest
   extend self
 
   def plugin_deprecation_toolkit_options(opts, options)
-    opts.on "-r", "--record-deprecations", "Record deprecations" do
+    opts.on("-r", "--record-deprecations", "Record deprecations") do
       options[:record_deprecations] = true
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deprecation_toolkit
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-28 00:00:00.000000000 Z
+date: 2019-01-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -28,14 +28,14 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.16'
 - !ruby/object:Gem::Dependency