deprecation_toolkit 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: be80ca28201896a87295673cc5baa19c594b5c7e
-  data.tar.gz: c3ca846545109f529196299957bba02634003dd9
+  metadata.gz: 0e89ce8cb136347a903186eec658e92f2d3e9719
+  data.tar.gz: 3282ad364e252d30856de442883c7e10d5ad6c36
 SHA512:
-  metadata.gz: 163dc7b2d6d19f339f5a8a38f4eca5088e65555e73b349df1e32644beed2523ca5793062c4efb8b93fa9c3363cd3ff3884b8c6bf1812bbfc56cff5a5cbd7e7d0
-  data.tar.gz: fc9a5a4db503e157daeb3ddfcd855eec86ccc013515f76498d98a3322f28486546523a1b84c5e2a9ff45dd0ba932b0c6166870ae24d76359df818153006e03d1
+  metadata.gz: 48696cf7330bc5df5ef56bdbc96295fbb22a7477d6375389d5fe2ffde30510a05f6af450ed7b7b080f3ebe0634e11e4328a797e14e287d0ff25c5c026318cf38
+  data.tar.gz: f2d5a3e940f779eba10f86383ee51fe1415561e8ac57fd44bb27be842706456ff4e5372331136e69c418184a67f1fe6e0ea93b17b4099e384f993d2ae201c67d

data/.travis.yml

@@ -0,0 +1,11 @@
+sudo: false
+cache: bundler
+language: ruby
+before_install:
+  - gem update bundler
+rvm:
+  - 2.3
+  - 2.4
+  - 2.5
+notifications:
+  email: false

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    deprecation_toolkit (1.0.0)
+    deprecation_toolkit (1.0.1)
       activesupport (>= 5.0)
 
 GEM

data/lib/deprecation_toolkit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module DeprecationToolkit
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/deprecation_toolkit/warning.rb

@@ -2,25 +2,40 @@
 
 module DeprecationToolkit
   module Warning
-    def warn(str)
-      if DeprecationToolkit::Configuration.warnings_treated_as_deprecation.any? { |warning| warning =~ str }
-        ActiveSupport::Deprecation.warn(str)
-      else
-        super
-      end
+    extend self
+
+    def deprecation_triggered?(str)
+      DeprecationToolkit::Configuration.warnings_treated_as_deprecation.any? { |warning| warning =~ str }
     end
   end
 end
 
-Warning.singleton_class.prepend(DeprecationToolkit::Warning)
+# Warning is a new feature in ruby 2.5
+module Warning
+  def warn(str)
+    if DeprecationToolkit::Warning.deprecation_triggered?(str)
+      ActiveSupport::Deprecation.warn(str)
+    else
+      super
+    end
+  end
+end
 
-# https://bugs.ruby-lang.org/issues/12944
-if RUBY_VERSION <= '2.5.0' && RUBY_ENGINE == 'ruby'
+# Support for version older < 2.5
+# Note that the `Warning` module exists in Ruby 2.4 but has a bug https://bugs.ruby-lang.org/issues/12944
+if RUBY_VERSION < '2.5.0' && RUBY_ENGINE == 'ruby'
   module Kernel
-    remove_method :warn
+    alias_method :__original_warn, :warn
 
     def warn(*messages)
-      Array(messages.flatten).each { |msg| Warning.warn(msg) }
+      message = messages.join("\n")
+      message += "\n" unless message.end_with?("\n")
+
+      if DeprecationToolkit::Warning.deprecation_triggered?(message)
+        ActiveSupport::Deprecation.warn(message)
+      else
+        __original_warn(messages)
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deprecation_toolkit
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Shopify
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-09 00:00:00.000000000 Z
+date: 2018-07-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -76,6 +76,7 @@ files:
 - ".gitignore"
 - ".rubocop-https---shopify-github-io-ruby-style-guide-rubocop-yml"
 - ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt