deprecation_collector 0.7.0 → 0.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 26bc69b0016762d0f5e8546f48177a7b2d90334bc8f4c995853c51e814386731
-  data.tar.gz: d059f4d6985f9136305160d0e0a6ffe184a6ac1a927e31959241e525974d78ea
+  metadata.gz: 81d6dd372292acd1a8e2fcddc6ed4ca2f8f2d4ab73f9894318ba26067e96a8a0
+  data.tar.gz: c4884163cbc574b1ce86d4a799c51507b88e2dbaa2f1c720c1d7362e1e39e7c0
 SHA512:
-  metadata.gz: 7a4609b79edbf7f54aa11538a7201595951ced8194d2a65fd01f4ef9be21cc75719fb27c1e0debbfcad5be2fc5407a9e8a04a6b398e7af2bc19c196461017437
-  data.tar.gz: 70f742f7dbd0525ee444c5aa076ccd241f1b8b5acd7c20a10b8778e838a40b3ba383dffd2b58b8776da6bc978583775f16104e89db5d1f1746bfe03e6e1ef8a3
+  metadata.gz: 9d17b36f5eee269337f20ca2901db6fb12f59d4fedc6a440be878e05956b742c69da0169ada8f89cd86e9d003e8a58421b00b18a767f23ce43ab0f17071aa0c4
+  data.tar.gz: a9902de9301144e6ed222eb786d32f1a13c3f504598d0dcc9d7479876c8fe0df566df1d6dc22af5695027c09231e360b72fbf9230632aacc9bd83656e08918e3

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+== 0.7.2
+- fix error `undefined method instance_of? for Redis::Future` for redis < 5
+
+== 0.7.1
+- fix ruby 2.7 on rails 7.1
+
 == 0.7.0
 - support for Rails 7.1
 - make install critical section smaller to prevent installation deprecations preventing installation

data/lib/deprecation_collector/collectors.rb

@@ -40,7 +40,7 @@ class DeprecationCollector
     def tap_activesupport
       # TODO: a more polite hook
       # not polite to turn off all other possible behaviors, but otherwise may get duplicate calls
-      if Rails.respond_to?(:gem_version) && Rails.gem_version >= "7.1"
+      if Rails.respond_to?(:gem_version) && Rails.gem_version >= Gem::Version.new("7.1")
         Rails.application.deprecators.behavior = ACTIVE_SUPPORT_BEHAVIORS[:rails71] if Rails.application&.deprecators
         # Rails.application.deprecators.behavior only captures new-style deprecations, but we need all:
         if ActiveSupport::Deprecation.respond_to?(:_instance)

data/lib/deprecation_collector/storage.rb

@@ -109,6 +109,8 @@ class DeprecationCollector
 
       def flush(force: false)
         return unless force || (current_time > @last_write_time + @write_interval)
+        # do not disturb existing redis connection if already in pipeline, hope that will be flushed some other time
+        return if in_redis_pipeline?
 
         deprecations_to_flush = nil
         @deprecations_mutex.synchronize do
@@ -182,6 +184,11 @@ class DeprecationCollector
       end
 
       protected
+      def in_redis_pipeline?
+        return false if Gem::Version.new(::Redis::VERSION) >= Gem::Version.new("5.0")
+
+        redis.instance_variable_get(:@client) != redis.instance_variable_get(:@original_client)
+      end
 
       def enabled_flag_key
         @enabled_flag_key ||= "#{@key_prefix}:enabled" # usually deprecations:enabled

data/lib/deprecation_collector/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class DeprecationCollector
-  VERSION = "0.7.0"
+  VERSION = "0.7.2"
 end

data/lib/deprecation_collector/web/helpers.rb

@@ -51,7 +51,7 @@ class DeprecationCollector
         return unless defined?(ActiveSupport::Deprecation)
 
         deprecator = ActiveSupport::Deprecation
-        deprecator = ActiveSupport::Deprecation.new("0.0", "deprecation_collector") if Rails.gem_version >= "7.1"
+        deprecator = ActiveSupport::Deprecation.new("0.0", "deprecation_collector") if Rails.gem_version >= Gem::Version.new("7.1")
 
         -> { deprecator.warn("Test deprecation") } []
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deprecation_collector
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.2
 platform: ruby
 authors:
 - Vasily Fedoseyev
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-23 00:00:00.000000000 Z
+date: 2024-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
@@ -78,7 +78,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
 summary: Collector for ruby/rails deprecations and warnings, suitable for production