dependabot-terraform 0.267.0 → 0.268.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62a91f9b85e8cc81dd3d94bfb86d6b260fe56c274f26ead6a1a4c678ba378af7
-  data.tar.gz: 2cee8a2dcaf9d7a5d8ec492ad68cc05dea72baa6d12d1c92ac45067b877e050c
+  metadata.gz: dfafcf14f07de855d5852c1b18e058e06ad589702cd65d520424b1b14800ba5c
+  data.tar.gz: 6af17e4d1fd4044c9d28c85e31a69ed20f620387bfe68cb088f521dcbef4b234
 SHA512:
-  metadata.gz: 79ad9009afbda29b20a54b5ae03044320ed88fc3fe97e06349aa0591fbaaecc45638b651d16ca7a2797d9c30cf645fbb08f0452c15615d67035d5cf1862c4411
-  data.tar.gz: 0ac7d95c328fdabc405b63b6d0085eb9f28aae8bf687f2b61bbb37c7a216d0b9d8e4a8f1c6d284c25a0fd5609b2a59112aada3837414a5b8c531df395bb26f8d
+  metadata.gz: d5dd70285d03158dc1245066f3ced39dfea1f5288d22098a7003ce6b7a7c686092beb32265c5839c0a76938a6e7f5a9f85b88bc4b8ae8660b1f3263831ad5e6d
+  data.tar.gz: 95b840a8d8ab35ece09fe671d8d477bfe2babbb131fe3f6db0b88fe10637952d42cac7a63240c394712cb0fd8cdc5a32c398a12c4b74e3c69dcdf8cc19e94b77

data/lib/dependabot/terraform/update_checker.rb

@@ -1,6 +1,8 @@
-# typed: true
+# typed: strict
 # frozen_string_literal: true
 
+require "sorbet-runtime"
+
 require "dependabot/update_checkers"
 require "dependabot/update_checkers/base"
 require "dependabot/git_commit_checker"
@@ -12,8 +14,14 @@ require "dependabot/terraform/registry_client"
 module Dependabot
   module Terraform
     class UpdateChecker < Dependabot::UpdateCheckers::Base
-      ELIGIBLE_SOURCE_TYPES = %w(git provider registry).freeze
+      extend T::Sig
+
+      ELIGIBLE_SOURCE_TYPES = T.let(
+        %w(git provider registry).freeze,
+        T::Array[String]
+      )
 
+      sig { override.returns(T.nilable(T.any(String, Gem::Version))) }
       def latest_version
         return latest_version_for_git_dependency if git_dependency?
         return latest_version_for_registry_dependency if registry_dependency?
@@ -22,17 +30,20 @@ module Dependabot
         # Other sources (mercurial, path dependencies) just return `nil`
       end
 
+      sig { override.returns(T.nilable(T.any(String, Gem::Version))) }
       def latest_resolvable_version
         # No concept of resolvability for terraform modules (that we're aware
         # of - there may be in future).
         latest_version
       end
 
+      sig { override.returns(T.nilable(T.any(String, Dependabot::Version))) }
       def latest_resolvable_version_with_no_unlock
         # Irrelevant, since Terraform doesn't have a lockfile
         nil
       end
 
+      sig { override.returns(T::Array[T::Hash[Symbol, T.untyped]]) }
       def updated_requirements
         RequirementsUpdater.new(
           requirements: dependency.requirements,
@@ -41,6 +52,7 @@ module Dependabot
         ).updated_requirements
       end
 
+      sig { returns(T::Boolean) }
       def requirements_unlocked_or_can_be?
         # If the requirement comes from a proxy URL then there's no way for
         # us to update it
@@ -49,15 +61,18 @@ module Dependabot
 
       private
 
+      sig { override.returns(T::Boolean) }
       def latest_version_resolvable_with_full_unlock?
         # Full unlock checks aren't relevant for Terraform files
         false
       end
 
+      sig { override.returns(T::Array[Dependabot::Dependency]) }
       def updated_dependencies_after_full_unlock
         raise NotImplementedError
       end
 
+      sig { returns(T.nilable(Dependabot::Terraform::Version)) }
       def latest_version_for_registry_dependency
         return unless registry_dependency?
 
@@ -67,26 +82,36 @@ module Dependabot
         versions.reject!(&:prerelease?) unless wants_prerelease?
         versions.reject! { |v| ignore_requirements.any? { |r| r.satisfied_by?(v) } }
 
-        @latest_version_for_registry_dependency = versions.max
+        @latest_version_for_registry_dependency = T.let(
+          versions.max,
+          T.nilable(Dependabot::Terraform::Version)
+        )
       end
 
+      sig { returns(T::Array[Dependabot::Terraform::Version]) }
       def all_module_versions
-        identifier = dependency_source_details.fetch(:module_identifier)
+        identifier = dependency_source_details&.fetch(:module_identifier)
         registry_client.all_module_versions(identifier: identifier)
       end
 
+      sig { returns(T::Array[Dependabot::Terraform::Version]) }
       def all_provider_versions
-        identifier = dependency_source_details.fetch(:module_identifier)
+        identifier = dependency_source_details&.fetch(:module_identifier)
         registry_client.all_provider_versions(identifier: identifier)
       end
 
+      sig { returns(Dependabot::Terraform::RegistryClient) }
       def registry_client
-        @registry_client ||= begin
-          hostname = dependency_source_details.fetch(:registry_hostname)
-          RegistryClient.new(hostname: hostname, credentials: credentials)
-        end
+        @registry_client ||= T.let(
+          begin
+            hostname = dependency_source_details&.fetch(:registry_hostname)
+            RegistryClient.new(hostname: hostname, credentials: credentials)
+          end,
+          T.nilable(Dependabot::Terraform::RegistryClient)
+        )
       end
 
+      sig { returns(T.nilable(Dependabot::Terraform::Version)) }
       def latest_version_for_provider_dependency
         return unless provider_dependency?
 
@@ -96,9 +121,13 @@ module Dependabot
         versions.reject!(&:prerelease?) unless wants_prerelease?
         versions.reject! { |v| ignore_requirements.any? { |r| r.satisfied_by?(v) } }
 
-        @latest_version_for_provider_dependency = versions.max
+        @latest_version_for_provider_dependency = T.let(
+          versions.max,
+          T.nilable(Dependabot::Terraform::Version)
+        )
       end
 
+      sig { returns(T::Boolean) }
       def wants_prerelease?
         current_version = dependency.version
         if current_version &&
@@ -112,6 +141,7 @@ module Dependabot
         end
       end
 
+      sig { returns(T.nilable(T.any(Dependabot::Version, String))) }
       def latest_version_for_git_dependency
         # If the module isn't pinned then there's nothing for us to update
         # (since there's no lockfile to update the version in). We still
@@ -138,6 +168,7 @@ module Dependabot
         nil
       end
 
+      sig { returns(T.nilable(String)) }
       def tag_for_latest_version
         return unless git_commit_checker.git_dependency?
         return unless git_commit_checker.pinned?
@@ -152,40 +183,48 @@ module Dependabot
         latest_tag
       end
 
+      sig { returns(T::Boolean) }
       def proxy_requirement?
         dependency.requirements.any? do |req|
           req.fetch(:source)&.fetch(:proxy_url, nil)
         end
       end
 
+      sig { returns(T::Boolean) }
       def registry_dependency?
         return false if dependency_source_details.nil?
 
-        dependency_source_details.fetch(:type) == "registry"
+        dependency_source_details&.fetch(:type) == "registry"
       end
 
+      sig { returns(T::Boolean) }
       def provider_dependency?
         return false if dependency_source_details.nil?
 
-        dependency_source_details.fetch(:type) == "provider"
+        dependency_source_details&.fetch(:type) == "provider"
       end
 
+      sig { returns(T.nilable(T::Hash[T.any(String, Symbol), T.untyped])) }
       def dependency_source_details
         dependency.source_details(allowed_types: ELIGIBLE_SOURCE_TYPES)
       end
 
+      sig { returns(T::Boolean) }
       def git_dependency?
         git_commit_checker.git_dependency?
       end
 
+      sig { returns(Dependabot::GitCommitChecker) }
       def git_commit_checker
-        @git_commit_checker ||=
+        @git_commit_checker ||= T.let(
           GitCommitChecker.new(
             dependency: dependency,
             credentials: credentials,
             ignored_versions: ignored_versions,
             raise_on_ignored: raise_on_ignored
-          )
+          ),
+          T.nilable(Dependabot::GitCommitChecker)
+        )
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-terraform
 version: !ruby/object:Gem::Version
-  version: 0.267.0
+  version: 0.268.0
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-07-25 00:00:00.000000000 Z
+date: 2024-08-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dependabot-common
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.267.0
+        version: 0.268.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.267.0
+        version: 0.268.0
 - !ruby/object:Gem::Dependency
   name: debug
   requirement: !ruby/object:Gem::Requirement
@@ -260,7 +260,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
-  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.267.0
+  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.268.0
 post_install_message: 
 rdoc_options: []
 require_paths: