dependabot-nuget 0.280.0 → 0.281.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2728d8749a316ac4ecbd46826beffaefc51e5101c1154d0fdef5ad756158c256
-  data.tar.gz: 3ec34208b76ed22dbef3ae0e49511e77f85d73aea1b980180292b5225e26367a
+  metadata.gz: 3afe0ac22f324c8dacf2c16437998a6b22ad23ae21092f3889d3973eb4a59ddb
+  data.tar.gz: e3aca7ae87df62bb56d264c5eb88e6f14fc9077e3c3c853cd769e34488d95cfa
 SHA512:
-  metadata.gz: 4cf2906e79a866fb5c4d89807e893d6486f1fae08b9b951da9a049fbd546cc59d522d6b8ace80fe0ee59353eb93224b648370b404bf69ff845d89fafd70894ba
-  data.tar.gz: '05801823dee91eba1e490ee4fef1d44a2e83f632c7823c5ae6bd9cd3955d085c8c6c5e015023c4a6a0e34ed453e2e3d956c9399f955d608fd87381ef2ff620d7'
+  metadata.gz: f25c4209f6aab5ae958a092b34c9ab9a5d1473e1322646dcd7f1a7d0e753e681b975516fe5b416ca62c7ba7be219590f17c4541f4635bbe3355b9213e3ff587d
+  data.tar.gz: e058837c6034711c21fd672774b3c37940f0f286af89fbd1e4cdefa9af415647f926bd626f13356bae3304f1e18b98cfcc67390f492ce0d8b06fa4bbf301356b

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli/Commands/AnalyzeCommand.cs

@@ -11,7 +11,6 @@ internal static class AnalyzeCommand
     internal static readonly Option<FileInfo> DependencyFilePathOption = new("--dependency-file-path") { IsRequired = true };
     internal static readonly Option<FileInfo> DiscoveryFilePathOption = new("--discovery-file-path") { IsRequired = true };
     internal static readonly Option<DirectoryInfo> AnalysisFolderOption = new("--analysis-folder-path") { IsRequired = true };
-    internal static readonly Option<bool> VerboseOption = new("--verbose", getDefaultValue: () => false);
 
     internal static Command GetCommand(Action<int> setExitCode)
     {
@@ -20,17 +19,16 @@ internal static class AnalyzeCommand
             RepoRootOption,
             DependencyFilePathOption,
             DiscoveryFilePathOption,
-            AnalysisFolderOption,
-            VerboseOption
+            AnalysisFolderOption
         };
 
         command.TreatUnmatchedTokensAsErrors = true;
 
-        command.SetHandler(async (repoRoot, discoveryPath, dependencyPath, analysisDirectory, verbose) =>
+        command.SetHandler(async (repoRoot, discoveryPath, dependencyPath, analysisDirectory) =>
         {
-            var worker = new AnalyzeWorker(new Logger(verbose));
+            var worker = new AnalyzeWorker(new ConsoleLogger());
             await worker.RunAsync(repoRoot.FullName, discoveryPath.FullName, dependencyPath.FullName, analysisDirectory.FullName);
-        }, RepoRootOption, DiscoveryFilePathOption, DependencyFilePathOption, AnalysisFolderOption, VerboseOption);
+        }, RepoRootOption, DiscoveryFilePathOption, DependencyFilePathOption, AnalysisFolderOption);
 
         return command;
     }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli/Commands/DiscoverCommand.cs

@@ -10,7 +10,6 @@ internal static class DiscoverCommand
     internal static readonly Option<DirectoryInfo> RepoRootOption = new("--repo-root") { IsRequired = true };
     internal static readonly Option<string> WorkspaceOption = new("--workspace") { IsRequired = true };
     internal static readonly Option<FileInfo> OutputOption = new("--output") { IsRequired = true };
-    internal static readonly Option<bool> VerboseOption = new("--verbose", getDefaultValue: () => false);
 
     internal static Command GetCommand(Action<int> setExitCode)
     {
@@ -18,17 +17,16 @@ internal static class DiscoverCommand
         {
             RepoRootOption,
             WorkspaceOption,
-            OutputOption,
-            VerboseOption
+            OutputOption
         };
 
         command.TreatUnmatchedTokensAsErrors = true;
 
-        command.SetHandler(async (repoRoot, workspace, outputPath, verbose) =>
+        command.SetHandler(async (repoRoot, workspace, outputPath) =>
         {
-            var worker = new DiscoveryWorker(new Logger(verbose));
+            var worker = new DiscoveryWorker(new ConsoleLogger());
             await worker.RunAsync(repoRoot.FullName, workspace, outputPath.FullName);
-        }, RepoRootOption, WorkspaceOption, OutputOption, VerboseOption);
+        }, RepoRootOption, WorkspaceOption, OutputOption);
 
         return command;
     }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli/Commands/FrameworkCheckCommand.cs

@@ -1,4 +1,3 @@
-using System;
 using System.CommandLine;
 
 using NuGetUpdater.Core;
@@ -10,25 +9,23 @@ internal static class FrameworkCheckCommand
 {
     internal static readonly Option<string[]> ProjectTfmsOption = new("--project-tfms") { IsRequired = true, AllowMultipleArgumentsPerToken = true };
     internal static readonly Option<string[]> PackageTfmsOption = new("--package-tfms") { IsRequired = true, AllowMultipleArgumentsPerToken = true };
-    internal static readonly Option<bool> VerboseOption = new("--verbose", getDefaultValue: () => false);
 
     internal static Command GetCommand(Action<int> setExitCode)
     {
         Command command = new("framework-check", "Checks that a project's target frameworks are satisfied by the target frameworks supported by a package.")
         {
             ProjectTfmsOption,
-            PackageTfmsOption,
-            VerboseOption
+            PackageTfmsOption
         };
 
         command.TreatUnmatchedTokensAsErrors = true;
 
-        command.SetHandler((projectTfms, packageTfms, verbose) =>
+        command.SetHandler((projectTfms, packageTfms) =>
         {
-            setExitCode(CompatibilityChecker.IsCompatible(projectTfms, packageTfms, new Logger(verbose))
+            setExitCode(CompatibilityChecker.IsCompatible(projectTfms, packageTfms, new ConsoleLogger())
                 ? 0
                 : 1);
-        }, ProjectTfmsOption, PackageTfmsOption, VerboseOption);
+        }, ProjectTfmsOption, PackageTfmsOption);
 
         return command;
     }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli/Commands/RunCommand.cs

@@ -13,7 +13,6 @@ internal static class RunCommand
     internal static readonly Option<string> JobIdOption = new("--job-id") { IsRequired = true };
     internal static readonly Option<FileInfo> OutputPathOption = new("--output-path") { IsRequired = true };
     internal static readonly Option<string> BaseCommitShaOption = new("--base-commit-sha") { IsRequired = true };
-    internal static readonly Option<bool> VerboseOption = new("--verbose", getDefaultValue: () => false);
 
     internal static Command GetCommand(Action<int> setExitCode)
     {
@@ -24,18 +23,17 @@ internal static class RunCommand
             ApiUrlOption,
             JobIdOption,
             OutputPathOption,
-            BaseCommitShaOption,
-            VerboseOption
+            BaseCommitShaOption
         };
 
         command.TreatUnmatchedTokensAsErrors = true;
 
-        command.SetHandler(async (jobPath, repoContentsPath, apiUrl, jobId, outputPath, baseCommitSha, verbose) =>
+        command.SetHandler(async (jobPath, repoContentsPath, apiUrl, jobId, outputPath, baseCommitSha) =>
         {
             var apiHandler = new HttpApiHandler(apiUrl.ToString(), jobId);
-            var worker = new RunWorker(apiHandler, new Logger(verbose));
+            var worker = new RunWorker(apiHandler, new ConsoleLogger());
             await worker.RunAsync(jobPath, repoContentsPath, baseCommitSha, outputPath);
-        }, JobPathOption, RepoContentsPathOption, ApiUrlOption, JobIdOption, OutputPathOption, BaseCommitShaOption, VerboseOption);
+        }, JobPathOption, RepoContentsPathOption, ApiUrlOption, JobIdOption, OutputPathOption, BaseCommitShaOption);
 
         return command;
     }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli/Commands/UpdateCommand.cs

@@ -12,7 +12,6 @@ internal static class UpdateCommand
     internal static readonly Option<string> NewVersionOption = new("--new-version") { IsRequired = true };
     internal static readonly Option<string> PreviousVersionOption = new("--previous-version") { IsRequired = true };
     internal static readonly Option<bool> IsTransitiveOption = new("--transitive", getDefaultValue: () => false);
-    internal static readonly Option<bool> VerboseOption = new("--verbose", getDefaultValue: () => false);
     internal static readonly Option<string?> ResultOutputPathOption = new("--result-output-path", getDefaultValue: () => null);
 
     internal static Command GetCommand(Action<int> setExitCode)
@@ -25,18 +24,17 @@ internal static class UpdateCommand
             NewVersionOption,
             PreviousVersionOption,
             IsTransitiveOption,
-            VerboseOption,
             ResultOutputPathOption
         };
 
         command.TreatUnmatchedTokensAsErrors = true;
 
-        command.SetHandler(async (repoRoot, solutionOrProjectFile, dependencyName, newVersion, previousVersion, isTransitive, verbose, resultOutputPath) =>
+        command.SetHandler(async (repoRoot, solutionOrProjectFile, dependencyName, newVersion, previousVersion, isTransitive, resultOutputPath) =>
         {
-            var worker = new UpdaterWorker(new Logger(verbose));
+            var worker = new UpdaterWorker(new ConsoleLogger());
             await worker.RunAsync(repoRoot.FullName, solutionOrProjectFile.FullName, dependencyName, previousVersion, newVersion, isTransitive, resultOutputPath);
             setExitCode(0);
-        }, RepoRootOption, SolutionOrProjectFileOption, DependencyNameOption, NewVersionOption, PreviousVersionOption, IsTransitiveOption, VerboseOption, ResultOutputPathOption);
+        }, RepoRootOption, SolutionOrProjectFileOption, DependencyNameOption, NewVersionOption, PreviousVersionOption, IsTransitiveOption, ResultOutputPathOption);
 
         return command;
     }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli.Test/EntryPointTests.Analyze.cs

@@ -34,7 +34,6 @@ public partial class EntryPointTests
                     Path.Join(path, "Some.Package.json"),
                     "--analysis-folder-path",
                     Path.Join(path, AnalyzeWorker.AnalysisDirectoryName),
-                    "--verbose",
                 ],
                 packages: [
                     MockNuGetPackage.CreateSimplePackage("Some.Package", "1.0.0", "net8.0", additionalMetadata: [repositoryXml]),
@@ -151,7 +150,6 @@ public partial class EntryPointTests
                     Path.Join(path, "some-global-tool.json"),
                     "--analysis-folder-path",
                     Path.Join(path, AnalyzeWorker.AnalysisDirectoryName),
-                    "--verbose",
                 ],
                 packages:
                 [
@@ -239,7 +237,6 @@ public partial class EntryPointTests
                     Path.Join(path, "Some.MSBuild.Sdk.json"),
                     "--analysis-folder-path",
                     Path.Join(path, AnalyzeWorker.AnalysisDirectoryName),
-                    "--verbose",
                 ],
                 packages:
                 [

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli.Test/EntryPointTests.FrameworkCheck.cs

@@ -28,7 +28,6 @@ public partial class EntryPointTests
             args.AddRange(projectTfms.Split(' ', StringSplitOptions.TrimEntries));
             args.Add("--package-tfms");
             args.AddRange(packageTfms.Split(' ', StringSplitOptions.TrimEntries));
-            args.Add("--verbose");
 
             var actual = await Program.Main(args.ToArray());
 

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli.Test/EntryPointTests.Run.cs

@@ -105,8 +105,7 @@ public partial class EntryPointTests
                 "--output-path",
                 Path.Combine(tempDirectory.DirectoryPath, "output.json"),
                 "--base-commit-sha",
-                "BASE-COMMIT-SHA",
-                "--verbose"
+                "BASE-COMMIT-SHA"
             };
 
             var output = new StringBuilder();

data/helpers/lib/NuGetUpdater/NuGetUpdater.Cli.Test/EntryPointTests.Update.cs

@@ -128,8 +128,7 @@ public partial class EntryPointTests
                     "--new-version",
                     "13.0.1",
                     "--previous-version",
-                    "7.0.1",
-                    "--verbose"
+                    "7.0.1"
                 ],
                 packages:
                 [
@@ -207,8 +206,7 @@ public partial class EntryPointTests
                     "--new-version",
                     "6.6.1",
                     "--previous-version",
-                    "6.1.0",
-                    "--verbose"
+                    "6.1.0"
                 ],
                 packages:
                 [
@@ -364,8 +362,7 @@ public partial class EntryPointTests
                 "--new-version",
                 "13.0.1",
                 "--previous-version",
-                "7.0.1",
-                "--verbose"
+                "7.0.1"
             ];
 
             // verify base run

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/AnalyzeWorker.cs

@@ -16,7 +16,7 @@ public partial class AnalyzeWorker
 {
     public const string AnalysisDirectoryName = "./.dependabot/analysis";
 
-    private readonly Logger _logger;
+    private readonly ILogger _logger;
 
     internal static readonly JsonSerializerOptions SerializerOptions = new()
     {
@@ -24,7 +24,7 @@ public partial class AnalyzeWorker
         Converters = { new JsonStringEnumConverter(), new RequirementConverter() },
     };
 
-    public AnalyzeWorker(Logger logger)
+    public AnalyzeWorker(ILogger logger)
     {
         _logger = logger;
     }
@@ -213,7 +213,7 @@ public partial class AnalyzeWorker
         ImmutableHashSet<string> packageIds,
         ImmutableArray<NuGetFramework> projectFrameworks,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         var versionResult = await VersionFinder.GetVersionsAsync(
@@ -239,7 +239,7 @@ public partial class AnalyzeWorker
         NuGetVersion version,
         bool findLowestVersion,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         var versionResult = await VersionFinder.GetVersionsAsync(
@@ -267,7 +267,7 @@ public partial class AnalyzeWorker
         ImmutableArray<NuGetFramework> projectFrameworks,
         bool findLowestVersion,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         var versions = versionResult.GetVersions();
@@ -299,7 +299,7 @@ public partial class AnalyzeWorker
         IEnumerable<NuGetVersion> orderedVersions,
         ImmutableArray<NuGetFramework> projectFrameworks,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         if (NuGetVersion.TryParse(versionString, out var currentVersion))
@@ -350,7 +350,7 @@ public partial class AnalyzeWorker
         NuGetVersion currentVersion,
         ImmutableArray<NuGetFramework> projectFrameworks,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         foreach (var packageId in packageIds)
@@ -376,7 +376,7 @@ public partial class AnalyzeWorker
         ImmutableHashSet<string> packageIds,
         NuGetVersion updatedVersion,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         // We need to find all projects which have the given dependency. Even in cases that they
@@ -459,7 +459,7 @@ public partial class AnalyzeWorker
             }).ToImmutableArray();
     }
 
-    internal static async Task WriteResultsAsync(string analysisDirectory, string dependencyName, AnalysisResult result, Logger logger)
+    internal static async Task WriteResultsAsync(string analysisDirectory, string dependencyName, AnalysisResult result, ILogger logger)
     {
         if (!Directory.Exists(analysisDirectory))
         {

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/CompatabilityChecker.cs

@@ -21,7 +21,7 @@ internal static class CompatibilityChecker
         PackageIdentity package,
         ImmutableArray<NuGetFramework> projectFrameworks,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         var (isDevDependency, packageFrameworks) = await GetPackageInfoAsync(
@@ -37,7 +37,7 @@ internal static class CompatibilityChecker
         ImmutableArray<NuGetFramework> projectFrameworks,
         bool isDevDependency,
         ImmutableArray<NuGetFramework> packageFrameworks,
-        Logger logger)
+        ILogger logger)
     {
         // development dependencies are packages such as analyzers which need to be compatible with the compiler not the
         // project itself, but some packages that report themselves as development dependencies still contain target

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/DependencyFinder.cs

@@ -14,7 +14,7 @@ internal static class DependencyFinder
         ImmutableHashSet<string> packageIds,
         NuGetVersion version,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         var versionString = version.ToNormalizedString();

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/NuGetContext.cs

@@ -19,10 +19,10 @@ internal record NuGetContext : IDisposable
     public ISettings Settings { get; }
     public IMachineWideSettings MachineWideSettings { get; }
     public ImmutableArray<PackageSource> PackageSources { get; }
-    public ILogger Logger { get; }
+    public NuGet.Common.ILogger Logger { get; }
     public string TempPackageDirectory { get; }
 
-    public NuGetContext(string? currentDirectory = null, ILogger? logger = null)
+    public NuGetContext(string? currentDirectory = null, NuGet.Common.ILogger? logger = null)
     {
         SourceCacheContext = new SourceCacheContext();
         PackageDownloadContext = new PackageDownloadContext(SourceCacheContext);

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Analyze/VersionFinder.cs

@@ -15,7 +15,7 @@ internal static class VersionFinder
         string packageId,
         NuGetVersion currentVersion,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         var versionFilter = CreateVersionFilter(currentVersion);
@@ -26,7 +26,7 @@ internal static class VersionFinder
     public static Task<VersionResult> GetVersionsAsync(
         DependencyInfo dependencyInfo,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         var packageId = dependencyInfo.Name;
@@ -42,7 +42,7 @@ internal static class VersionFinder
         NuGetVersion currentVersion,
         Func<NuGetVersion, bool> versionFilter,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         var includePrerelease = currentVersion.IsPrerelease;
@@ -130,7 +130,7 @@ internal static class VersionFinder
         IEnumerable<string> packageIds,
         NuGetVersion version,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         foreach (var packageId in packageIds)
@@ -148,7 +148,7 @@ internal static class VersionFinder
         string packageId,
         NuGetVersion version,
         NuGetContext nugetContext,
-        Logger logger,
+        ILogger logger,
         CancellationToken cancellationToken)
     {
         var includePrerelease = version.IsPrerelease;

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DirectoryPackagesPropsDiscovery.cs

@@ -4,7 +4,7 @@ namespace NuGetUpdater.Core.Discover;
 
 internal static class DirectoryPackagesPropsDiscovery
 {
-    public static DirectoryPackagesPropsDiscoveryResult? Discover(string repoRootPath, string workspacePath, ImmutableArray<ProjectDiscoveryResult> projectResults, Logger logger)
+    public static DirectoryPackagesPropsDiscoveryResult? Discover(string repoRootPath, string workspacePath, ImmutableArray<ProjectDiscoveryResult> projectResults, ILogger logger)
     {
         var projectResult = projectResults.FirstOrDefault(
             p => p.Properties.FirstOrDefault(prop => prop.Name.Equals("ManagePackageVersionsCentrally", StringComparison.OrdinalIgnoreCase)) is Property property

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DiscoveryWorker.cs

@@ -16,7 +16,7 @@ public partial class DiscoveryWorker
 {
     public const string DiscoveryResultFileName = "./.dependabot/discovery.json";
 
-    private readonly Logger _logger;
+    private readonly ILogger _logger;
     private readonly HashSet<string> _processedProjectPaths = new(StringComparer.OrdinalIgnoreCase); private readonly HashSet<string> _restoredMSBuildSdks = new(StringComparer.OrdinalIgnoreCase);
 
     internal static readonly JsonSerializerOptions SerializerOptions = new()
@@ -25,7 +25,7 @@ public partial class DiscoveryWorker
         Converters = { new JsonStringEnumConverter() },
     };
 
-    public DiscoveryWorker(Logger logger)
+    public DiscoveryWorker(ILogger logger)
     {
         _logger = logger;
     }
@@ -125,7 +125,7 @@ public partial class DiscoveryWorker
     /// Restores MSBuild SDKs from the given dependencies.
     /// </summary>
     /// <returns>Returns `true` when SDKs were restored successfully.</returns>
-    private async Task<bool> TryRestoreMSBuildSdksAsync(string repoRootPath, string workspacePath, ImmutableArray<Dependency> dependencies, Logger logger)
+    private async Task<bool> TryRestoreMSBuildSdksAsync(string repoRootPath, string workspacePath, ImmutableArray<Dependency> dependencies, ILogger logger)
     {
         var msbuildSdks = dependencies
             .Where(d => d.Type == DependencyType.MSBuildSdk && !string.IsNullOrEmpty(d.Version))

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/DotNetToolsJsonDiscovery.cs

@@ -4,7 +4,7 @@ namespace NuGetUpdater.Core.Discover;
 
 internal static class DotNetToolsJsonDiscovery
 {
-    public static DotNetToolsJsonDiscoveryResult? Discover(string repoRootPath, string workspacePath, Logger logger)
+    public static DotNetToolsJsonDiscoveryResult? Discover(string repoRootPath, string workspacePath, ILogger logger)
     {
         if (!MSBuildHelper.TryGetDotNetToolsJsonPath(repoRootPath, workspacePath, out var dotnetToolsJsonPath))
         {

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/GlobalJsonDiscovery.cs

@@ -4,7 +4,7 @@ namespace NuGetUpdater.Core.Discover;
 
 internal static class GlobalJsonDiscovery
 {
-    public static GlobalJsonDiscoveryResult? Discover(string repoRootPath, string workspacePath, Logger logger)
+    public static GlobalJsonDiscoveryResult? Discover(string repoRootPath, string workspacePath, ILogger logger)
     {
         if (!MSBuildHelper.TryGetGlobalJsonPath(repoRootPath, workspacePath, out var globalJsonPath))
         {

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/PackagesConfigDiscovery.cs

@@ -4,7 +4,7 @@ namespace NuGetUpdater.Core.Discover;
 
 internal static class PackagesConfigDiscovery
 {
-    public static PackagesConfigDiscoveryResult? Discover(string workspacePath, string projectPath, Logger logger)
+    public static PackagesConfigDiscoveryResult? Discover(string workspacePath, string projectPath, ILogger logger)
     {
         if (!NuGetHelper.TryGetPackagesConfigFile(projectPath, out var packagesConfigPath))
         {

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Discover/SdkProjectDiscovery.cs

@@ -6,7 +6,7 @@ namespace NuGetUpdater.Core.Discover;
 
 internal static class SdkProjectDiscovery
 {
-    public static async Task<ImmutableArray<ProjectDiscoveryResult>> DiscoverAsync(string repoRootPath, string workspacePath, string projectPath, Logger logger)
+    public static async Task<ImmutableArray<ProjectDiscoveryResult>> DiscoverAsync(string repoRootPath, string workspacePath, string projectPath, ILogger logger)
     {
         // Determine which targets and props files contribute to the build.
         var (buildFiles, projectTargetFrameworks) = await MSBuildHelper.LoadBuildFilesAndTargetFrameworksAsync(repoRootPath, projectPath);
@@ -97,7 +97,7 @@ internal static class SdkProjectDiscovery
         return results.ToImmutable();
     }
 
-    private static async Task<ImmutableArray<Dependency>> GetTransitiveDependencies(string repoRootPath, string projectPath, ImmutableArray<string> tfms, ImmutableArray<Dependency> directDependencies, Logger logger)
+    private static async Task<ImmutableArray<Dependency>> GetTransitiveDependencies(string repoRootPath, string projectPath, ImmutableArray<string> tfms, ImmutableArray<Dependency> directDependencies, ILogger logger)
     {
         Dictionary<string, Dependency> transitiveDependencies = new(StringComparer.OrdinalIgnoreCase);
         foreach (var tfm in tfms)

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/ErrorType.cs

@@ -2,9 +2,9 @@ namespace NuGetUpdater.Core;
 
 public enum ErrorType
 {
-    // TODO: add `Unknown` option to track all other failure types
     None,
     AuthenticationFailure,
     MissingFile,
     UpdateNotPossible,
+    Unknown,
 }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Files/DotNetToolsJsonBuildFile.cs

@@ -4,10 +4,10 @@ namespace NuGetUpdater.Core;
 
 internal sealed class DotNetToolsJsonBuildFile : JsonBuildFile
 {
-    public static DotNetToolsJsonBuildFile Open(string basePath, string path, Logger logger)
+    public static DotNetToolsJsonBuildFile Open(string basePath, string path, ILogger logger)
         => new(basePath, path, File.ReadAllText(path), logger);
 
-    public DotNetToolsJsonBuildFile(string basePath, string path, string contents, Logger logger)
+    public DotNetToolsJsonBuildFile(string basePath, string path, string contents, ILogger logger)
         : base(basePath, path, contents, logger)
     {
     }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Files/GlobalJsonBuildFile.cs

@@ -4,10 +4,10 @@ namespace NuGetUpdater.Core;
 
 internal sealed class GlobalJsonBuildFile : JsonBuildFile
 {
-    public static GlobalJsonBuildFile Open(string basePath, string path, Logger logger)
+    public static GlobalJsonBuildFile Open(string basePath, string path, ILogger logger)
         => new(basePath, path, File.ReadAllText(path), logger);
 
-    public GlobalJsonBuildFile(string basePath, string path, string contents, Logger logger)
+    public GlobalJsonBuildFile(string basePath, string path, string contents, ILogger logger)
         : base(basePath, path, contents, logger)
     {
     }

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Files/JsonBuildFile.cs

@@ -8,9 +8,9 @@ namespace NuGetUpdater.Core;
 internal abstract class JsonBuildFile : BuildFile<string>
 {
     protected Lazy<JsonNode?> Node;
-    private readonly Logger logger;
+    private readonly ILogger logger;
 
-    public JsonBuildFile(string repoRootPath, string path, string contents, Logger logger)
+    public JsonBuildFile(string repoRootPath, string path, string contents, ILogger logger)
         : base(repoRootPath, path, contents)
     {
         Node = new Lazy<JsonNode?>(() => null);

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/FrameworkChecker/CompatabilityChecker.cs

@@ -4,7 +4,7 @@ namespace NuGetUpdater.Core.FrameworkChecker;
 
 public class CompatibilityChecker
 {
-    public static bool IsCompatible(string[] projectTfms, string[] packageTfms, Logger logger)
+    public static bool IsCompatible(string[] projectTfms, string[] packageTfms, ILogger logger)
     {
         var projectFrameworks = projectTfms.Select(ParseFramework);
         var packageFrameworks = packageTfms.Select(ParseFramework);

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Run/RunWorker.cs

@@ -12,7 +12,7 @@ namespace NuGetUpdater.Core.Run;
 public class RunWorker
 {
     private readonly IApiHandler _apiHandler;
-    private readonly Logger _logger;
+    private readonly ILogger _logger;
 
     internal static readonly JsonSerializerOptions SerializerOptions = new()
     {
@@ -21,7 +21,7 @@ public class RunWorker
         Converters = { new JsonStringEnumConverter() },
     };
 
-    public RunWorker(IApiHandler apiHandler, Logger logger)
+    public RunWorker(IApiHandler apiHandler, ILogger logger)
     {
         _apiHandler = apiHandler;
         _logger = logger;

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/BindingRedirectManager.cs

@@ -116,19 +116,19 @@ internal static class BindingRedirectManager
             return null;
         }
 
-        var configFilePath = Path.GetFullPath(Path.Combine(directoryPath, GetContent(configFile)));
+        var configFilePath = Path.GetFullPath(Path.Combine(directoryPath, GetValue(configFile)));
         var configFileContents = await File.ReadAllTextAsync(configFilePath);
         return new ConfigurationFile(configFilePath, configFileContents, false);
 
-        static string GetContent(IXmlElementSyntax element)
+        static string GetValue(IXmlElementSyntax element)
         {
-            var content = element.GetContentValue();
+            var content = element.GetAttributeValue("Include");
             if (!string.IsNullOrEmpty(content))
             {
                 return content;
             }
 
-            content = element.GetAttributeValue("Include");
+            content = element.GetContentValue();
             if (!string.IsNullOrEmpty(content))
             {
                 return content;
@@ -139,7 +139,7 @@ internal static class BindingRedirectManager
 
         static bool IsConfigFile(IXmlElementSyntax element)
         {
-            var content = GetContent(element);
+            var content = GetValue(element);
             if (content is null)
             {
                 return false;

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/DotNetToolsJsonUpdater.cs

@@ -8,7 +8,7 @@ internal static class DotNetToolsJsonUpdater
         string dependencyName,
         string previousDependencyVersion,
         string newDependencyVersion,
-        Logger logger)
+        ILogger logger)
     {
         if (!MSBuildHelper.TryGetDotNetToolsJsonPath(repoRootPath, workspacePath, out var dotnetToolsJsonPath))
         {

data/helpers/lib/NuGetUpdater/NuGetUpdater.Core/Updater/GlobalJsonUpdater.cs

@@ -8,7 +8,7 @@ internal static class GlobalJsonUpdater
         string dependencyName,
         string previousDependencyVersion,
         string newDependencyVersion,
-        Logger logger)
+        ILogger logger)
     {
         if (!MSBuildHelper.TryGetGlobalJsonPath(repoRootPath, workspacePath, out var globalJsonPath))
         {