dependabot-nuget 0.145.1 → 0.145.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37fe2a45777b3c8e967624e5c260f3a56fd83de7085eb8bf737f48acafa48b5c
-  data.tar.gz: 47e4ba5df6e3d26129742a0dbccda1c8f80d0ab4043a7422da4848fa7861858a
+  metadata.gz: 52d629fb65085fe2ba42f1146a516978f751a10c4e8e3751696f3e61a0a707a3
+  data.tar.gz: b6fab20229edb3be27a8f9f3e099516d5e99f45f9c59a5648302e7ba1283ed94
 SHA512:
-  metadata.gz: dbc78cc4eb83e32158816358d06974e96974ad8937fc9068dbc775cc0c69dcbec582a001d4a31c47b3d580e21d9d3fb29994ab7c5351b16ce837bde7151d3560
-  data.tar.gz: 66740c29dcdc262291e405faaeaa79eb95607f59801a509fcc7354e23d453629c8c13040d0f0de0c87ee3c8cb96faea511c4b288d218b82f35e86c7a4bc3cde2
+  metadata.gz: 389596d77cf162e0af83ed032013372008c53127a17bd31823b2c738fc7867f86aa07f8b4f3213ef8f3c35f51077c4314c2e4b9d652fb22ddeda33b72916d7aa
+  data.tar.gz: 9fe1376597dd60fd78fd0ea496ef173296240d5382a9e3cef6d65671a7afecb30acf960b881fdeadc6749673cb42c1230d20326d149ef754267ba487585dc2a0

data/lib/dependabot/nuget/update_checker/version_finder.rb

@@ -210,14 +210,8 @@ module Dependabot
           @v2_nuget_listings ||=
             dependency_urls.
             select { |details| details.fetch(:repository_type) == "v2" }.
-            map do |url_details|
-              response = Excon.get(
-                url_details[:versions_url],
-                idempotent: true,
-                **SharedHelpers.excon_defaults(
-                  excon_options.merge(headers: url_details[:auth_header])
-                )
-              )
+            flat_map { |url_details| fetch_paginated_v2_nuget_listings(url_details) }.
+            map do |url_details, response|
               next unless response.status == 200
 
               {
@@ -227,6 +221,39 @@ module Dependabot
             end.compact
         end
 
+        def fetch_paginated_v2_nuget_listings(url_details, results = {})
+          response = Excon.get(
+            url_details[:versions_url],
+            idempotent: true,
+            **SharedHelpers.excon_defaults(excon_options.merge(headers: url_details[:auth_header]))
+          )
+
+          # NOTE: Short circuit if we get a circular next link
+          return results.to_a if results.key?(url_details)
+
+          results[url_details] = response
+
+          if (link_href = fetch_v2_next_link_href(response.body))
+            url_details = url_details.dup
+            url_details[:versions_url] = link_href
+            fetch_paginated_v2_nuget_listings(url_details, results)
+          end
+
+          results.to_a
+        end
+
+        def fetch_v2_next_link_href(xml_body)
+          doc = Nokogiri::XML(xml_body)
+          doc.remove_namespaces!
+          link_node = doc.xpath("/feed/link").find do |node|
+            rel = node.attribute("rel").value.strip
+            rel == "next"
+          end
+          link_node.attribute("href").value.strip if link_node
+        rescue Nokogiri::XML::XPath::SyntaxError
+          nil
+        end
+
         def versions_for_v3_repository(repository_details)
           # If we have a search URL that returns results we use it
           # (since it will exclude unlisted versions)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-nuget
 version: !ruby/object:Gem::Version
-  version: 0.145.1
+  version: 0.145.2
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-06 00:00:00.000000000 Z
+date: 2021-05-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dependabot-common
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.145.1
+        version: 0.145.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.145.1
+        version: 0.145.2
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: 1.14.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.13.0
+        version: 1.14.0
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement