dependabot-github_actions 0.404.0 → 0.405.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 439ae35a254e6fb3ec27a8dd060058d37c03a05da17b84de0b321d6c4206fd53
4
- data.tar.gz: 74bc5c6f5ae244fec2f7edb9d764c0f758799d7e2d2fdc4c13ab4a6e8249d5b5
3
+ metadata.gz: d6c3f14be8ff4c3a6a1cb3634cbcbbf9f47c30eb71b2034b84802193ace3af82
4
+ data.tar.gz: be6ef882fa9591aaf4381efaefdbe777d4cb961e195bfbeabca5ab325643cac6
5
5
  SHA512:
6
- metadata.gz: faaaa7e87687396144daa0e46dff8b04c4f8f13787d57e1fdccba5cceaf41907415c9992c9d82d21e889d35e70a8637f130387427aee59a761a9c9f04aeeacbc
7
- data.tar.gz: da9848633ca5f4c5f018ea55c9ee6c90d72651b8dbe25704b666e6ec82b822b9a997d74668478de0a832c64ae3ad60f23c2d76162c26cdd553cbd8e5f78c5eb7
6
+ metadata.gz: 3fe7406c511290314ac96c4541446f9d9a26a928050a4497ee78f3217d5085af035af4ff7953ad53cd28a70a61e31e7a64e815b8e82f840b8fea79b859d8428b
7
+ data.tar.gz: ae3fc027502bab283b582e5e43d9380544d6f343b026cb0ac6187b53a21a0eaea419f1c3cbe7622c5c3528017976dcfe59458ea853afb11980cf7202dc00d810
@@ -10,6 +10,7 @@ require "dependabot/errors"
10
10
  require "dependabot/git_tag_with_detail"
11
11
  require "dependabot/github_actions/containing_branch_finder"
12
12
  require "dependabot/github_actions/helpers"
13
+ require "dependabot/github_actions/package/release_candidate"
13
14
  require "dependabot/github_actions/repository_cloner"
14
15
  require "dependabot/github_actions/requirement"
15
16
  require "dependabot/github_actions/update_checker"
@@ -79,7 +80,7 @@ module Dependabot
79
80
  # If the dependency is pinned to a tag that looks like a version then
80
81
  # we want to update that tag.
81
82
  if git_commit_checker.pinned_ref_looks_like_version? && latest_version_tag
82
- latest_version = tag_version(T.must(latest_version_tag))
83
+ latest_version = T.must(latest_version_tag).version
83
84
  return unless latest_version.is_a?(Dependabot::Version)
84
85
  return current_version if shortened_semver_eq?(dependency.version, latest_version.to_s)
85
86
 
@@ -87,7 +88,7 @@ module Dependabot
87
88
  end
88
89
 
89
90
  if git_commit_checker.pinned_ref_looks_like_commit_sha? && latest_version_tag
90
- latest_version = tag_version(T.must(latest_version_tag))
91
+ latest_version = T.must(latest_version_tag).version
91
92
  return unless latest_version.is_a?(Dependabot::Version)
92
93
  return latest_commit_for_pinned_ref unless git_commit_checker.local_tag_for_pinned_sha
93
94
 
@@ -100,7 +101,7 @@ module Dependabot
100
101
  end
101
102
  # rubocop:enable Metrics/PerceivedComplexity
102
103
 
103
- sig { returns(T.nilable(T::Hash[Symbol, Object])) }
104
+ sig { returns(T.nilable(ReleaseCandidate)) }
104
105
  def lowest_security_fix_version_tag
105
106
  # TODO: Support Docker sources
106
107
  return unless git_dependency?
@@ -116,11 +117,11 @@ module Dependabot
116
117
  find_lowest_secure_version(tags)
117
118
  end
118
119
  end,
119
- T.nilable(T::Hash[Symbol, Object])
120
+ T.nilable(ReleaseCandidate)
120
121
  )
121
122
  end
122
123
 
123
- sig { returns(T.nilable(T::Hash[Symbol, Object])) }
124
+ sig { returns(T.nilable(Dependabot::GitTagDetails)) }
124
125
  def latest_version_tag
125
126
  @latest_version_tag ||= T.let(
126
127
  begin
@@ -136,7 +137,7 @@ module Dependabot
136
137
 
137
138
  lower_precision_ref
138
139
  end,
139
- T.nilable(T::Hash[Symbol, Object])
140
+ T.nilable(Dependabot::GitTagDetails)
140
141
  )
141
142
  end
142
143
 
@@ -164,9 +165,9 @@ module Dependabot
164
165
  []
165
166
  end
166
167
 
167
- sig { returns(T::Array[T::Hash[Symbol, Object]]) }
168
+ sig { returns(T::Array[ReleaseCandidate]) }
168
169
  def allowed_version_tags_with_release_dates
169
- allowed_version_tags_hashes = git_commit_checker.local_tags_for_allowed_versions
170
+ allowed_version_tags = git_commit_checker.local_tags_for_allowed_versions
170
171
  tag_to_release_date = T.let({}, T::Hash[String, T.nilable(String)])
171
172
 
172
173
  # Build a map of tag names to release dates for quick lookup
@@ -175,15 +176,12 @@ module Dependabot
175
176
  end
176
177
 
177
178
  # Combine version info with release dates and sort by version descending
178
- result = allowed_version_tags_hashes.map do |tag_hash|
179
- tag_name = tag_name(tag_hash)
180
- tag_hash.merge(
181
- release_date: tag_to_release_date[tag_name]
182
- )
179
+ result = allowed_version_tags.map do |tag|
180
+ ReleaseCandidate.from_details(tag, release_date: tag_to_release_date[tag.tag])
183
181
  end
184
182
 
185
183
  # Sort by version descending (newest first)
186
- result.sort_by { |tag_hash| T.cast(tag_hash.fetch(:version), Gem::Version) }.reverse
184
+ result.sort_by(&:version).reverse
187
185
  end
188
186
 
189
187
  private
@@ -247,39 +245,25 @@ module Dependabot
247
245
  end
248
246
 
249
247
  sig do
250
- params(tags: T::Array[T::Hash[Symbol, Object]]).returns(T.nilable(T::Hash[Symbol, Object]))
248
+ params(tags: T::Array[Dependabot::GitTagDetails]).returns(T.nilable(ReleaseCandidate))
251
249
  end
252
250
  def find_lowest_secure_version(tags)
253
- relevant_tags = tags.reject do |tag|
254
- security_advisories.any? { |advisory| advisory.vulnerable?(T.must(tag_version(tag))) }
251
+ candidates = tags.map { |tag| ReleaseCandidate.from_details(tag) }
252
+ relevant_tags = candidates.reject do |candidate|
253
+ security_advisories.any? { |advisory| advisory.vulnerable?(candidate.version) }
255
254
  end
256
255
 
257
256
  relevant_tags = filter_lower_tags(relevant_tags)
258
- relevant_tags.min_by { |tag| T.must(tag_version(tag)) }
257
+ relevant_tags.min_by(&:version)
259
258
  end
260
259
 
261
260
  sig do
262
- params(tags_array: T::Array[T::Hash[Symbol, Object]]).returns(T::Array[T::Hash[Symbol, Object]])
261
+ params(tags_array: T::Array[ReleaseCandidate]).returns(T::Array[ReleaseCandidate])
263
262
  end
264
263
  def filter_lower_tags(tags_array)
265
264
  return tags_array unless current_version
266
265
 
267
- tags_array.select { |tag| T.must(tag_version(tag)) > current_version }
268
- end
269
-
270
- sig { params(tag: T::Hash[Symbol, Object]).returns(String) }
271
- def tag_name(tag)
272
- return tag.tag if tag.is_a?(Dependabot::GitTagDetails)
273
-
274
- T.cast(tag.fetch(:tag), String)
275
- end
276
-
277
- sig { params(tag: T::Hash[Symbol, Object]).returns(T.nilable(Gem::Version)) }
278
- def tag_version(tag)
279
- return tag.version if tag.is_a?(Dependabot::GitTagDetails)
280
-
281
- version = tag[:version]
282
- version if version.is_a?(Gem::Version)
266
+ tags_array.select { |tag| tag.version > current_version }
283
267
  end
284
268
 
285
269
  sig { returns(T::Boolean) }
@@ -0,0 +1,40 @@
1
+ # typed: strong
2
+ # frozen_string_literal: true
3
+
4
+ require "sorbet-runtime"
5
+
6
+ require "dependabot/git_tag_details"
7
+ require "dependabot/version"
8
+
9
+ module Dependabot
10
+ module GithubActions
11
+ module Package
12
+ class ReleaseCandidate < T::ImmutableStruct
13
+ extend T::Sig
14
+
15
+ const :details, Dependabot::GitTagDetails
16
+ const :version, Dependabot::Version
17
+ const :release_date, T.nilable(String), default: nil
18
+
19
+ sig do
20
+ params(details: Dependabot::GitTagDetails, release_date: T.nilable(String)).returns(ReleaseCandidate)
21
+ end
22
+ def self.from_details(details, release_date: nil)
23
+ version = details.version
24
+ unless version.is_a?(Dependabot::Version)
25
+ raise TypeError, "Git tag #{details.tag} must have a parsed dependency version"
26
+ end
27
+
28
+ new(details: details, version: version, release_date: release_date)
29
+ end
30
+
31
+ private_class_method :new
32
+
33
+ sig { returns(String) }
34
+ def tag
35
+ details.tag
36
+ end
37
+ end
38
+ end
39
+ end
40
+ end
@@ -1,4 +1,4 @@
1
- # typed: strict
1
+ # typed: strong
2
2
  # frozen_string_literal: true
3
3
 
4
4
  require "sorbet-runtime"
@@ -108,17 +108,17 @@ module Dependabot
108
108
  release
109
109
  end
110
110
 
111
- sig { returns(T.nilable(T::Hash[Symbol, T.untyped])) }
111
+ sig { returns(T.nilable(Dependabot::GithubActions::Package::ReleaseCandidate)) }
112
112
  def lowest_security_fix_release
113
113
  available_security_fix_releases
114
114
  end
115
115
 
116
- sig { returns(T.nilable(T::Hash[Symbol, T.untyped])) }
116
+ sig { returns(T.nilable(Dependabot::GitTagDetails)) }
117
117
  def latest_version_tag
118
118
  available_latest_version_tag
119
119
  end
120
120
 
121
- sig { returns(T.nilable(T::Hash[Symbol, T.untyped])) }
121
+ sig { returns(T.nilable(Dependabot::GitTagDetails)) }
122
122
  def latest_version_tag_respecting_cooldown
123
123
  return @latest_version_tag_respecting_cooldown if defined?(@latest_version_tag_respecting_cooldown)
124
124
 
@@ -129,14 +129,14 @@ module Dependabot
129
129
  nil
130
130
  else
131
131
  latest_tag = available_latest_version_tag
132
- if latest_tag&.fetch(:version) == selected_release
132
+ if latest_tag&.version == selected_release
133
133
  latest_tag
134
134
  else
135
135
  tag_for_version(selected_release)
136
136
  end
137
137
  end
138
138
  end,
139
- T.nilable(T::Hash[Symbol, T.untyped])
139
+ T.nilable(Dependabot::GitTagDetails)
140
140
  )
141
141
  end
142
142
 
@@ -176,19 +176,19 @@ module Dependabot
176
176
  )
177
177
  end
178
178
 
179
- sig { returns(T.nilable(T::Hash[Symbol, T.untyped])) }
179
+ sig { returns(T.nilable(Dependabot::GithubActions::Package::ReleaseCandidate)) }
180
180
  def available_security_fix_releases
181
181
  @available_security_fix_releases = T.let(
182
182
  T.must(package_details_fetcher).lowest_security_fix_version_tag,
183
- T.nilable(T::Hash[Symbol, T.untyped])
183
+ T.nilable(Dependabot::GithubActions::Package::ReleaseCandidate)
184
184
  )
185
185
  end
186
186
 
187
- sig { returns(T.nilable(T::Hash[Symbol, T.untyped])) }
187
+ sig { returns(T.nilable(Dependabot::GitTagDetails)) }
188
188
  def available_latest_version_tag
189
189
  @latest_version_tag = T.let(
190
190
  T.must(package_details_fetcher).latest_version_tag,
191
- T.nilable(T::Hash[Symbol, T.untyped])
191
+ T.nilable(Dependabot::GitTagDetails)
192
192
  )
193
193
  end
194
194
 
@@ -231,10 +231,10 @@ module Dependabot
231
231
  # Walk through the candidate version tags in descending order (newest first)
232
232
  # and return the first one NOT in cooldown
233
233
  candidates.each do |tag_info|
234
- tag_name = tag_info.fetch(:tag)
234
+ tag_name = tag_info.tag
235
235
  next if tags_in_cooldown.include?(tag_name)
236
236
 
237
- version = tag_info.fetch(:version)
237
+ version = tag_info.version
238
238
  # Candidates are sorted descending, so once we drop below the pinned version
239
239
  # every remaining candidate would be a downgrade.
240
240
  break if pinned_version && version < pinned_version
@@ -253,27 +253,28 @@ module Dependabot
253
253
  # version. Returns every tag when the pin isn't a version we can reason about
254
254
  # (e.g. a commit SHA), since precision has no meaning in that case.
255
255
  sig do
256
- params(tags: T::Array[T::Hash[Symbol, T.untyped]])
257
- .returns(T::Array[T::Hash[Symbol, T.untyped]])
256
+ params(tags: T::Array[Dependabot::GithubActions::Package::ReleaseCandidate])
257
+ .returns(T::Array[Dependabot::GithubActions::Package::ReleaseCandidate])
258
258
  end
259
259
  def tags_matching_pinned_precision(tags)
260
260
  pinned = pinned_version
261
261
  return tags unless pinned
262
262
 
263
263
  pinned_precision = precision(pinned.to_s)
264
- tags.select { |tag_info| precision(tag_info.fetch(:version).to_s) == pinned_precision }
264
+ tags.select { |tag_info| precision(tag_info.version.to_s) == pinned_precision }
265
265
  end
266
266
 
267
267
  # Resolves a version back to its tag. Versions compare equal across precisions
268
268
  # (`2` == `2.0.0`), so tags matching the pinned precision are preferred to avoid
269
269
  # rewriting e.g. a `v2` pin to `v2.0.0`.
270
- sig { params(version: Dependabot::Version).returns(T.nilable(T::Hash[Symbol, T.untyped])) }
270
+ sig { params(version: Dependabot::Version).returns(T.nilable(Dependabot::GitTagDetails)) }
271
271
  def tag_for_version(version)
272
272
  all_tags = T.must(package_details_fetcher).allowed_version_tags_with_release_dates
273
273
  matching_precision = tags_matching_pinned_precision(all_tags)
274
274
 
275
- matching_precision.find { |tag_hash| tag_hash.fetch(:version) == version } ||
276
- all_tags.find { |tag_hash| tag_hash.fetch(:version) == version }
275
+ candidate = matching_precision.find { |tag| tag.version == version } ||
276
+ all_tags.find { |tag| tag.version == version }
277
+ candidate&.details
277
278
  end
278
279
 
279
280
  sig { returns(T.nilable(Dependabot::Version)) }
@@ -292,18 +293,19 @@ module Dependabot
292
293
  sig do
293
294
  params(
294
295
  tags_with_dates: T.nilable(
295
- T.any(T::Array[Dependabot::GitTagWithDetail], T::Array[T::Hash[Symbol, T.untyped]])
296
+ T.any(
297
+ T::Array[Dependabot::GitTagWithDetail],
298
+ T::Array[Dependabot::GithubActions::Package::ReleaseCandidate]
299
+ )
296
300
  )
297
301
  ).returns(T::Array[String])
298
302
  end
299
303
  def select_version_tags_in_cooldown_period(tags_with_dates = nil)
300
304
  tags_to_check = tags_with_dates || T.must(package_details_fetcher).fetch_tag_and_release_date
301
- # Handle both GitTagWithDetail objects and hashes with release_date
302
305
  in_cooldown = tags_to_check.select do |tag|
303
- release_date = tag.is_a?(Hash) ? tag.fetch(:release_date, nil) : tag.release_date
304
- check_if_version_in_cooldown_period?(release_date)
306
+ check_if_version_in_cooldown_period?(tag.release_date)
305
307
  end
306
- in_cooldown.map { |tag| tag.is_a?(Hash) ? tag.fetch(:tag) : tag.tag }
308
+ in_cooldown.map(&:tag)
307
309
  rescue StandardError => e
308
310
  Dependabot.logger.error("Error checking if version is in cooldown (using empty filter): #{e.message}")
309
311
  []
@@ -324,7 +326,7 @@ module Dependabot
324
326
  sig { returns(T.nilable(String)) }
325
327
  def resolve_commit_metadata_details
326
328
  # First, try GitHub Release published_at via Octokit
327
- tag_name = latest_version_tag&.fetch(:tag, nil)
329
+ tag_name = latest_version_tag&.tag
328
330
  normalized_tag = tag_name ? normalize_tag_name(tag_name) : nil
329
331
  if normalized_tag
330
332
  release_date = github_release_published_at(normalized_tag)
@@ -402,7 +404,7 @@ module Dependabot
402
404
 
403
405
  sig { returns(String) }
404
406
  def commit_ref
405
- latest_version_tag&.fetch(:commit_sha)
407
+ T.must(latest_version_tag&.commit_sha)
406
408
  end
407
409
 
408
410
  sig { returns(T.nilable(T.any(Dependabot::Version, String))) }
@@ -1,4 +1,4 @@
1
- # typed: strict
1
+ # typed: strong
2
2
  # frozen_string_literal: true
3
3
 
4
4
  require "sorbet-runtime"
@@ -53,7 +53,7 @@ module Dependabot
53
53
  sig { override.returns(T.nilable(Dependabot::Version)) }
54
54
  def lowest_security_fix_version
55
55
  @lowest_security_fix_version ||= T.let(
56
- T.must(latest_version_finder).lowest_security_fix_release&.fetch(:version),
56
+ T.must(latest_version_finder).lowest_security_fix_release&.version,
57
57
  T.nilable(Dependabot::Version)
58
58
  )
59
59
  end
@@ -272,7 +272,7 @@ module Dependabot
272
272
  finder = onboarded ? latest_version_finder_for(git_source) : T.must(latest_version_finder)
273
273
 
274
274
  if vulnerable? && (new_tag = finder.lowest_security_fix_release)
275
- return ref_for_release(new_tag, current_ref: current_ref)
275
+ return ref_for_release(new_tag.details, current_ref: current_ref)
276
276
  end
277
277
 
278
278
  source_git_commit_checker = git_helper.git_commit_checker_for(git_source)
@@ -300,17 +300,15 @@ module Dependabot
300
300
 
301
301
  sig do
302
302
  params(
303
- release: T::Hash[Symbol, Object],
303
+ release: Dependabot::GitTagDetails,
304
304
  current_ref: T.nilable(String)
305
305
  ).returns(String)
306
306
  end
307
307
  def ref_for_release(release, current_ref:)
308
- return T.cast(release.fetch(:tag), String) unless pin_to_sha?
309
- if current_ref && Dependabot::GithubActions::Version.path_based?(current_ref)
310
- return T.cast(release.fetch(:tag), String)
311
- end
308
+ return release.tag unless pin_to_sha?
309
+ return release.tag if current_ref && Dependabot::GithubActions::Version.path_based?(current_ref)
312
310
 
313
- T.cast(release.fetch(:commit_sha), String)
311
+ T.must(release.commit_sha)
314
312
  end
315
313
 
316
314
  sig do
@@ -360,7 +358,7 @@ module Dependabot
360
358
 
361
359
  if source_checker.local_tag_for_pinned_sha
362
360
  new_tag = finder.latest_version_tag_respecting_cooldown
363
- new_tag&.fetch(:commit_sha)
361
+ new_tag&.commit_sha
364
362
  else
365
363
  # Keep SHA rewrites aligned with the checker decision (including cooldown filtering).
366
364
  latest = finder.latest_release_version
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: dependabot-github_actions
3
3
  version: !ruby/object:Gem::Version
4
- version: 0.404.0
4
+ version: 0.405.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Dependabot
@@ -15,14 +15,14 @@ dependencies:
15
15
  requirements:
16
16
  - - '='
17
17
  - !ruby/object:Gem::Version
18
- version: 0.404.0
18
+ version: 0.405.0
19
19
  type: :runtime
20
20
  prerelease: false
21
21
  version_requirements: !ruby/object:Gem::Requirement
22
22
  requirements:
23
23
  - - '='
24
24
  - !ruby/object:Gem::Version
25
- version: 0.404.0
25
+ version: 0.405.0
26
26
  - !ruby/object:Gem::Dependency
27
27
  name: debug
28
28
  requirement: !ruby/object:Gem::Requirement
@@ -263,6 +263,7 @@ files:
263
263
  - lib/dependabot/github_actions/lockfile/version_gate.rb
264
264
  - lib/dependabot/github_actions/metadata_finder.rb
265
265
  - lib/dependabot/github_actions/package/package_details_fetcher.rb
266
+ - lib/dependabot/github_actions/package/release_candidate.rb
266
267
  - lib/dependabot/github_actions/package_manager.rb
267
268
  - lib/dependabot/github_actions/repository_cloner.rb
268
269
  - lib/dependabot/github_actions/requirement.rb
@@ -279,7 +280,7 @@ licenses:
279
280
  - MIT
280
281
  metadata:
281
282
  bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
282
- changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.404.0
283
+ changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.405.0
283
284
  rdoc_options: []
284
285
  require_paths:
285
286
  - lib