dependabot-elm 0.364.0 → 0.365.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c007965a651130d28a97c4838ba25cfa0f77a2d661b635702c0480437125ffe4
-  data.tar.gz: 8e81fcbd096a863c7bb6ccef298b445852f02c287d16705e5b11826b78787377
+  metadata.gz: e9e41f54d5b97f943a9bf8e5e7da6b4af66a3a1e6d577ed0c9fb9b9127b156ab
+  data.tar.gz: 6f24cc10c0ba54c38215a2c62d9aceea0f8b62c515292c81b6afd83f8ff5ef4c
 SHA512:
-  metadata.gz: 9b6350658d2c53e3774607101460bbd95c6afc9a42f43486d6b1f4624ff21ba7d60fb1c41bea232165445aaa67218fdfe0232778925f592f094eb16e977304b7
-  data.tar.gz: 16fc5de230b0c9139bc7cda5dae900b30cc45c41c4fb2196f74fd5c1fb5006d6217c2b9b80a1d49c4af1fd5eae7ec9fe023c50393309e620c62ddf07c72668a3
+  metadata.gz: cbc603570ffa409f0b55b5358eb3cf3b5a2eb3f1718d55de0fde3398160c7fd5c2bc6227786a1068506a57f80096c3eca76cb0c2541e8afb65c83c5f36d4b8c5
+  data.tar.gz: 159c85588a710184e0058152b6ecd8dff5243505b6f59ae210c2c4a6d10ec52cfa8ecf58b0f2891c14fe877ce5de2b13e03e908b750b123af71e04b7f70fcb2d

data/lib/dependabot/elm/update_checker/latest_version_finder.rb

@@ -117,12 +117,14 @@ module Dependabot
           params(
             dependency: Dependabot::Dependency,
             dependency_files: T::Array[Dependabot::DependencyFile],
+            ignored_versions: T::Array[String],
             cooldown_options: T.nilable(Dependabot::Package::ReleaseCooldownOptions)
           ).void
         end
-        def initialize(dependency:, dependency_files:, cooldown_options: nil)
+        def initialize(dependency:, dependency_files:, ignored_versions: [], cooldown_options: nil)
           @dependency = dependency
           @dependency_files = dependency_files
+          @ignored_versions = ignored_versions
           @cooldown_options = cooldown_options
 
           @install_metadata = T.let(nil, T.nilable(T::Hash[String, Dependabot::Elm::Version]))
@@ -137,9 +139,17 @@ module Dependabot
           # unlock requirements are `none`. Just return the current version.
           return current_version if unlock_requirement == :none
 
-          # Otherwise, we gotta check a few conditions to see if bumping
-          # wouldn't also bump other deps in elm.json
-          fetch_latest_resolvable_version(unlock_requirement)
+          current = current_version
+          # Run the solver first so errors (unsupported deps, invalid layouts) propagate
+          resolved = fetch_latest_resolvable_version(unlock_requirement)
+          return current unless resolved
+          # If there is no current version (e.g., only a range in elm.json), treat any
+          # successfully resolved version as the candidate update.
+          return cap_at_max_allowed_version(resolved) unless current
+          return current unless resolved > current
+
+          # Cap the solver result at the highest non-ignored, non-cooldown version
+          cap_at_max_allowed_version(resolved)
         end
 
         sig { returns(T::Array[Dependabot::Dependency]) }
@@ -181,6 +191,27 @@ module Dependabot
         sig { returns(T::Array[Dependabot::DependencyFile]) }
         attr_reader :dependency_files
 
+        sig { returns(T::Array[String]) }
+        attr_reader :ignored_versions
+
+        sig { params(resolved: Dependabot::Elm::Version).returns(Dependabot::Elm::Version) }
+        def cap_at_max_allowed_version(resolved)
+          current = current_version
+          releases = package_releases
+          releases = filter_ignored_versions(T.must(releases))
+          releases = filter_by_cooldown(releases)
+          max_allowed = releases.max_by(&:version)&.version
+
+          return resolved unless current
+          return current unless max_allowed && max_allowed > current
+
+          if resolved > max_allowed
+            T.cast(max_allowed, Dependabot::Elm::Version)
+          else
+            resolved
+          end
+        end
+
         sig { returns(T.nilable(T::Array[Dependabot::Package::PackageRelease])) }
         def package_releases
           T.let(
@@ -197,17 +228,6 @@ module Dependabot
           result = check_install_result(changed_deps)
           version_after_install = changed_deps.fetch(dependency.name)
 
-          # returns current version if new proposed version is in cooldown period
-          new_release = package_releases&.find { |release| release.version == version_after_install }
-
-          if cooldown_options && in_cooldown_period?(T.must(new_release))
-            Dependabot.logger.info(
-              "#{dependency.name} #{new_release} is in cooldown period," \
-              " returning current version #{current_version}"
-            )
-            return current_version
-          end
-
           # If the install was clean then we can definitely update
           return version_after_install if result == :clean_bump
 

data/lib/dependabot/elm/update_checker.rb

@@ -75,6 +75,7 @@ module Dependabot
             Elm19LatestVersionFinder.new(
               dependency: dependency,
               dependency_files: dependency_files,
+              ignored_versions: ignored_versions,
               cooldown_options: update_cooldown
             )
           end,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-elm
 version: !ruby/object:Gem::Version
-  version: 0.364.0
+  version: 0.365.0
 platform: ruby
 authors:
 - Dependabot
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.364.0
+        version: 0.365.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.364.0
+        version: 0.365.0
 - !ruby/object:Gem::Dependency
   name: debug
   requirement: !ruby/object:Gem::Requirement
@@ -261,7 +261,7 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
-  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.364.0
+  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.365.0
 rdoc_options: []
 require_paths:
 - lib