dependabot-docker 0.98.31 → 0.98.32

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71d6f0a2cd21acd33075deedcf09591b5ade5461ae5a76c59bd74e172c7ecb7c
-  data.tar.gz: b215653cf9b31b89035e894e83dbfded330d39d0afb7c8b1623bcc8f59f103a8
+  metadata.gz: 68c1ff19fc7aa50edc22b3d8bf09ae125bbd9cfe3e1ba0cfbdec92d44046f60d
+  data.tar.gz: 9ed799e69191a6c6200fc03e24ee07fd64f51dd6b96f00f14f2fbc293ec891bd
 SHA512:
-  metadata.gz: 319457de322c0a93bf7bfa897d37af541ec7ac5d3e584cdc958206482ef5a2395df60eeec1204f3e5a6ed81d58d4c9645a0e7e89704def535be4b2cdf8ec0095
-  data.tar.gz: 299d22c5203fed9dd290abc0611f50ea03812e5f6d7ba96c1dda5a8b91566f220dc761ea3e31e5e65018e45e0cc3f1dad32b5ec93e774f81d2da85c65c7a7a84
+  metadata.gz: 823ba6700646b0a22b35a1147ea10950fc153aac376f88a49a4fc8b254fe12ec23e424a8b7d966b003ed4c88dd53f523d035f00f41e61725c6ea1ce8d2fe811c
+  data.tar.gz: 35a1928043f55b733cb018f3c001755dcff09724949fce771d446c938209805461bfd9da6b809d6be607c38e0cc403f625437eade52939ada09cdf38bcabdf22

data/lib/dependabot/docker/file_parser.rb

@@ -129,14 +129,16 @@ module Dependabot
 
           DockerRegistry2::Registry.new(
             "https://#{registry}",
-            user: credentials&.fetch("username"),
-            password: credentials&.fetch("password")
+            user: credentials&.fetch("username", nil),
+            password: credentials&.fetch("password", nil)
           )
         else
           DockerRegistry2::Registry.new("https://registry.hub.docker.com")
         end
       end
 
+      # Has test that it works without username / password.
+      # TODO: Test with proxy
       def registry_credentials(registry_url)
         credentials_finder.credentials_for_registry(registry_url)
       end

data/lib/dependabot/docker/update_checker.rb

@@ -267,6 +267,8 @@ module Dependabot
         registry_hostname == "registry.hub.docker.com"
       end
 
+      # Has test that it works without username / password.
+      # TODO: Test with proxy
       def registry_credentials
         credentials_finder.credentials_for_registry(registry_hostname)
       end
@@ -286,8 +288,8 @@ module Dependabot
         @docker_registry_client ||=
           DockerRegistry2::Registry.new(
             "https://#{registry_hostname}",
-            user: registry_credentials&.fetch("username"),
-            password: registry_credentials&.fetch("password")
+            user: registry_credentials&.fetch("username", nil),
+            password: registry_credentials&.fetch("password", nil)
           )
       end
 

data/lib/dependabot/docker/utils/credentials_finder.rb

@@ -32,13 +32,15 @@ module Dependabot
 
         def build_aws_credentials(registry_details)
           # If credentials have been generated from AWS we can just return them
-          return registry_details if registry_details.fetch("username") == "AWS"
+          return registry_details if registry_details["username"] == "AWS"
 
           # Otherwise, we need to use the provided Access Key ID and secret to
           # generate a temporary username and password
+          #
+          # TODO: Make this work with proxying
           aws_credentials = Aws::Credentials.new(
-            registry_details.fetch("username"),
-            registry_details.fetch("password")
+            registry_details.fetch("username", nil),
+            registry_details.fetch("password", nil)
           )
 
           registry_hostname = registry_details.fetch("registry")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-docker
 version: !ruby/object:Gem::Version
-  version: 0.98.31
+  version: 0.98.32
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-22 00:00:00.000000000 Z
+date: 2019-03-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dependabot-common
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.98.31
+        version: 0.98.32
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.98.31
+        version: 0.98.32
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement