dependabot-composer 0.112.32 → 0.112.33

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a06f4eb70905fea773a29edb4ba7af3496c7857102d01d1aec9d9fa2bda80443
-  data.tar.gz: efce4200735bb2cca9c0df3f6446ba275b351eaa24df88c2578e1a3a4d0408a3
+  metadata.gz: 91a4093bf950e8bc4c8f79d1ce3133d054ee18e5efc23e0cfedbc61ecf417439
+  data.tar.gz: 1d1a19877cc4eb6ac7d32ebd827d1cea6bbca1c9782f352453c58392d61a898c
 SHA512:
-  metadata.gz: ec74a33c5d11712722f9712729fad4078d7502439f4add027b1973597957fb7e0a41ea50e9a0b65069496e5ea8d2e92c7e6940dfa2c8c5ab8d023a6a63ea2344
-  data.tar.gz: 5a92402a0b9616bf83612e2129c480299e3521a4d1f9310a3ea777845227c0cd1233745973a247ec51f6cfbc299234e8d4a8c23c503d213aed6a5003ef98661e
+  metadata.gz: 205451c0d8d74f86c9c34b137a0875afba60fdd0b924f7f1595880a02107369fe4115d3fbb9f9d5290fe92cae92223999c70f23bef1745d14d782bafc98e7767
+  data.tar.gz: 4322682f89a52185443fc24c4f76b01136a953a6b2dec3fbbe211111323b8f8e2d6f88e6ead31b689766411fbcb64b5884becf0f141f51b6cd41418461b01ea1

data/helpers/src/UpdateChecker.php

@@ -14,37 +14,40 @@ class UpdateChecker
     {
         [$workingDirectory, $dependencyName, $gitCredentials, $registryCredentials] = $args;
 
-        $io = new ExceptionIO();
-        $composer = Factory::create($io, $workingDirectory . '/composer.json');
-        $config = $composer->getConfig();
         $httpBasicCredentials = [];
 
-        foreach ($gitCredentials as &$cred) {
-            $httpBasicCredentials[$cred['host']] = [
-                'username' => $cred['username'],
-                'password' => $cred['password'],
+        foreach ($gitCredentials as $credentials) {
+            $httpBasicCredentials[$credentials['host']] = [
+                'username' => $credentials['username'],
+                'password' => $credentials['password'],
             ];
         }
 
-        foreach ($registryCredentials as &$cred) {
-            $httpBasicCredentials[$cred['registry']] = [
-                'username' => $cred['username'],
-                'password' => $cred['password'],
+        foreach ($registryCredentials as $credentials) {
+            $httpBasicCredentials[$credentials['registry']] = [
+                'username' => $credentials['username'],
+                'password' => $credentials['password'],
             ];
         }
 
-        if ($httpBasicCredentials) {
-            $config->merge(
-                [
-                    'config' => [
-                        'http-basic' => $httpBasicCredentials,
-                    ],
-                ]
-            );
+        $io = new ExceptionIO();
+
+        $composer = Factory::create($io, $workingDirectory . '/composer.json');
+
+        $config = $composer->getConfig();
+
+        if (0 < count($httpBasicCredentials)) {
+            $config->merge([
+                'config' => [
+                    'http-basic' => $httpBasicCredentials,
+                ],
+            ]);
+
             $io->loadConfiguration($config);
         }
 
         $installationManager = new DependabotInstallationManager();
+
         $install = new Installer(
             $io,
             $config,
@@ -73,25 +76,26 @@ class UpdateChecker
 
         $installedPackages = $installationManager->getInstalledPackages();
 
-        $updatedPackage = current(array_filter($installedPackages, function (PackageInterface $package) use ($dependencyName) {
-            return $package->getName() == $dependencyName;
+        $updatedPackage = current(array_filter($installedPackages, static function (PackageInterface $package) use ($dependencyName): bool {
+            return $package->getName() === $dependencyName;
         }));
 
         // We found the package in the list of updated packages. Return its version.
-        if ($updatedPackage) {
+        if ($updatedPackage instanceof PackageInterface) {
             return preg_replace('/^([v])/', '', $updatedPackage->getPrettyVersion());
         }
 
         // We didn't find the package in the list of updated packages. Check if
         // it was replaced by another package (in which case we can ignore).
         foreach ($composer->getPackage()->getReplaces() as $link) {
-            if ($link->getTarget() == $dependencyName) {
+            if ($link->getTarget() === $dependencyName) {
                 return null;
             }
         }
+
         foreach ($installedPackages as $package) {
             foreach ($package->getReplaces() as $link) {
-                if ($link->getTarget() == $dependencyName) {
+                if ($link->getTarget() === $dependencyName) {
                     return null;
                 }
             }
@@ -99,13 +103,14 @@ class UpdateChecker
 
         // Similarly, check if the package was provided by any other package.
         foreach ($composer->getPackage()->getProvides() as $link) {
-            if ($link->getTarget() == $dependencyName) {
+            if ($link->getTarget() === $dependencyName) {
                 return preg_replace('/^([v])/', '', $link->getPrettyConstraint());
             }
         }
+
         foreach ($installedPackages as $package) {
             foreach ($package->getProvides() as $link) {
-                if ($link->getTarget() == $dependencyName) {
+                if ($link->getTarget() === $dependencyName) {
                     return preg_replace('/^([v])/', '', $link->getPrettyConstraint());
                 }
             }

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-composer
 version: !ruby/object:Gem::Version
-  version: 0.112.32
+  version: 0.112.33
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-02 00:00:00.000000000 Z
+date: 2019-09-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: dependabot-common
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.112.32
+        version: 0.112.33
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.112.32
+        version: 0.112.33
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement