dependabot-common 0.253.0 → 0.254.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e33e7c4c1aa5bd36b0efa81b3a427012da0bfe76036df7d3ab232f7ef22ad6fa
-  data.tar.gz: 73d202071035da3cc4c3b81dd69b740dc10ee1acb0f03d47daca39f8a483d07a
+  metadata.gz: cf205c21f19217f308e953e1e19e56366b4ae2235a6cb105f0b0c96a45654693
+  data.tar.gz: '058f62ee7de2253b6eb44011a7bbbf8da613ca2f8e98c393229093ac75d23e98'
 SHA512:
-  metadata.gz: ae1bd08cf3fb1a9a2cbcfee3128655310a114aa4f1525716efcf330aea9ddcc3ae6d25186e1129a4ce3f399827accad03c8ce1848d8bf137c390f1c53d1ff947
-  data.tar.gz: ee68112308238c31e141af0eca5097df87d957e7f733f76034cb407aab6589c79e1f2fa2575a4798dbbcf7f0878128bb5dd6853e7998603589c449a77347663a
+  metadata.gz: 972a03d3e7e8cac3368c7379edccef965578d0528c9a5bd9668a16af6e96ad15af8f8dbf251b2883c83cac98aa12fd933f87bbaf46ec85c0cc6868ca35706ebd
+  data.tar.gz: c304a257424d6c8f2dc6dafd3922214406a019b586458085f330a3c87d4851fac2a48744abfb658ed0891e3abb22ea66d71db714f9dca96bfa05875c7662e882

data/lib/dependabot/clients/azure.rb

@@ -176,7 +176,7 @@ module Dependabot
           base_commit: String,
           commit_message: String,
           files: T::Array[Dependabot::DependencyFile],
-          author_details: T.nilable(T::Hash[String, String])
+          author_details: T.nilable(T::Hash[Symbol, String])
         )
           .returns(T.untyped)
       end

data/lib/dependabot/clients/codecommit.rb

@@ -246,7 +246,7 @@ module Dependabot
       sig do
         params(
           branch_name: String,
-          author_name: String,
+          author_name: T.nilable(String),
           base_commit: String,
           commit_message: String,
           files: T::Array[Dependabot::DependencyFile]

data/lib/dependabot/metadata_finders/base/changelog_finder.rb

@@ -53,6 +53,8 @@ module Dependabot
           @dependency = dependency
           @credentials = credentials
           @suggested_changelog_url = suggested_changelog_url
+          # strip fragment from URL, if present
+          @suggested_changelog_url = @suggested_changelog_url&.split("#")&.first
 
           @new_version = T.let(nil, T.nilable(String))
           @changelog_from_suggested_url = T.let(nil, T.untyped)
@@ -127,16 +129,7 @@ module Dependabot
           suggested_source_client = github_client_for_source(T.must(suggested_source))
           tmp_files = T.unsafe(suggested_source_client).contents(suggested_source&.repo, opts)
 
-          filename = T.must(T.must(suggested_changelog_url).split("/").last).split("#").first
-
-          # If the suggested source points to a specific directory
-          # then we will receive a hash for just the changelog file
-          if suggested_source&.directory && tmp_files[:name] == filename
-            return @changelog_from_suggested_url = tmp_files
-          end
-
-          # Otherwise we will get back an array of hashes representing the files
-          # in the root directory and we need to find the changelog
+          filename = T.must(T.must(suggested_changelog_url).split("/").last)
           @changelog_from_suggested_url =
             tmp_files.find { |f| f.name == filename }
         rescue Octokit::NotFound, Octokit::UnavailableForLegalReasons

data/lib/dependabot/metadata_finders/base.rb

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 require "sorbet-runtime"

data/lib/dependabot/pull_request_creator/bitbucket.rb

@@ -1,4 +1,4 @@
-# typed: strict
+# typed: strong
 # frozen_string_literal: true
 
 require "sorbet-runtime"
@@ -134,7 +134,7 @@ module Dependabot
           base_commit,
           commit_message,
           files,
-          author
+          T.must(author)
         )
       end
 

data/lib/dependabot/pull_request_creator/codecommit.rb

@@ -197,12 +197,11 @@ module Dependabot
 
       sig { void }
       def create_commit
-        author = author_details&.slice(:name, :email, :date)
-        author = nil unless author&.any?
+        author_name = author_details&.fetch(:name)
 
         codecommit_client_for_source.create_commit(
           branch_name,
-          author,
+          author_name,
           base_commit,
           commit_message,
           files

data/lib/dependabot/pull_request_creator/message_builder.rb

@@ -1,6 +1,7 @@
 # typed: strict
 # frozen_string_literal: true
 
+require "time"
 require "pathname"
 require "sorbet-runtime"
 
@@ -126,7 +127,7 @@ module Dependabot
 
         truncate_pr_message(msg)
       rescue StandardError => e
-        Dependabot.logger.error("Error while generating PR message: #{e.message}")
+        suppress_error("PR message", e)
         suffixed_pr_message_header + prefixed_pr_message_footer
       end
 
@@ -161,7 +162,7 @@ module Dependabot
         message += "\n\n" + T.must(message_trailers) if message_trailers
         message
       rescue StandardError => e
-        Dependabot.logger.error("Error while generating commit message: #{e.message}")
+        suppress_error("commit message", e)
         message = commit_subject
         message += "\n\n" + T.must(message_trailers) if message_trailers
         message
@@ -275,7 +276,7 @@ module Dependabot
       def pr_name_prefix
         pr_name_prefixer.pr_name_prefix
       rescue StandardError => e
-        Dependabot.logger.error("Error while generating PR name: #{e.message}")
+        suppress_error("PR name", e)
         ""
       end
 
@@ -735,9 +736,9 @@ module Dependabot
         # Return an empty string if no valid ignore conditions after filtering
         return "" if valid_ignore_conditions.empty?
 
-        # Sort them by updated_at (or created_at if updated_at is nil), taking the latest 20
+        # Sort them by updated_at, taking the latest 20
         sorted_ignore_conditions = valid_ignore_conditions.sort_by do |ic|
-          ic["updated_at"].nil? ? T.must(ic["created_at"]) : T.must(ic["updated_at"])
+          ic["updated-at"].nil? ? Time.at(0).iso8601 : T.must(ic["updated-at"])
         end.last(20)
 
         # Map each condition to a row string
@@ -883,6 +884,12 @@ module Dependabot
           T.nilable(String)
         )
       end
+
+      sig { params(method: String, err: StandardError).void }
+      def suppress_error(method, err)
+        Dependabot.logger.error("Error while generating #{method}: #{err.message}")
+        Dependabot.logger.error(err.backtrace&.join("\n"))
+      end
     end
   end
 end

data/lib/dependabot.rb

@@ -2,5 +2,5 @@
 # frozen_string_literal: true
 
 module Dependabot
-  VERSION = "0.253.0"
+  VERSION = "0.254.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-common
 version: !ruby/object:Gem::Version
-  version: 0.253.0
+  version: 0.254.0
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-04-18 00:00:00.000000000 Z
+date: 2024-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-codecommit
@@ -298,14 +298,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: 1.9.2
 - !ruby/object:Gem::Dependency
   name: gpgme
   requirement: !ruby/object:Gem::Requirement
@@ -382,56 +382,56 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.58.0
+        version: 1.63.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.58.0
+        version: 1.63.2
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: 1.21.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.19.0
+        version: 1.21.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.27.1
+        version: 2.29.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.27.1
+        version: 2.29.1
 - !ruby/object:Gem::Dependency
   name: rubocop-sorbet
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.3
+        version: 0.8.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.7.3
+        version: 0.8.1
 - !ruby/object:Gem::Dependency
   name: turbo_tests
   requirement: !ruby/object:Gem::Requirement
@@ -583,7 +583,7 @@ licenses:
 - Nonstandard
 metadata:
   bug_tracker_uri: https://github.com/dependabot/dependabot-core/issues
-  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.253.0
+  changelog_uri: https://github.com/dependabot/dependabot-core/releases/tag/v0.254.0
 post_install_message: 
 rdoc_options: []
 require_paths: