dependabot-common 0.106.38 → 0.106.39

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec5fad87ccbb53803055b87daa43e794c16f6cfce5718d294eec76e54c9e8ae7
-  data.tar.gz: c1f30794da5a888b6a467c5f7f114dc4b438a864be34a986bcaae0e53ad6ffc5
+  metadata.gz: fa2c92c266b4750d28e0b7a9f8cab6b587c2a7fe250649ae37921ac3180e15a6
+  data.tar.gz: fc8da7b5841ea09f87052ada232dd4ffdbaff7c870f61d5d43f60b21898735e1
 SHA512:
-  metadata.gz: 7df25b052cd32459ca0ef0bb8f32866bf3bb843eed0da9187ba0085b84c9ed34a957843b13d004bbac70f61f21f62a0723c700e4df2f3d8046c11ee99e981552
-  data.tar.gz: 6b79f8456928e87b42f91e66b41c50dfbb8d0ea30a2b5784093a5d0d1138228a6704897e33a3652db395b3fa7112cd0716d46038f2927b44c4d37588408b849e
+  metadata.gz: a48c6d09c14c204ab6741a80b0fa731a8fc2c64ce97e65b03369e7d4f7dff02ea1d6304d0f258b8a9f5e7370666d1c0ea6adfd9dad7b76d2eeddaed2e860ff5e
+  data.tar.gz: a65b102d1d70ff76c203f7f6bd9afd15cb61ad8ddff1f83ad3d776680a052e4f7ab2163fb506824d6ec8fb8f8d27c3c0be01ae8917cdaa8c3a4cc8b5b36280dc

data/lib/dependabot/git_metadata_fetcher.rb

@@ -22,6 +22,14 @@ module Dependabot
       @tags ||= tags_for_upload_pack(upload_pack)
     end
 
+    def ref_names
+      @ref_names ||=
+        upload_pack.lines.
+        select { |l| l.split(" ")[-1].start_with?("refs/tags", "refs/heads") }.
+        map { |line| line.split(%r{ refs/(tags|heads)/}).last.strip }.
+        reject { |l| l.end_with?("^{}") }
+    end
+
     private
 
     attr_reader :url, :credentials

data/lib/dependabot/pull_request_creator/github.rb

@@ -62,18 +62,11 @@ module Dependabot
       end
 
       def branch_exists?(name)
-        @branch_ref ||= {}
-        @branch_ref[name] ||=
-          github_client_for_source.ref(source.repo, "heads/#{name}")
+        git_metadata_fetcher.ref_names.include?(name)
+      rescue Dependabot::GitDependenciesNotReachable
+        raise "Unexpected git error!" if repo_exists?
 
-        if @branch_ref[name].is_a?(Array)
-          @branch_ref[name].any? { |r| r.ref == "refs/heads/#{name}" }
-        else
-          @branch_ref[name].ref == "refs/heads/#{name}"
-        end
-      rescue Octokit::NotFound
-        @branch_ref[name] = []
-        false
+        raise RepoNotFound, source.url
       end
 
       def pull_request_exists?
@@ -281,6 +274,14 @@ module Dependabot
           github_client_for_source.repository(source.repo).default_branch
       end
 
+      def git_metadata_fetcher
+        @git_metadata_fetcher ||=
+          GitMetadataFetcher.new(
+            url: source.url,
+            credentials: credentials
+          )
+      end
+
       def commit_signature(tree, author_details_with_date)
         CommitSigner.new(
           author_details: author_details_with_date,

data/lib/dependabot/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Dependabot
-  VERSION = "0.106.38"
+  VERSION = "0.106.39"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: dependabot-common
 version: !ruby/object:Gem::Version
-  version: 0.106.38
+  version: 0.106.39
 platform: ruby
 authors:
 - Dependabot
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-08 00:00:00.000000000 Z
+date: 2019-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-ecr