departure 7.0.0 → 8.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c90b332f5ca8002ae23bedaab9b368f2aa89c103ab287aa593f5563901e9bb10
-  data.tar.gz: 46c52d6ce29dda0c0358cca5da19bfd5ebbe327e626c3c4c332fa7189df17759
+  metadata.gz: f073be830cc9193469fb3d31d99ce910ac32ab2de6838f8ee18fd30e1b5a4f26
+  data.tar.gz: beaffddbe848d268c6a83051c7b98e294ae06ae489111a8038aed3d836febffd
 SHA512:
-  metadata.gz: dd21cf4f7b78ea979a92424540dde3a0e8bad9d1acf891f334352e5e6f9cc372d0c4fa897d9afb88d1cb282504a65895c00a87b467a52f6ca2423501c7f68af0
-  data.tar.gz: 4b9b1112c42fd3b823eeb613bbde33ec596da1a7b2e1371ef2f87960b60a4c40a21a7d43bd2222269b2a8e71bd00c91bfa5d044ff5c2dce489cc299473b73a22
+  metadata.gz: 37730fd17a593c457fd02060f1bdf07f8c2feb8c9e9e2ad8bb2e3820c38943b0761efb3ee49b9d6fd2d6dc77949b7f9d2c9d784e12556c0826e7462374a128d1
+  data.tar.gz: 24dff29fd1900e9fd555edd491e1f6715548ca04ce9b7dce0a455e935c07790a6b9ecd8fad52e68fec51834df51c87057b9f937d741159503d73d32c40f3207a

data/.github/workflows/test.yml

@@ -12,10 +12,9 @@ jobs:
           - 3.3
           - 3.4
         gemfile:
-          - gemfiles/rails_7_0.gemfile
-          - gemfiles/rails_7_1.gemfile
           - gemfiles/rails_7_2.gemfile
           - gemfiles/rails_8_0.gemfile
+          - gemfiles/rails_8_1.gemfile
     env:
       PERCONA_DB_USER: root
       PERCONA_DB_PASSWORD: root
@@ -43,12 +42,12 @@ jobs:
     env:
       PERCONA_DB_USER: root
       PERCONA_DB_PASSWORD: root
-      BUNDLE_GEMFILE: gemfiles/rails_7_1.gemfile
+      BUNDLE_GEMFILE: gemfiles/rails_8_1.gemfile
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 3.3
+          ruby-version: 3.4
           bundler-cache: true
       - run: bundle exec rubocop --parallel

data/Appraisals

@@ -1,15 +1,13 @@
-appraise 'rails-7-0' do
-  gem 'rails', '7.0.8'
-end
-
-appraise 'rails-7-1' do
-  gem 'rails', '7.1.3'
-end
-
 appraise 'rails-7-2' do
+  gem 'bigdecimal'
   gem 'rails', '7.2.2.1'
 end
 
 appraise 'rails-8-0' do
+  gem 'bigdecimal'
   gem 'rails', '8.0.2.1'
 end
+
+appraise 'rails-8-1' do
+  gem 'rails', '8.1.1'
+end

data/CHANGELOG.md

@@ -4,6 +4,16 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 Please follow the format in [Keep a Changelog](http://keepachangelog.com/)
 
+## [NEXT]
+
+## [8.0.0] - 2025-11-24
+
+- Bump [appraisal to 2.5.0](https://github.com/departurerb/departure/pull/129)
+- Add support for [Rails 8.1](https://github.com/departurerb/departure/pull/128)
+- Skinnify Departure [to remove most non pt-online-schema-change](https://github.com/departurerb/departure/pull/131) responsibility from departure
+- Inherit from [Mysql2 Adapter instead of AbstractMysqlAdapter](https://github.com/departurerb/departure/pull/130)
+- Remove Support for [Rails 7.0 and Rails 7.1](https://github.com/departurerb/departure/pull/135)
+  
 ## [7.0.0] - 2025-08-21
 
 - Drop Ruby 3.1 support.  Add >= 3.2 ruby support in gemspec.  EOL for 3.1.0 was 2025-03-31

data/Dockerfile

@@ -1,4 +1,4 @@
-FROM ruby:3.0
+FROM ruby:3.4
 MAINTAINER muffinista@gmail.com
 
 # Install apt based dependencies required to run Rails as
@@ -14,17 +14,10 @@ RUN apt-get update && apt-get install -y \
 RUN mkdir -p /app /app/lib/departure
 WORKDIR /app
 
-# Copy the Gemfile as well as the Gemfile.lock and install
-# the RubyGems. This is a separate step so the dependencies
-# will be cached unless changes to one of those two files
-# are made.
-COPY departure.gemspec Gemfile ./
-COPY lib/departure/version.rb ./lib/departure/
+# Install bundler - dependencies will be installed via volume mount
+RUN gem install bundler
 
-RUN gem install bundler && bundle install --jobs 20 --retry 5
-
-# Copy the main application.
-COPY . ./
+# Project root will be mounted as volume for live development
 
 # The main command to run when the container starts. Also
 # tell the Rails dev server to bind to all interfaces by

data/Gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: .
   specs:
-    departure (7.0.0)
-      activerecord (>= 7.0.1)
+    departure (8.0.0)
+      activerecord (>= 7.2.0)
       mysql2 (>= 0.4.0, < 0.6.0)
-      railties (>= 7.0.1)
+      railties (>= 7.2.0)
 
 GEM
   remote: https://rubygems.org/
@@ -44,7 +44,7 @@ GEM
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
-    appraisal (2.4.1)
+    appraisal (2.5.0)
       bundler
       rake
       thor (>= 0.14.0)
@@ -86,6 +86,8 @@ GEM
     minitest (5.25.5)
     mutex_m (0.3.0)
     mysql2 (0.5.6)
+    nokogiri (1.18.7-aarch64-linux-gnu)
+      racc (~> 1.4)
     nokogiri (1.18.7-arm64-darwin)
       racc (~> 1.4)
     nokogiri (1.18.7-x86_64-linux-gnu)
@@ -191,6 +193,7 @@ GEM
     zeitwerk (2.6.18)
 
 PLATFORMS
+  aarch64-linux
   arm64-darwin-21
   arm64-darwin-22
   arm64-darwin-23
@@ -198,7 +201,7 @@ PLATFORMS
   x86_64-linux
 
 DEPENDENCIES
-  appraisal (~> 2.4.1)
+  appraisal (~> 2.5.0)
   base64
   climate_control (~> 0.0.3)
   codeclimate-test-reporter (~> 1.0.3)

data/README.md

@@ -213,6 +213,70 @@ When any errors occur, an `ActiveRecord::StatementInvalid` exception is
 raised and the migration is aborted, as all other ActiveRecord connection
 adapters.
 
+### Diagram
+
+```mermaid
+ flowchart TB
+      %% User Level
+      subgraph "Rails Application"
+          Migration["Rails Migration<br/>(ActiveRecord::Migration)"]
+          DSL["Migration DSL<br/>(add_column, create_table, etc.)"]
+      end
+
+      %% Core Departure Components
+      subgraph "Departure System"
+          RailsAdapter["RailsAdapter<br/>(Version Detection)"]
+          DepartureAdapter["Rails81DepartureAdapter<br/>(Connection Adapter)"]
+          Runner["Runner<br/>(Query Interceptor)"]
+          Command["Command<br/>(Process Executor)"]
+          CliGenerator["CliGenerator<br/>(Command Builder)"]
+      end
+
+      %% External Components
+      subgraph "External Tools"
+          PTOSC["pt-online-schema-change<br/>(Percona Toolkit)"]
+          MySQL["MySQL Database"]
+      end
+
+      %% LHM Integration
+      subgraph "LHM Integration"
+          LhmAdapter["Lhm::Adapter<br/>(DSL Translator)"]
+          LhmMigration["LHM Migration"]
+      end
+
+      %% Flow connections
+      Migration --> DSL
+      DSL --> DepartureAdapter
+      DepartureAdapter --> Runner
+      Runner --> |"Non-ALTER statements"| MySQL
+      CliGenerator --> Command
+      Command --> PTOSC
+      PTOSC --> MySQL
+
+      %% LHM Flow
+      LhmMigration --> LhmAdapter
+      LhmAdapter --> DSL
+
+      %% Configuration Flow
+      RailsAdapter --> |"Registers"| DepartureAdapter
+
+      %% Decision Points
+      Runner --> |"Check: ALTER TABLE?"| DecisionNode{{"ALTER TABLE<br/>Statement?"}}
+      DecisionNode --> |"Yes"| CliGenerator
+      DecisionNode --> |"No"| MySQL
+
+      %% Styling
+      classDef departure fill:#e1f5fe
+      classDef external fill:#fff3e0
+      classDef rails fill:#e8f5e8
+      classDef lhm fill:#fce4ec
+
+      class RailsAdapter,DepartureAdapter,Runner,Command,CliGenerator departure
+      class PTOSC,MySQL external
+      class Migration,DSL rails
+      class LhmAdapter,LhmMigration lhm
+```
+
 ## Trouleshooting
 
 ### Error creating new table: DBD::mysql::db do failed: Can't write; duplicate key in table (TABLE_NAME)
@@ -221,6 +285,24 @@ that prevents schema changes when a table has constraints. You should upgrade to
 
 ## Development
 
+### Setup
+
+#### Docker Compose
+
+You can bring up the docker-compose setup and bash into rails in order to not install dependencies on your system
+
+Gems are available on your local file system from tmp/local_gems directory.  We need this due to changes in 
+internals of ActiveRecord and needing to run things like pry to debug how they work.
+
+```
+docker compose up
+docker compose exec rails bash
+bundle install
+# off to the races
+```
+
+#### Manual
+
 After checking out the repo, run `bin/setup` to install dependencies. Then, run
 `rake spec` to run the tests. You can also run `bin/console` for an interactive
 prompt that will allow you to experiment.
@@ -231,6 +313,26 @@ release a new version, update the version number in `version.rb`, and then run
 git commits and tags, and push the `.gem` file to
 [rubygems.org](https://rubygems.org).
 
+### Appraisal
+
+All versions of supported rails are defined in the [Appraisals file](./Appraisals) in project root
+
+#### Usage
+
+Say you want to run a specific test under a version of rails defined in Appraisal `rails-8-0`
+
+```
+bundle exec appraisal rails-8-0 bundle install
+bundle exec appraisal rails-8-0 bundle exec rspec spec/lhm/column_with_sql_spec.rb:50
+```
+
+#### Adding Versions
+
+- Add the version to [Appraisals file](./Appraisals)
+- Run `bundle exec appraisal generate`
+- Run `bundle exec appraisal install`
+- updates ci [test.yml](./.github/workflows/test.yml) in the `gemfile:` section
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at

data/config.yml.erb

@@ -1,5 +1,9 @@
 username: <%= ENV['PERCONA_DB_USER'] || 'root' %>
-password: <%= ENV['PERCONA_DB_PASSWORD'] || '' %> 
-database: <%= ENV['PERCONA_DB_NAME'] || 'departure_test' %> 
-hostname: <%= ENV['PERCONA_DB_HOST'] || 'localhost' %>
-socket: <%= ENV['PERCONA_DB_SOCKET'] || '' %>
+password: <%= ENV['PERCONA_DB_PASSWORD'] || '' %>
+database: <%= ENV['PERCONA_DB_NAME'] || 'departure_test' %>
+<% if ENV['PERCONA_DB_SOCKET'] && !ENV['PERCONA_DB_SOCKET'].empty? %>
+socket: <%= ENV['PERCONA_DB_SOCKET'] %>
+<% else %>
+host: <%= ENV['PERCONA_DB_HOST'] || 'localhost' %>
+port: <%= ENV['PERCONA_DB_PORT'] || 3306 %>
+<% end %>

data/departure.gemspec

@@ -21,11 +21,11 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 3.2.0'
 
-  spec.add_runtime_dependency 'railties', '>= 7.0.1'
-  spec.add_runtime_dependency 'activerecord', '>= 7.0.1'
+  spec.add_runtime_dependency 'railties', '>= 7.2.0'
+  spec.add_runtime_dependency 'activerecord', '>= 7.2.0'
   spec.add_runtime_dependency 'mysql2', '>= 0.4.0', '< 0.6.0'
 
-  spec.add_development_dependency 'appraisal', '~> 2.4.1'
+  spec.add_development_dependency 'appraisal', '~> 2.5.0'
   spec.add_development_dependency 'rake', '>= 10.0'
   spec.add_development_dependency 'rspec', '~> 3.4', '>= 3.4.0'
   spec.add_development_dependency 'rspec-its', '~> 1.2'

data/docker-compose.yml

@@ -16,7 +16,11 @@ services:
       - db
     tty: true
     stdin_open: true
+    volumes:
+      - .:/app
+      - ./tmp/local_gems:/app/vendor/bundle
     environment:
+      BUNDLE_PATH: /app/vendor/bundle
       PERCONA_DB_USER: root
       PERCONA_DB_HOST: db
       PERCONA_DB_PASSWORD:

data/gemfiles/rails_7_2.gemfile

@@ -1,15 +1,16 @@
 # This file was generated by Appraisal
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-gem 'base64'
-gem 'codeclimate-test-reporter', '~> 1.0.3', group: :test, require: nil
-gem 'lhm'
-gem 'logger'
-gem 'mutex_m', require: false
-gem 'rails', '7.2.2.1'
-gem 'rubocop', '~> 1.74.0', require: false
-gem 'rubocop-performance', '~> 1.20.2', require: false
-gem 'zeitwerk', '< 2.7.0'
+gem "base64"
+gem "codeclimate-test-reporter", "~> 1.0.3", group: :test, require: nil
+gem "lhm"
+gem "logger"
+gem "mutex_m", require: false
+gem "rubocop", "~> 1.74.0", require: false
+gem "rubocop-performance", "~> 1.20.2", require: false
+gem "zeitwerk", "< 2.7.0"
+gem "bigdecimal"
+gem "rails", "7.2.2.1"
 
-gemspec path: '../'
+gemspec path: "../"

data/gemfiles/rails_7_2.gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: ..
   specs:
-    departure (6.8.0)
-      activerecord (>= 7.0.1)
+    departure (8.0.0)
+      activerecord (>= 7.2.0)
       mysql2 (>= 0.4.0, < 0.6.0)
-      railties (>= 7.0.1)
+      railties (>= 7.2.0)
 
 GEM
   remote: https://rubygems.org/
@@ -80,14 +80,14 @@ GEM
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
-    appraisal (2.4.1)
+    appraisal (2.5.0)
       bundler
       rake
       thor (>= 0.14.0)
     ast (2.4.3)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
+    base64 (0.3.0)
+    benchmark (0.5.0)
+    bigdecimal (3.3.1)
     builder (3.3.0)
     byebug (12.0.0)
     climate_control (0.0.4)
@@ -96,42 +96,45 @@ GEM
       simplecov (<= 0.13)
     coderay (1.1.3)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.0)
+    connection_pool (2.5.4)
     crass (1.0.6)
-    date (3.4.1)
-    diff-lcs (1.6.1)
+    date (3.5.0)
+    diff-lcs (1.6.2)
     docile (1.1.5)
-    drb (2.2.1)
+    drb (2.2.3)
+    erb (5.1.3)
     erubi (1.13.1)
-    globalid (1.2.1)
+    globalid (1.3.0)
       activesupport (>= 6.1)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    io-console (0.8.0)
-    irb (1.15.1)
+    io-console (0.8.1)
+    irb (1.15.3)
       pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.10.2)
-    language_server-protocol (3.17.0.4)
+    json (2.15.2)
+    language_server-protocol (3.17.0.5)
     lhm (2.2.0)
     lint_roller (1.1.0)
     logger (1.7.0)
-    loofah (2.24.0)
+    loofah (2.24.1)
       crass (~> 1.0.2)
       nokogiri (>= 1.12.0)
-    mail (2.8.1)
+    mail (2.9.0)
+      logger
       mini_mime (>= 0.1.1)
       net-imap
       net-pop
       net-smtp
-    marcel (1.0.4)
+    marcel (1.1.0)
     method_source (1.1.0)
     mini_mime (1.1.5)
-    minitest (5.25.5)
+    minitest (5.26.0)
     mutex_m (0.3.0)
-    mysql2 (0.5.6)
-    net-imap (0.5.6)
+    mysql2 (0.5.7)
+      bigdecimal
+    net-imap (0.5.12)
       date
       net-protocol
     net-pop (0.1.2)
@@ -140,31 +143,43 @@ GEM
       timeout
     net-smtp (0.5.1)
       net-protocol
-    nio4r (2.7.4)
-    nokogiri (1.18.6-arm64-darwin)
+    nio4r (2.7.5)
+    nokogiri (1.18.10-aarch64-linux-gnu)
+      racc (~> 1.4)
+    nokogiri (1.18.10-aarch64-linux-musl)
+      racc (~> 1.4)
+    nokogiri (1.18.10-arm-linux-gnu)
+      racc (~> 1.4)
+    nokogiri (1.18.10-arm-linux-musl)
+      racc (~> 1.4)
+    nokogiri (1.18.10-arm64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.18.10-x86_64-darwin)
+      racc (~> 1.4)
+    nokogiri (1.18.10-x86_64-linux-gnu)
       racc (~> 1.4)
-    nokogiri (1.18.6-x86_64-linux-gnu)
+    nokogiri (1.18.10-x86_64-linux-musl)
       racc (~> 1.4)
-    parallel (1.26.3)
-    parser (3.3.7.4)
+    parallel (1.27.0)
+    parser (3.3.10.0)
       ast (~> 2.4.1)
       racc
-    pp (0.6.2)
+    pp (0.6.3)
       prettyprint
     prettyprint (0.2.0)
-    prism (1.4.0)
+    prism (1.6.0)
     pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
     pry-byebug (3.11.0)
       byebug (~> 12.0)
       pry (>= 0.13, < 0.16)
-    psych (5.2.3)
+    psych (5.2.6)
       date
       stringio
     racc (1.8.1)
-    rack (3.1.12)
-    rack-session (2.1.0)
+    rack (3.1.19)
+    rack-session (2.1.1)
       base64 (>= 0.1.0)
       rack (>= 3.0.0)
     rack-test (2.2.0)
@@ -185,7 +200,7 @@ GEM
       activesupport (= 7.2.2.1)
       bundler (>= 1.15.0)
       railties (= 7.2.2.1)
-    rails-dom-testing (2.2.0)
+    rails-dom-testing (2.3.0)
       activesupport (>= 5.0.0)
       minitest
       nokogiri (>= 1.6)
@@ -201,28 +216,30 @@ GEM
       thor (~> 1.0, >= 1.2.2)
       zeitwerk (~> 2.6)
     rainbow (3.1.1)
-    rake (13.2.1)
-    rdoc (6.13.1)
+    rake (13.3.1)
+    rdoc (6.15.1)
+      erb
       psych (>= 4.0.0)
-    regexp_parser (2.10.0)
-    reline (0.6.0)
+      tsort
+    regexp_parser (2.11.3)
+    reline (0.6.2)
       io-console (~> 0.5)
-    rspec (3.13.0)
+    rspec (3.13.2)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
-    rspec-core (3.13.3)
+    rspec-core (3.13.6)
       rspec-support (~> 3.13.0)
-    rspec-expectations (3.13.3)
+    rspec-expectations (3.13.5)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
     rspec-its (1.3.1)
       rspec-core (>= 3.0.0)
       rspec-expectations (>= 3.0.0)
-    rspec-mocks (3.13.2)
+    rspec-mocks (3.13.7)
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.13.0)
-    rspec-support (3.13.2)
+    rspec-support (3.13.6)
     rubocop (1.74.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
@@ -234,7 +251,7 @@ GEM
       rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.43.0)
+    rubocop-ast (1.47.1)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-performance (1.20.2)
@@ -247,28 +264,36 @@ GEM
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
     simplecov-html (0.10.2)
-    stringio (3.1.6)
-    thor (1.3.2)
-    timeout (0.4.3)
+    stringio (3.1.7)
+    thor (1.4.0)
+    timeout (0.4.4)
+    tsort (0.2.0)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
     useragent (0.16.11)
-    websocket-driver (0.7.7)
+    websocket-driver (0.8.0)
       base64
       websocket-extensions (>= 0.1.0)
     websocket-extensions (0.1.5)
     zeitwerk (2.6.18)
 
 PLATFORMS
-  arm64-darwin-24
-  x86_64-linux
+  aarch64-linux-gnu
+  aarch64-linux-musl
+  arm-linux-gnu
+  arm-linux-musl
+  arm64-darwin
+  x86_64-darwin
+  x86_64-linux-gnu
+  x86_64-linux-musl
 
 DEPENDENCIES
-  appraisal (~> 2.4.1)
+  appraisal (~> 2.5.0)
   base64
+  bigdecimal
   climate_control (~> 0.0.3)
   codeclimate-test-reporter (~> 1.0.3)
   departure!

data/gemfiles/rails_8_0.gemfile

@@ -1,14 +1,16 @@
 # This file was generated by Appraisal
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 
-gem 'base64'
-gem 'codeclimate-test-reporter', '~> 1.0.3', group: :test, require: nil
-gem 'lhm'
-gem 'logger'
-gem 'mutex_m', require: false
-gem 'rails', '8.0.2.1'
-gem 'rubocop', '~> 1.74.0', require: false
-gem 'rubocop-performance', '~> 1.20.2', require: false
+gem "base64"
+gem "codeclimate-test-reporter", "~> 1.0.3", group: :test, require: nil
+gem "lhm"
+gem "logger"
+gem "mutex_m", require: false
+gem "rubocop", "~> 1.74.0", require: false
+gem "rubocop-performance", "~> 1.20.2", require: false
+gem "zeitwerk", "< 2.7.0"
+gem "bigdecimal"
+gem "rails", "8.0.2.1"
 
-gemspec path: '../'
+gemspec path: "../"