departure 4.0.1 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 89a3f4d1cb84878f4a556da1439057a2dc8a402e
-  data.tar.gz: c6b8f26150c220f793ef021b7dc1d7ceb0a7ebe7
+  metadata.gz: 188abb75d64bc512bba775dfe589294bdf3bd075
+  data.tar.gz: 7c06bd461fe3c1a8756a6be3ebf38cc6aad7a9e6
 SHA512:
-  metadata.gz: 66727be4d155815b20da61075f06ddf5e94665e165a3cc9f5ebada94f96e63ac8940efc555a812a127fa013533feb2f3bc0e9342aa5ca0ca699ff8044f000efb
-  data.tar.gz: 89ae513dd2268fddea60c3e11325fcdc309ae02283b74d07a719b77ecf8df968d041d7d92af8d6a35f36d8b341e826a2ce6c42ac9154dec5606cf0da18462daa
+  metadata.gz: fcdc8acbd5a3e40643a745b29423eda2dab89e7b919d6248eb3b73d64c9371bf50874d089790f05012b09845ffe4040ebaee9b9bdc1c01a0043d1ee6d26fa96c
+  data.tar.gz: 1a7933c409ab19e804849a60dd0507d9c6861c9deeadb141fcf03a3022a134dd0c124d56d4911033e2d096aed1b6eb249669f97dbaf8d1eda903d09d0455c744

data/.codeclimate.yml

@@ -0,0 +1,8 @@
+---
+engines:
+  rubocop:
+    enabled: true
+    channel: rubocop-0-49
+ratings:
+  paths:
+  - "**.rb"

data/.rubocop.yml

@@ -0,0 +1,60 @@
+---
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/BlockLength:
+  Max: 20
+  Exclude:
+    - 'spec/*'
+    - 'spec/**/*'
+
+Metrics/BlockNesting:
+  Max: 4
+
+Metrics/ClassLength:
+  Max: 250
+
+Metrics/LineLength:
+  Max: 120
+  Exclude:
+    - 'departure.gemspec'
+    - 'test_database.rb'
+
+Metrics/MethodLength:
+  Max: 30
+
+Metrics/ModuleLength:
+  Max: 250
+
+Metrics/ParameterLists:
+  Max: 5
+
+Performance/Casecmp:
+  Enabled: false
+
+Style/BracesAroundHashParameters:
+  Exclude:
+    - 'spec/fixtures/migrate/**.rb'
+    - 'spec/integration/**.rb'
+
+Style/CommandLiteral:
+  Exclude:
+    - 'test_database.rb'
+
+Style/Documentation:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Exclude:
+    - 'spec/integration_spec.rb'
+
+Style/MultilineMethodCallIndentation:
+  Enabled: false
+
+Style/SymbolArray:
+  Enabled: false
+
+Style/UnneededPercentQ:
+  Exclude:
+    - 'departure.gemspec'
+

data/CHANGELOG.md

@@ -4,14 +4,20 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 
 Please follow the format in [Keep a Changelog](http://keepachangelog.com/)
 
-## [Unreleased]
+## [5.0.0] - 2017-09-19
 
 ### Added
+
+- Support for ActiveRecord 5.0
+- Docker setup to run the spec suite
+
 ### Changed
 ### Deprecated
 ### Removed
 ### Fixed
 
+- Allow using bash special characters in passwords
+
 ## [4.0.1] - 2017-08-01
 
 ### Added

data/Dockerfile

@@ -0,0 +1,32 @@
+FROM ruby:2.3.4
+MAINTAINER muffinista@gmail.com
+
+# Install apt based dependencies required to run Rails as
+# well as RubyGems. As the Ruby image itself is based on a
+# Debian image, we use apt-get to install those.
+RUN apt-get update && apt-get install -y \
+  build-essential \
+  percona-toolkit
+
+# Configure the main working directory. This is the base
+# directory used in any further RUN, COPY, and ENTRYPOINT
+# commands.
+RUN mkdir -p /app /app/lib/departure
+WORKDIR /app
+
+# Copy the Gemfile as well as the Gemfile.lock and install 
+# the RubyGems. This is a separate step so the dependencies 
+# will be cached unless changes to one of those two files 
+# are made.
+COPY departure.gemspec Gemfile ./ 
+COPY lib/departure/version.rb ./lib/departure/
+
+RUN gem install bundler && bundle install --jobs 20 --retry 5
+
+# Copy the main application.
+COPY . ./
+
+# The main command to run when the container starts. Also
+# tell the Rails dev server to bind to all interfaces by
+# default.
+#CMD ["bundle", "exec", "rails", "server", "-b", "0.0.0.0"]

data/Gemfile

@@ -2,4 +2,5 @@ source 'https://rubygems.org'
 
 gemspec
 
-gem "codeclimate-test-reporter", '~> 1.0.3', group: :test, require: nil
+gem 'codeclimate-test-reporter', '~> 1.0.3', group: :test, require: nil
+gem 'rubocop', '~> 0.49.1', require: false

data/README.md

@@ -117,10 +117,10 @@ Departure.configure do |config|
 end
 ```
 
-Unlike using `PERCONA_ARGS`, options provided with global configuration will be applied 
+Unlike using `PERCONA_ARGS`, options provided with global configuration will be applied
 every time sql command is executed via `pt-online-schema-change`.
- 
-Arguments provided in global configuration can be overwritten with `PERCONA_ARGS` env variable. 
+
+Arguments provided in global configuration can be overwritten with `PERCONA_ARGS` env variable.
 
 We recommend using this option with caution and only when you understand the consequences.
 
@@ -171,6 +171,12 @@ When an any error occurs, an `ActiveRecord::StatementInvalid` exception is
 raised and the migration is aborted, as all other ActiveRecord connection
 adapters.
 
+## Trouleshooting
+
+### Error creating new table: DBD::mysql::db do failed: Can't write; duplicate key in table (TABLE_NAME)
+There is a [known bug](https://bugs.launchpad.net/percona-toolkit/+bug/1498128) in percona-toolkit version 2.2.15
+that prevents schema changes when a table has constraints. You should upgrade to a version later than 2.2.17 to fix the issue.
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
-require "bundler/setup"
-require "percona_migrator"
+require 'bundler/setup'
+require 'percona_migrator'
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.
@@ -10,5 +10,5 @@ require "percona_migrator"
 # require "pry"
 # Pry.start
 
-require "irb"
+require 'irb'
 IRB.start

data/bin/rspec

@@ -1,17 +1,16 @@
 #!/usr/bin/env ruby
 # frozen_string_literal: true
-#
+
 # This file was generated by Bundler.
 #
 # The application 'rspec' is installed as part of a gem, and
 # this file is here to facilitate running it.
 #
 
-require "pathname"
-ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../../Gemfile",
-  Pathname.new(__FILE__).realpath)
+require 'pathname'
+ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', Pathname.new(__FILE__).realpath)
 
-require "rubygems"
-require "bundler/setup"
+require 'rubygems'
+require 'bundler/setup'
 
-load Gem.bin_path("rspec-core", "rspec")
+load Gem.bin_path('rspec-core', 'rspec')

data/config.yml.erb

@@ -0,0 +1,4 @@
+username: <%= ENV['PERCONA_DB_USER'] || 'root' %>
+password: <%= ENV['PERCONA_DB_PASSWORD'] || '' %> 
+database: <%= ENV['PERCONA_DB_NAME'] || 'departure_test' %> 
+hostname: <%= ENV['PERCONA_DB_HOST'] || 'localhost' %>

data/configuration.rb

@@ -1,12 +1,13 @@
 require 'yaml'
+require 'erb'
 
 class Configuration
-  CONFIG_PATH = 'config.yml'
+  CONFIG_PATH = 'config.yml.erb'.freeze
 
   attr_reader :config
 
   def initialize
-    @config = YAML.load_file(CONFIG_PATH)
+    @config = YAML.load(ERB.new(File.read(CONFIG_PATH)).result).freeze
   end
 
   def [](key)

data/departure.gemspec

@@ -1,4 +1,5 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
@@ -7,21 +8,20 @@ require 'departure/version'
 Gem::Specification.new do |spec|
   spec.name          = 'departure'
   spec.version       = Departure::VERSION
-  spec.authors       = ['Ilya Zayats', 'Pau Pérez', 'Fran Casas', 'Jorge Morante', 'Enrico Stano', 'Adrian Serafin']
-  spec.email         = ['ilya.zayats@redbooth.com', 'pau.perez@redbooth.com', 'fran.casas@redbooth.com', 'jorge.morante@redbooth.com', 'adrian@softmad.pl']
+  spec.authors       = ['Ilya Zayats', 'Pau Pérez', 'Fran Casas', 'Jorge Morante', 'Enrico Stano', 'Adrian Serafin', 'Kirk Haines']
+  spec.email         = ['ilya.zayats@redbooth.com', 'pau.perez@redbooth.com', 'fran.casas@redbooth.com', 'jorge.morante@redbooth.com', 'adrian@softmad.pl', 'wyhaines@gmail.com']
 
-  spec.summary       = %q{pt-online-schema-change runner for ActiveRecord migrations}
-  spec.description   = %q{Execute your ActiveRecord migrations with Percona's pt-online-schema-change. Formerly known as Percona Migrator.}
+  spec.summary       = %q(pt-online-schema-change runner for ActiveRecord migrations)
+  spec.description   = %q(Execute your ActiveRecord migrations with Percona's pt-online-schema-change. Formerly known as Percona Migrator.)
   spec.homepage      = 'http://github.com/redbooth/departure'
   spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'rails', '~> 4.2.0'
+  spec.add_runtime_dependency 'rails', '~> 5.0.0'
   spec.add_runtime_dependency 'mysql2', '~> 0.4.0'
 
-  spec.add_development_dependency 'bundler', '~> 1.10'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.4', '>= 3.4.0'
   spec.add_development_dependency 'rspec-its', '~> 1.2'

data/docker-compose.yml

@@ -0,0 +1,23 @@
+version: '2'
+services:
+  db:
+    image: mysql/mysql-server
+    ports: 
+      - "3306:3306"
+    environment:
+      MYSQL_DATABASE: departure_test
+      MYSQL_ALLOW_EMPTY_PASSWORD: 'yes'
+      MYSQL_ROOT_HOST: '%'
+  rails:
+    build: .
+    links:
+      - db
+    depends_on:
+      - db
+    tty: true
+    stdin_open: true
+    environment:
+      PERCONA_DB_USER: root
+      PERCONA_DB_HOST: db
+      PERCONA_DB_PASSWORD:
+      PERCONA_DB_NAME: departure_test

data/lib/active_record/connection_adapters/percona_adapter.rb

@@ -41,7 +41,7 @@ module ActiveRecord
   module ConnectionAdapters
     class DepartureAdapter < AbstractMysqlAdapter
 
-      class Column < AbstractMysqlAdapter::Column
+      class Column < ActiveRecord::ConnectionAdapters::MySQL::Column
         def adapter
           DepartureAdapter
         end
@@ -54,18 +54,18 @@ module ActiveRecord
       def_delegators :mysql_adapter, :last_inserted_id, :each_hash, :set_field_encoding
 
       def initialize(connection, _logger, connection_options, _config)
+        @mysql_adapter = connection_options[:mysql_adapter]
         super
         @prepared_statements = false
-        @mysql_adapter = connection_options[:mysql_adapter]
       end
 
       def exec_delete(sql, name, binds)
         execute(to_sql(sql, binds), name)
         @connection.affected_rows
       end
-      alias :exec_update :exec_delete
+      alias exec_update exec_delete
 
-      def exec_insert(sql, name, binds, pk = nil, sequence_name = nil)
+      def exec_insert(sql, name, binds, pk = nil, sequence_name = nil) # rubocop:disable Lint/UnusedMethodArgument, Metrics/LineLength
         execute(to_sql(sql, binds), name)
       end
 
@@ -76,8 +76,9 @@ module ActiveRecord
 
       # Executes a SELECT query and returns an array of rows. Each row is an
       # array of field values.
-      def select_rows(sql, name = nil)
-        execute(sql, name).to_a
+
+      def select_rows(arel, name = nil, binds = [])
+        select_all(arel, name, binds).rows
       end
 
       # Executes a SELECT query and returns an array of record hashes with the
@@ -91,9 +92,11 @@ module ActiveRecord
         true
       end
 
-      def new_column(field, default, cast_type, sql_type = nil, null = true, collation = '', extra = '')
-        Column.new(field, default, cast_type, sql_type, null, collation, strict_mode?, extra)
+      # rubocop:disable Metrics/ParameterLists
+      def new_column(field, default, type_metadata, null, table_name, default_function, collation, comment)
+        Column.new(field, default, type_metadata, null, table_name, default_function, collation, comment)
       end
+      # rubocop:enable Metrics/ParameterLists
 
       # Adds a new index to the table
       #
@@ -102,7 +105,7 @@ module ActiveRecord
       # @param options [Hash] optional
       def add_index(table_name, column_name, options = {})
         index_name, index_type, index_columns, index_options = add_index_options(table_name, column_name, options)
-        execute "ALTER TABLE #{quote_table_name(table_name)} ADD #{index_type} INDEX #{quote_column_name(index_name)} (#{index_columns})#{index_options}"
+        execute "ALTER TABLE #{quote_table_name(table_name)} ADD #{index_type} INDEX #{quote_column_name(index_name)} (#{index_columns})#{index_options}" # rubocop:disable Metrics/LineLength
       end
 
       # Remove the given index from the table.
@@ -116,8 +119,7 @@ module ActiveRecord
 
       # Returns the MySQL error number from the exception. The
       # AbstractMysqlAdapter requires it to be implemented
-      def error_number(_exception)
-      end
+      def error_number(_exception); end
 
       def full_version
         mysql_adapter.raw_connection.server_info[:version]

data/lib/departure.rb

@@ -32,7 +32,7 @@ module Departure
   def self.load
     ActiveRecord::Migrator.instance_eval do
       class << self
-        alias_method(:original_migrate, :migrate)
+        alias original_migrate migrate
       end
 
       # Checks whether arguments are being passed through PERCONA_ARGS when running

data/lib/departure/alter_argument.rb

@@ -37,7 +37,7 @@ module Departure
     def parsed_statement
       @parsed_statement ||= statement
         .gsub(ALTER_TABLE_REGEX, '')
-        .gsub('`','\\\`')
+        .gsub('`', '\\\`')
     end
   end
 end

data/lib/departure/cli_generator.rb

@@ -5,12 +5,11 @@ require 'departure/connection_details'
 require 'departure/user_options'
 
 module Departure
-
   # Generates the equivalent Percona's pt-online-schema-change command to the
   # given SQL statement
   #
-  # --no-check-alter is used to allow running CHANGE COLUMN statements. For
-  #   more details, check: www.percona.com/doc/percona-toolkit/2.2/pt-online-schema-change.html#cmdoption-pt-online-schema-change--[no]check-alter
+  # --no-check-alter is used to allow running CHANGE COLUMN statements. For more details, check:
+  # www.percona.com/doc/percona-toolkit/2.2/pt-online-schema-change.html#cmdoption-pt-online-schema-change--[no]check-alter # rubocop:disable Metrics/LineLength
   #
   class CliGenerator
     COMMAND_NAME = 'pt-online-schema-change'.freeze

data/lib/departure/command.rb

@@ -47,7 +47,7 @@ module Departure
             data = stdout.read_nonblock(8)
             logger.write_no_newline(data)
           end
-        rescue EOFError
+        rescue EOFError # rubocop:disable Lint/HandleExceptions
           # noop
         ensure
           @status = waith_thr.value
@@ -69,7 +69,7 @@ module Departure
     # @raise [SignalError] if the spawned process received a signal
     # @raise [CommandNotFoundError] if pt-online-schema-change can't be found
     def validate_status!
-      raise SignalError.new(status) if status.signaled?
+      raise SignalError.new(status) if status.signaled? # rubocop:disable Style/RaiseArgs
       raise CommandNotFoundError if status.exitstatus == COMMAND_NOT_FOUND
       raise Error, error_message unless status.success?
     end

data/lib/departure/connection_details.rb

@@ -1,7 +1,8 @@
+require 'shellwords'
 module Departure
   # Holds the parameters of the DB connection and formats them to string
   class ConnectionDetails
-
+    DEFAULT_PORT = 3306
     # Constructor
     #
     # @param [Hash] connection parametes as used in #establish_conneciton
@@ -14,7 +15,7 @@ module Departure
     #
     # @return [String]
     def to_s
-      @to_s ||= "-h #{host} -u #{user} #{password_argument}"
+      @to_s ||= "-h #{host} -P #{port} -u #{user} #{password_argument}"
     end
 
     # TODO: Doesn't the abstract adapter already handle this somehow?
@@ -33,7 +34,7 @@ module Departure
     # @return [String]
     def password_argument
       if password.present?
-        "-p #{password}"
+        %(--password #{Shellwords.escape(password)} )
       else
         ''
       end
@@ -66,5 +67,12 @@ module Departure
     def password
       ENV.fetch('PERCONA_DB_PASSWORD', connection_data[:password])
     end
+
+    # Returns the database's port.
+    #
+    # @return [String]
+    def port
+      connection_data.fetch(:port, DEFAULT_PORT)
+    end
   end
 end

data/lib/departure/dsn.rb

@@ -1,9 +1,7 @@
 module Departure
-
   # Represents the 'DSN' argument of Percona's pt-online-schema-change
   # See https://www.percona.com/doc/percona-toolkit/2.0/pt-online-schema-change.html#dsn-options
   class DSN
-
     # Constructor
     #
     # @param database [String, Symbol]

data/lib/departure/log_sanitizers/password_sanitizer.rb

@@ -1,7 +1,7 @@
 module Departure
   module LogSanitizers
     class PasswordSanitizer
-      PASSWORD_REPLACEMENT = '[filtered_password]'
+      PASSWORD_REPLACEMENT = '[filtered_password]'.freeze
 
       delegate :password_argument, to: :connection_details
 
@@ -15,6 +15,7 @@ module Departure
       end
 
       private
+
       attr_accessor :connection_details
     end
   end

data/lib/departure/logger.rb

@@ -4,7 +4,6 @@ module Departure
   # the from ActiveRecord::Migration because the migration's instance can't be
   # seen from the connection adapter.
   class Logger
-
     def initialize(sanitizers)
       @sanitizers = sanitizers
     end
@@ -15,7 +14,7 @@ module Departure
     # @param message [String]
     # @param subitem [Boolean] whether to show message as a nested log item
     def say(message, subitem = false)
-      write "#{subitem ? "   ->" : "--"} #{message}"
+      write "#{subitem ? '   ->' : '--'} #{message}"
     end
 
     # Outputs the text through the stdout adding a new line at the end

data/lib/departure/logger_factory.rb

@@ -1,6 +1,5 @@
 module Departure
   module LoggerFactory
-
     # Returns the appropriate logger instance for the given configuration. Use
     # :verbose option to log to the stdout
     #

data/lib/departure/option.rb

@@ -24,10 +24,10 @@ module Departure
     #
     # @param [Option]
     # @return [Boolean]
-    def ==(another_option)
-      name == another_option.name
+    def ==(other)
+      name == other.name
     end
-    alias :eql? :==
+    alias eql? ==
 
     # Returns the option's hash
     #
@@ -65,7 +65,7 @@ module Departure
     def value_as_string
       if value.nil?
         ''
-      elsif value.include?("=")
+      elsif value.include?('=')
         " #{value}"
       else
         "=#{value}"

data/lib/departure/runner.rb

@@ -1,11 +1,9 @@
 require 'open3'
 
 module Departure
-
   # It executes pt-online-schema-change commands in a new process and gets its
   # output and status
   class Runner
-
     # Constructor
     #
     # @param logger [#say, #write]

data/lib/departure/version.rb

@@ -1,3 +1,3 @@
 module Departure
-  VERSION = '4.0.1'.freeze
+  VERSION = '5.0.0'.freeze
 end

data/lib/lhm.rb

@@ -4,14 +4,13 @@ require 'lhm/adapter'
 # while providing a different behaviour. We delegate all LHM's methods to
 # ActiveRecord so that you don't need to modify your old LHM migrations
 module Lhm
-
   # Yields an adapter instance so that Lhm migration Dsl methods get
   # delegated to ActiveRecord::Migration ones instead
   #
   # @param table_name [String]
   # @param _options [Hash]
   # @param block [Block]
-  def self.change_table(table_name, _options = {}, &block)
+  def self.change_table(table_name, _options = {}, &block) # rubocop:disable Lint/UnusedMethodArgument
     yield Adapter.new(@migration, table_name)
   end
 
@@ -22,4 +21,3 @@ module Lhm
     @migration = migration
   end
 end
-

data/lib/lhm/adapter.rb

@@ -2,12 +2,10 @@ require 'lhm/column_with_sql'
 require 'lhm/column_with_type'
 
 module Lhm
-
   # Translates Lhm DSL to ActiveRecord's one, so Lhm migrations will now go
   # through Percona as well, without any modification on the migration's
   # code
   class Adapter
-
     # Constructor
     #
     # @param migration [ActiveRecord::Migtration]
@@ -79,7 +77,7 @@ module Lhm
     # @param index_name [String]
     def add_unique_index(columns, index_name = nil)
       options = { unique: true }
-      options.merge!(name: index_name) if index_name
+      options.merge!(name: index_name) if index_name # rubocop:disable Performance/RedundantMerge
 
       migration.add_index(table_name, columns, options)
     end

data/lib/lhm/column_with_sql.rb

@@ -1,7 +1,6 @@
 require 'forwardable'
 
 module Lhm
-
   # Abstracts the details of a table column definition when specified with a MySQL
   # column definition string
   class ColumnWithSql
@@ -54,11 +53,16 @@ module Lhm
     # @return [column_factory]
     def column
       cast_type = ActiveRecord::Base.connection.lookup_cast_type(definition)
+      metadata = ActiveRecord::ConnectionAdapters::SqlTypeMetadata.new(
+        type: cast_type.type,
+        sql_type: definition,
+        limit: cast_type.limit
+      )
+      mysql_metadata = ActiveRecord::ConnectionAdapters::MySQL::TypeMetadata.new(metadata)
       @column ||= self.class.column_factory.new(
         name,
         default_value,
-        cast_type,
-        definition,
+        mysql_metadata,
         null_value
       )
     end

data/lib/lhm/column_with_type.rb

@@ -1,12 +1,10 @@
 module Lhm
-
   # Abstracts the details of a table column definition when specified with a type
   # as a symbol. This is the regular ActiveRecord's #add_column syntax:
   #
   #   add_column :tablenames, :field, :string
   #
   class ColumnWithType
-
     # Constructor
     #
     # @param name [String, Symbol]

data/test_database.rb

@@ -1,9 +1,12 @@
+require 'active_record'
+
 # Setups the test database with the schema_migrations table that ActiveRecord
 # requires for the migrations, plus a table for the Comment model used throught
 # the tests.
 #
 class TestDatabase
 
+
   # Constructor
   #
   # @param config [Hash]
@@ -19,7 +22,7 @@ class TestDatabase
     drop_and_create_schema_migrations_table
   end
 
-  # Creates the #{database} database and the comments table in it.
+  # Creates the #{@database} database and the comments table in it.
   # Before, it drops both if they already exist
   def setup_test_database
     drop_and_create_test_database
@@ -29,7 +32,13 @@ class TestDatabase
   # Creates the ActiveRecord's schema_migrations table required for
   # migrations to work. Before, it drops the table if it already exists
   def drop_and_create_schema_migrations_table
-    %x(#{mysql_command} "USE #{database}; DROP TABLE IF EXISTS schema_migrations; CREATE TABLE schema_migrations ( version varchar(255) COLLATE utf8_unicode_ci NOT NULL, UNIQUE KEY unique_schema_migrations (version)) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci")
+   sql = [
+    "USE #{@database}",
+    "DROP TABLE IF EXISTS schema_migrations",
+    "CREATE TABLE schema_migrations ( version varchar(255) COLLATE utf8_unicode_ci NOT NULL, UNIQUE KEY unique_schema_migrations (version)) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci"
+    ]
+
+    run_commands(sql)
   end
 
   private
@@ -37,16 +46,37 @@ class TestDatabase
   attr_reader :config, :database
 
   def drop_and_create_test_database
-    %x(#{mysql_command} "DROP DATABASE IF EXISTS #{database}; CREATE DATABASE #{database} DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_unicode_ci;")
+    sql = [
+      "DROP DATABASE IF EXISTS #{@database}",
+      "CREATE DATABASE #{@database} DEFAULT CHARACTER SET utf8 DEFAULT COLLATE utf8_unicode_ci"
+    ]
+
+    run_commands(sql)
   end
 
   def drop_and_create_comments_table
-    %x(#{mysql_command} "USE #{database}; DROP TABLE IF EXISTS comments; CREATE TABLE comments ( id int(12) NOT NULL AUTO_INCREMENT, PRIMARY KEY (id)) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci;")
+    sql = [
+      "USE #{@database}",
+      "DROP TABLE IF EXISTS comments",
+      "CREATE TABLE comments ( id int(12) NOT NULL AUTO_INCREMENT, PRIMARY KEY (id)) ENGINE=InnoDB DEFAULT CHARSET=utf8 COLLATE=utf8_unicode_ci"
+    ]
+
+    run_commands(sql)
+  end
+
+  def run_commands(sql)
+    conn.execute("START TRANSACTION")
+    sql.each { |str|
+      conn.execute(str)
+    }
+    conn.execute("COMMIT")
   end
 
-  # Returns the command to run the mysql client. It uses the crendentials from
-  # the provided config
-  def mysql_command
-    "mysql --user=#{config['username']} --password=#{config['password']} -e"
+  def conn
+    @conn ||= ActiveRecord::Base.mysql2_connection(
+      host: @config['hostname'],
+      username: @config['username'],
+      password: @config['password'],
+      reconnect: true)
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: departure
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 5.0.0
 platform: ruby
 authors:
 - Ilya Zayats
@@ -10,10 +10,11 @@ authors:
 - Jorge Morante
 - Enrico Stano
 - Adrian Serafin
+- Kirk Haines
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-01 00:00:00.000000000 Z
+date: 2017-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -21,14 +22,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.0.0
 - !ruby/object:Gem::Dependency
   name: mysql2
   requirement: !ruby/object:Gem::Requirement
@@ -43,20 +44,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.4.0
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.10'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.10'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -147,15 +134,19 @@ email:
 - fran.casas@redbooth.com
 - jorge.morante@redbooth.com
 - adrian@softmad.pl
+- wyhaines@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
+- Dockerfile
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -164,10 +155,11 @@ files:
 - bin/console
 - bin/rspec
 - bin/setup
-- config.yml
+- config.yml.erb
 - configuration.rb
 - departure.gemspec
 - departure_error.log
+- docker-compose.yml
 - lib/active_record/connection_adapters/percona_adapter.rb
 - lib/departure.rb
 - lib/departure/alter_argument.rb

data/config.yml

@@ -1,3 +0,0 @@
-username: 'root'
-password: ''
-database: 'departure_test'