departure 3.0.1 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4128e93b7f92a2b1b74274f3f96936e37463c565
-  data.tar.gz: f01ddfd8e230f37bbd3d1dfaaca7f7dd235d4fca
+  metadata.gz: 6212b46cc9534ddacaefd8341432e124ccce6247
+  data.tar.gz: 4f99581bf9f9657ff07adf9684dc93d40b9dfa8c
 SHA512:
-  metadata.gz: 68807558488c5cf6dd6ecdcb6b0ad83966a1e75d5994ab8b650aeed12e3784c20035cf6ce750af7a430f2263573d2cde049b627aa6fe125793bd39c6ebad5b54
-  data.tar.gz: 0ea99d8fa590efee5874d0cefe8b8ed78d2d4bb8f1c03ca774a1f32d873d7ea2eac3934767ef983982dcb36fef2d2d1a7e0469e677dffa4fe87196aeb2537026
+  metadata.gz: 85c386d3d73919fe7e61d805835d5ddd8478fc8f204be09bd563151d67f1469424c7a89e40bdee579da483687f9602d071f80dd3bf9cdd547c78d2e80a91e325
+  data.tar.gz: aeef6570099eee655fc5eb7cd4b9dda7c0f7f4c482d575b83700ad8cbdbe63a1a914e173de1dc68467aa2b84fd2d3ba61d7608ed8a6ea03d422451a798e297c7

data/CHANGELOG.md

@@ -12,29 +12,31 @@ Please follow the format in [Keep a Changelog](http://keepachangelog.com/)
 ### Removed
 ### Fixed
 
-## [3.0.1] - 2017-05-11
+## [4.0.0] - 2017-06-12
 
 ### Added
+### Changed
 
-- Allow running on other than default MySQL port
+- Rename the gem from percona_migrator to departure.
 
-### Changed
 ### Deprecated
 ### Removed
-### Fixed
 
-- Handle special characters in connection's password
-- `rename_table` and `rename_index` migration methods
+- Percona_migrator's deprecation warnings when installing and running the gem.
+
+### Fixed
 
-## [3.0.0] - 2017-05-02
+## [3.0.0] - 2016-04-07
 
 ### Added
 
+- Support for ActiveRecord 4.2.x
+- Support for Mysql2 4.x
 - Allow passing any `pt-online-schema-change`'s arguments through the
    `PERCONA_ARGS` env var when executing a migration with `rake db:migrate:up`
    or `db:migrate:down`.
-- Filter MySQL's password from logs.
-- Allow setting global percona arguments via gem configuration.
+- Allow setting global percona arguments via gem configuration
+- Filter MySQL's password from logs
 
 ### Changed
 
@@ -42,13 +44,6 @@ Please follow the format in [Keep a Changelog](http://keepachangelog.com/)
     So far, this was purposely set to `none`. To keep this same behaviour
     provide the `PERCONA_ARGS=--recursion-method=none` env var when running the
     migration.
-- Rename the gem from percona_migrator to departure.
-
-### Removed
-
-- Percona_migrator's deprecation warnings when installing and running the gem.
-
-### Fixed
 
 ## [1.0.0] - 2016-11-30
 

data/README.md

@@ -26,6 +26,21 @@ Toolkit](https://www.percona.com/doc/percona-toolkit/2.0/pt-online-schema-change
 
 `brew install percona-toolkit`
 
+If when running a migration you see an error like:
+
+```
+PerconaMigrator::Error: Cannot connect to MySQL: Cannot connect to MySQL because
+the Perl DBI module is not installed or not found.
+```
+
+You also need to install the DBI and DBD::MySQL modules from `cpan`.
+
+```
+$ sudo cpan
+cpan> install DBI
+cpan> install DBD::mysql
+```
+
 ### Linux
 
 #### Ubuntu/Debian based
@@ -97,7 +112,7 @@ You can specify any `pt-online-schema-change` arguments in global gem configurat
 using `global_percona_args` option.
 
 ```ruby
-PerconaMigrator.configure do |config|
+Departure.configure do |config|
   config.global_percona_args = '--chunk-time=1 --critical-load=55'
 end
 ```
@@ -123,7 +138,7 @@ again in your next migration.
 You can override any of the default values from an initializer:
 
 ```ruby
-PerconaMigrator.configure do |config|
+Departure.configure do |config|
   config.tmp_path = '/tmp/'
 end
 ```
@@ -135,20 +150,20 @@ It's strongly recommended to name it after this gems name, such as
 
 When booting your Rails app, Departure extends the
 `ActiveRecord::Migration#migrate` method to reset the connection and reestablish
-it using the `PerconaAdapter` instead of the one you defined in your
+it using the `DepartureAdapter` instead of the one you defined in your
 `config/database.yml`.
 
 Then, when any migration DSL methods such as `add_column` or `create_table` are
 executed, they all go to the
-[PerconaAdapter](https://github.com/redbooth/departure/blob/master/lib/active_record/connection_adapters/percona_adapter.rb).
+[DepartureAdapter](https://github.com/redbooth/departure/blob/master/lib/active_record/connection_adapters/departure_adapter.rb).
 There, the methods that require `ALTER TABLE` SQL statements, like `add_column`,
 are overriden to get executed with
-[PerconaMigrator::Runner](https://github.com/redbooth/departure/blob/master/lib/departure/runner.rb),
+[Departure::Runner](https://github.com/redbooth/departure/blob/master/lib/departure/runner.rb),
 which deals with the `pt-online-schema-change` binary. All the others, like
 `create_table`, are delegated to the ActiveRecord's built in Mysql2Adapter and
 so they follow the regular path.
 
-[PerconaMigrator::Runner](https://github.com/redbooth/departure/blob/master/lib/departure/runner.rb)
+[Departure::Runner](https://github.com/redbooth/departure/blob/master/lib/departure/runner.rb)
 spawns a new process that runs the `pt-online-schema-change` binary present in
 the system, with the apropriate arguments for the generated SQL.
 

data/RELEASING.md

@@ -1,4 +1,4 @@
-# Releasing Departure
+# Releasing Percona Migrator
 
 All releases come from the master branch. All other branches won't be maintained
 and will receive bug fix releases only.
@@ -7,7 +7,7 @@ In order to give support to a new major Rails version, we'll branch off of
 master, name it following the Rails repo convention, such as `v4.2`, and
 we'll keep it open for bug fixes.
 
-1. Update `lib/departure/version.rb` accordingly
+1. Update `lib/percona_migrator/version.rb` accordingly
 2. Review the `CHANGELOG.md` and add a new section following the format
    `[version] - YYYY-MM-DD`. We conform to the guidelines of
    http://keepachangelog.com/

data/departure.gemspec

@@ -18,8 +18,8 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   spec.require_paths = ['lib']
 
-  spec.add_runtime_dependency 'rails', '~> 4.1.0'
-  spec.add_runtime_dependency 'mysql2', '0.3.20'
+  spec.add_runtime_dependency 'rails', '~> 4.2.0'
+  spec.add_runtime_dependency 'mysql2', '~> 0.4.0'
 
   spec.add_development_dependency 'bundler', '~> 1.10'
   spec.add_development_dependency 'rake', '~> 10.0'

data/lib/active_record/connection_adapters/percona_adapter.rb

@@ -51,12 +51,11 @@ module ActiveRecord
 
       ADAPTER_NAME = 'Percona'.freeze
 
-      def_delegators :mysql_adapter, :last_inserted_id, :each_hash,
-                     :set_field_encoding, :full_version
+      def_delegators :mysql_adapter, :last_inserted_id, :each_hash, :set_field_encoding
 
       def initialize(connection, _logger, connection_options, _config)
         super
-        @visitor = BindSubstitution.new(self)
+        @prepared_statements = false
         @mysql_adapter = connection_options[:mysql_adapter]
       end
 
@@ -92,8 +91,8 @@ module ActiveRecord
         true
       end
 
-      def new_column(field, default, type, null, collation, extra = "")
-        Column.new(field, default, type, null, collation, extra)
+      def new_column(field, default, cast_type, sql_type = nil, null = true, collation = '', extra = '')
+        Column.new(field, default, cast_type, sql_type, null, collation, strict_mode?, extra)
       end
 
       # Adds a new index to the table
@@ -120,6 +119,10 @@ module ActiveRecord
       def error_number(_exception)
       end
 
+      def full_version
+        mysql_adapter.raw_connection.server_info[:version]
+      end
+
       private
 
       attr_reader :mysql_adapter

data/lib/departure/cli_generator.rb

@@ -18,7 +18,6 @@ module Departure
       [
         Option.new('execute'),
         Option.new('statistics'),
-        Option.new('recursion-method', 'none'),
         Option.new('alter-foreign-keys-method', 'auto'),
         Option.new('no-check-alter')
       ]

data/lib/departure/connection_details.rb

@@ -2,7 +2,6 @@ module Departure
   # Holds the parameters of the DB connection and formats them to string
   class ConnectionDetails
 
-    DEFAULT_PORT = 3306
     # Constructor
     #
     # @param [Hash] connection parametes as used in #establish_conneciton
@@ -15,7 +14,7 @@ module Departure
     #
     # @return [String]
     def to_s
-      @to_s ||= "-h #{host} -P #{port} -u #{user} #{password_argument}"
+      @to_s ||= "-h #{host} -u #{user} #{password_argument}"
     end
 
     # TODO: Doesn't the abstract adapter already handle this somehow?
@@ -34,7 +33,7 @@ module Departure
     # @return [String]
     def password_argument
       if password.present?
-        %Q[--password "#{password}" ]
+        "-p #{password}"
       else
         ''
       end
@@ -67,12 +66,5 @@ module Departure
     def password
       ENV.fetch('PERCONA_DB_PASSWORD', connection_data[:password])
     end
-
-    # Returns the database's port.
-    #
-    # @return [String]
-    def port
-      connection_data.fetch(:port, DEFAULT_PORT)
-    end
   end
 end

data/lib/departure/version.rb

@@ -1,3 +1,3 @@
 module Departure
-  VERSION = '3.0.1'.freeze
+  VERSION = '4.0.0'.freeze
 end

data/lib/lhm/column_with_sql.rb

@@ -2,8 +2,8 @@ require 'forwardable'
 
 module Lhm
 
-  # Abstracts the details of a table column definition when specified with a
-  # MySQL column definition string
+  # Abstracts the details of a table column definition when specified with a MySQL
+  # column definition string
   class ColumnWithSql
     extend Forwardable
 
@@ -53,9 +53,11 @@ module Lhm
     #
     # @return [column_factory]
     def column
+      cast_type = ActiveRecord::Base.connection.lookup_cast_type(definition)
       @column ||= self.class.column_factory.new(
         name,
         default_value,
+        cast_type,
         definition,
         null_value
       )

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: departure
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 4.0.0
 platform: ruby
 authors:
 - Ilya Zayats
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-11 00:00:00.000000000 Z
+date: 2017-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -21,28 +21,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 4.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 4.1.0
+        version: 4.2.0
 - !ruby/object:Gem::Dependency
   name: mysql2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.20
+        version: 0.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.3.20
+        version: 0.4.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement