departure 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ef3cc8883b3b4dc294f1b94b7d93744e98812849
-  data.tar.gz: 242eac0339dd6f9aedf020d321cd9e6cc0bc24fe
+  metadata.gz: 46a9c8a62c998a6bf3caf83ed058da349e5acd37
+  data.tar.gz: 589cbb49256f86b439f2efd1f8091a837826543e
 SHA512:
-  metadata.gz: 515ab293664312a15f3482f1b0cc0156c325b59df452fa82a9a700adbff81197d1cfffcb4b1296a1afdad47f828a6aeffe0e5b831b61ff37dd89fab0127abdd4
-  data.tar.gz: 35b2746785ba419acddf8e2629e564f9382e7107fd4e57dcd75750e7440f347b3d1e4ce4c96a22a330096bec2bb383ef039070244a522dfd27df87018f850dd1
+  metadata.gz: 750081ba7900c49b24771556c38ce074302ac3db19c713c697fa3631108a8674056d7a42dac53a6978a04f8fdddb7ceac8c4603d11ef8a5579128c8bb5caf206
+  data.tar.gz: d083c3d43c83161ddb1c243582d8b1910589b687b751b0209a52c27058be29b026f295cae1e3b1cb2c133b4ef20f8c9edfa32a27958e3ed028951c9cbc502e73

data/CHANGELOG.md

@@ -8,9 +8,22 @@ Please follow the format in [Keep a Changelog](http://keepachangelog.com/)
 
 ### Added
 ### Changed
+### Deprecated
 ### Removed
 ### Fixed
 
+## [2.0.1 - 2017-05-11]
+
+### Added
+
+- Allow running on other than default MySQL port
+
+### Changed
+### Removed
+### Fixed
+
+- Handle special characters in connection's password
+
 ## [2.0.0 - 2017-04-20]
 
 ### Added

data/README.md

@@ -1,4 +1,4 @@
-# Departure [![Build Status](https://travis-ci.org/redbooth/departure.svg?branch=master)](https://travis-ci.org/redbooth/percona_migrator) [![Code Climate](https://codeclimate.com/github/redbooth/percona_migrator/badges/gpa.svg)](https://codeclimate.com/github/redbooth/percona_migrator)
+# Departure [![Build Status](https://travis-ci.org/redbooth/departure.svg?branch=master)](https://travis-ci.org/redbooth/departure) [![Code Climate](https://codeclimate.com/github/redbooth/departure/badges/gpa.svg)](https://codeclimate.com/github/redbooth/departure)
 
 Departure is an **ActiveRecord connection adapter** that allows running
 **MySQL online and non-blocking DDL** through `ActiveRecord::Migration` without needing
@@ -62,7 +62,7 @@ You can also get it from [Percona's apt repository](https://www.percona.com/doc/
 Once installed, add this line to your application's Gemfile:
 
 ```ruby
-gem 'percona_migrator'
+gem 'departure'
 ```
 
 And then execute:
@@ -71,7 +71,7 @@ And then execute:
 
 Or install it yourself as:
 
-    $ gem install percona_migrator
+    $ gem install departure
 
 ## Usage
 
@@ -144,7 +144,7 @@ end
 ```
 
 It's strongly recommended to name it after this gems name, such as
-`config/initializers/percona_migrator.rb`
+`config/initializers/departure.rb`
 
 ## How it works
 
@@ -155,15 +155,15 @@ it using the `PerconaAdapter` instead of the one you defined in your
 
 Then, when any migration DSL methods such as `add_column` or `create_table` are
 executed, they all go to the
-[PerconaAdapter](https://github.com/redbooth/percona_migrator/blob/master/lib/active_record/connection_adapters/percona_adapter.rb).
+[PerconaAdapter](https://github.com/redbooth/departure/blob/master/lib/active_record/connection_adapters/percona_adapter.rb).
 There, the methods that require `ALTER TABLE` SQL statements, like `add_column`,
 are overriden to get executed with
-[PerconaMigrator::Runner](https://github.com/redbooth/percona_migrator/blob/master/lib/percona_migrator/runner.rb),
+[PerconaMigrator::Runner](https://github.com/redbooth/departure/blob/master/lib/departure/runner.rb),
 which deals with the `pt-online-schema-change` binary. All the others, like
 `create_table`, are delegated to the ActiveRecord's built in Mysql2Adapter and
 so they follow the regular path.
 
-[PerconaMigrator::Runner](https://github.com/redbooth/percona_migrator/blob/master/lib/percona_migrator/runner.rb)
+[PerconaMigrator::Runner](https://github.com/redbooth/departure/blob/master/lib/departure/runner.rb)
 spawns a new process that runs the `pt-online-schema-change` binary present in
 the system, with the apropriate arguments for the generated SQL.
 
@@ -186,7 +186,7 @@ git commits and tags, and push the `.gem` file to
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at
-https://github.com/redbooth/percona_migrator. They need to be opened against
+https://github.com/redbooth/departure. They need to be opened against
 `master` or `v3.2` only if the changes fix a bug in Rails 3.2 apps.
 
 Please note that this project is released with a Contributor Code of Conduct. By

data/RELEASING.md

@@ -1,4 +1,4 @@
-# Releasing Percona Migrator
+# Releasing Departure
 
 All releases come from the master branch. All other branches won't be maintained
 and will receive bug fix releases only.
@@ -7,7 +7,7 @@ In order to give support to a new major Rails version, we'll branch off of
 master, name it following the Rails repo convention, such as `v4.2`, and
 we'll keep it open for bug fixes.
 
-1. Update `lib/percona_migrator/version.rb` accordingly
+1. Update `lib/departure/version.rb` accordingly
 2. Review the `CHANGELOG.md` and add a new section following the format
    `[version] - YYYY-MM-DD`. We conform to the guidelines of
    http://keepachangelog.com/

data/bin/console

@@ -1,7 +1,7 @@
 #!/usr/bin/env ruby
 
 require "bundler/setup"
-require "percona_migrator"
+require "departure"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

data/departure.gemspec

@@ -7,7 +7,7 @@ require 'departure/version'
 Gem::Specification.new do |spec|
   spec.name          = 'departure'
   spec.version       = Departure::VERSION
-  spec.authors       = ['Ilya Zayats', 'Pau Pérez', 'Fran Casas', 'Jorge Morante', 'Adrian Serafin']
+  spec.authors       = ['Ilya Zayats', 'Pau Pérez', 'Fran Casas', 'Jorge Morante', 'Enrico Stano', 'Adrian Serafin']
   spec.email         = ['ilya.zayats@redbooth.com', 'pau.perez@redbooth.com', 'fran.casas@redbooth.com', 'jorge.morante@redbooth.com', 'adrian@softmad.pl']
 
   spec.summary       = %q{pt-online-schema-change runner for ActiveRecord migrations}

data/lib/departure/connection_details.rb

@@ -2,6 +2,7 @@ module Departure
   # Holds the parameters of the DB connection and formats them to string
   class ConnectionDetails
 
+    DEFAULT_PORT = 3306
     # Constructor
     #
     # @param [Hash] connection parametes as used in #establish_conneciton
@@ -14,7 +15,7 @@ module Departure
     #
     # @return [String]
     def to_s
-      @to_s ||= "-h #{host} -u #{user} #{password_argument}"
+      @to_s ||= "-h #{host} -P #{port} -u #{user} #{password_argument}"
     end
 
     # TODO: Doesn't the abstract adapter already handle this somehow?
@@ -33,7 +34,7 @@ module Departure
     # @return [String]
     def password_argument
       if password.present?
-        "-p #{password}"
+        %Q[--password "#{password}" ]
       else
         ''
       end
@@ -66,5 +67,12 @@ module Departure
     def password
       ENV.fetch('PERCONA_DB_PASSWORD', connection_data[:password])
     end
+
+    # Returns the database's port.
+    #
+    # @return [String]
+    def port
+      connection_data.fetch(:port, DEFAULT_PORT)
+    end
   end
 end

data/lib/departure/version.rb

@@ -1,3 +1,3 @@
 module Departure
-  VERSION = '2.0.0'.freeze
+  VERSION = '2.0.1'.freeze
 end

metadata

@@ -1,18 +1,19 @@
 --- !ruby/object:Gem::Specification
 name: departure
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - Ilya Zayats
 - Pau Pérez
 - Fran Casas
 - Jorge Morante
+- Enrico Stano
 - Adrian Serafin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-20 00:00:00.000000000 Z
+date: 2017-05-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails