dentaku 4.0.1 → 4.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8c52e5ed43e8cc6d9ac6f3cf81ae522e408860ab24bf59109bdd97301e0d6e12
-  data.tar.gz: fa376e35d073d5c0ebce858f96c4c1322ed1bba2a202dc6e41d265c1e5fa24f3
+  metadata.gz: 498d10748b47ba3ab1930e2d3df6685d8d557e1e4f7b95a0887952507557325a
+  data.tar.gz: a47a69280b8c298a299edbba9758b0dc132fdcceecb055eaa4008c0427d785de
 SHA512:
-  metadata.gz: 040e836d96fad9833095285a2d3a9b6b7e7a3c4bffcd84cac9603bc16128308acb719103eb96693cc04910c028265231f72f982658dd34523d3685ac4dea8e7d
-  data.tar.gz: 66aa9ee21ce77b2d9dd25d44b3a7f1db7212e7776614839d4c92e403ed0d4e5561fee07e28a50eb81c1a886bf889c1ae285c4a89aa78a59910f5636de66159d4
+  metadata.gz: '0466598da5b7018075787a018873cc72f4185faa40eabe3596b1666646625d70d29c199a8ac91d5fe0c4436d5b960f5cc9c95efbfe6ff2ea91a4855928074288'
+  data.tar.gz: '0440877441b431ffb55da23343fe1fff2271afd6ef4868f86a860927ba26f6e37ffa586514dee83a3c018cea4506615377e092ead2135b1cf39e440006a3a933'

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Change Log
 
+## [v4.0.2] 2026-08-02
+- the 4.0.1 guard against arithmetic that rejects a well-typed operand only
+  worked on Ruby 3.4+. Ruby 3.2 and 3.3 do not raise for an oversized
+  exponent: `Integer#**` warns and returns `Float::INFINITY`, so there was
+  nothing to rescue and `Infinity` still leaked out of the non-bang
+  `Calculator#evaluate` (#332). Arithmetic now also rejects a non-finite
+  result computed from finite operands, so `evaluate` returns `nil` and
+  `evaluate!` raises `Dentaku::ArgumentError` on every supported Ruby.
+  Operands that are already infinite are passed through unchanged.
+
 ## [v4.0.1] 2026-08-02
 - parsing no longer executes user functions. The three parse-time operand
   validators (`Arithmetic`, `Negation`, and the logical combinators) asked

data/lib/dentaku/ast/arithmetic.rb

@@ -38,7 +38,7 @@ module Dentaku
         l = cast(left_value)
         r = cast(right_value)
 
-        begin
+        result = begin
           l.public_send(operator, r)
         rescue ::TypeError => e
           # Right cannot be converted to a suitable type for left. e.g. [] + 1
@@ -53,6 +53,27 @@ module Dentaku
           # promises to return nil rather than raise.
           raise Dentaku::ArgumentError.for(:invalid_value, actual: r), e.message
         end
+
+        validate_result(result, l, r)
+      end
+
+      # Not every Ruby rejects an operation it cannot carry out. Before 3.4,
+      # `Integer#**` with an oversized exponent warns and returns
+      # Float::INFINITY where 3.4+ raises ArgumentError, and overflowing float
+      # arithmetic is silently infinite on every version. Finite operands that
+      # produce a non-finite result mean the operation overflowed, so treat it
+      # as the same rejection newer Rubies raise -- otherwise Infinity leaks
+      # out of Calculator#evaluate, which promises nil on failure (#332).
+      def validate_result(result, l, r)
+        return result unless nonfinite?(result)
+        return result if nonfinite?(l) || nonfinite?(r)
+
+        raise Dentaku::ArgumentError.for(:invalid_value, actual: r),
+              "Result of #{l} #{operator} #{r} is not a finite number"
+      end
+
+      def nonfinite?(val)
+        val.is_a?(::Numeric) && val.respond_to?(:finite?) && !val.finite?
       end
 
       def cast(val)

data/lib/dentaku/version.rb

@@ -1,3 +1,3 @@
 module Dentaku
-  VERSION = "4.0.1"
+  VERSION = "4.0.2"
 end

data/spec/ast/arithmetic_spec.rb

@@ -177,9 +177,12 @@ describe Dentaku::AST::Arithmetic do
     let(:oversized) { "999999999999999 ^ 99999999999999" }
 
     it 'wraps the raw Ruby error so it is a Dentaku::Error' do
+      # Ruby 3.4+ raises ArgumentError('exponent is too large') and we pass its
+      # message through; older Rubies only warn and return Infinity, which the
+      # non-finite result guard turns into the equivalent Dentaku error.
       expect {
         Dentaku::Calculator.new.evaluate!(oversized)
-      }.to raise_error(Dentaku::ArgumentError, /exponent is too large/)
+      }.to raise_error(Dentaku::ArgumentError, /exponent is too large|is not a finite number/)
     end
 
     it 'is rescuable as Dentaku::Error' do
@@ -209,6 +212,17 @@ describe Dentaku::AST::Arithmetic do
       expect(Dentaku::Calculator.new.evaluate!("2 ^ 10")).to eq(1024)
     end
 
+    it 'still evaluates large results that BigDecimal can represent' do
+      expect(Dentaku::Calculator.new.evaluate!("1e308 * 10")).to eq(BigDecimal("1e309"))
+    end
+
+    it 'leaves arithmetic alone when an operand is already infinite' do
+      calculator = Dentaku::Calculator.new
+
+      expect(calculator.evaluate!("a + 1", a: Float::INFINITY)).to be_infinite
+      expect(calculator.evaluate!("a * 2", a: Float::INFINITY)).to be_infinite
+    end
+
     it 'does not swallow Dentaku errors raised by the operation itself' do
       expect {
         Dentaku::Calculator.new.evaluate!("1 / 0")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: dentaku
 version: !ruby/object:Gem::Version
-  version: 4.0.1
+  version: 4.0.2
 platform: ruby
 authors:
 - Solomon White