deltavista_crif_dva_interface 0.0.15 → 0.0.16

data/lib/deltavista_crif_dva_interface/address_update.rb

@@ -79,7 +79,7 @@ module DeltavistaCrifDvaInterface
 
         [address, metadata]
       else
-        raise NotFoundError.new(2, "Test")
+        raise NotFoundError.new response_code(xml_doc), response_text(xml_doc)
       end
     end
 

data/lib/deltavista_crif_dva_interface/credit_check_short_v02.rb

@@ -1,27 +1,33 @@
 module DeltavistaCrifDvaInterface
   class CreditCheckShortV02 < XmlConverter
+    DEFAULT_OPTIONS = {
+      :encoding => 'UTF-8',
+      :request_type => 'CreditCheckShort'
+    }.freeze
 
-    # XML request and response encoding
-    @@encoding = 'UTF-8'
     # unique id for each request
     @@reference_id = 1000
 
-    def initialize config
-      @username = config.username
-      @password = config.password
-      @request_type = "CreditCheckShort"
+    def initialize options
+      @config = {}
+      if options.is_a? Hash
+        @config = DEFAULT_OPTIONS.merge(options)
+      else
+        @config[:username] = options.username
+        @config[:password] = options.password
+        @config = DEFAULT_OPTIONS.merge(@config)
+      end
     end
 
     def to_xml(address)
-      puts address.inspect
-      builder = Nokogiri::XML::Builder.new(:encoding => @@encoding) do |xml|
+      builder = Nokogiri::XML::Builder.new(:encoding => @config[:encoding]) do |xml|
         xml.dvaCheckRequest {
           xml.identity {
-            xml.username @username
-            xml.password @password
+            xml.username @config[:username]
+            xml.password @config[:password]
           }
           xml.reference @@reference_id
-          xml.requestType @request_type
+          xml.requestType @config[:request_type]
           xml.private {
             %w(title lastName firstName maidenName street house poBox zip city country phone birthDate sex).each do |key|
               xml.send(key, address[key.downcase]) if address[key.downcase] && !address[key.downcase].empty?
@@ -34,39 +40,29 @@ module DeltavistaCrifDvaInterface
     end
 
     def to_hash(xml_body)
-      puts xml_body
-      xml_doc = Nokogiri.XML(xml_body, nil, @@encoding)
+      xml_doc = Nokogiri.XML(xml_body, nil, @config[:encoding])
       if valid_response? xml_doc
         # private tag
         address = {}
-        xml_doc.xpath("//private").each do |private_node|
-          %w(addressId title lastName firstName maidenName street house poBox zip city country phone birthDate sex score).each do |key|
+        xml_doc.xpath("//dvaCheckResponse/private").each do |private_node|
+          %w(addressId title lastName firstName maidenName street house poBox zip city country phone birthDate sex).each do |key|
             if key == "country"
-              address[key.downcase] = convert_country(private_node.xpath(key).collect(&:text)[0])
+              address[key.downcase.to_sym] = convert_country get_value(private_node, key)
             else
-              address[key.downcase] = private_node.xpath(key).collect(&:text)[0]
+              address[key.downcase.to_sym] = get_value(private_node, key)
             end
           end
         end
-        xml_doc.xpath("//payLoad").each do |payload_node|
+        xml_doc.xpath("//dvaCheckResponse/private/payLoad").each do |payload_node|
           %w(personStatus score decision hasDebt decisionComment).each do |key|
-            address[key.downcase] = payload_node.xpath(key).collect(&:text)[0]
+            address[key.downcase.to_sym] = get_value(payload_node, key)
           end
         end
         address
       else
-        puts "Response not valid!"
-        nil
+        raise NotFoundError.new response_code(xml_doc), response_text(xml_doc)
       end
     end
-
-    def response_code(xml)
-      xml.xpath("//response/responseCode").collect(&:text)[0]
-    end
-
-    def valid_response?(xml)
-      response_code(xml) == '0' ? true : false
-    end
   end
 end
 

data/lib/deltavista_crif_dva_interface/delta_vista_service.rb

@@ -32,7 +32,6 @@ module DeltavistaCrifDvaInterface
     end
 
     def extract_response(xml_body)
-      puts xml_body
       @parser.to_hash(xml_body)
     end
   end

data/lib/deltavista_crif_dva_interface/version.rb

@@ -1,3 +1,3 @@
 module DeltavistaCrifDvaInterface
-  VERSION = "0.0.15"
+  VERSION = "0.0.16"
 end

metadata

@@ -2,7 +2,7 @@
 name: deltavista_crif_dva_interface
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.15
+  version: 0.0.16
 platform: ruby
 authors: 
   - Marc Cadalbert
@@ -11,7 +11,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-03-27 00:00:00 +02:00
+date: 2012-03-28 00:00:00 +02:00
 default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency