deltavista_crif_dva_interface 0.0.9 → 0.0.10

data/lib/deltavista_crif_dva_interface.rb

@@ -4,9 +4,6 @@ require "deltavista_crif_dva_interface/version"
 require "deltavista_crif_dva_interface/config"
 require "deltavista_crif_dva_interface/restful_service"
 require "deltavista_crif_dva_interface/delta_vista_service"
+require "deltavista_crif_dva_interface/xml_converter"
 require "deltavista_crif_dva_interface/credit_check_short_v02"
 require "deltavista_crif_dva_interface/address_update"
-
-module DeltavistaCrifDvaInterface
-  # Your code goes here...
-end

data/lib/deltavista_crif_dva_interface/address_update.rb

@@ -1,5 +1,5 @@
 module DeltavistaCrifDvaInterface
-  class AddressUpdate
+  class AddressUpdate < XmlConverter
 
     # XML request and response encoding
     @@encoding = 'UTF-8'
@@ -13,7 +13,6 @@ module DeltavistaCrifDvaInterface
     end
 
     def to_xml(address)
-      puts address.inspect
       builder = Nokogiri::XML::Builder.new(:encoding => @@encoding) do |xml|
         xml.dvaCheckRequest {
           xml.identity {
@@ -24,7 +23,8 @@ module DeltavistaCrifDvaInterface
           xml.requestType @request_type
           xml.private {
             %w(title lastName firstName maidenName street house poBox zip city country phone birthDate sex).each do |key|
-              xml.send(key, address[key.downcase]) if address[key.downcase] && !address[key.downcase].empty?
+              value = to_string(address[key.downcase])
+              xml.send(key, value) if value && !value.empty?
             end
           }
         }
@@ -34,7 +34,6 @@ module DeltavistaCrifDvaInterface
     end
 
     def to_hash(xml_body)
-      puts xml_body
       xml_doc = Nokogiri::XML(xml_body, @@encoding)
       if valid_response? xml_doc
         # private tag
@@ -42,20 +41,22 @@ module DeltavistaCrifDvaInterface
         xml_doc.xpath("//private").each do |private_node|
           %w(addressId title lastName firstName maidenName street house poBox zip city country phone birthDate sex).each do |key|
             if key == "country"
-              address[key.downcase] = convert_country(private_node.xpath(key).collect(&:text)[0])
+              address[key.downcase] = convert_country(get_value(private_node, key))
             else
-              address[key.downcase] = private_node.xpath(key).collect(&:text)[0]
+              address[key.downcase] = get_value(private_node, key)
             end
           end
         end
+
         xml_doc.xpath("//private/payLoad").each do |payload_node|
           %w(matchLevel isDeceased dateOfDeath reqDeliverabilityClass higherDelivKnown).each do |key|
-            address[key.downcase] = payload_node.xpath(key).collect(&:text)[0]
+            address[key.downcase] = get_value(payload_node, key)
           end
         end
+
         xml_doc.xpath("//private/payLoad/highestAddress").each do |highestaddress_node|
           %w(deliverabilityClass).each do |key|
-            address[key.downcase] = highestaddress_node.xpath(key).collect(&:text)[0]
+            address[key.downcase] = get_value(highestaddress_node, key)
           end
         end
         address
@@ -72,12 +73,6 @@ module DeltavistaCrifDvaInterface
     def valid_response?(xml)
       response_code(xml) == '0' ? true : false
     end
-
-    def convert_country(alpha3_code)
-      SunDawg::CountryIsoTranslater.translate_standard(alpha3_code, "alpha3", "alpha2")
-    end
-
   end
-
 end
 

data/lib/deltavista_crif_dva_interface/credit_check_short_v02.rb

@@ -1,5 +1,5 @@
 module DeltavistaCrifDvaInterface
-  class CreditCheckShortV02
+  class CreditCheckShortV02 < XmlConverter
 
     # XML request and response encoding
     @@encoding = 'UTF-8'
@@ -67,12 +67,6 @@ module DeltavistaCrifDvaInterface
     def valid_response?(xml)
       response_code(xml) == '0' ? true : false
     end
-
-    def convert_country(alpha3_code)
-      SunDawg::CountryIsoTranslater.translate_standard(alpha3_code, "alpha3", "alpha2")
-    end
-
   end
-
 end
 

data/lib/deltavista_crif_dva_interface/version.rb

@@ -1,3 +1,3 @@
 module DeltavistaCrifDvaInterface
-  VERSION = "0.0.9"
+  VERSION = "0.0.10"
 end

data/lib/deltavista_crif_dva_interface/xml_converter.rb

@@ -0,0 +1,29 @@
+module DeltavistaCrifDvaInterface
+  class XmlConverter
+
+    def to_xml(object)
+
+    end
+
+    def to_hash(xml_doc)
+
+    end
+
+    def to_string(value)
+      if value.is_a? Time
+        return value.strftime("%d.%m.%Y")
+      else
+        return value.to_s.strip
+      end
+    end
+    # Returns the value of a XPATH expression
+    def get_value(node, key)
+      node.xpath(key).collect(&:text)[0]
+    end
+
+    # Converts alpha-3 country code into alpha-2 country code
+    def convert_country(alpha3_code)
+      SunDawg::CountryIsoTranslater.translate_standard(alpha3_code, "alpha3", "alpha2")
+    end
+  end
+end

metadata

@@ -2,15 +2,16 @@
 name: deltavista_crif_dva_interface
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors: 
   - Marc Cadalbert
+  - Maik Duff
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2012-03-22 00:00:00 +01:00
+date: 2012-03-26 00:00:00 +02:00
 default_executable: 
 dependencies: 
   - !ruby/object:Gem::Dependency 
@@ -46,9 +47,10 @@ dependencies:
             version: "0"
     type: :runtime
     version_requirements: *id003
-description: Deltavista Crif DVA Interface
+description: This interface is used to get credit check and address informations from Deltavista service.
 email: 
   - mc@impac.ch
+  - md@impac.ch
 executables: []
 
 extensions: []
@@ -63,6 +65,7 @@ files:
   - lib/deltavista_crif_dva_interface/delta_vista_service.rb
   - lib/deltavista_crif_dva_interface/restful_service.rb
   - lib/deltavista_crif_dva_interface/version.rb
+  - lib/deltavista_crif_dva_interface/xml_converter.rb
 has_rdoc: true
 homepage: ""
 licenses: []
@@ -90,6 +93,6 @@ rubyforge_project: deltavista_crif_dva_interface
 rubygems_version: 1.5.1
 signing_key: 
 specification_version: 3
-summary: Deltavista Crif DVA Interface
+summary: Interface to connect services from Deltavsita
 test_files: []