delta_attributes 0.0.3 → 0.0.4

data/README.md

@@ -11,13 +11,13 @@
     It replaces it with
 
       UPDATE users
-      SET money = money + d
+      SET money = money + delta
       WHERE id = 1;
 
-    where d is difference between old value and new value of that field.
+    where delta is difference between old value and new value of that field.
 
     This solves problem with simultaneous updating of same field by different threads
-    without locking record.
+    without locking record (problem known as race condition http://en.wikipedia.org/wiki/Race_condition).
 
 ## Installation
 
@@ -35,7 +35,7 @@ Or install it yourself as:
 
 ## Usage
 
-  To mark numeric field to be updated by "field = field + d" way you just need to add field
+  To mark numeric field to be updated by "field = field + delta" way you just need to add field
   name to delta_attributes like this:
 
     class User < ActiveRecord::Base
@@ -50,11 +50,35 @@ Or install it yourself as:
     u.money = 5
     u.save
 
-  will generate
+  rails will generate
 
     UPDATE users SET money = money + 2 where id = 1
 
-  Tested with rails 3.2.0, 3.2.8, 3.2.9.
+  and if
+
+    u = User.first # money = 5, id = 1
+    u.money = 1
+    u.money += 3
+    u.save
+
+  rails will generate
+
+    UPDATE users SET money = money - 1 where id = 1
+
+  You can use any operations with numeric field like:
+
+    u.money -= 10
+
+    u.money += 7
+
+    u.money = u.money * 2
+
+  etc.
+
+  It doesn't matter as delta is calculated as difference between original value received from database and new value
+  before update.
+
+  Tested with rails 3.1.0, 3.2.0, 3.2.8, 3.2.9.
 
 ## Contributing
 

data/delta_attributes.gemspec

@@ -6,7 +6,7 @@ require 'delta_attributes/version'
 Gem::Specification.new do |gem|
   gem.name          = "delta_attributes"
   gem.version       = DeltaAttributes::VERSION
-  gem.authors       = ["Oleh Novosad, Yuriy Lavryk, Arya"]
+  gem.authors       = ["Oleh (izbor) Novosad, Yuriy Lavryk, Arya"]
   gem.email         = ["oleh.novosad@gmail.com"]
   gem.description   = %q{
     This gem makes updating specified number fields by ActiveRecord in unusual way.
@@ -20,12 +20,13 @@ Gem::Specification.new do |gem|
     It replaces it with
 
       UPDATE users
-      SET money = money + d
+      SET money = money + delta
       WHERE id = 1;
 
-    where d is difference between old value and new value of that field.
+    where delta is difference between old value and new value of that field.
 
-    This solves problem with simultaneous updating of the same field by different threads.
+    This solves problem with simultaneous updating of the same field by different threads
+    (problem known as race condition).
 
     Source code: https://github.com/izbor/delta_attributes
   }
@@ -36,5 +37,5 @@ Gem::Specification.new do |gem|
   gem.executables   = gem.files.grep(%r{^bin/}).map{ |f| File.basename(f) }
   gem.test_files    = gem.files.grep(%r{^(test|spec|features)/})
   gem.require_paths = ["lib"]
-  gem.add_dependency "rails", "~> 3.2.0"
+  gem.add_dependency "rails", ">= 3.1.0"
 end

data/lib/delta_attributes/mysql.rb

@@ -14,16 +14,6 @@ module Arel
         ].compact.join ' '
       end
 
-      # original
-      #def visit_Arel_Nodes_UpdateStatement o
-      #  [
-      #    "UPDATE #{visit o.relation}",
-      #    ("SET #{o.values.map { |value| visit value }.join ', '}" unless o.values.empty?),
-      #    ("WHERE #{o.wheres.map { |x| visit x }.join ' AND '}" unless o.wheres.empty?),
-      #    ("ORDER BY #{o.orders.map { |x| visit x }.join(', ')}" unless o.orders.empty?),
-      #    (visit(o.limit) if o.limit),
-      #  ].compact.join ' '
-      #end
     end
   end
 end

data/lib/delta_attributes/version.rb

@@ -1,3 +1,3 @@
 module DeltaAttributes
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/lib/delta_attributes/visitor.rb

@@ -18,8 +18,6 @@ module Arel
         retry
       end
 
-      #alias_method_chain :visit, :delta_attribute
-
       alias_method :visit_without_delta_attribute, :visit
       alias_method :visit, :visit_with_delta_attribute
     end

metadata

@@ -1,21 +1,21 @@
 --- !ruby/object:Gem::Specification 
 name: delta_attributes
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
-- Oleh Novosad, Yuriy Lavryk, Arya
+- Oleh (izbor) Novosad, Yuriy Lavryk, Arya
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2012-11-20 00:00:00 +02:00
+date: 2012-11-21 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -24,17 +24,17 @@ dependencies:
   requirement: &id001 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ~>
+    - - ">="
       - !ruby/object:Gem::Version 
-        hash: 15
+        hash: 3
         segments: 
         - 3
-        - 2
+        - 1
         - 0
-        version: 3.2.0
+        version: 3.1.0
   type: :runtime
   version_requirements: *id001
-description: "\n    This gem makes updating specified number fields by ActiveRecord in unusual way.\n\n    Instead of generating sql script to update value in usual way like this:\n\n      UPDATE users\n      SET money = 10\n      WHERE id = 1;\n\n    It replaces it with\n\n      UPDATE users\n      SET money = money + d\n      WHERE id = 1;\n\n    where d is difference between old value and new value of that field.\n\n    This solves problem with simultaneous updating of the same field by different threads.\n\n    Source code: https://github.com/izbor/delta_attributes\n  "
+description: "\n    This gem makes updating specified number fields by ActiveRecord in unusual way.\n\n    Instead of generating sql script to update value in usual way like this:\n\n      UPDATE users\n      SET money = 10\n      WHERE id = 1;\n\n    It replaces it with\n\n      UPDATE users\n      SET money = money + delta\n      WHERE id = 1;\n\n    where delta is difference between old value and new value of that field.\n\n    This solves problem with simultaneous updating of the same field by different threads\n    (problem known as race condition).\n\n    Source code: https://github.com/izbor/delta_attributes\n  "
 email: 
 - oleh.novosad@gmail.com
 executables: []