deliver 1.13.2 → 1.13.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 76ec28b9855115a33bb1020b293807287a8ceebb
-  data.tar.gz: 74438ce41d66d70c8af587fae63143e052be95ae
+  metadata.gz: 253317c8d2cf6785e0787b07a470794fcf7dc71f
+  data.tar.gz: 4070511b5366fea5c6b54683a0caa526ae26e98d
 SHA512:
-  metadata.gz: ae372b3440d0d757e085acb6e5628871cd7d8f5d068bd09c6b52a95fa12647f44accbaf438727d68afa68c2bdfaef3e521d4d7b3a113698be4e61a5cdedb814b
-  data.tar.gz: 2abd51f2f0fe4ee3797e6074350c478617912ab5cde514e51f0c7bb8daa1f26969c618017bcd4f91512d71ee3a99bb9c2fe2c71f566ebb81b478ef01ce70a119
+  metadata.gz: be91200a19832cb2f8f6b4033e3fe896a24b0cfccce027a53106134b52d01ddedccdb39b0bbac51af952858d8e1ea8699f4cdf013573a133e769811461563d63
+  data.tar.gz: d9bc44b903bfe27091f083884828cf977878d289128efa159753b0d390b4f18fdbc0ee3e7c69c0479abc5ac731d3cd2952e455a8a40112e34d6480e66d08bd79

data/README.md

@@ -36,7 +36,7 @@ deliver
 
 ###### Upload screenshots, metadata and your app to the App Store using a single command
 
-`deliver` uploads screenshots, metadata and binaries to iTunes Connect. Use `'deliver` to submit your app for App Store review.
+`deliver` uploads screenshots, metadata and binaries to iTunes Connect. Use `deliver` to submit your app for App Store review.
 
 Get in contact with the developer on Twitter: [@FastlaneTools](https://twitter.com/FastlaneTools)
 

data/lib/deliver.rb

@@ -23,4 +23,8 @@ module Deliver
 
   Helper = FastlaneCore::Helper # you gotta love Ruby: Helper.* should use the Helper class contained in FastlaneCore
   UI = FastlaneCore::UI
+
+  # Constant that captures the root Pathname for the project. Should be used for building paths to assets or other
+  # resources that code needs to locate locally
+  ROOT = Pathname.new(File.expand_path('../..', __FILE__))
 end

data/lib/deliver/commands_generator.rb

@@ -14,8 +14,6 @@ module Deliver
       FastlaneCore::UpdateChecker.show_update_status('deliver', Deliver::VERSION)
     end
 
-    # rubocop:disable Metrics/AbcSize
-    # rubocop:disable Metrics/MethodLength
     def run
       program :version, Deliver::VERSION
       program :description, Deliver::DESCRIPTION
@@ -124,8 +122,6 @@ module Deliver
           end
         end
       end
-      # rubocop:enable Metrics/AbcSize
-      # rubocop:enable Metrics/MethodLength
 
       default_command :run
 

data/lib/deliver/html_generator.rb

@@ -24,15 +24,13 @@ module Deliver
       if okay
         UI.success("HTML file confirmed...") # print this to give feedback to the user immediately
       else
-        UI.user_error!("Did not upload the metadata, because the HTML file was rejected by the user", show_github_issues: false)
+        UI.user_error!("Did not upload the metadata, because the HTML file was rejected by the user")
       end
     end
 
     # Renders all data available to quickly see if everything was correctly generated.
     # @param export_path (String) The path to a folder where the resulting HTML file should be stored.
     def render(options, screenshots, export_path = nil)
-      lib_path = Helper.gem_path('deliver')
-
       @screenshots = screenshots || []
       @options = options
 
@@ -42,7 +40,7 @@ module Deliver
       @languages = options[:description].keys if options[:description]
       @languages ||= options[:app].latest_version.description.languages
 
-      html_path = File.join(lib_path, "lib/assets/summary.html.erb")
+      html_path = File.join(Deliver::ROOT, "lib/assets/summary.html.erb")
       html = ERB.new(File.read(html_path)).result(binding) # http://www.rrn.dk/rubys-erb-templating-system
 
       export_path = File.join(export_path, "Preview.html")

data/lib/deliver/runner.rb

@@ -80,7 +80,7 @@ module Deliver
 
       transporter = FastlaneCore::ItunesTransporter.new(options[:username], nil, false, options[:itc_provider])
       result = transporter.upload(options[:app].apple_id, package_path)
-      UI.user_error!("Could not upload binary to iTunes Connect. Check out the error above") unless result
+      UI.user_error!("Could not upload binary to iTunes Connect. Check out the error above", show_github_issues: true) unless result
     end
 
     def submit_for_review

data/lib/deliver/setup.rb

@@ -15,7 +15,7 @@ module Deliver
 
         # Add a README to the screenshots folder
         FileUtils.mkdir_p File.join(deliver_path, 'screenshots') # just in case the fetching didn't work
-        File.write(File.join(deliver_path, 'screenshots', 'README.txt'), File.read("#{Helper.gem_path('deliver')}/lib/assets/ScreenshotsHelp"))
+        File.write(File.join(deliver_path, 'screenshots', 'README.txt'), File.read("#{Deliver::ROOT}/lib/assets/ScreenshotsHelp"))
       end
 
       UI.success("Successfully created new Deliverfile at path '#{file_path}'")
@@ -28,8 +28,7 @@ module Deliver
       generate_metadata_files(v, File.join(deliver_path, 'metadata'))
 
       # Generate the final Deliverfile here
-      gem_path = Helper.gem_path('deliver')
-      deliver = File.read("#{gem_path}/lib/assets/DeliverfileDefault")
+      deliver = File.read("#{Deliver::ROOT}/lib/assets/DeliverfileDefault")
       deliver.gsub!("[[APP_IDENTIFIER]]", options[:app].bundle_id)
       deliver.gsub!("[[USERNAME]]", Spaceship::Tunes.client.user)
       return deliver

data/lib/deliver/upload_metadata.rb

@@ -163,7 +163,7 @@ module Deliver
     def set_review_information(v, options)
       return unless options[:app_review_information]
       info = options[:app_review_information]
-      UI.user_error!("`app_review_information` must be a hash") unless info.kind_of?(Hash)
+      UI.user_error!("`app_review_information` must be a hash", show_github_issues: true) unless info.kind_of?(Hash)
 
       v.review_first_name = info[:first_name] if info[:first_name]
       v.review_last_name = info[:last_name] if info[:last_name]

data/lib/deliver/version.rb

@@ -1,4 +1,4 @@
 module Deliver
-  VERSION = "1.13.2"
+  VERSION = "1.13.3"
   DESCRIPTION = 'Upload screenshots, metadata and your app to the App Store using a single command'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deliver
 version: !ruby/object:Gem::Version
-  version: 1.13.2
+  version: 1.13.3
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-08-09 00:00:00.000000000 Z
+date: 2016-08-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane_core
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.0
+        version: 0.50.3
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.49.0
+        version: 0.50.3
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -56,7 +56,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.30.0
+        version: 0.31.6
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -66,7 +66,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.30.0
+        version: 0.31.6
     - - "<"
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -304,7 +304,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Upload screenshots, metadata and your app to the App Store using a single