deliver 1.0.0.beta2 → 1.0.0.beta3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b9fb4847975830357721f85e8cbb9632d6f34216
-  data.tar.gz: 18d885cc25098731f12fb1ae44efcb09b796a3b3
+  metadata.gz: 0a5b737293ce73f59d6a2a28caac48d4f0c743b4
+  data.tar.gz: 5e0ee132997246d7bd51f14d1f5310e7627d8e20
 SHA512:
-  metadata.gz: 50dcbfe8b9072e8ccc1625255cacdc1b70bba7af2068057920fe79cb5301d5d5ca8d331ffd30aaed02b7b664836b5016ca9e65ff1ee5253384d03f221ada7363
-  data.tar.gz: d9384a6081a57ec61c5246e2ec4fa1bd80bdd6b4f2e3d350a0f876872d09c8e4645ca566a6de4833c87fe3126412c5919aabcbf8db37ce44343c874060eb0611
+  metadata.gz: 21d14cfcdf927fed64439e24cc36164b40fccccfa3977ba55f949b1299c378103e1b28caee293ee53581aedd90b93349f4261420d15fa46c22223bd8a0d2e59c
+  data.tar.gz: 2bdf1e912069b245e4f563db6e753987ac971d91bd5ea47fac44a68a43765ac94e62fb61c9e402db50c93032131d4792a89ea910e64572c54236288977907811

data/README.md

@@ -35,7 +35,7 @@ deliver
 
 ###### Upload screenshots, metadata and your app to the App Store using a single command
 
-`deliver` **can upload ipa files, app screenshots and more to the iTunes Connect backend**, which means, you can deploy new iPhone app updates using the command line.
+`deliver` **can upload ipa files, app screenshots and more to iTunes Connect** from the command line.
 
 Get in contact with the developer on Twitter: [@KrauseFx](https://twitter.com/KrauseFx)
 
@@ -46,7 +46,6 @@ Get in contact with the developer on Twitter: [@KrauseFx](https://twitter.com/Kr
     <a href="#installation">Installation</a> &bull; 
     <a href="#quick-start">Quick Start</a> &bull; 
     <a href="#usage">Usage</a> &bull; 
-    <a href="#can-i-trust-deliver">Can I trust deliver?</a> &bull; 
     <a href="#tips">Tips</a> &bull; 
     <a href="#need-help">Need help?</a>
 </p>
@@ -56,13 +55,14 @@ Get in contact with the developer on Twitter: [@KrauseFx](https://twitter.com/Kr
 <h5 align="center"><code>deliver</code> is part of <a href="https://fastlane.tools">fastlane</a>: connect all deployment tools into one streamlined workflow.</h5>
 
 # Features
-- Upload hundreds of screenshots with different languages from different devices
-- Upload a new ipa file to iTunes Connect without Xcode from any computer
-- Update app metadata
-- Easily implement a real Continuous Deployment process using [fastlane](https://github.com/KrauseFx/fastlane)
-- Store the configuration in git to easily deploy from **any** computer, including your Continuous Integration server (e.g. Jenkins)
-- Get a PDF preview of the fetched metadata before uploading the app metadata and screenshots to Apple: [Example Preview](https://github.com/krausefx/deliver/blob/master/assets/PDFExample.png?raw=1)
-- Automatically create new screenshots with [snapshot](https://github.com/KrauseFx/snapshot)
+- Upload hundreds of localised screenshots completely automatically
+- Upload a new ipa file to iTunes Connect without Xcode from any Mac
+- Maintain your app metadata locally and push changes back to iTunes Connect
+- Easily implement a real Continuous Deployment process using [fastlane](https://fastlane.tools)
+- Store the configuration in git to easily deploy from **any** Mac, including your Continuous Integration server
+- Get a HTML preview of the fetched metadata before uploading the app metadata and screenshots to iTC
+
+To upload builds to TestFlight check out [pilot](https://github.com/fastlane/pilot).
 
 ##### [Like this tool? Be the first to know about updates and new fastlane tools](https://tinyletter.com/krausefx)
 
@@ -76,10 +76,6 @@ Make sure, you have the latest version of the Xcode command line tools installed
 
     xcode-select --install
 
-To create new screenshots automatically, check out my other open source project [snapshot](https://github.com/KrauseFx/snapshot).
-
-To upload builds to TestFlight check out [pilot](https://github.com/fastlane/pilot).
-
 # Quick Start
 
 The guide will create all the necessary files for you, using the existing app metadata from iTunes Connect.
@@ -94,20 +90,53 @@ From now on, you can run `deliver` to deploy a new update, or just upload new ap
 
 # Usage
 
-TODO
+Check out your local `./fastlane/metadata` and `./fastlane/screenshots` folders (if you don't use [fastlane](https://fastlane.tools) it's `./metadata` instead)
+
+![/assets/metadata.png](/assets/metadata.png)
+
+You'll see your metadata from iTunes Connect. Feel free to store the metadata in git (not the screenshots). You can now modify it locally and push the changes back to iTunes Connect.
+
+Run `deliver` to upload the app metadata from your local machine
+
+```
+deliver
+```
+
+Provide the path to an `ipa` file to upload and submit your app for review:
+
+```
+deliver --ipa "App.ipa" --submit_for_review
+```
+
+If you use [fastlane](https://fastlane.tools) you don't have to manually specify the path to your `ipa` file. 
+
+This is just a small sub-set of what you can do with `deliver`, check out the full documentation in [Deliverfile.md](https://github.com/KrauseFx/deliver/blob/master/Deliverfile.md)
+
+Download existing screenshots from iTunes Connect
+
+```
+deliver download_screenshots
+```
+
+To get a list of available options run
+
+```
+deliver --help
+```
+
+Check out [Deliverfile.md](https://github.com/KrauseFx/deliver/blob/master/Deliverfile.md) for more options.
 
 # Credentials
 
 A detailed description about your credentials is available on a [separate repo](https://github.com/fastlane/CredentialsManager).
 
-# Can I trust `deliver`? 
-###How does this thing even work? Is magic involved? 🎩###
+### How does this thing even work? Is magic involved? 🎩###
 
-`deliver` is fully open source, you can take a look at its source files. It will only modify the content you want to modify using the ```Deliverfile```. Your password will be stored in the Mac OS X keychain, but can also be passed using environment variables. (More information available on [CredentialsManager](https://github.com/fastlane/CredentialsManager))
+Your password will be stored in the Mac OS X keychain, but can also be passed using environment variables. (More information available on [CredentialsManager](https://github.com/fastlane/CredentialsManager))
 
-Before actually uploading anything to iTunes, ```deliver``` will generate a [HTML summary](https://github.com/krausefx/deliver/blob/master/assets/PDFExample.png?raw=1) of the collected data. 
+Before actually uploading anything to iTunes, ```deliver``` will generate a HTML summary of the collected data. 
 
-```deliver``` uses the following techniques under the hood:
+`deliver` uses the following techniques under the hood:
 
 - The iTMSTransporter tool is used to upload the binary to iTunes Connect. iTMSTransporter is a command line tool provided by Apple.
 - For all metadata related actions `deliver` uses [spaceship](https://github.com/fastlane/spaceship)
@@ -132,15 +161,13 @@ Before actually uploading anything to iTunes, ```deliver``` will generate a [HTM
 ##### [Like this tool? Be the first to know about updates and new fastlane tools](https://tinyletter.com/krausefx)
 
 ## Available language codes
-```ruby
-"da", "de-DE", "el", "en-AU", "en-CA", "en-GB", "en-US", "es-ES", "es-MX", "fi", "fr-CA", "fr-FR", "id", "it", "ja", "ko", "ms", "nl", "no", "pt-BR", "pt-PT", "ru", "sv", "th", "tr", "vi", "zh-Hans", "zh-Hant"
+```
+en-GB, de-DE, fr-FR, it, nl-NL, pt-PT, ru, es-ES, sv, es-MX, pt-BR, en-CA, en-US, en-AU, zh-Hans, ja, ko
 ```
 
 ## Automatically create screenshots
 
-If you want to integrate ```deliver``` with ```snapshot```, check out [fastlane](https://github.com/KrauseFx/fastlane)!
-
-More information about ```snapshot``` can be found on the [Snapshot GitHub page](https://github.com/KrauseFx/snapshot).
+If you want to integrate `deliver` with [snapshot](https://github.com/KrauseFx/snapshot), check out [fastlane](https://fastlane.tools)!
 
 ## Jenkins integration
 Detailed instructions about how to set up `deliver` and `fastlane` in `Jenkins` can be found in the [fastlane README](https://github.com/KrauseFx/fastlane/blob/master/docs/Jenkins.md).

data/lib/assets/summary.html.erb

@@ -110,7 +110,7 @@
     </head>
     
     <body>
-      <% @options[:description].keys.each do |language| %>
+      <% @languages.each do |language| %>
         <% if @options[:name] %>
           <div id="app-name">
             <%= language %>: <%= @options[:name][language] %>
@@ -120,7 +120,7 @@
         <div id="app-urls">
           <% all_keys = [:support_url, :marketing_url] %>
           <% all_keys.each do |key| %>
-            <% value = @options[key][language] %>
+            <% value = @options[key][language] if @options[key] %>
             <% if value %>
               <div class="app-url-descr">
                 <%= key %>: <a target="_blank" class="app-url" href="<%= value %>"><%= value %></a>
@@ -140,17 +140,21 @@
           </div>
         <% end %>
         
-        <div id="app-description">
-             <div class="cat-headline">Description</div>
-             <div id="app-description-text">
-                <%= (@options[:description][language] || '').gsub("\n", "<br />") %>
-             </div>
-        </div>
+        <% if @options[:description] %>
+          <div id="app-description">
+               <div class="cat-headline">Description</div>
+               <div id="app-description-text">
+                  <%= (@options[:description][language] || '').gsub("\n", "<br />") %>
+               </div>
+          </div>
+        <% end %>
         
-        <div id="app-changelog">
-            <div class="cat-headline">Changelog</div>
-            <%= (@options[:release_notes][language] || '').gsub("\n", "<br />") %>
-        </div>
+        <% if @options[:release_notes] %>
+          <div id="app-changelog">
+              <div class="cat-headline">Changelog</div>
+              <%= (@options[:release_notes][language] || '').gsub("\n", "<br />") %>
+          </div>
+        <% end %>
         
         <div id="app-screenshots">
           <div class="cat-headline">Screenshots</div>

data/lib/deliver/commands_generator.rb

@@ -33,7 +33,17 @@ module Deliver
         c.description = 'Upload metadata and binary to iTunes Connect'
         c.action do |args, options|
           options = FastlaneCore::Configuration.create(Deliver::Options.available_options, options.__hash__)
-          options.load_configuration_file("Deliverfile")
+          loaded = options.load_configuration_file("Deliverfile")
+          loaded = true if options[:description] || options[:ipa] # do we have *anything* here?
+          unless loaded
+            if agree("No deliver configuration found in the current directory. Do you want to setup deliver? (y/n)".yellow, true)
+              require 'deliver/setup'
+              Deliver::Runner.new(options) # to login...
+              Deliver::Setup.new.run(options)
+              return 0
+            end
+          end
+
           Deliver::Runner.new(options).run
         end
       end

data/lib/deliver/detect_values.rb

@@ -14,10 +14,10 @@ module Deliver
     def find_folders(options)
       containing = Helper.fastlane_enabled? ? './fastlane' : '.'
       options[:screenshots_path] ||= File.join(containing, 'screenshots')
-      options[:metadata_folder] ||= File.join(containing, 'metadata')
+      options[:metadata_path] ||= File.join(containing, 'metadata')
 
       FileUtils.mkdir_p(options[:screenshots_path])
-      FileUtils.mkdir_p(options[:metadata_folder])
+      FileUtils.mkdir_p(options[:metadata_path])
     end
   end
 end

data/lib/deliver/html_generator.rb

@@ -1,5 +1,30 @@
 module Deliver
   class HtmlGenerator
+    def run(options, screenshots)
+      begin
+        html_path = self.render(options, screenshots, '.')
+      rescue => ex
+        Helper.log.error ex.inspect
+        Helper.log.error ex.backtrace.join("\n")
+        okay = agree("Could not render HTML preview. Do you still want to continue? (y/n)".red, true)
+        return if okay
+        raise "Could not render HTML page"
+      end
+      puts "----------------------------------------------------------------------------"
+      puts "Verifying the upload via the HTML file can be disabled by either adding"
+      puts "`force true` to your Deliverfile or using `deliver --force`"
+      puts "----------------------------------------------------------------------------"
+
+      system("open '#{html_path}'")
+      okay = agree("Does the Preview on path '#{html_path}' look okay for you? (blue = updated) (y/n)", true)
+
+      if okay
+        puts "HTML file confirmed...".green # print this to give feedback to the user immediately
+      else
+        raise "Did not upload the metadata, because the HTML file was rejected by the user".yellow
+      end
+    end
+
     # Renders all data available to quickly see if everything was correctly generated.
     # @param export_path (String) The path to a folder where the resulting HTML file should be stored.
     def render(options, screenshots, export_path = nil)
@@ -11,6 +36,9 @@ module Deliver
       @app_name = (options[:name]['en-US'] || options[:name].values.first) if options[:name]
       @app_name ||= options[:app].name
 
+      @languages = options[:description].keys if options[:description]
+      @languages ||= options[:app].latest_version.description.languages
+
       html_path = File.join(lib_path, "lib/assets/summary.html.erb")
       html = ERB.new(File.read(html_path)).result(binding) # http://www.rrn.dk/rubys-erb-templating-system
 

data/lib/deliver/options.rb

@@ -30,7 +30,7 @@ module Deliver
                                        raise "Could not find ipa file at path '#{value}'".red unless File.exist?(value)
                                        raise "'#{value}' doesn't seem to be an ipa file".red unless value.end_with?(".ipa")
                                      end),
-        FastlaneCore::ConfigItem.new(key: :metadata_folder,
+        FastlaneCore::ConfigItem.new(key: :metadata_path,
                                      short_option: '-m',
                                      description: "Path to the folder containing the metadata files",
                                      optional: true),
@@ -51,11 +51,29 @@ module Deliver
                                      description: "Submit the new version for Review after uploading everything",
                                      is_string: false,
                                      default_value: false),
+        FastlaneCore::ConfigItem.new(key: :automatic_release,
+                                     description: "Should the app be automatically released once it's approved?",
+                                     is_string: false,
+                                     default_value: false),
         FastlaneCore::ConfigItem.new(key: :price_tier,
                                      short_option: "-r",
                                      description: "The price tier of this application",
                                      is_string: false,
                                      optional: true),
+        FastlaneCore::ConfigItem.new(key: :app_rating_config_path,
+                                     short_option: "-g",
+                                     description: "Path to the app rating's config",
+                                     is_string: true,
+                                     optional: true,
+                                     verify_block: proc do |value|
+                                       raise "Could not find config file at path '#{value}'".red unless File.exist?(value)
+                                       raise "'#{value}' doesn't seem to be a JSON file".red unless value.end_with?(".json")
+                                     end),
+        FastlaneCore::ConfigItem.new(key: :submission_information,
+                                     short_option: "-b",
+                                     description: "Extra information for the submission (e.g. third party content)",
+                                     is_string: false,
+                                     optional: true),
 
         # App Metadata
         # Non Localised

data/lib/deliver/runner.rb

@@ -15,6 +15,7 @@ module Deliver
     end
 
     def run
+      verify_version if options[:ipa]
       upload_metadata unless options[:skip_metadata]
       upload_binary if options[:ipa]
 
@@ -23,18 +24,22 @@ module Deliver
       submit_for_review if options[:submit_for_review]
     end
 
-    def upload_binary
-      Helper.log.info "Uploading binary to iTunes Connect"
-      package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(
-        app_id: options[:app].apple_id,
-        ipa_path: options[:ipa],
-        package_path: "/tmp"
-      )
-
-      transporter = FastlaneCore::ItunesTransporter.new(options[:username])
-      transporter.upload(options[:app].apple_id, package_path)
+    # Make sure the version on iTunes Connect matches the one in the ipa
+    # If not, the new version will automatically be created
+    def verify_version
+      app_version = FastlaneCore::IpaFileAnalyser.fetch_app_version(options[:ipa])
+      return unless app_version.to_s.length > 0
+      Helper.log.info "Making sure the latest version on iTunes Connect matches '#{app_version}' from the ipa file..."
+
+      changed = options[:app].ensure_version!(app_version)
+      if changed
+        Helper.log.info "Successfully set the version to '#{app_version}'".green
+      else
+        Helper.log.info "'#{app_version}' is the latest version on iTunes Connect".green
+      end
     end
 
+    # Upload all metadata, screenshots, pricing information, etc. to iTunes Connect
     def upload_metadata
       # First, collect all the things for the HTML Report
       screenshots = UploadScreenshots.new.collect_screenshots(options)
@@ -50,6 +55,19 @@ module Deliver
       UploadAssets.new.upload(options) # e.g. app icon
     end
 
+    # Upload the binary to iTunes Connect
+    def upload_binary
+      Helper.log.info "Uploading binary to iTunes Connect"
+      package_path = FastlaneCore::IpaUploadPackageBuilder.new.generate(
+        app_id: options[:app].apple_id,
+        ipa_path: options[:ipa],
+        package_path: "/tmp"
+      )
+
+      transporter = FastlaneCore::ItunesTransporter.new(options[:username])
+      transporter.upload(options[:app].apple_id, package_path)
+    end
+
     def submit_for_review
       SubmitForReview.new.submit!(options)
     end
@@ -58,21 +76,7 @@ module Deliver
 
     def validate_html(screenshots)
       return if options[:force]
-      Helper.log.info "In the beta version of deliver the generation of the PDF is currently disabled"
-      return
-
-      html_path = HtmlGenerator.new.render(options, screenshots, '.')
-      puts "----------------------------------------------------------------------------"
-      puts "Verifying the upload via the HTML file can be disabled by either adding"
-      puts "'skip_pdf true' to your Deliverfile or using the flag --force."
-      puts "----------------------------------------------------------------------------"
-
-      system("open '#{html_path}'")
-      okay = agree("Does the Preview on path '#{html_path}' look okay for you? (blue = updated) (y/n)", true)
-
-      unless okay
-        raise "Did not upload the metadata, because the HTML file was rejected by the user".yellow
-      end
+      HtmlGenerator.new.run(options, screenshots)
     end
   end
 end

data/lib/deliver/submit_for_review.rb

@@ -8,10 +8,20 @@ module Deliver
       submission = app.create_submission
 
       # Set app submission information
+      # Default Values
       submission.content_rights_contains_third_party_content = false
       submission.content_rights_has_rights = true
       submission.add_id_info_uses_idfa = false
 
+      # User Values
+      if options[:submission_information]
+        raise "`submission_information` must be a hash" unless options[:submission_information].kind_of?(Hash)
+        options[:submission_information].each do |key, value|
+          Helper.log.info "Setting '#{key}' to '#{value}'..."
+          submission.send("#{key}=", value)
+        end
+      end
+
       # Finalize app submission
       submission.complete!
 

data/lib/deliver/upload_metadata.rb

@@ -15,13 +15,12 @@ module Deliver
 
     # Make sure to call `load_from_filesystem` before calling upload
     def upload(options)
+      verify_available_languages!(options)
+
       app = options[:app]
 
       details = app.details
       v = app.edit_version
-      raise "Could not find a version to edit for app '#{app.name}'".red unless v
-
-      # TODO: Create new language
 
       (LOCALISED_VERSION_VALUES + LOCALISED_APP_VALUES).each do |key|
         current = options[key]
@@ -46,7 +45,10 @@ module Deliver
         details.send("#{key}=", current) if NON_LOCALISED_APP_VALUES.include?(key)
       end
 
-      set_review_information(v, options) if options[:app_review_information]
+      v.release_on_approval = options[:automatic_release]
+
+      set_review_information(v, options)
+      set_app_rating(v, options)
 
       Helper.log.info "Uploading metadata to iTunes Connect"
       v.save!
@@ -54,10 +56,37 @@ module Deliver
       Helper.log.info "Successfully uploaded initial set of metadata to iTunes Connect".green
     end
 
+    # Makes sure all languages we need are actually created
+    def verify_available_languages!(options)
+      # Collect all languages we need
+      # We only care about languages from user provided values
+      # as the other languages are on iTC already anyway
+      v = options[:app].edit_version
+      raise "Could not find a version to edit for app '#{options[:app].name}', the app metadata is read-only currently".red unless v
+
+      enabled_languages = []
+      LOCALISED_VERSION_VALUES.each do |key|
+        current = options[key]
+        next unless current && current.kind_of?(Hash)
+        current.each do |language, value|
+          enabled_languages << language unless enabled_languages.include?(language)
+        end
+      end
+
+      if enabled_languages.count > 0
+        v.create_languages(enabled_languages)
+        lng_text = "language"
+        lng_text += "s" if enabled_languages.count != 1
+        Helper.log.info "Activating #{lng_text} #{enabled_languages.join(', ')}..."
+        v.save!
+      end
+      true
+    end
+
     # Loads the metadata files and stores them into the options object
     def load_from_filesystem(options)
       # Load localised data
-      Dir.glob(File.join(options[:metadata_folder], "*")).each do |lng_folder|
+      Dir.glob(File.join(options[:metadata_path], "*")).each do |lng_folder|
         next unless File.directory?(lng_folder) # We don't want to read txt as they are non localised
 
         language = File.basename(lng_folder)
@@ -74,7 +103,7 @@ module Deliver
 
       # Load non localised data
       (NON_LOCALISED_VERSION_VALUES + NON_LOCALISED_APP_VALUES).each do |key|
-        path = File.join(options[:metadata_folder], "#{key}.txt")
+        path = File.join(options[:metadata_path], "#{key}.txt")
         next unless File.exist?(path)
 
         Helper.log.info "Loading '#{path}'..."
@@ -85,6 +114,7 @@ module Deliver
     private
 
     def set_review_information(v, options)
+      return unless options[:app_review_information]
       info = options[:app_review_information]
       raise "`app_review_information` must be a hash" unless info.kind_of?(Hash)
 
@@ -96,5 +126,18 @@ module Deliver
       v.review_demo_password = info[:demo_password] if info[:demo_password]
       v.review_notes = info[:notes] if info[:notes]
     end
+
+    def set_app_rating(v, options)
+      return unless options[:app_rating_config_path]
+
+      require 'json'
+      begin
+        json = JSON.parse(File.read(options[:app_rating_config_path]))
+      rescue => ex
+        Helper.log.fatal ex.to_s
+        raise "Error parsing JSON file at path '#{options[:app_rating_config_path]}'".red
+      end
+      v.update_rating(json)
+    end
   end
 end

data/lib/deliver/upload_screenshots.rb

@@ -52,7 +52,10 @@ module Deliver
         files = Dir.glob(File.join(lng_folder, '*.png'))
         next if files.count == 0
 
+        prefer_framed = Dir.glob(File.join(lng_folder, '*_framed.png')).count > 0
+
         files.each do |path|
+          next if prefer_framed && !path.include?("_framed.png")
           screenshots << AppScreenshot.new(path, language)
         end
       end

data/lib/deliver/version.rb

@@ -1,4 +1,4 @@
 module Deliver
-  VERSION = "1.0.0.beta2"
+  VERSION = "1.0.0.beta3"
   DESCRIPTION = 'Upload screenshots, metadata and your app to the App Store using a single command'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deliver
 version: !ruby/object:Gem::Version
-  version: 1.0.0.beta2
+  version: 1.0.0.beta3
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-27 00:00:00.000000000 Z
+date: 2015-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane_core
@@ -50,7 +50,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.1
     - - "<="
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -60,7 +60,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.9.0
+        version: 0.10.1
     - - "<="
       - !ruby/object:Gem::Version
         version: 1.0.0
@@ -254,7 +254,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Upload screenshots, metadata and your app to the App Store using a single