deliver 0.9.1 → 0.9.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b28de89015651dbe03c9ac0c28e74329a075c364
-  data.tar.gz: df5f55d91ba602887031c18f2322a11439855eeb
+  metadata.gz: 51d1e7e4a4f03919a27b9a791a3e56a9f70bbb06
+  data.tar.gz: a83a945c3eeccc1d0f35809e1db13e421bdd3b46
 SHA512:
-  metadata.gz: 9f2eebadd74349779049af994042bea47c9aef56dce60ebc2b75f3ff046e2b2e794df642fc4a96dc3ad6cfbc72decc9014588ac084d68e0524a41eee1f045abc
-  data.tar.gz: 19088f2ece72916b2b5c219f39ce50ba7d888aff1292a6bd75c50b4f2d1c02f6d867a9b611d8e97a7e685e3742517f67513998288c38a4958764bff62edfa92c
+  metadata.gz: e12280fbf8ea425234e8eae10b43b8aee7a304eb5a129bb3e197a658e027029dad22d13ac652a04782036c5ed4d74b2cf97fee183c3086a7d709c9ee52305191
+  data.tar.gz: b64a78195b42c34bc7c10012a66278e3a8dc19089a4218f951664527d9bf4ca9309f389bb20520d4c8ea1a347739285e60d2abaa8ebfbf9bfcbec09666968f84

data/README.md

@@ -59,7 +59,7 @@ Get in contact with the developer on Twitter: [@KrauseFx](https://twitter.com/Kr
 - Easily implement a real Continuous Deployment process using [fastlane](https://github.com/KrauseFx/fastlane)
 - Store the configuration in git to easily deploy from **any** computer, including your Continuous Integration server (e.g. Jenkins)
 - Get a PDF preview of the fetched metadata before uploading the app metadata and screenshots to Apple: [Example Preview](https://github.com/krausefx/deliver/blob/master/assets/PDFExample.png?raw=1)
-- Automatically create new screenshots with [Snapshot](https://github.com/KrauseFx/snapshot)
+- Automatically create new screenshots with [snapshot](https://github.com/KrauseFx/snapshot)
 - Upload new builds to the new Apple TestFlight
 
 ##### [Like this tool? Be the first to know about updates and new fastlane tools](https://tinyletter.com/krausefx)
@@ -137,7 +137,7 @@ From now on, you can run ```deliver``` to deploy a new update, or just upload ne
 Open the ```Deliverfile``` using a text editor and customize it even further. Take a look at the following settings:
 
 - ```ipa```: You can either pass a static path to an ipa file, or add your custom build script.
-- ```unit_tests```: Uncomment the code to run tests. (e.g. using [xctool](https://github.com/facebook/xctool))
+- ```unit_tests```: Uncomment the code to run tests. (e.g. using [xctool](https://github.com/facebook/xctool)). It is recommended to use [fastlane](https://fastlane.tools) for running tests.
 
 # Usage
 

data/bin/deliver

@@ -12,7 +12,7 @@ class FastlaneApplication
 
   def run
     program :version, Deliver::VERSION
-    program :description, 'CLI for \'Deliver\' - Upload screenshots, metadata and your app to the App Store using a single command'
+    program :description, 'CLI for \'deliver\' - Upload screenshots, metadata and your app to the App Store using a single command'
     program :help, 'Author', 'Felix Krause <deliver@krausefx.com>'
     program :help, 'Website', 'https://fastlane.tools'
     program :help, 'GitHub', 'https://github.com/krausefx/deliver'
@@ -28,8 +28,6 @@ class FastlaneApplication
       c.syntax = 'deliver'
       c.description = 'Run a deploy process using the Deliverfile in the current folder'
       c.action do |args, options|
-        FastlaneCore::UpdateChecker.start_looking_for_update('deliver')
-
         path = (Deliver::Helper.fastlane_enabled?? './fastlane' : '.')
         Dir.chdir(path) do # switch the context
           if File.exists?(deliver_path)
@@ -43,8 +41,6 @@ class FastlaneApplication
             end
           end
         end
-
-        FastlaneCore::UpdateChecker.show_update_status('deliver', Deliver::VERSION)
       end
     end
 
@@ -68,15 +64,11 @@ class FastlaneApplication
       c.option '-u', '--username String', String, 'Your Apple ID'
 
       c.action do |args, options|
-        FastlaneCore::UpdateChecker.start_looking_for_update('deliver')
-
         ipa_path = (args.first || determine_ipa) + '' # unfreeze the string
 
         set_username(options.username)
 
         Deliver::Testflight.upload!(ipa_path, options.app_id, options.skip_deploy)
-
-        FastlaneCore::UpdateChecker.show_update_status('deliver', Deliver::VERSION)
       end
     end
 
@@ -107,4 +99,9 @@ def enclosed_directory
   "."
 end
 
-FastlaneApplication.new.run
+begin
+  FastlaneCore::UpdateChecker.start_looking_for_update('deliver')
+  FastlaneApplication.new.run
+ensure
+  FastlaneCore::UpdateChecker.show_update_status('deliver', Deliver::VERSION)
+end

data/lib/assets/ScreenshotsHelp

@@ -1,4 +1,4 @@
 Put all screenshots you want to use inside the folder of its language (e.g. en-US).
 The device type will automatically be recognized using the image resolution.
 
-The name of the screenshots itself does not matter
+The screenshots can be named whatever you want, but keep in mind they are sorted alphabetically.

data/lib/deliver/app_metadata.rb

@@ -83,8 +83,7 @@ module Deliver
     end
 
     # Adds a new locale (language) to the given app
-    # @param language (FastlaneCore::Languages::ALL_LANGUAGES) the language you want to
-    #  this app
+    # @param language (FastlaneCore::Languages::ALL_LANGUAGES) the language you want to add
     # @raise (AppMetadataParameterError) Is thrown when don't pass a correct hash with correct language codes.
     # @return (Bool) Is true, if the language was created. False, when the language alreade existed
     def add_new_locale(language)

data/lib/deliver/deliver_process.rb

@@ -178,7 +178,7 @@ module Deliver
     end
 
     def load_metadata_folder
-      # Fetch the inforamtion from the ./metadata folder if it exists
+      # Fetch the information from the ./metadata folder if it exists
       metadata_folder = './metadata'
       return unless File.exists?metadata_folder
 

data/lib/deliver/deliverfile/deliverfile_creator.rb

@@ -92,7 +92,6 @@ module Deliver
           folder = File.join(path, "metadata", language)
           FileUtils.mkdir_p(folder)
           value.each do |key, content|
-            next if key == :version_whats_new
             content = content.join("\n") if key == :keywords
             File.write(File.join(folder, "#{key}.txt"), content)
           end

data/lib/deliver/itunes_connect/itunes_connect_submission.rb

@@ -48,7 +48,7 @@ module Deliver
 
           Helper.log.info("Sorry, we have to wait for iTunesConnect, since it's still processing the uploaded ipa file\n" + 
             "If this takes longer than 45 minutes, you have to re-upload the ipa file again.\n" + 
-            "You can always open the browser page yourself: '#{current_url}'\n" +
+            "You can always open the browser page yourself: '#{current_url}/pre/builds'\n" +
             "Passed time: ~#{((Time.now - started) / 60.0).to_i} minute(s)")
           sleep 60
         end

data/lib/deliver/version.rb

@@ -1,3 +1,3 @@
 module Deliver
-  VERSION = "0.9.1"
+  VERSION = "0.9.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deliver
 version: !ruby/object:Gem::Version
-  version: 0.9.1
+  version: 0.9.2
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-10 00:00:00.000000000 Z
+date: 2015-04-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane_core
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '>='
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: 0.5.2
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement