deliver 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 730cbb7ddcff1c957d5f345f8487448ef7258c30
-  data.tar.gz: 1f8c6bed0405116fa8e0224ea9ea80cf21313411
+  metadata.gz: 7825cad46a3db5213d94db08896c5394e18512c8
+  data.tar.gz: 31d1b651b4ace51293122a5ec0684d0892b1765d
 SHA512:
-  metadata.gz: 716d790846a95f3eb33ccd1f9233a66e92a3cd47054907b62622a86094e4d6bb0d1ada51141ed2b12cf2db0e138179ef41926039da2fb1cd7cd74b8c9f818941
-  data.tar.gz: 4be310b04a8de4efec25a81c9f0c18adb4f32c741a644a13e79dede102da51d64e6ba5504bf5f9b60f17ac122f5a4c3f3e2c415b41915f412054d8d1f21df8b6
+  metadata.gz: e2988f558367ae0b5b66518a4b343cac30066c2ac021bfac6d6d01c55f40eeea6394e6f66a0135667062093e2b3b852fd7a7f0f1fe236129ebcaba99b1f95dfc
+  data.tar.gz: 2a20b2d94d1c236a16fac8416bcc355c9a6d5e1b01b394ce6074446edbd202ac00f14aa7216b7e3b9139a4951f2d4338be32a3c2d7347517f525695aad48a3dd

data/README.md

@@ -113,6 +113,8 @@ The screenshots are ordered alphabetically. The best way to sort them is to prep
 
 To let the computer create the screenshots for you, checkout [this section of the README](#automatically-create-screenshots).
 
+If you want to have the screenshots inside a device frame, with a background and a fancy label on top, you can use [Sketch to App Store](http://sketchtoappstore.com/).
+
 #### Upload a new ipa file with a changelog to the App Store
 This will submit a new update to Apple
 ```ruby
@@ -280,6 +282,13 @@ From now on, when you start ```deliver```, it will first create the new screensh
 
 More information about ```snapshot``` can be found on the [Snapshot GitHub page](https://github.com/KrauseFx/snapshot).
 
+## Jenkins integration
+Depending on how you set up your Jenkins instance, there might be problems with the ```phantomjs``` dependency.
+
+I've been using [Jenkins App](https://github.com/stisti/jenkins-app) for a long time, where ```Deliver``` works just fine. 
+
+You should not deploy a new App Store update after every commit, since you still have to wait for your review. Instead I recommend using Git Tags, or custom triggers to deploy a new update. 
+
 ## Editing the ```Deliverfile```
 Change syntax highlighting to *Ruby*.
 

data/lib/deliver/ipa_uploader.rb

@@ -135,7 +135,7 @@ module Deliver
       def fetch_info_plist_file
         Zip::File.open(@ipa_file.path) do |zipfile|
           zipfile.each do |file|
-            if file.name.include?'.plist' and not file.name.include?".bundle"
+            if file.name.include?'.plist' and not ['.bundle', '.framework'].any? { |a| file.name.include?a }
               # We can not be completely sure, that's the correct plist file, so we have to try
               begin
                 # The XML file has to be properly unpacked first

data/lib/deliver/version.rb

@@ -1,3 +1,3 @@
 module Deliver
-  VERSION = "0.3.2"
+  VERSION = "0.3.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deliver
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-14 00:00:00.000000000 Z
+date: 2014-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json