deliver 0.12.0 → 0.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee1f2455f67977381b2c1909c56c7bdd45c5adda
-  data.tar.gz: f4f29d1ce61876009a825f8202ffe9de5a88cdc9
+  metadata.gz: e108e3caa9516e89362f501f31194a5a0f6a78f5
+  data.tar.gz: 846af397201b2846f64c3cbb0857cf8e10ebdc47
 SHA512:
-  metadata.gz: 187e3da45c63d08f418c15fa202a07dc8f2ddc34edd0cdda44d7ba4dad2c3d4fa42c1c1d616f0f990ab7bb426a506d752012878f5262a00fa77b57b2d4fd612c
-  data.tar.gz: cb4fd8be0b83e046a04d00230bf5065d40625dff2e86b1545e91ddfd9daee2cd732d37a53576cfbf0511c62c2742f5adc93782476b57ff8464c33315f80cfb69
+  metadata.gz: d7b2bdfcb42843c29d02aef79334de2ad4578ea79d115edb59b2f2f7003df575c7318ec9d521e18b794b37d53f4e3938cf2e8c7509bc688f7d8d91cf0215622d
+  data.tar.gz: 6f6a4a9702e8d7339718082b7a142ac7b708fd5ea0484bdeb3201daf728f06a832058c1631b884fe05b1621e95d611dbf5842405bd0990fb850b9ff2df66d53e

data/README.md

@@ -84,7 +84,7 @@ To upload a new build to Apple `TestFlight` use the following command:
 deliver testflight
 ```
 
-This will auotmatically look for an ipa file in the current directory.
+This will automatically look for an ipa file in the current directory.
 
 `deliver` currently supports **Internal Testers** only.
 
@@ -170,6 +170,8 @@ To let the computer create the screenshots for you, checkout [this section of th
 
 If you want to have the screenshots inside a device frame, with a background and a fancy label on top, you can use [Sketch to App Store](http://sketchtoappstore.com/).
 
+To download all existing screenshots, use `deliver download_screenshots`.
+
 #### Update App description, keywords and more
 
 If you used `deliver init`, take a look at the `./metadata/` folder, which contains your app description, keywords and app title. If you change the content of the files, it will get updated when you run `deliver`.
@@ -285,7 +287,7 @@ app.itc.submit_for_review!(app)
 
 FastlaneCore::ItunesSearchApi.fetch_by_identifier("net.sunapps.15") # => Fetches public metadata
 ```
-This project is well documented, check it out on [Rubydoc](http://www.rubydoc.info/github/KrauseFx/deliver/frames).
+This project is well documented, check it out on [RubyDoc](http://www.rubydoc.info/github/KrauseFx/deliver/frames).
 
 
 # Credentials
@@ -336,7 +338,18 @@ If you want to integrate ```deliver``` with ```snapshot```, check out [fastlane]
 More information about ```snapshot``` can be found on the [Snapshot GitHub page](https://github.com/KrauseFx/snapshot).
 
 ## Jenkins integration
-Detailed instructions about how to set up `deliver` and `fastlane` in `Jenkins` can be found in the [fastlane README](https://github.com/KrauseFx/fastlane#jenkins-integration).
+Detailed instructions about how to set up `deliver` and `fastlane` in `Jenkins` can be found in the [fastlane README](https://github.com/KrauseFx/fastlane/blob/master/docs/Jenkins.md).
+
+## Firewall Issues
+
+`deliver` uses the iTunes Transporter to upload metadata and binaries. In case you are behind a firewall, you can specify a different transporter protocoll using
+
+```
+DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS="-t DAV" deliver
+```
+
+## Limit
+Apple has a limit of 150 binary uploads per day. 
 
 ## Editing the ```Deliverfile```
 Change syntax highlighting to *Ruby*.

data/lib/assets/DeliverLanguageMapping.json

@@ -25,20 +25,32 @@
   {
   "locale": "en-AU",
   "name": "Australian English",
-  "game-center": false,
-  "readable-alternatives": ["English_Australian"]
+  "game-center": false
+  },
+  {
+  "locale": "en-AU",
+  "name": "English_Australian",
+  "game-center": false
   },
   {
   "locale": "en-CA",
   "name": "Canadian English",
-  "game-center": false,
-  "readable-alternatives": ["English_CA"]
+  "game-center": false
+  },
+  {
+  "locale": "en-CA",
+  "name": "English_CA",
+  "game-center": false
   },
   {
   "locale": "en-GB",
   "name": "UK English",
-  "game-center": true,
-  "readable-alternatives": ["English_UK"]
+  "game-center": true
+  },
+  {
+  "locale": "en-GB",
+  "name": "English_UK",
+  "game-center": true
   },
   {
   "locale": "en-US",
@@ -54,8 +66,12 @@
   {
   "locale": "fr-CA",
   "name": "Canadian French",
-  "game-center": false,
-  "readable-alternatives": ["French_CA"]
+  "game-center": false
+  },
+  {
+  "locale": "fr-CA",
+  "name": "French_CA",
+  "game-center": false
   },
   {
   "locale": "fr-FR",
@@ -131,8 +147,12 @@
   {
   "locale": "es-MX",
   "name": "Mexican Spanish",
-  "game-center": false,
-  "readable-alternatives": ["Spanish_MX"]
+  "game-center": false
+  },
+  {
+  "locale": "es-MX",
+  "name": "Spanish_MX",
+  "game-center": false
   },
   {
   "locale": "es-ES",
@@ -164,4 +184,4 @@
  "game-center": true,
  "alternatives": ["vi"]
   }
-  ]
+  ]

data/lib/deliver/app.rb

@@ -32,7 +32,7 @@ module Deliver
     # @param app_identifier If you don't pass this, it will automatically be fetched from the Apple API
     #   which means it takes longer. If you **can** pass the app_identifier (e.g. com.facebook.Facebook) do it
     def initialize(apple_id: nil, app_identifier: nil)
-      self.apple_id = (apple_id || '').to_s.gsub('id', '').to_i
+      self.apple_id = apple_id.to_s.gsub('id', '').to_i
       self.app_identifier = app_identifier
       
       if apple_id and not app_identifier

data/lib/deliver/app_metadata.rb

@@ -145,14 +145,20 @@ module Deliver
     #  as keys.
     # @raise (AppMetadataParameterError) Is thrown when don't pass a correct hash with correct language codes.
     def update_changelog(hash)
+      update_metadata_key(:version_whats_new, hash)
+
+      
+      # The code below doesn't work when the app
+      # is not in the US App Store
+      # https://github.com/KrauseFx/deliver/issues/236#issuecomment-111016436
       # check if we're allowed to do that
-      if FastlaneCore::ItunesSearchApi.fetch(@app.apple_id)
-        # App is already in the store
-        update_metadata_key(:version_whats_new, hash)
-      else
-        # App is not in the store, skipping changelog for now
-        Helper.log.info "It seems like this it the initial release of your app, which can't contain a changelog. Skipping the changelog for now.".yellow
-      end
+      # if FastlaneCore::ItunesSearchApi.fetch(@app.apple_id)
+      #   # App is already in the store
+      #   update_metadata_key(:version_whats_new, hash)
+      # else
+      #   # App is not in the store, skipping changelog for now
+      #   Helper.log.info "It seems like this it the initial release of your app, which can't contain a changelog. Skipping the changelog for now.".yellow
+      # end
     end
 
     # Updates the Marketing URL

data/lib/deliver/deliver_process.rb

@@ -109,6 +109,7 @@ module Deliver
       @app_identifier ||= (@ipa.fetch_app_identifier rescue nil) # since ipa might be nil
 
       @app_version ||= @deploy_information[Deliverer::ValKey::APP_VERSION]
+      @app_version ||= ENV["DELIVER_VERSION"]
       @app_version ||= (@ipa.fetch_app_version rescue nil) # since ipa might be nil
       @app_version ||= (app.get_live_version rescue nil) # pull the latest version from iTunes Connect
     end

data/lib/deliver/itunes_connect/itunes_connect_submission.rb

@@ -73,9 +73,9 @@ module Deliver
         Helper.log.info "DELIVER_BETA_FEEDBACK_EMAIL: '#{ENV['DELIVER_BETA_FEEDBACK_EMAIL']}'"
 
         build_info['details'].each_with_index do |hash, index|
-          build_info['details'][0]['whatsNew']['value'] = ENV["DELIVER_WHAT_TO_TEST"]
-          build_info['details'][index]['description']['value'] = ENV["DELIVER_BETA_DESCRIPTION"]
-          build_info['details'][index]['feedbackEmail']['value'] = ENV["DELIVER_BETA_FEEDBACK_EMAIL"]
+          build_info['details'][index]['whatsNew']['value'] = ENV["DELIVER_WHAT_TO_TEST"]
+          build_info['details'][index]['description']['value'] ||= ENV["DELIVER_BETA_DESCRIPTION"]
+          build_info['details'][index]['feedbackEmail']['value'] ||= ENV["DELIVER_BETA_FEEDBACK_EMAIL"]
         end
         
         h = Excon.post(build_url, body: build_info.to_json, headers: { "Cookie" => cookie_string } )

data/lib/deliver/testflight.rb

@@ -17,7 +17,7 @@ module Deliver
 
       Helper.log.info "Ready to upload new build to TestFlight (#{app_identifier} - #{app_id})".green
 
-      # Got everything to replaoy
+      # Got everything to ready to deploy
       app = App.new(app_identifier: app_identifier, apple_id: app_id)
       ipa = IpaUploader.new(app, '/tmp/', ipa_path, strategy)
       result = ipa.upload!

data/lib/deliver/version.rb

@@ -1,3 +1,3 @@
 module Deliver
-  VERSION = "0.12.0"
+  VERSION = "0.12.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deliver
 version: !ruby/object:Gem::Version
-  version: 0.12.0
+  version: 0.12.1
 platform: ruby
 authors:
 - Felix Krause
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-26 00:00:00.000000000 Z
+date: 2015-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: fastlane_core
@@ -215,11 +215,15 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- LICENSE
+- README.md
+- bin/deliver
+- lib/assets/DeliverLanguageMapping.json
 - lib/assets/DeliverfileDefault
 - lib/assets/DeliverfileExample
-- lib/assets/DeliverLanguageMapping.json
 - lib/assets/ScreenshotsHelp
 - lib/assets/summary.html.erb
+- lib/deliver.rb
 - lib/deliver/app.rb
 - lib/deliver/app_metadata.rb
 - lib/deliver/app_metadata_screenshots.rb
@@ -249,10 +253,6 @@ files:
 - lib/deliver/metadata_item.rb
 - lib/deliver/testflight.rb
 - lib/deliver/version.rb
-- lib/deliver.rb
-- bin/deliver
-- README.md
-- LICENSE
 homepage: https://fastlane.tools
 licenses:
 - MIT
@@ -273,7 +273,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.4.7
 signing_key: 
 specification_version: 4
 summary: Upload screenshots, metadata and your app to the App Store using a single