delighted 1.6.0 → 1.7.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5c28520aa4ae06801122ea66abb81e9e6f3128cb
-  data.tar.gz: f83f3f26990f39e39e8291c9fdeb20fe2133bd9d
+  metadata.gz: 7a52df44b1402d8a586e07ac6277e62088fccf77
+  data.tar.gz: 55967247930e41a650c6265b6446ee16054f09e0
 SHA512:
-  metadata.gz: efc632e1ca316fe1e8721284c1c6409bc9d99ef2a03e5f665fa8b22e7359758a5cbaa7429e5ed27a13e4f9bb64e45c7777a6ce1ec16f35cd608d7348f2a7886e
-  data.tar.gz: 044252f5a7349db4e1a6f5306dc8d05992ec3af18df4a63273d3f889449ab28addeeb52e313a26e63865459eecdc9c1bc4e8ea1a8c37432e7ce69e4f455722fd
+  metadata.gz: d779c8bb232361aaa4658d21aeb1af3f09ad246fa9f7fabf6e6cfc521b95dcec9cd4fc0a6ab2be4c4fdb0c433bc0b84ec19683746bfe6d957f6eddebf3c862f9
+  data.tar.gz: d3b37eae025ea14583932e735d659aa90e705ddaf8b78151b37f00e1acfc4b342fafb3f0ce10a116f1b40b2d9e467962393cc9fcea57843bb0db12d3e270e94f

data/CHANGELOG.md

@@ -1,3 +1,10 @@
+## 1.7.0.rc1 (2017-10-03)
+
+Features:
+
+- Add `Delighted::RateLimitedError#retry_after`.
+- Add `Delighted::Error#response`.
+
 ## 1.6.0 (2017-09-27)
 
 Features:

data/README.md

@@ -194,3 +194,12 @@ metrics_from_custom_shared_client = Delighted::Metrics.retrieve
 4. Commit your changes (`git commit -am 'Add some feature'`)
 5. Push to the branch (`git push origin my-new-feature`)
 6. Create new Pull Request
+
+## Releasing
+
+1. Bump the version in `lib/delighted/version.rb`.
+2. Update the README and CHANGELOG as needed.
+3. Tag the commit for release.
+4. Build the gem with `gem build delighted.gemspec`.
+5. Install locally to verify `gem install PATH_TO_GENERATED_GEM.gem`.
+6. Push to Rubygems.org with `gem push PATH_TO_GENERATED_GEM.gem`.

data/lib/delighted/errors.rb

@@ -1,5 +1,7 @@
 module Delighted
   class Error < StandardError
+    attr_reader :response
+
     def initialize(response)
       @response = response
     end
@@ -23,6 +25,10 @@ module Delighted
 
   class RateLimitedError < Error
     # 429, rate limited
+
+    def retry_after
+      response.retry_after
+    end
   end
 
   class GeneralAPIError < Error

data/lib/delighted/http_response.rb

@@ -11,5 +11,11 @@ module Delighted
     def content_type
       @headers.values_at('content-type', 'Content-Type')[0]
     end
+
+    def retry_after
+      if value = @headers["Retry-After"]
+        value.to_i
+      end
+    end
   end
 end

data/lib/delighted/version.rb

@@ -1,3 +1,3 @@
 module Delighted
-  VERSION = "1.6.0"
+  VERSION = "1.7.0.rc1"
 end

data/test/delighted_test.rb

@@ -7,11 +7,18 @@ class Delighted::ClientTest < Delighted::TestCase
   end
 
   def test_handles_rate_limited_response
-    response = Delighted::HTTPResponse.new(429, {}, Delighted::JSON.dump({ status: 429, message: "Too Many Requests" }
+    response = Delighted::HTTPResponse.new(429, { "Retry-After" => "10" }, Delighted::JSON.dump({ :status => 429, :message => "Too Many Requests" }
 ))
     mock_http_adapter.stubs(:request).returns(response)
 
-    assert_raises(Delighted::RateLimitedError) { Delighted.shared_client.get_json("/foo") }
+    assert_raises(Delighted::RateLimitedError) do
+      begin
+        Delighted.shared_client.get_json("/foo")
+      rescue Delighted::RateLimitedError => e
+        assert_equal 10, e.retry_after
+        raise
+      end
+    end
   end
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: delighted
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0.rc1
 platform: ruby
 authors:
 - Mark Dodwell
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-27 00:00:00.000000000 Z
+date: 2017-10-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -118,9 +118,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.6.13