delegate_presenter 0.0.1 → 0.0.2

data/CHANGELOG.markdown

@@ -0,0 +1,9 @@
+0.0.2 (October 20, 2011)
+============================
+The Previous version of the gem automatically extended ApplicationController. Pulling this gem into an actual project, it was found that this automatic extension broke controller class methods.
+
+Now you must manually extend ApplicationController yourself. See the README on how to do this.
+
+0.0.1 (October 19, 2011)
+============================
+Initial public release of this code (extracted from other projects)

data/Gemfile

@@ -1,4 +1,6 @@
 source "http://rubygems.org"
 
+gem 'actionpack', "~> 3.1.0", :require => 'action_view'
+
 # Specify your gem's dependencies in delegate_presenter.gemspec
 gemspec

data/README.markdown

@@ -32,11 +32,11 @@ As `DelegatePresenter::Base` subclasses are just `SimpleDelegator`s at heart, th
 So, what is DelegatePresenter, really?
 ================================
 
-DelegatePresenter does two things:
+DelegatePresenter does three things:
 
-  1. Inherits from Ruby Standard Library's SimpleDelegator. This simple class solves many of the problems I've seen with decorators in the past. (calling object.method everywhere)
+  1. Inherits from Ruby Standard Library's SimpleDelegator. This simple class solves many of the problems I've seen with presenter APIs in the past. (calling object.method everywhere)
 
-  2. Makes Rails helpers available to you via the helpers method, gives you s (above) and h (your old Rails 2 friend)
+  2. Makes Rails helpers available to you via the `helpers` method, gives you `s` (above) and `h` (your old Rails 2 friend).
 
   3. Gives you a `record_id` method, which will return the ActiveRecord ID of the database object. Because I think it should have been this way in the first place :)
 
@@ -45,5 +45,39 @@ Installation
 ================================
 
   1. Add me to your Gemfile
-  2. In your `config/application.rb`, add an autoload path for `app/presenters/`
-  3. Create presenters for your classes. For example: `app/presenters/todo_presenter.rb`. These classes should subclass `DelegatePresenter::Base`
+  2. In your ApplicationController `extend DelegatePresenter::ApplicationController`
+  3. In your `config/application.rb`, add an autoload path for `app/presenters/`
+  4. Create presenters for your classes. For example: `app/presenters/todo_presenter.rb`. These classes should subclass `DelegatePresenter::Base`
+
+
+Credit where Credit Is Due
+=================================
+
+Most of this gem was inspired by (and the initial structure stolen from), [Avdi Grimm](avdi.org)'s blog posts on [Demeter](http://avdi.org/devblog/2011/07/05/demeter-its-not-just-a-good-idea-its-the-law/) and [Nil objects and Falsiness](http://avdi.org/devblog/2011/05/30/null-objects-and-falsiness/). While these articles talk about other things, they give part of a very simple Presenter strategy.
+
+The simplest presenter strategy that could possibly work.
+
+So I used it on a few projects, and extended the abilities were I had to. It's still *very* simple, doing only one or two things more than that original pattern. I just built on the shoulders of giants.
+
+But what about....
+==============================
+
+I know there are a few other presenter frameworks out there for Rails. One hasn't seen any activity since 2008, and one is [Draper](https://rubygems.org/gems/draper).
+
+I'm not a big fan of Draper's API, and it seemed too heavy to me. If Draper's your style, that's great: different strokes for different folks.
+
+
+License
+==============================
+
+LICENSE:
+
+(The MIT License)
+
+Copyright © 2011 Ryan Wilcox
+
+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the ‘Software’), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED ‘AS IS’, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/lib/delegate_presenter.rb

@@ -2,6 +2,8 @@ require "delegate_presenter/version"
 require 'delegate_presenter/application_controller'
 require 'delegate_presenter/present'
 
+require 'delegate'
+
 module DelegatePresenter
   class Base < SimpleDelegator
 
@@ -16,7 +18,7 @@ module DelegatePresenter
 
 
     def helpers
-      ApplicationController.all_helpers
+      ::ApplicationController.all_helpers  # the GLOBAL ApplicationController, not the ApplicationController in this namespace
     end
 
     def s(*args)

data/lib/delegate_presenter/application_controller.rb

@@ -1,3 +1,9 @@
+
+# This module adds a method so DelegatePresenter::Base can access your Rails helpers
+# You'll need to extend your ApplicationController with this module name
+#
+# Earlier versions of the gem extended ApplicationController for you, but introduced bugs
+# (possibly dealing with load order???) WD-rpw 10-20-2011
 module DelegatePresenter::ApplicationController
   # Provide access to helper methods from outside controllers and views,
   # such as in Presenter objects. Rails provides ActionController::Base.helpers,
@@ -28,6 +34,3 @@ module DelegatePresenter::ApplicationController
   end
 end
 
-class ApplicationController
-  extend DelegatePresenter::ApplicationController
-end

data/lib/delegate_presenter/version.rb

@@ -1,3 +1,3 @@
 module DelegatePresenter
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/delegate_presenter_base_spec.rb

@@ -2,12 +2,27 @@
 
 require 'spec_helper'
 
+# Pull in some fake helpers. In a Real Rails app these would be provided by Rails
+# TODO: is there an easy way to test this closer to the actual behavior? By pulling in
+# some of Rails, for example?
+class FakeHelpers
+  def h(s)
+    s.gsub(/&/, "&amp;").gsub(/\"/, "&quot;").gsub(/>/, "&gt;").gsub(/</, "&lt;")
+  end
+end
+
+class FakeDelegatePresenter < DelegatePresenter::Base
+  def helpers
+    FakeHelpers.new
+  end
+end
+
 describe "DelegatePresenter::Base" do
 
   describe "HTML building helpers" do
 
     before do
-      @ap = DelegatePresenter::Base.new(1)
+      @ap = FakeDelegatePresenter.new(1)
     end
 
     it "handles HTML elements that should not be escaped" do

data/spec/samples/application_controller.rb

@@ -0,0 +1,32 @@
+module ActionController
+  class Base
+    @@before_filters = []
+    def self.before_filters
+      @@before_filters
+    end
+    def self.before_filter(name)
+      @@before_filters << name
+    end
+  end
+end
+
+module ApplicationHelper
+end
+
+class ApplicationController < ActionController::Base
+  extend ActionView::Helpers
+  extend ActionView::Helpers::TagHelper
+  extend ActionView::Helpers::UrlHelper
+  extend ApplicationHelper
+
+  extend DelegatePresenter::ApplicationController
+
+  def view_context
+    @view_context ||= ApplicationController
+  end
+
+  def view_context=(input)
+    @view_context = input
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,11 @@
+$LOAD_PATH << File.join(File.dirname(__FILE__), '..', 'lib')
+require 'delegate_presenter'
+
+require 'rubygems'
+require 'bundler/setup'
+
+Bundler.require
+
+Dir.glob(['./spec/samples/*.rb', './spec/support/*.rb']) do |file|
+  require file
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delegate_presenter
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2011-10-20 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &82177300 !ruby/object:Gem::Requirement
+  requirement: &72643760 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *82177300
+  version_requirements: *72643760
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &82177090 !ruby/object:Gem::Requirement
+  requirement: &72643400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +32,7 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *82177090
+  version_requirements: *72643400
 description: Presenters are easier with delegators, and other friends
 email:
 - rwilcox@wilcoxd.com
@@ -41,6 +41,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- CHANGELOG.markdown
 - Gemfile
 - README.markdown
 - Rakefile
@@ -50,6 +51,7 @@ files:
 - lib/delegate_presenter/present.rb
 - lib/delegate_presenter/version.rb
 - spec/delegate_presenter_base_spec.rb
+- spec/samples/application_controller.rb
 - spec/spec_helper.rb
 homepage: http://github.com/rwilcox/delegate_presenter
 licenses: []