delayed_job_shallow_mongoid 0.3.0 → 0.4.0

data/Gemfile

@@ -1,14 +1,2 @@
 source "http://rubygems.org"
-
-gem "delayed_job", ">= 2.1.1"
-gem "mongoid", "~> 2.0"
-
-group :development do
-  gem "actionmailer"
-  gem "shoulda", ">= 0"
-  gem "bundler", "~> 1.0.0"
-  gem "jeweler", "~> 1.6.4"
-  gem "rspec"
-  gem "ruby-debug19"
-  gem "bson_ext", "~> 1.5"
-end
+gemspec

data/VERSION

@@ -1 +1 @@
-0.3.0
+0.4.0

data/delayed_job_shallow_mongoid.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "delayed_job_shallow_mongoid"
-  s.version = "0.3.0"
+  s.version = "0.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Joey Aghion"]
-  s.date = "2012-02-12"
+  s.date = "2012-10-27"
   s.description = "When the object or arg to a delayed_job is a Mongoid document, store only a small stub of the object instead of the full serialization."
   s.email = "joey@aghion.com"
   s.extra_rdoc_files = [
@@ -35,39 +35,36 @@ Gem::Specification.new do |s|
   s.homepage = "http://github.com/joeyAghion/delayed_job_shallow_mongoid"
   s.licenses = ["MIT"]
   s.require_paths = ["lib"]
-  s.rubygems_version = "1.8.10"
+  s.rubygems_version = "1.8.24"
   s.summary = "More efficient Mongoid document serialization for delayed_job."
 
   if s.respond_to? :specification_version then
     s.specification_version = 3
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_runtime_dependency(%q<delayed_job>, [">= 2.1.1"])
-      s.add_runtime_dependency(%q<mongoid>, ["~> 2.0"])
+      s.add_runtime_dependency(%q<delayed_job_shallow_mongoid>, [">= 0"])
       s.add_development_dependency(%q<actionmailer>, [">= 0"])
       s.add_development_dependency(%q<shoulda>, [">= 0"])
-      s.add_development_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_development_dependency(%q<bundler>, [">= 0"])
       s.add_development_dependency(%q<jeweler>, ["~> 1.6.4"])
       s.add_development_dependency(%q<rspec>, [">= 0"])
       s.add_development_dependency(%q<ruby-debug19>, [">= 0"])
       s.add_development_dependency(%q<bson_ext>, ["~> 1.5"])
     else
-      s.add_dependency(%q<delayed_job>, [">= 2.1.1"])
-      s.add_dependency(%q<mongoid>, ["~> 2.0"])
+      s.add_dependency(%q<delayed_job_shallow_mongoid>, [">= 0"])
       s.add_dependency(%q<actionmailer>, [">= 0"])
       s.add_dependency(%q<shoulda>, [">= 0"])
-      s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+      s.add_dependency(%q<bundler>, [">= 0"])
       s.add_dependency(%q<jeweler>, ["~> 1.6.4"])
       s.add_dependency(%q<rspec>, [">= 0"])
       s.add_dependency(%q<ruby-debug19>, [">= 0"])
       s.add_dependency(%q<bson_ext>, ["~> 1.5"])
     end
   else
-    s.add_dependency(%q<delayed_job>, [">= 2.1.1"])
-    s.add_dependency(%q<mongoid>, ["~> 2.0"])
+    s.add_dependency(%q<delayed_job_shallow_mongoid>, [">= 0"])
     s.add_dependency(%q<actionmailer>, [">= 0"])
     s.add_dependency(%q<shoulda>, [">= 0"])
-    s.add_dependency(%q<bundler>, ["~> 1.0.0"])
+    s.add_dependency(%q<bundler>, [">= 0"])
     s.add_dependency(%q<jeweler>, ["~> 1.6.4"])
     s.add_dependency(%q<rspec>, [">= 0"])
     s.add_dependency(%q<ruby-debug19>, [">= 0"])

data/lib/delayed/shallow_mongoid/performable_mailer.rb

@@ -1,7 +1,13 @@
 module Delayed
   class PerformableMailer
     def perform
-      ShallowMongoid.load(object).send(method_name, *args.map{|a| ShallowMongoid.load(a) }).deliver
+      begin
+        klass = ShallowMongoid.load(object)
+        delayed_arguments = *args.map{|a| ShallowMongoid.load(a) }
+      rescue Mongoid::Errors::DocumentNotFound
+        return true  # do nothing if document has been removed
+      end
+      klass.send(method_name, *delayed_arguments).deliver
     end
   end
 end

data/lib/delayed/shallow_mongoid/performable_method.rb

@@ -9,9 +9,13 @@ module Delayed
     end
     
     def perform
-      ShallowMongoid.load(object).send(method_name, *args.map{|a| ShallowMongoid.load(a) })
-    rescue Mongoid::Errors::DocumentNotFound
-      true  # do nothing if document has been removed
+      begin
+        klass = ShallowMongoid.load(object)
+        delayed_arguments = *args.map{|a| ShallowMongoid.load(a) }
+      rescue Mongoid::Errors::DocumentNotFound
+        return true  # do nothing if document has been removed
+      end
+      klass.send(method_name, *delayed_arguments)
     end
     
     def display_name

data/spec/delayed_job_shallow_mongoid_spec.rb

@@ -132,16 +132,39 @@ describe ::Delayed::PerformableMethod do
 end
 
 describe ::Delayed::PerformableMailer do
-  before do
-    @model = TestModel.create
-    @email = mock('email', :deliver => true)
-    @mailer_class = mock('MailerClass', :signup => @email)
-    @mailer = ::Delayed::PerformableMailer.new(@mailer_class, :signup, [@model])
+  context "successful mailer" do
+    before do
+      @model = TestModel.create
+      @email = mock('email', :deliver => true)
+      @mailer_class = mock('MailerClass', :signup => @email)
+      @mailer = ::Delayed::PerformableMailer.new(@mailer_class, :signup, [@model])
+    end
+    it "should call the method and #deliver on the mailer" do
+      TestModel.should_receive(:find).with(@model._id.to_s).and_return(@model)
+      @mailer_class.should_receive(:signup).with(@model)
+      @email.should_receive(:deliver)
+      @mailer.perform
+    end
+    it "should do nothing if an argument document is not found" do
+      error = ::Mongoid::Errors::DocumentNotFound.new(TestModel, @model._id)
+      TestModel.should_receive(:find).with(@model._id.to_s).and_raise(error)
+      @mailer.perform.should be_true
+    end
   end
-  it "should call the method and #deliver on the mailer" do
-    TestModel.should_receive(:find).with(@model._id.to_s).and_return(@model)
-    @mailer_class.should_receive(:signup).with(@model)
-    @email.should_receive(:deliver)
-    @mailer.perform
+  context "failing mailer from bad record" do
+    before do
+      @model = TestModel.create
+      error = ::Mongoid::Errors::DocumentNotFound.new(TestModel, @model._id)
+      @email = mock('email')
+      @email.stub(:deliver).and_raise(error)
+      @mailer_class = mock('MailerClass', :signup => @email)
+      @mailer = ::Delayed::PerformableMailer.new(@mailer_class, :signup, [@model])
+    end
+    it "should fail if an exception comes up" do
+      TestModel.stub(:find).with(@model._id.to_s).and_return(@model)
+      -> {
+        @mailer.perform
+      }.should raise_error(::Mongoid::Errors::DocumentNotFound)
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delayed_job_shallow_mongoid
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,33 +9,27 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-12 00:00:00.000000000Z
+date: 2012-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: delayed_job
-  requirement: &2153406800 !ruby/object:Gem::Requirement
+  name: delayed_job_shallow_mongoid
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 2.1.1
+        version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2153406800
-- !ruby/object:Gem::Dependency
-  name: mongoid
-  requirement: &2153406140 !ruby/object:Gem::Requirement
+  version_requirements: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: '2.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: *2153406140
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: actionmailer
-  requirement: &2153405420 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +37,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153405420
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: shoulda
-  requirement: &2153404800 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,21 +53,31 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153404800
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
-  requirement: &2153404140 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
-    - - ~>
+    - - ! '>='
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153404140
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: jeweler
-  requirement: &2153403480 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -76,10 +85,15 @@ dependencies:
         version: 1.6.4
   type: :development
   prerelease: false
-  version_requirements: *2153403480
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.6.4
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2153402780 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -87,10 +101,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153402780
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: ruby-debug19
-  requirement: &2153399500 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -98,10 +117,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2153399500
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bson_ext
-  requirement: &2153398800 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -109,7 +133,12 @@ dependencies:
         version: '1.5'
   type: :development
   prerelease: false
-  version_requirements: *2153398800
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.5'
 description: When the object or arg to a delayed_job is a Mongoid document, store
   only a small stub of the object instead of the full serialization.
 email: joey@aghion.com
@@ -148,7 +177,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -1991508222429325858
+      hash: -2014166991515156884
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -157,7 +186,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.10
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: More efficient Mongoid document serialization for delayed_job.