delayed 3.0.1 → 3.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2078916c01265f24d3f7bb05ef6bb752dae563413973d4efaf8622bb3c7a40bf
-  data.tar.gz: d388130dd48000d4148eeb5246e8975989b45e106d144fcbea7ffbc140fb0e4e
+  metadata.gz: 40ac1d14d7043c15029a5e563ad4e278315f50cd99d947b97ecb5205cde483fa
+  data.tar.gz: 0e4d7ffd516267c28a2b2ab6468cfe383a5c486aaf4875ffeb92b72797af9e29
 SHA512:
-  metadata.gz: f624aabb72e24fb49b8f81e1bf90562a6dd62354f5145ea6ff693d08b13a4089ef03a17544cc26359d5ef0891fdc2e1bdd6d82e7fc683684cb6006aefd12f8d3
-  data.tar.gz: c1a3066fcd79c66b0b264467364a9640d0854fe5a08cd61a4ed305ba23c3998afb9297775a7d49a9a2761799dc9bf56497173e73f618ddee8a3991303d2cff0e
+  metadata.gz: bfa5833f65f57e02447e6ace001d8cd0be205399ab5a108f1cc2d7ef13ce749b99b557f3bd36a79a9e4cb6e0ef37bd6c11746318013c9f084626a96b2fd4b1a4
+  data.tar.gz: 8aa12f59cbf61b68881853351cb19af8ff8b391014e3eacafe8f78e556dcf98bbde2a918fdb0b24386ea95d72d14ec43ec4a1af98db60ee297c4d31db071139a

data/lib/delayed/priority.rb

@@ -70,10 +70,12 @@ module Delayed
       def names=(names)
         raise "must include a name for priority >= 0" if names && !names.value?(0)
 
+        remove_named_priority_methods
         @ranges = nil
         @alerts = nil
         @names_to_priority = nil
         @names = names&.sort_by(&:last)&.to_h&.transform_values { |v| new(v) }
+        define_named_priority_methods
       end
 
       def alerts=(alerts)
@@ -124,17 +126,35 @@ module Delayed
         low + ((high - low).to_d / 2).ceil
       end
 
-      def respond_to_missing?(method_name, include_private = false)
-        names_to_priority.key?(method_name) || super
+      # Defines a class method (e.g. `Priority.eventual`) and an instance predicate (e.g.
+      # `priority.eventual?`) per name, as real, introspectable methods (visible to `methods`,
+      # RDoc, and Sorbet's tapioca, unlike `method_missing` dispatch). Pre-existing methods
+      # (e.g. a name of `superclass`) are never overridden.
+      def define_named_priority_methods
+        names.each_key do |name|
+          predicate = :"#{name}?"
+          define_singleton_method(name) { names_to_priority.fetch(name) } unless method_defined_on?(singleton_class, name)
+          define_method(predicate) { name.to_s == to_s } unless method_defined_on?(self, predicate)
+        end
       end
 
-      def method_missing(method_name, *args)
-        if names_to_priority.key?(method_name) && args.none?
-          names_to_priority[method_name]
-        else
-          super
+      # Removes the methods previously defined for the current `names` (called before `names` is
+      # reassigned). The non-inherited (`false`) checks mean we only remove methods we defined
+      # ourselves, leaving any pre-existing method a colliding name never overrode (e.g.
+      # `Class#superclass`, `Numeric#zero?`) in place.
+      def remove_named_priority_methods
+        names.each_key do |name|
+          predicate = :"#{name}?"
+          singleton_class.send(:remove_method, name) if singleton_class.method_defined?(name, false)
+          remove_method(predicate) if method_defined?(predicate, false)
         end
       end
+
+      # Whether `mod` already responds to `name` (public, protected, private, or inherited), in
+      # which case a same-named priority must not override it.
+      def method_defined_on?(mod, name)
+        mod.method_defined?(name) || mod.private_method_defined?(name)
+      end
     end
 
     attr_reader :value
@@ -188,18 +208,6 @@ module Delayed
       to_i.to_d
     end
 
-    private
-
-    def respond_to_missing?(method_name, include_private = false)
-      (method_name.to_s.end_with?('?') && self.class.names.key?(method_name.to_s[0..-2].to_sym)) || super
-    end
-
-    def method_missing(method_name, *args)
-      if method_name.to_s.end_with?('?') && self.class.names.key?(method_name.to_s[0..-2].to_sym)
-        method_name.to_s[0..-2] == to_s
-      else
-        super
-      end
-    end
+    send(:define_named_priority_methods)
   end
 end

data/lib/delayed/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Delayed
-  VERSION = '3.0.1'
+  VERSION = '3.1.0'
 end

data/spec/delayed/priority_spec.rb

@@ -13,9 +13,10 @@ RSpec.describe Delayed::Priority do
   ensure
     described_class.alerts = nil
     described_class.names = nil
+    described_class.assign_at_midpoint = nil
   end
 
-  describe '.names, .ranges, .alerts, .names_to_priority, method_missing' do
+  describe '.names, .ranges, .alerts, .names_to_priority, named priority methods' do
     it 'defaults to interactive, user_visible, eventual, reporting' do
       expect(described_class.names).to eq(
         interactive: 0,
@@ -68,6 +69,34 @@ RSpec.describe Delayed::Priority do
       end
     end
 
+    it 'defines named priority methods as real, introspectable methods' do
+      expect(described_class.singleton_class.method_defined?(:eventual)).to be true
+      expect(described_class.method_defined?(:eventual?)).to be true
+    end
+
+    it 'removes methods for the old names when names are reassigned' do
+      described_class.names = { high: 0 }
+      expect(described_class).to respond_to(:high)
+      expect(described_class.new(0)).to be_high
+
+      described_class.names = nil
+      expect(described_class).not_to respond_to(:high)
+      expect(described_class.new(0)).not_to respond_to(:high?)
+      expect(described_class).to respond_to(:interactive)
+      expect(described_class.new(0)).to be_interactive
+    end
+
+    context 'when a name collides with an existing method' do
+      let(:custom_names) { { superclass: 0, zero: 10 } }
+
+      it 'does not redefine the existing method' do
+        expect(described_class.superclass).to eq Numeric # Class#superclass, not the priority
+        expect(described_class.new(0).zero?).to be true # Numeric#zero?, not the range predicate
+        expect(described_class.zero).to eq 10
+        expect(described_class.new(5).superclass?).to be true
+      end
+    end
+
     context 'when customized to high, medium, low' do
       let(:custom_names) { { high: 0, medium: 100, low: 500 } }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delayed
 version: !ruby/object:Gem::Version
-  version: 3.0.1
+  version: 3.1.0
 platform: ruby
 authors:
 - Nathan Griffith
@@ -19,7 +19,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2026-06-15 00:00:00.000000000 Z
+date: 2026-07-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord