delayed 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 02d090c8d335114c2ca9d46a6aee12025dba8e78e13351619e7712ee49a6df98
-  data.tar.gz: 9e9cc9e3e41209de66c2dac1adfe62a6b4fb7ed243220d16fd39beb1da11a6a8
+  metadata.gz: 4f978a0dbfd75659bb230acd0941387a03ad410861aeb4f50f9f13e1e0bca68c
+  data.tar.gz: c8505cfdc0730e2ce2ed8f21f92ec25e9fcd332fead3591650db9b6e95090205
 SHA512:
-  metadata.gz: 9515b3eea5aa30a6745458f50bc843e4857b77e7ec73576e2acca8562a21fd14e80293f4b4278aa566a837b2b33166e92239a6904df6d60c2d42a77416362aad
-  data.tar.gz: e32e446db1d012a252d93dce7ca31318c1877c700085892a0071a88a54418fa78ad44b764c757ded8d9a157a09b7b7249679e6d5728fcf5deeec45370f881361
+  metadata.gz: e6c4e6b4f82a6bb7687130a7c069b5a3a3334902762d7b106ac36f049f2cdeca047aa260cf97cbbfa7ea3791cfd44ea8611eb274a217dddf8c3d8e7d8ac2ed22
+  data.tar.gz: ed3f2531eb4baba2029d080696267c8c578f1d573fdc919e63edefcd2151be577e64a246babe14bfe500154a11d0abdbbdb045921ae95f2f0102dddb18894e32

data/app/models/delayed/job.rb

@@ -256,8 +256,8 @@ module Delayed
     private
 
     def set_name
-      # [feat:NameColumn] remove 'if' statement once the 'name' column is required.
-      self.name ||= display_name if respond_to?(:name=)
+      # [feat:NameColumn] remove 'if' statement and use `||=` once the 'name' column is required.
+      self.name = display_name if respond_to?(:name=) && attributes.fetch('name').nil?
     end
   end
 end

data/lib/delayed/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Delayed
-  VERSION = '1.2.0'
+  VERSION = '1.2.1'
 end

data/spec/delayed/job_spec.rb

@@ -259,6 +259,7 @@ describe Delayed::Job do
         expect(job.name).to eq('ErrorJob')
         job.save!
         expect(job.reload.name).to eq('ErrorJob')
+        expect(described_class.group(:name).count).to eq('ErrorJob' => 1)
       end
 
       it 'is the class name of the performable job if it is an ActiveJob' do
@@ -267,6 +268,7 @@ describe Delayed::Job do
         expect(job.name).to eq('ActiveJobJob')
         job.save!
         expect(job.reload.name).to eq('ActiveJobJob')
+        expect(described_class.group(:name).count).to eq('ActiveJobJob' => 1)
       end
 
       it 'is the returned display_name if display_name is defined on the job object' do
@@ -274,11 +276,13 @@ describe Delayed::Job do
         expect(job.name).to eq('named_job')
         job.save!
         expect(job.reload.name).to eq('named_job')
+        expect(described_class.group(:name).count).to eq('named_job' => 1)
       end
 
       it 'is the instance method that will be called if its a performable method object' do
         job = Story.create(text: '...').delay.save
         expect(job.name).to eq('Story#save')
+        expect(described_class.group(:name).count).to eq('Story#save' => 1)
       end
 
       it 'is the custom name value when set explicitly' do
@@ -286,6 +290,7 @@ describe Delayed::Job do
         job.name = 'Custom Name'
         job.save!
         expect(job.reload.name).to eq('Custom Name')
+        expect(described_class.group(:name).count).to eq('Custom Name' => 1)
       end
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delayed
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Nathan Griffith