delayed 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ea752ae23dd7aee646bcd0be946a7e414c328c4323dc4a2f34d0ee2106c36364
-  data.tar.gz: 6b2509d426b6e7dd25340fde6a3ff4ccfea88fbf15d53d91a1724629ff21c170
+  metadata.gz: 6268c514bb90e5279b8265c4ce21eea8262ac4d539ff161c7f9eab12f15f17ba
+  data.tar.gz: eb0c1f81475163766a680eab603740a4632956fb415e4158430a67bb3998c381
 SHA512:
-  metadata.gz: 015dd62d37946fd70411776f89a6d96850b76a1f3d54a280d38ff82d816b0ab0532b673309ace4882575b443a9ce1244e8a053a82d25413d2217213d3c72284f
-  data.tar.gz: 5dcd12088fb0bbe76abe2559a35aa53a6b90155fe22dd992033b31f12f63b0d572ec8ba2b87d2ad418837dc25ebaeecd1a558108e8cf74f08081c11435ddcafb
+  metadata.gz: 73686b95d83b336dcf268f4524fb8b512e64f61b58773b0884e8f1a4c30abc89532aaa0df4e1395d69417d2062ae7e948157c7cd5b3b7cb80982c68dbf798936
+  data.tar.gz: 9f3b7437e5772e0fe44b3f168cd32b78073b6c49b2fc208b713d946d4b48f14549646363856e3d62a7525059a7d841fbe0191a520af3dc06a71e3d258679b68e

data/lib/delayed/priority.rb

@@ -140,6 +140,7 @@ module Delayed
     attr_reader :value
 
     delegate :to_i, to: :value
+    delegate :to_f, to: :value
     delegate :to_s, to: :name
 
     def initialize(value)

data/lib/delayed/worker.rb

@@ -142,17 +142,17 @@ module Delayed
           job.destroy
         end
         job_say job, format('COMPLETED after %.4f seconds', run_time)
+        true # did work
+      rescue DeserializationError => e
+        job_say job, "FAILED permanently with #{e.class.name}: #{e.message}", 'error'
+
+        job.error = e
+        failed(job)
+        false # work failed
+      rescue Exception => e # rubocop:disable Lint/RescueException
+        self.class.lifecycle.run_callbacks(:error, self, job) { handle_failed_job(job, e) }
+        false # work failed
       end
-      true # did work
-    rescue DeserializationError => e
-      job_say job, "FAILED permanently with #{e.class.name}: #{e.message}", 'error'
-
-      job.error = e
-      failed(job)
-      false # work failed
-    rescue Exception => e # rubocop:disable Lint/RescueException
-      self.class.lifecycle.run_callbacks(:error, self, job) { handle_failed_job(job, e) }
-      false # work failed
     end
 
     # Reschedule the job in the future (when a job fails).

data/spec/delayed/priority_spec.rb

@@ -207,6 +207,13 @@ RSpec.describe Delayed::Priority do
     expect(described_class.new(101)).to eq described_class.new(101) # rubocop:disable RSpec/IdenticalEqualityAssertion
   end
 
+  it 'supports explicit casting' do
+    expect(described_class.new(0).to_i).to eq 0
+    expect(described_class.new(3).to_f).to eq 3.0
+    expect(described_class.new(10).to_s).to eq 'user_visible'
+    expect(described_class.new(:eventual).to_d).to eq '20'.to_d
+  end
+
   it 'suports coercion' do
     expect(described_class.new(0)).to eq 0
     expect(described_class.new(8)).to be > 5

data/spec/worker_spec.rb

@@ -239,5 +239,35 @@ describe Delayed::Worker do
 
       expect(performances.value).to eq(1)
     end
+
+    it 'wraps perform and cleanup, even when perform raises' do
+      events = []
+      last_error = nil
+
+      plugin = Class.new(Delayed::Plugin) do
+        callbacks do |lifecycle|
+          lifecycle.around(:thread) do |_, &blk|
+            events << :thread_start
+            blk.call
+            events << :thread_end
+          end
+          lifecycle.around(:perform) do |_, job, &blk|
+            events << :perform_start
+            blk.call.tap do
+              last_error = job.last_error
+              events << :perform_end
+            end
+          end
+        end
+      end
+
+      Delayed.plugins << plugin
+
+      Delayed::Job.enqueue ErrorJob.new
+      described_class.new.work_off
+
+      expect(events).to eq %i(thread_start perform_start perform_end thread_end)
+      expect(last_error).to match(/did not work/) # assert that cleanup happened before `:perform_end`
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: delayed
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.8.0
 platform: ruby
 authors:
 - Nathan Griffith
@@ -18,7 +18,7 @@ authors:
 - Tobias Lütke
 bindir: bin
 cert_chain: []
-date: 2025-04-02 00:00:00.000000000 Z
+date: 2025-04-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord