define-poro 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 033b78f766bc6090768bb0ab44668594d5f1e6a4
-  data.tar.gz: a9790b5fbb89d3f539594d5c80b8ee199617bf47
+  metadata.gz: a146c56f301e4736fcbebd38b2009c426a0efce8
+  data.tar.gz: 3902688e7b28ed1ff378e438ecc83224d744fd2a
 SHA512:
-  metadata.gz: 8abf6b17bd0ce8384d46f373dd5af53737a7bec5691e2b4e32b6d0531fc41b18ca2e558d3f6dbfe0b7eae88b4bccffde092fc2f885a133909180b260b6724f66
-  data.tar.gz: f3774c785ce47070349f4aad8123403b72cf32d292166c9ca45991a382a03da7e0edb41ae07863310497bb8306a05b33e443288561e9295361ef622a64ab5de4
+  metadata.gz: 4d4784973eba13d96a8841d079ac0e1bdd121a26ca3d6abeda1e22d65c77fa31a49bf5dc6f248453e4050c19c8c8e7c0c8a0d124449ca9386c6dea88b5c4d556
+  data.tar.gz: 2936c60f6ae1b3a4667c407d23c844625ae9f9f794f8f34533ce8685874381c9d164453ad824b9d1f9d6fc7abcc134d52919b5cb9395faa2e1889ab092a8c955

data/README.md

@@ -2,7 +2,27 @@
 
 Plain Old Ruby Object class builder from provided attribute list and block.
 
-## Rationale
+## WARNING
+
+Sadly assignment does not handle constants scope well:
+
+```
+RegisterUser = DefinePoro::As.new(:user, :params) do
+  USER_TYPE = 1
+
+  # logic for registering user
+end
+
+puts USER_TYPE #> 1 WHAT! constant is bound to outer context
+puts RegisterUser::USER_TYPE #> NameError: uninitialized constant RegisterUser::XX
+```
+
+Conclusion - please use old plain ruby objects with initializer and attr_reader,
+fancy things are not always the best ones.
+
+## History
+
+### Rationale
 
 I have been using Struct.new to dynamically create ruby objects that base their identity
 on functionality and not on values.
@@ -39,21 +59,23 @@ end
 Ruby guys are lazy so we would like to type something shorter - that's provided by DefinePoro:
 
 ```
-RegisterUser = DefinePoro::Define.new(:user, :params) do
+RegisterUser = DefinePoro::As.new(:user, :params) do
   # logic for registering user
 end
 ```
 
-The `DefinePoro::Define` implementation is easy and performant ruby code.
+The `DefinePoro::As` implementation is easy and performant ruby code.
 
-## Should you use it?
+### Should you use it?
 
 Yes - if you are lazy to type initializers.
 
 No - if you think that dynamic class definition could be harmful.
 And I believe that in some cases it could.
 
-## Installation
+SURELY NOT - sadly assignment does not handle constants scope well.
+
+### Installation
 
 Add this line to your application's Gemfile:
 
@@ -69,7 +91,7 @@ Or install it yourself as:
 
     $ gem install define-poro
 
-## Usage
+### Usage
 
 Instead of
 
@@ -88,12 +110,12 @@ end
 Define you class via
 
 ```
-RegisterUser = DefinePoro::Define.new(:user, :params) do
+RegisterUser = DefinePoro::As.new(:user, :params) do
   # logic for registering user
 end
 ```
 
-## Contributing
+### Contributing
 
 1. Fork it ( https://github.com/astrauka/define-poro/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
@@ -101,3 +123,7 @@ end
 4. Ensure that you have written specs (rspec)
 5. Push to the branch (`git push origin my-new-feature`)
 6. Create a new Pull Request
+
+### Changelog
+
+`0.1.0` - renamed `DefinePoro::Define` to `DefinePoro::As`

data/lib/define-poro.rb

@@ -1,5 +1,5 @@
 require 'define-poro/version'
-require 'define-poro/define'
+require 'define-poro/as'
 
 module DefinePoro
 end

data/lib/define-poro/{define.rb → as.rb}

@@ -1,5 +1,5 @@
 module DefinePoro
-  class Define
+  class As
     def self.new(*attributes, &block)
       Class.new do
         class_eval(%(

data/lib/define-poro/version.rb

@@ -1,3 +1,3 @@
 module DefinePoro
-  VERSION = '0.0.1'
+  VERSION = '0.1.0'
 end

data/spec/lib/{define_spec.rb → as_spec.rb}

@@ -1,7 +1,7 @@
 require 'spec_helper'
 
 module DefinePoro
-  describe Define do
+  describe As do
     describe '.new' do
       let(:klass) { described_class.new(:b, :a) }
 
@@ -25,6 +25,8 @@ module DefinePoro
 
         it 'supports block' do
           klass2 = described_class.new(:a) do
+            KLASS2_CONSTANT = 1
+
             def qq
               "a is #{a}"
             end
@@ -36,6 +38,8 @@ module DefinePoro
 
           expect(klass2.new('1').qq).to eq 'a is 1'
           expect(klass2.class_qq).to eq 'class qq'
+          # !!! constant not bound to klass2 but to outer scope :(
+          expect(KLASS2_CONSTANT).to eq 1
         end
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: define-poro
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - Karolis Astrauka
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-18 00:00:00.000000000 Z
+date: 2015-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -81,10 +81,10 @@ files:
 - README.md
 - Rakefile
 - lib/define-poro.rb
-- lib/define-poro/define.rb
+- lib/define-poro/as.rb
 - lib/define-poro/version.rb
 - poro.gemspec
-- spec/lib/define_spec.rb
+- spec/lib/as_spec.rb
 - spec/spec_helper.rb
 homepage: ''
 licenses:
@@ -111,5 +111,5 @@ signing_key:
 specification_version: 4
 summary: Plain Old Ruby Object class builder from provided attribute list.
 test_files:
-- spec/lib/define_spec.rb
+- spec/lib/as_spec.rb
 - spec/spec_helper.rb