deferring 0.0.6 → 0.0.7

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MGM5OTgyNTJhMTg3OTAzNjA2MWM4ODAwNWQxYTRiZjk1ZTM0ODQ0ZQ==
+    YmQ0ODk2NjQ5MWRkMDI2ZjIzZjEyNzdjNzk1MGIyNmVkOGEwNmNjZQ==
   data.tar.gz: !binary |-
-    YWVmMmQzNmQ2N2EzNDlkYjc2M2EyODNjYzUyZThkMGQ3OTJhODI0Yw==
+    MmZmOThmYzFkNDkzOTMzZGNhZmFhYmFkZmViOTc5ZmJmMzZmNjFmYw==
 SHA512:
   metadata.gz: !binary |-
-    ZTIwY2IyYzczZmIyN2QxYjlhZDU0Mjk5ZDk1ZTI0NmVmMWY0ZjVmMWJjMWIz
-    NjU1NjUzYWJmNDU4M2I2Y2QwZTA2NDUwMWMzM2QxNTZmODc1ZjRhNjdlNDQw
-    ZjliOTMxMGMxNTkyMzIyODk4ODE4NTY5MzFlNWY0MWM4OGU0Njc=
+    OWI3OTAxNjNlNGIzNWZhMGEyMGE5NDM4MzQxODcwMGViZDBmNWNmNDdjZmJl
+    ODY0MzVjNTdhNjU4MjU4ZTQwYzBkNzMwNjU3NWQ2YzA4ZDM2OWU2NThlYTMx
+    NTAwODZjNzYyNGMzNTQ3ZTUxMjlhMzk2NDg5OTIxZjVlMWM3MWE=
   data.tar.gz: !binary |-
-    ODY2MmI3ZDJkZGY3MDg0OWE0NTZkMzNkMDA5MWRkYzY0MTE0OTQyMDAxNzE3
-    NGEyYjQ2ZDA5OTFmMzIwNzM3MDcyMTVlMTFlZGVkZTJjMDE2ODU4YTY2NmEx
-    NTU0M2ZiZjAwZjcwNGRlOWQ0MzY1YWM5ZTkxMTQ4NzViMzgwNWQ=
+    YTEyYzMyNTJiMzBjOTY1ODkwOGE2OWUzZDRkYzNmMGMyYjAyMTE0N2E0Yjg2
+    ZmRjOWNkZjcxZjQxNjQ0Mjc4OGRmMzVjYjYxYjUwYTA5ZmY5OTQzMWQ0Y2Q1
+    NWNjNGU4MDk2ZGQ4MTA5YzQ2ZDM2N2EzNTc0MWZlZDI0Yzg2Mjk=

data/gemfiles/rails_30.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    deferring (0.0.5)
+    deferring (0.1.0)
       activerecord (> 3.0)
 
 GEM

data/gemfiles/rails_32.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    deferring (0.0.5)
+    deferring (0.1.0)
       activerecord (> 3.0)
 
 GEM

data/gemfiles/rails_40.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    deferring (0.0.5)
+    deferring (0.1.0)
       activerecord (> 3.0)
 
 GEM

data/gemfiles/rails_41.gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ../
   specs:
-    deferring (0.0.5)
+    deferring (0.1.0)
       activerecord (> 3.0)
 
 GEM

data/lib/deferring.rb

@@ -32,12 +32,15 @@ module Deferring
   end
 
   def deferred_accepts_nested_attributes_for(*args)
-    accepts_nested_attributes_for(*args)
+    options = args.extract_options!
+    inverse_association_name = options.fetch(:as, self.name.underscore.to_sym)
+    accepts_nested_attributes_for(*args, options)
+
     association_name = args.first.to_s
 
     # teams_attributes=
     define_method :"#{association_name}_attributes=" do |records|
-      find_or_create_deferred_association(association_name, [], nil)
+      find_or_create_deferred_association(association_name, [], inverse_association_name)
 
       # Remove the records that are to be destroyed from the ids that are to be
       # assigned to the DeferredAssociation instance.
@@ -110,7 +113,6 @@ module Deferring
     #  the save after the parent object has been saved
     after_save :"perform_deferred_#{association_name}_save!"
     define_method :"perform_deferred_#{association_name}_save!" do
-
       find_or_create_deferred_association(association_name, listeners, inverse_association_name)
 
       # Send the objects of our delegated association to the original

data/lib/deferring/deferred_association.rb

@@ -80,11 +80,23 @@ module Deferring
     end
 
     def objects=(records)
-      @objects = records
+      @objects = records.map do |record|
+        if inverse_name && record.class.reflect_on_association(inverse_name)
+          record.send(:"#{inverse_name}=", parent_record)
+        end
+        record
+      end
+
       @original_objects = original_association.to_a.clone
       objects_loaded!
 
-      pending_deletes.each { |record| run_deferring_callbacks(:unlink, record) }
+      pending_deletes.each do |record|
+        run_deferring_callbacks(:unlink, record) do
+          if inverse_name && record.class.reflect_on_association(inverse_name)
+            record.send(:"#{inverse_name}=", nil)
+          end
+        end
+      end
       pending_creates.each { |record| run_deferring_callbacks(:link, record) }
 
       @objects
@@ -99,6 +111,10 @@ module Deferring
       # but it will probably be filtered after saving and retrieving as well.
       Array(records).flatten.uniq.each do |record|
         run_deferring_callbacks(:link, record) do
+          if inverse_name && record.class.reflect_on_association(inverse_name)
+            record.send(:"#{inverse_name}=", parent_record)
+          end
+
           objects << record
         end
       end
@@ -111,6 +127,10 @@ module Deferring
     def delete(records)
       Array(records).flatten.uniq.each do |record|
         run_deferring_callbacks(:unlink, record) do
+          if inverse_name && record.class.reflect_on_association(inverse_name)
+            record.send(:"#{inverse_name}=", nil)
+          end
+
           objects.delete(record)
         end
       end

data/lib/deferring/version.rb

@@ -1,5 +1,5 @@
 # encoding: UTF-8
 
 module Deferring
-  VERSION = '0.0.6'
+  VERSION = '0.0.7'
 end

data/spec/lib/deferring_has_many_spec.rb

@@ -11,10 +11,125 @@ RSpec.describe 'deferred has_many associations' do
     Issue.create!(subject: 'Make me a sandwich!')
   end
 
+  let(:bob) { Person.where(name: 'Bob').first }
+
   let(:printer_issue) { Issue.where(subject: 'Printer PRT-001 jammed').first }
   let(:db_issue) { Issue.where(subject: 'Database server DB-1337 down').first }
   let(:sandwich_issue) { Issue.where(subject: 'Make me a sandwich!').first }
 
+  describe 'deferring' do
+    it 'does not create a link until parent is saved' do
+      bob.issues << db_issue << printer_issue
+      expect{ bob.save! }.to change{ Person.find(bob.id).issues.size }.from(0).to(2)
+    end
+
+    it 'does not unlink until parent is saved' do
+      bob.issue_ids = [db_issue.id, printer_issue.id, sandwich_issue.id]
+      bob.save!
+
+      bob.issues.delete([
+        Issue.find(db_issue.id),
+        Issue.find(sandwich_issue.id)
+      ])
+
+      expect{ bob.save }.to change{ Person.find(bob.id).issues.size }.from(3).to(1)
+    end
+
+    xit 'does not create a link when parent is not valid'
+
+    it 'replaces existing records when assigning a new set of records' do
+      bob.issues = [db_issue]
+
+      # A mistake was made, Bob wants to submit a printer and a sandwich issue.
+      bob.issues = [printer_issue, sandwich_issue]
+
+      expect{ bob.save }.to change{ Person.find(bob.id).issues.size }.from(0).to(2)
+    end
+
+    it 'sets the belongs_to association of the associated record' do
+      bob.issues << printer_issue
+      expect(bob.issues.first.person).to eq bob
+    end
+
+    describe '#collection_singular_ids' do
+      it 'returns ids of saved & unsaved associated records' do
+        bob.issues = [printer_issue, db_issue]
+        expect(bob.issue_ids.size).to eq(2)
+        expect(bob.issue_ids).to eq [printer_issue.id, db_issue.id]
+
+        expect{ bob.save }.to change{ Person.find(bob.id).issue_ids.size }.from(0).to(2)
+
+        expect(bob.issue_ids.size).to eq(2)
+        expect(bob.issue_ids).to eq [printer_issue.id, db_issue.id]
+      end # collection_singular_ids
+    end
+
+    describe '#collections_singular_ids=' do
+      it 'sets associated records' do
+        bob.issue_ids = [printer_issue.id, db_issue.id]
+        bob.save
+        expect(bob.issues).to eq [printer_issue, db_issue]
+        expect(bob.issue_ids).to eq [printer_issue.id, db_issue.id]
+
+        bob.reload
+        expect(bob.issues).to eq [printer_issue, db_issue]
+        expect(bob.issue_ids).to eq [printer_issue.id, db_issue.id]
+      end
+
+      it 'replace existing records when assigning a new set of ids of records' do
+        bob.issues = [db_issue]
+
+        bob.issue_ids = [printer_issue.id, sandwich_issue.id]
+        expect(bob.issues.length).to eq(2)
+
+        expect{ bob.save }.to change{ Person.find(bob.id).issues.size }.from(0).to(2)
+      end
+
+      it 'clears empty values from the ids to be assigned' do
+        bob.issue_ids = [db_issue.id, '']
+        expect(bob.issues.length).to eq(1)
+
+        expect{ bob.save }.to change{ Person.where(name: 'Bob').first.issues.size }.from(0).to(1)
+      end
+
+      it 'sets the belongs_to association of the associated record' do
+        expect(printer_issue.person).to be_nil
+        bob.issue_ids = [printer_issue.id]
+        expect(bob.issues.first.person).to eq bob
+      end
+    end # collections_singular_ids=
+  end
+
+  describe 'accepts_nested_attributes' do
+    it 'should mass-assign' do
+      p = Person.first
+      p.issues << printer_issue << db_issue << sandwich_issue
+      p.save
+
+      # Destroy db and sandwich issues. Keep printer issue.
+      p = Person.first
+      p.attributes = {
+        issues_attributes: [
+          { id: printer_issue.id },
+          { id: sandwich_issue.id, _destroy: true },
+          { id: db_issue.id, _destroy: true }
+        ]
+      }
+      expect(p.issues.length).to eq(1)
+      expect(p.issue_ids.sort).to eq([1])
+
+      expect{ p.save! }.to change{ Person.first.issues.size }.from(3).to(1)
+    end
+
+    it 'sets the belongs_to association of the associated record' do
+      expect(printer_issue.person).to be_nil
+      bob.attributes = {
+        issues_attributes: [{ id: printer_issue.id }]
+      }
+      expect(bob.issues.first.person).to eq bob
+    end
+  end # accepts_nested_attributes
+
   describe 'preloading associations' do
     before do
       bob = Person.where(name: 'Bob').first
@@ -55,10 +170,9 @@ RSpec.describe 'deferred has_many associations' do
       people = Person.all
       expect(people[1].issues.loaded?).to be_falsey
     end
-  end
+  end # preloading associations
 
   describe 'active record api' do
-
     describe '#build' do
       it 'builds a new record' do
         bob = Person.where(name: 'Bob').first
@@ -74,6 +188,5 @@ RSpec.describe 'deferred has_many associations' do
         expect(bob.issues.last.person).to eq bob
       end
     end
-  end
-
+  end # active record api
 end

data/spec/support/models.rb

@@ -15,6 +15,7 @@ class Person < ActiveRecord::Base
 
   deferred_has_many :issues, before_remove: :remove_issue,
                              after_remove: :removed_issue
+  deferred_accepts_nested_attributes_for :issues, allow_destroy: true
 
   validates_presence_of :name
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deferring
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
 platform: ruby
 authors:
 - Robin Roestenburg
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-29 00:00:00.000000000 Z
+date: 2014-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord