deep_pluck 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 19d462353caa430573529609f5761ee472a5f19d
-  data.tar.gz: 05d5b136c5018928378669da37fc7eddd8ce3686
+SHA256:
+  metadata.gz: f546a72a6ba6196d025dab3228d9f7bdb96ceed1675c10d4bdb04f9fd7cbd047
+  data.tar.gz: 99b48a384f25ccf25b7996d9cfcfc8594a4dd9bbc41e71976481ede3e4b89e94
 SHA512:
-  metadata.gz: af0a2b2cec4422dc4471c7e8a08057889c042c18d246f923f8d8864a34c8816fb58b02359790aa536acf9c0a2887bf4a14f6fce262ecd17d3850602d661fa611
-  data.tar.gz: 64acd5ce3393d4d7d9d2055266826ab9e06e4888a8f4f84d558b7299f2dc8f8ece40df57491e81c392da1bb05eff219d74ed86ec41ffff7eb2e5db8ab3334910
+  metadata.gz: 326f4d9c3af855a85e48935ddc25e26e59603a3b43fe1c5b5e7e5dcf7450dcbf33dea3208215c19c7da60d91e6b570d66cb266de7a4d84de2434b6412d09e830
+  data.tar.gz: 9239f528f10b466c00ce367da8d8a5eb546264627e179c37a80ad492d00a80cec3f2ae0168955c14a4625ea1d0a798daa9be24d9aab1a613f739c502ce08c28f

data/.travis.yml

@@ -13,6 +13,7 @@ gemfile:
   - gemfiles/4.2.gemfile
   - gemfiles/5.0.gemfile
   - gemfiles/5.1.gemfile
+  - gemfiles/5.2.gemfile
 addons:
     code_climate:
         repo_token: 29e69e7da6b55678f27b7de2444b6161a6c98e3c4b22e0e017ebab87ada18fd5

data/CHANGELOG.md

@@ -0,0 +1,43 @@
+## Change Log
+
+### [upcoming](https://github.com/khiav223577/deep_pluck/compare/v1.1.0...HEAD) 2018/04/05
+- [#22](https://github.com/khiav223577/deep_pluck/pull/22) #deep_pluck at active model without plucking deeply will cause ArgumentError (@khiav223577)
+- [#20](https://github.com/khiav223577/deep_pluck/pull/20) [ENHANCE] Eliminate Extra Select Loop in Hash Lookup (@berniechiu)
+
+### [v1.1.0](https://github.com/khiav223577/deep_pluck/compare/v1.0.3...v1.1.0) 2018/02/15
+- [#19](https://github.com/khiav223577/deep_pluck/pull/19) Support deep_pluck at active model (@khiav223577)
+- [#18](https://github.com/khiav223577/deep_pluck/pull/18) Add rubocop and Improve code quality (@khiav223577)
+
+### [v1.0.3](https://github.com/khiav223577/deep_pluck/compare/v1.0.0...v1.0.3) 2017/06/30
+- [#15](https://github.com/khiav223577/deep_pluck/pull/15) test deep_pluck in rails 5.1.x (@khiav223577)
+- [#14](https://github.com/khiav223577/deep_pluck/pull/14) Handle polymorphic associations correctly. (@Bogadon)
+
+### [v1.0.0](https://github.com/khiav223577/deep_pluck/compare/v0.1.4...v1.0.0) 2017/03/28
+- [#12](https://github.com/khiav223577/deep_pluck/pull/12) reduce cyclomatic complexity in model.rb (@khiav223577)
+
+### [v0.1.4](https://github.com/khiav223577/deep_pluck/compare/v0.1.3...v0.1.4) 2017/03/27
+- [#11](https://github.com/khiav223577/deep_pluck/pull/11) Fix conditional associations (@khiav223577)
+
+### [v0.1.3](https://github.com/khiav223577/deep_pluck/compare/v0.1.2...v0.1.3) 2017/03/20
+- [#10](https://github.com/khiav223577/deep_pluck/pull/10) fix custom foreign_key, custom primary_key issues (@khiav223577)
+- [#9](https://github.com/khiav223577/deep_pluck/pull/9) fix has_and_belongs_to_many (@khiav223577)
+
+### [v0.1.2](https://github.com/khiav223577/deep_pluck/compare/v0.1.1...v0.1.2) 2017/03/17
+- [#8](https://github.com/khiav223577/deep_pluck/pull/8) fix some need columns is missing (@khiav223577)
+- [#7](https://github.com/khiav223577/deep_pluck/pull/7) raise error message when association not found (@khiav223577)
+
+### [v0.1.1](https://github.com/khiav223577/deep_pluck/compare/v0.1.0...v0.1.1) 2017/03/16
+- [#6](https://github.com/khiav223577/deep_pluck/pull/6) fix deep_pluck with #joins (@khiav223577)
+
+### [v0.1.0](https://github.com/khiav223577/deep_pluck/compare/v0.0.4...v0.1.0) 2017/03/15
+- [#5](https://github.com/khiav223577/deep_pluck/pull/5) Support pluck many-to-many associations (@khiav223577)
+
+### [v0.0.4](https://github.com/khiav223577/deep_pluck/compare/v0.0.3...v0.0.4) 2017/03/14
+- [#4](https://github.com/khiav223577/deep_pluck/pull/4) Fix use deep_pluck on NullRelation will raise exception and prevent unneeded query. (@khiav223577)
+
+### [v0.0.3](https://github.com/khiav223577/deep_pluck/compare/v0.0.2...v0.0.3) 2017/03/06
+- [#3](https://github.com/khiav223577/deep_pluck/pull/3) support more than two level (@khiav223577)
+
+### v0.0.2 2017/03/06
+- [#2](https://github.com/khiav223577/deep_pluck/pull/2) The result of has_one association should not be array (@khiav223577)
+- [#1](https://github.com/khiav223577/deep_pluck/pull/1) deep pluck (@khiav223577)

data/README.md

@@ -8,9 +8,7 @@
 
 Allow you to pluck deeply into nested associations without loading a bunch of records.
 
-And DRY up your code when using #as_json.
-
-Works in Rails 3+.
+Support Rails 3.2, 4.2, 5.0, 5.1, 5.2.
 
 
 ## Installation
@@ -32,29 +30,57 @@ Or install it yourself as:
 ## Usage
 
 ### Similar to #pluck method
+
 ```rb
 User.deep_pluck(:id, :name)
 # SELECT `users`.`id`, `users`.`name` FROM `users` 
-# => [{'id' => 1, 'name' => 'David'}, {'id' => 2, 'name' => 'Jeremy'}]
+# => 
+# [
+#   {'id' => 1, 'name' => 'David'}, 
+#   {'id' => 2, 'name' => 'Jeremy'},
+# ]
 ```
 
-### Pluck deep into associations
+### Pluck attributes from nested associations
+
 ```rb
-User.deep_pluck(:name, :posts => :title)
+User.deep_pluck(:name, 'posts' => :title)
 # SELECT `users`.`id`, `users`.`name` FROM `users`
 # SELECT `posts`.`user_id`, `posts`.`title` FROM `posts` WHERE `posts`.`user_id` IN (1, 2)
-# => [
-#  {'name' => 'David' , :posts => [{'title' => 'post1'}, {'title' => 'post2'}]}, 
-#  {'name' => 'Jeremy', :posts => [{'title' => 'post3'}]}
+# => 
+# [
+#  {
+#    'name' => 'David' , 
+#    'posts' => [
+#      {'title' => 'post1'}, 
+#      {'title' => 'post2'},
+#    ],
+#  }, 
+#  {
+#    'name' => 'Jeremy', 
+#    'posts' => [
+#      {'title' => 'post3'},
+#    ],
+#  },
 # ]
 ```
-### Support plucking at active models
+
+### Pluck at models
+
 ```rb
-user = User.find_by(name: 'David').deep_pluck(:name, :posts => :title)
-# => {'name' => 'David' , :posts => [{'title' => 'post1'}, {'title' => 'post2'}]}
+user = User.find_by(name: 'David')
+user.deep_pluck(:name, :posts => :title)
+# =>
+# {
+#   'name' => 'David' , 
+#   :posts => [
+#     {'title' => 'post1'}, 
+#     {'title' => 'post2'},
+#   ],
+# }
 ```
 
-### DRY up Rails/ActiveRecord includes when using as_json
+### Compare with using `#as_json`
 
 Assume the following relations:
 
@@ -85,7 +111,9 @@ User.where(:name => %w(Pearl Kathenrie)).includes([{:posts => :post_comments}, :
 ```
 It works as expected, but is not very DRY, repeat writing `include`, `posts`, `post_comments` so many times.
 
-You could refactor it with #deep_pluck like:
+Not to mention the huge performace improvement by using #deep_pluck.
+
+You could refactor the example with #deep_pluck:
 ```rb
 User.where(:name => %w(Pearl Kathenrie)).deep_pluck(
   :name, 
@@ -97,9 +125,7 @@ User.where(:name => %w(Pearl Kathenrie)).deep_pluck(
 
 ### Better Performance
 
-#deep_pluck return raw hash data without loading a bunch of records.
-
-In that faster than #as_json, or #select.
+#deep_pluck return raw hash data without loading a bunch of records, so that faster than #as_json, or #select.
 
 The following is the benchmark test on 3 users, 6 posts, where `users` table have 14 columns and `posts` have 6 columns. As it shows, `deep_pluck` is 4x faster than `as_json`.
 

data/gemfiles/3.2.gemfile

@@ -2,7 +2,7 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in pluck_all.gemspec
 
-gem "activerecord", "~> 3.2"
+gem "activerecord", "~> 3.2.0"
 gem "pluck_all", "~> 1.2.2"
 
 group :test do

data/gemfiles/4.2.gemfile

@@ -2,7 +2,7 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in pluck_all.gemspec
 
-gem "activerecord", "~> 4.2"
+gem "activerecord", "~> 4.2.0"
 gem "pluck_all", "~> 1.2.2"
 
 group :test do

data/gemfiles/5.0.gemfile

@@ -2,7 +2,7 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in pluck_all.gemspec
 
-gem "activerecord", "~> 5.0"
+gem "activerecord", "~> 5.0.0"
 gem "pluck_all", "~> 1.2.2"
 
 group :test do

data/gemfiles/5.1.gemfile

@@ -2,7 +2,7 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in pluck_all.gemspec
 
-gem "activerecord", "~> 5.1"
+gem "activerecord", "~> 5.1.0"
 gem "pluck_all", "~> 1.2.2"
 
 group :test do

data/gemfiles/5.2.gemfile

@@ -0,0 +1,14 @@
+source 'https://rubygems.org'
+
+# Specify your gem's dependencies in pluck_all.gemspec
+
+gem "activerecord", "~> 5.2.0"
+gem "pluck_all", "~> 1.2.2"
+
+group :test do
+  gem "simplecov"
+  gem "codeclimate-test-reporter", "~> 1.0.0"
+end
+
+gemspec :path => "../"
+

data/lib/deep_pluck.rb

@@ -15,10 +15,10 @@ class ActiveRecord::Base
   end
 
   def deep_pluck(*args)
-    hash_args = args.select{|s| s.is_a?(Hash) }
-    other_args = args.select{|s| !s.is_a?(Hash) }
+    hash_args, other_args = args.partition { |s| s.is_a?(Hash) }
     preloaded_model = DeepPluck::PreloadedModel.new(self, other_args)
     model = DeepPluck::Model.new(self.class.where(id: id), preloaded_model: preloaded_model)
-    return model.add(*hash_args).load_all.first
+    model.add(*hash_args) if hash_args.any?
+    return model.load_all.first
   end
 end

data/lib/deep_pluck/model.rb

@@ -10,7 +10,7 @@ module DeepPluck
       @preloaded_model = preloaded_model
       @parent_association_key = parent_association_key
       @parent_model = parent_model
-      @need_columns = []
+      @need_columns = (preloaded_model ? preloaded_model.need_columns : [])
       @associations = {}
     end
 

data/lib/deep_pluck/preloaded_model.rb

@@ -1,5 +1,7 @@
 module DeepPluck
   class PreloadedModel
+    attr_reader :need_columns
+
     def initialize(active_model, need_columns)
       @active_model = active_model
       @need_columns = need_columns

data/lib/deep_pluck/version.rb

@@ -1,3 +1,3 @@
 module DeepPluck
-  VERSION = "1.1.0"
+  VERSION = "1.1.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: deep_pluck
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - khiav reoy
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-02-15 00:00:00.000000000 Z
+date: 2018-07-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -106,6 +106,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - LICENSE.txt
 - README.md
@@ -117,6 +118,7 @@ files:
 - gemfiles/4.2.gemfile
 - gemfiles/5.0.gemfile
 - gemfiles/5.1.gemfile
+- gemfiles/5.2.gemfile
 - lib/deep_pluck.rb
 - lib/deep_pluck/data_combiner.rb
 - lib/deep_pluck/model.rb
@@ -142,7 +144,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Use deep_pluck as a shortcut to select one or more attributes and include