decisive 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d3805656cea8c630b1d46c799071fb70a59af525
-  data.tar.gz: 5e6dd96156d8c2370a4872015b92ad16ad591981
+  metadata.gz: 4bc57309fcab7adf511b3466ac8c9c095de7f712
+  data.tar.gz: e8801558b0e62a7c554035eb73cbbfd1581238db
 SHA512:
-  metadata.gz: 5a948b1d5efb0ec4fec949624bf37c74826a1c9fa80a31bd28630084d4193561ffd28b6dcab6cbcf8f229da208298f76f9730cc5ed0efc93ce9594d5f6f81a74
-  data.tar.gz: '031396a9a012d1b8bc3b6562d5c9350cc68e37372a943c4dfb7b5c03434835dd5b05686f0ce86c3c119d8d94a43944e0b528c92256fc2813a7204d5891b17abb'
+  metadata.gz: c5dbe6515ca10e2e2563ebe01794241ce94b23de34b10b508eda20110ac50df1ccdb29987edb159ff6601f9eef2807988193f8498869b88926f99ad5554498aa
+  data.tar.gz: 614171337be8cf6a2b74fbfaeb735c8ad9b333a437a4078164a281e8fcb1d3ab3afdfb1b80c56b855ff6c0896a1dad0b22300182931025545f5ce45a5e07c081

data/README.md

@@ -70,6 +70,28 @@ Visiting /users.csv will render a file named "users-2010_01_01.csv" with the fol
 | frodo@example.com | Frodo Baggins  | Yes      |       | 2002-06-19 |
 | sam@example.com   | Samwise Gamgee |          | Frodo | 2008-10-13 |
 
+### Debugging
+
+Errors in your decisive template will often be swallowed while streaming is enabled, resulting in only some of the csv being rendered, without any explanation. You can temporarily switch decisive into non-streaming mode to see these errors:
+
+```ruby
+# decisive template
+
+csv @records, filename: "report.csv", stream: false do
+  ...
+end
+```
+
+```ruby
+# controller
+
+class ReportController < ApplicationController
+  # include ActionController::Live
+
+  ...
+end
+```
+
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake spec` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.

data/lib/decisive/template_handler.rb

@@ -20,9 +20,9 @@ module Decisive
         if controller.respond_to?(:new_controller_thread) # has AC::Live mixed in
           begin
             context.each do |row|
-              response.stream.write row.to_csv
+              response.stream.write row.to_csv(force_quotes: true)
             end
-            raise if ENV["RAILS_ENV"] == "test" # WTF WTF without this the stream isn't closed in test mode??? WTF WTF
+            raise if Rails.env.test? # WTF WTF without this the stream isn't closed in test mode??? WTF WTF
           ensure
             response.stream.close
           end
@@ -91,8 +91,10 @@ module Decisive
   end
 
   class RenderContext < Struct.new(:records, :filename, :block)
-    def to_csv
-      (header + body).map(&:to_csv).join
+    def to_csv(*args, **kwargs)
+      (header + body).map do |row|
+        row.to_csv(*args, **kwargs)
+      end.join
     end
 
     private

data/lib/decisive/version.rb

@@ -1,3 +1,3 @@
 module Decisive
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: decisive
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Micah Geisel