decision_agent 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6c760652b22f7cf3e4524aec1757f1fba1fc21c206c960ad3836eed18279f13
-  data.tar.gz: e0c2f21dfac36d7a4ce7935d6ea38375265c64e15eec4c276c514a1bf759dd6e
+  metadata.gz: 93d5c128215a2a4a834f609111870adafa6f74bebdc05ada319399e5945f13de
+  data.tar.gz: 61133113389fd9da5b52833d4c2d640f3a7b4eb866979da9d4c783d4a2f95468
 SHA512:
-  metadata.gz: d9a402f62fa86a4cf83d727f048b6de8a8d67ab317cbc3dd2d681cd537a2a1a68a1bbe77b2f34a4c6f4a805babace2e7c6d449435d8fef9831dff884152b441a
-  data.tar.gz: 2b00ae31f1e89caa62c004c6e649296e1c6a193faf90ded7ef2fd6e930b3c5547113d028349de2b6904bfb9e2371fd37335251b6391bac4315cda1ca6407c4e8
+  metadata.gz: f9c6fb182e3a729baa5773796121d5e202bc40fc3d9979e137dd7c8c8ab892446067e64489be7431b77196d64cae0df52fa653f90b80f1436ebb70281ec32710
+  data.tar.gz: 7f44db70f5a2f3368eecb91e11fc6879d1d36142d787ba10f2d1be9216acdac46c54db45dd401cc67f6e35faaa643e0a12652235909ed6c4f677f63670049c4a

data/README.md

@@ -118,7 +118,7 @@ See [Code Examples](docs/CODE_EXAMPLES.md) for more comprehensive examples.
 - **Grafana Integration** - Pre-built dashboards and alert rules
 - **Version Control** - Full rule version control, rollback, and history ([Versioning Guide](docs/VERSIONING.md))
 - **Thread-Safe** - Safe for multi-threaded servers and background jobs
-- **High Performance** - 10,000+ decisions/second, ~0.1ms latency
+- **High Performance** - 8,000–9,000+ decisions/second, ~0.1ms latency (hardware-dependent; see [benchmarks](docs/PERFORMANCE_AND_THREAD_SAFETY.md))
 
 ## Web UI - Visual Rule Builder
 
@@ -413,6 +413,7 @@ See [A/B Testing Guide](docs/AB_TESTING.md) for complete documentation.
 ### Reference
 - [API Contract](docs/API_CONTRACT.md) - Full API reference
 - [Changelog](docs/CHANGELOG.md) - Version history
+- [Roadmap](docs/ROADMAP.md) - Shipped, in-progress, and deferred features
 - [Code Coverage Report](coverage.md) - Test coverage statistics
 
 ### More Resources
@@ -423,7 +424,7 @@ See [A/B Testing Guide](docs/AB_TESTING.md) for complete documentation.
 
 DecisionAgent is designed to be **thread-safe and FAST** for use in multi-threaded environments:
 
-- **10,000+ decisions/second** throughput
+- **8,000–9,000+ decisions/second** throughput (hardware-dependent)
 - **~0.1ms average latency** per decision
 - **Zero performance overhead** from thread-safety
 - **Linear scalability** with thread count

data/lib/decision_agent/ab_testing/storage/activerecord_adapter.rb

@@ -79,14 +79,11 @@ module DecisionAgent
             .map { |record| to_assignment(record) }
         end
 
-        # rubocop:disable Naming/PredicateMethod
         def delete_test(test_id)
           record = ::ABTestModel.find(test_id)
           ::ABTestAssignmentModel.where(ab_test_id: test_id).delete_all
           record.destroy
-          true
         end
-        # rubocop:enable Naming/PredicateMethod
 
         private
 

data/lib/decision_agent/dmn/exporter.rb

@@ -13,6 +13,27 @@ module DecisionAgent
         @version_manager = version_manager || Versioning::VersionManager.new
       end
 
+      # Serialize an in-memory DMN Model object to DMN XML.
+      # Unlike #export, this does NOT look up any stored version — it converts
+      # the live model directly.  Use this when saving a new version.
+      # @param model [DecisionAgent::Dmn::Model]
+      # @return [String] DMN XML
+      def serialize_model(model)
+        builder = Nokogiri::XML::Builder.new(encoding: "UTF-8") do |xml|
+          xml.definitions(
+            "xmlns" => "https://www.omg.org/spec/DMN/20191111/MODEL/",
+            "xmlns:dmndi" => "https://www.omg.org/spec/DMN/20191111/DMNDI/",
+            "xmlns:dc" => "http://www.omg.org/spec/DMN/20180521/DC/",
+            "id" => "definitions_#{model.id}",
+            "name" => model.name,
+            "namespace" => model.namespace
+          ) do
+            model.decisions.each { |d| serialize_decision_node(xml, d) }
+          end
+        end
+        builder.to_xml
+      end
+
       # Export ruleset to DMN XML
       # @param rule_id [String] Rule ID to export
       # @param output_path [String, nil] Optional file path to write
@@ -33,12 +54,31 @@ module DecisionAgent
 
       private
 
+      def serialize_decision_node(xml, decision)
+        xml.decision(id: decision.id, name: decision.name) do
+          xml.description(decision.description) if decision.description
+          if (dt = decision.decision_table)
+            xml.decisionTable(id: dt.id, hitPolicy: dt.hit_policy) do
+              dt.inputs.each do |inp|
+                xml.input(id: inp.id, label: inp.label) do
+                  xml.inputExpression(typeRef: inp.type_ref) do
+                    xml.text_ inp.expression
+                  end
+                end
+              end
+              dt.outputs.each do |out|
+                xml.output(id: out.id, label: out.label, name: out.name, typeRef: out.type_ref)
+              end
+            end
+          end
+        end
+      end
+
       # Helper to get hash value with both string and symbol key support
       def hash_get(hash, key)
         hash[key.to_s] || hash[key.to_sym]
       end
 
-      # rubocop:disable Metrics/MethodLength
       def convert_to_dmn(rules_json, rule_id)
         # Handle both string and symbol keys
         ruleset_name = rules_json["ruleset"] || rules_json[:ruleset] || rule_id
@@ -85,7 +125,6 @@ module DecisionAgent
 
         builder.to_xml
       end
-      # rubocop:enable Metrics/MethodLength
 
       def extract_inputs(rules)
         # Extract all unique field names used in conditions

data/lib/decision_agent/dmn/feel/evaluator.rb

@@ -15,7 +15,6 @@ module DecisionAgent
       # Phase 2A: Basic comparisons, ranges, list membership (regex-based)
       # Phase 2B: Arithmetic, logical operators, functions (enhanced parser)
       # Maps FEEL expressions to DecisionAgent ConditionEvaluator
-      # rubocop:disable Metrics/ClassLength
       class Evaluator
         def initialize
           @simple_parser = SimpleParser.new
@@ -493,7 +492,6 @@ module DecisionAgent
         end
 
         # Evaluate Parslet AST node (Phase 2B - full FEEL support)
-        # rubocop:disable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
         def evaluate_ast_node(node, context)
           return node unless node.is_a?(Hash)
 
@@ -549,7 +547,6 @@ module DecisionAgent
             raise FeelEvaluationError, "Unknown AST node type: #{node[:type]}"
           end
         end
-        # rubocop:enable Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength
 
         # Get field value from context
         def get_field_value(field_name, context)
@@ -807,7 +804,6 @@ module DecisionAgent
           start_check && end_check
         end
       end
-      # rubocop:enable Metrics/ClassLength
     end
   end
 end

data/lib/decision_agent/dmn/testing.rb

@@ -43,7 +43,6 @@ module DecisionAgent
       end
 
       # Run a single test scenario
-      # rubocop:disable Metrics/MethodLength
       def run_test(scenario, index = nil)
         decision = @model.find_decision(scenario[:decision_id])
 
@@ -92,11 +91,9 @@ module DecisionAgent
             passed: false
           }
         end
-        # rubocop:enable Metrics/MethodLength
       end
 
       # Generate test coverage report
-      # rubocop:disable Metrics/AbcSize
       def generate_coverage_report
         coverage = {
           total_decisions: @model.decisions.size,
@@ -328,7 +325,6 @@ module DecisionAgent
           model_results: results
         }
       end
-      # rubocop:enable Metrics/AbcSize
     end
   end
 end

data/lib/decision_agent/dmn/validator.rb

@@ -16,10 +16,9 @@ module DecisionAgent
         @feel_evaluator = Feel::Evaluator.new
       end
 
-      # rubocop:disable Naming/PredicateMethod
       def validate(model = nil)
         @model = model if model
-        return false unless @model
+        return unless @model
 
         @errors = []
         @warnings = []
@@ -35,18 +34,15 @@ module DecisionAgent
         # Business rule validation
         validate_decision_tables
 
-        @errors.empty?
+        nil
       end
-      # rubocop:enable Naming/PredicateMethod
 
-      # rubocop:disable Naming/PredicateMethod
       def validate!
         validate
         raise InvalidDmnModelError, format_errors if @errors.any?
 
-        true
+        nil
       end
-      # rubocop:enable Naming/PredicateMethod
 
       def valid?
         @errors.empty?

data/lib/decision_agent/dmn/versioning.rb

@@ -16,12 +16,17 @@ module DecisionAgent
       end
 
       # Save a DMN model as a new version
-      def save_dmn_version(model:, created_by: "system", changelog: nil)
-        # Export DMN model to XML
+      # @param model [Object] The DMN model to save
+      # @param created_by [String] Who is saving this version
+      # @param changelog [String, nil] Human-readable description of what changed
+      # @param tag [String, nil] Optional tag name to apply to the new version at creation time
+      # @return [Hash] The created version
+      def save_dmn_version(model:, created_by: "system", changelog: nil, tag: nil)
+        # Serialize the in-memory DMN model to XML (no DB lookup needed)
         exporter = Exporter.new
-        xml_content = exporter.export(model)
+        xml_content = exporter.serialize_model(model)
 
-        # Save as version
+        # Save as version (with optional tag applied atomically)
         @version_manager.save_version(
           rule_id: model.id,
           rule_content: {
@@ -31,7 +36,8 @@ module DecisionAgent
             namespace: model.namespace
           },
           created_by: created_by,
-          changelog: changelog || "DMN model updated"
+          changelog: changelog || "DMN model updated",
+          tag: tag
         )
       end
 
@@ -136,17 +142,37 @@ module DecisionAgent
         @version_manager.delete_version(version_id: version_id)
       end
 
-      # Tag a DMN version
-      # rubocop:disable Naming/PredicateMethod
-      def tag_dmn_version(version_id:, tag:)
-        _tag = tag # TODO: Implement tag functionality
-        version = @version_manager.get_version(version_id: version_id)
-        return false unless version
-        # rubocop:enable Naming/PredicateMethod
+      # Tag a specific DMN version after the fact.
+      # Creates the tag if it does not exist; re-points it if the name is already in use.
+      # @param model_id [String] The model identifier
+      # @param version_id [String] The version to tag
+      # @param name [String] The tag name (e.g. "release-candidate")
+      # @return [Hash] The tag ({ name:, version_id:, created_at: })
+      def tag_dmn!(model_id:, version_id:, name:)
+        @version_manager.tag!(model_id, version_id, name)
+      end
+
+      # Resolve a tag to its tag hash for the given model.
+      # @param model_id [String] The model identifier
+      # @param name [String] The tag name
+      # @return [Hash, nil] Tag hash or nil if not found
+      def get_dmn_tag(model_id:, name:)
+        @version_manager.get_tag(model_id: model_id, name: name)
+      end
+
+      # List all tags for a DMN model.
+      # @param model_id [String] The model identifier
+      # @return [Array<Hash>] Tag hashes sorted by name
+      def list_dmn_tags(model_id:)
+        @version_manager.list_tags(model_id: model_id)
+      end
 
-        # Add tag to metadata (this would need to be implemented in VersionManager)
-        # For now, we'll use changelog to append the tag
-        true
+      # Delete a tag by name.
+      # @param model_id [String] The model identifier
+      # @param name [String] The tag name
+      # @return [Boolean] True if deleted, false if the tag did not exist
+      def delete_dmn_tag(model_id:, name:)
+        @version_manager.delete_tag(model_id: model_id, name: name)
       end
 
       # Get active DMN version for a model

data/lib/decision_agent/dsl/operators/base.rb

@@ -61,8 +61,8 @@ module DecisionAgent
         end
 
         # Epsilon comparison for floating point numbers
-        def self.epsilon_equal?(a, b, epsilon = 1e-10) # rubocop:disable Naming/MethodParameterName
-          (a - b).abs < epsilon
+        def self.epsilon_equal?(lhs, rhs, epsilon = 1e-10)
+          (lhs - rhs).abs < epsilon
         end
       end
     end

data/lib/decision_agent/dsl/operators/date_time_operators.rb

@@ -5,7 +5,7 @@ module DecisionAgent
     module Operators
       # Handles date/time operators: before_date, after_date, within_days, day_of_week
       module DateTimeOperators
-        def self.handle(op, actual_value, expected_value, date_cache: nil, date_cache_mutex: nil) # rubocop:disable Lint/UnusedMethodArgument
+        def self.handle(op, actual_value, expected_value, _date_cache: nil, _date_cache_mutex: nil)
           case op
           when "before_date"
             # Checks if date is before specified date

data/lib/decision_agent/evaluators/json_rule_evaluator.rb

@@ -13,6 +13,11 @@ module DecisionAgent
         @ruleset_name = @ruleset["ruleset"] || "unknown"
         @name = name || "JsonRuleEvaluator(#{@ruleset_name})"
 
+        # Pre-build O(1) rule lookup map keyed by rule_id
+        @rules_by_id = (@ruleset["rules"] || []).each_with_index.to_h do |rule, i|
+          [rule["id"] || "rule_#{i}", rule]
+        end.freeze
+
         # Freeze ruleset to ensure thread-safety
         deep_freeze(@ruleset)
         @rules_json.freeze
@@ -30,9 +35,8 @@ module DecisionAgent
         matched_rule_trace = explainability_result&.matched_rules&.first
         return nil unless matched_rule_trace
 
-        # Find the original rule to get the then clause
-        rules = @ruleset["rules"] || []
-        matched_rule = rules.find { |r| (r["id"] || "rule_#{rules.index(r)}") == matched_rule_trace.rule_id }
+        # Find the original rule to get the then clause (O(1) lookup)
+        matched_rule = @rules_by_id[matched_rule_trace.rule_id]
         return nil unless matched_rule
 
         then_clause = matched_rule["then"]
@@ -59,37 +63,35 @@ module DecisionAgent
 
       def collect_explainability(context)
         rules = @ruleset["rules"] || []
-        rule_traces = []
 
-        rules.each do |rule|
-          rule_id = rule["id"] || "rule_#{rules.index(rule)}"
-          if_clause = rule["if"]
-          next unless if_clause
+        # Fast pass: find the first matching rule without building trace objects.
+        # This avoids allocating TraceCollector + RuleTrace for every non-matching rule.
+        matched_index = nil
+        rules.each_with_index do |rule, i|
+          next unless rule["if"]
 
-          # Create trace collector for this rule
-          trace_collector = Explainability::TraceCollector.new
-
-          # Evaluate condition with tracing
-          matched = Dsl::ConditionEvaluator.evaluate(
-            if_clause,
-            context,
-            trace_collector: trace_collector
-          )
+          if Dsl::ConditionEvaluator.evaluate(rule["if"], context)
+            matched_index = i
+            break
+          end
+        end
 
+        # Trace pass: re-evaluate only the matched rule with full condition tracing.
+        rule_traces = []
+        if matched_index
+          rule = rules[matched_index]
+          rule_id = rule["id"] || "rule_#{matched_index}"
+          trace_collector = Explainability::TraceCollector.new
+          Dsl::ConditionEvaluator.evaluate(rule["if"], context, trace_collector: trace_collector)
           then_clause = rule["then"] || {}
-          rule_trace = Explainability::RuleTrace.new(
+          rule_traces << Explainability::RuleTrace.new(
             rule_id: rule_id,
-            matched: matched,
+            matched: true,
             condition_traces: trace_collector.traces,
             decision: then_clause["decision"],
             weight: then_clause["weight"],
             reason: then_clause["reason"]
           )
-
-          rule_traces << rule_trace
-
-          # Stop after first match (short-circuit evaluation)
-          break if matched
         end
 
         Explainability::ExplainabilityResult.new(

data/lib/decision_agent/monitoring/storage/memory_adapter.rb

@@ -97,7 +97,7 @@ module DecisionAgent
         def time_series(metric_type, bucket_size: 60, time_range: 3600)
           synchronize do
             cutoff = Time.now - time_range
-            metrics = @metrics[metric_type].select { |m| m[:timestamp] >= cutoff }
+            metrics = (@metrics[metric_type] || []).select { |m| m[:timestamp] >= cutoff }
 
             buckets = Hash.new(0)
             metrics.each do |metric|