decision_agent 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a016bb964d8daeb5676d84ba597f07af9e7b4816a8f075d3ca9feb6f1ddd2f44
-  data.tar.gz: ccc960d23a5c863b8e9be429b08188f32abe630d83e2008a3e70534401779d92
+  metadata.gz: c6c760652b22f7cf3e4524aec1757f1fba1fc21c206c960ad3836eed18279f13
+  data.tar.gz: e0c2f21dfac36d7a4ce7935d6ea38375265c64e15eec4c276c514a1bf759dd6e
 SHA512:
-  metadata.gz: 4f84301ecb298b3fdc3d39b2ca02e850345d2df13eb0c8834555f1b3f08241f243dee54fd044dfd0a37bd2fa32e690dca7583c69049af68d0e951572ca222ad0
-  data.tar.gz: a52598d8c6358ea03ed16a3fd23d68fbea1ef9619f1c4dec613359427a11e9290cd6f4b9f8816fb6673d436b59bdd23b986f816a23ecac185eae1e27b86e6dee
+  metadata.gz: d9a402f62fa86a4cf83d727f048b6de8a8d67ab317cbc3dd2d681cd537a2a1a68a1bbe77b2f34a4c6f4a805babace2e7c6d449435d8fef9831dff884152b441a
+  data.tar.gz: 2b00ae31f1e89caa62c004c6e649296e1c6a193faf90ded7ef2fd6e930b3c5547113d028349de2b6904bfb9e2371fd37335251b6391bac4315cda1ca6407c4e8

data/README.md

@@ -3,7 +3,7 @@
 [![Gem Version](https://badge.fury.io/rb/decision_agent.svg)](https://badge.fury.io/rb/decision_agent)
 [![CI](https://github.com/samaswin/decision_agent/actions/workflows/ci.yml/badge.svg)](https://github.com/samaswin/decision_agent/actions/workflows/ci.yml)
 [![License](https://img.shields.io/badge/license-MIT-blue.svg)](LICENSE.txt)
-[![Ruby](https://img.shields.io/badge/ruby-%3E%3D%202.7.0-red.svg)](https://www.ruby-lang.org)
+[![Ruby](https://img.shields.io/badge/ruby-%3E%3D%203.0.0-red.svg)](https://www.ruby-lang.org)
 
 A production-grade, deterministic, explainable, and auditable decision engine for Ruby.
 
@@ -72,7 +72,6 @@ See [Code Examples](docs/CODE_EXAMPLES.md) for more comprehensive examples.
 - **Conflict Resolution** - Weighted average, consensus, threshold, max weight
 - **Rich Context** - Nested data, dot notation, flexible operators
 - **Advanced Operators** - String, numeric, date/time, collection, and geospatial operators
-- **REST API Data Enrichment** - Fetch external data during decision-making with caching and circuit breaker
 
 ### Auditability & Compliance
 - **Complete Audit Trails** - Every decision fully logged
@@ -105,7 +104,7 @@ See [Code Examples](docs/CODE_EXAMPLES.md) for more comprehensive examples.
 
 ### Developer Experience
 - **Pluggable Architecture** - Custom evaluators, scoring, audit adapters
-- **Framework Agnostic** - Works with Rails, Sinatra, or standalone
+- **Framework Agnostic** - Works with Rails, Rack, or standalone
 - **JSON Rule DSL** - Non-technical users can write rules
 - **DMN 1.3 Support** - Industry-standard Decision Model and Notation with full FEEL expression language
 - **Visual Rule Builder** - Web UI for rule management and DMN modeler
@@ -131,6 +130,8 @@ decision_agent web
 
 Open [http://localhost:4567](http://localhost:4567) in your browser.
 
+The Web UI includes a **DMN visual modeler** at `/dmn/editor` for building and editing decision tables.
+
 ### Integration
 
 **Rails:**
@@ -141,7 +142,7 @@ Rails.application.routes.draw do
 end
 ```
 
-**Rack/Sinatra:**
+**Rack:**
 ```ruby
 require 'decision_agent/web/server'
 map '/decision_agent' do
@@ -149,7 +150,7 @@ map '/decision_agent' do
 end
 ```
 
-See [Web UI Integration Guide](docs/WEB_UI_RAILS_INTEGRATION.md) for detailed setup.
+See [Web UI Integration Guide](docs/WEB_UI_INTEGRATION.md) for detailed setup with Rails, Sinatra, Hanami, and other frameworks.
 
 ## DMN (Decision Model and Notation) Support
 
@@ -185,57 +186,6 @@ result = agent.decide(context: { amount: 50000, credit_score: 750 })
 
 See [DMN Guide](docs/DMN_GUIDE.md) for complete documentation and [DMN Examples](examples/dmn/README.md) for working examples.
 
-## REST API Data Enrichment
-
-DecisionAgent supports fetching external data during decision-making without manual context assembly:
-
-```ruby
-require 'decision_agent'
-
-# Configure data enrichment endpoints
-DecisionAgent.configure_data_enrichment do |config|
-  config.add_endpoint(:credit_bureau,
-    url: "https://api.creditbureau.com/v1/score",
-    method: :post,
-    auth: { type: :api_key, header: "X-API-Key" },
-    cache: { ttl: 3600, adapter: :memory }
-  )
-end
-
-# Use in rules with fetch_from_api operator
-rules = {
-  version: "1.0",
-  ruleset: "loan_approval",
-  rules: [{
-    id: "check_credit",
-    if: {
-      field: "credit_score",
-      op: "fetch_from_api",
-      value: {
-        endpoint: "credit_bureau",
-        params: { ssn: "{{customer.ssn}}" },
-        mapping: { score: "credit_score" }
-      }
-    },
-    then: { decision: "approve", weight: 0.8 }
-  }]
-}
-
-evaluator = DecisionAgent::Evaluators::JsonRuleEvaluator.new(rules_json: rules)
-agent = DecisionAgent::Agent.new(evaluators: [evaluator])
-result = agent.decide(context: { customer: { ssn: "123-45-6789" } })
-```
-
-**Features:**
-- **HTTP Client** - Support for GET, POST, PUT, DELETE methods
-- **Response Caching** - Configurable TTL per endpoint with memory adapter
-- **Circuit Breaker** - Fail-fast after N failures to prevent cascading failures
-- **Authentication** - API key, Basic Auth, and Bearer token support
-- **Template Parameters** - Use `{{path}}` syntax to reference context values
-- **Error Handling** - Graceful degradation with cached data fallback
-
-See [Data Enrichment Guide](docs/DATA_ENRICHMENT.md) for complete documentation and [Data Enrichment Example](examples/data_enrichment_example.rb) for working examples.
-
 ## Monitoring & Analytics
 
 Real-time monitoring, metrics, and alerting for production environments.
@@ -268,31 +218,32 @@ DecisionAgent provides comprehensive simulation capabilities to test rule change
 
 ```ruby
 require 'decision_agent/simulation/replay_engine'
+require 'decision_agent/simulation/what_if_analyzer'
+require 'decision_agent/simulation/impact_analyzer'
 
 # Replay historical decisions with new rules
 replay_engine = DecisionAgent::Simulation::ReplayEngine.new(
   agent: agent,
   version_manager: version_manager
 )
-
 results = replay_engine.replay(historical_data: "decisions.csv")
 
-# What-if analysis
+# What-if analysis (scenarios = array of context hashes)
 whatif = DecisionAgent::Simulation::WhatIfAnalyzer.new(agent: agent)
 analysis = whatif.analyze(
-  base_context: { credit_score: 700, amount: 50000 },
   scenarios: [
-    { credit_score: 750 },
-    { credit_score: 650 }
+    { credit_score: 700, amount: 50000 },
+    { credit_score: 750, amount: 50000 },
+    { credit_score: 650, amount: 50000 }
   ]
 )
 
-# Impact analysis
-impact = DecisionAgent::Simulation::ImpactAnalyzer.new
-comparison = impact.compare(
-  baseline: baseline_evaluator,
-  proposed: proposed_evaluator,
-  contexts: test_contexts
+# Impact analysis (compare two rule versions on test data)
+impact = DecisionAgent::Simulation::ImpactAnalyzer.new(version_manager: version_manager)
+comparison = impact.analyze(
+  baseline_version: baseline_version_id,
+  proposed_version: proposed_version_id,
+  test_data: test_contexts
 )
 ```
 
@@ -348,23 +299,22 @@ Test rules against large datasets with comprehensive analysis:
 
 ```ruby
 require 'decision_agent/testing/batch_test_runner'
+require 'decision_agent/testing/batch_test_importer'
 
-runner = DecisionAgent::Testing::BatchTestRunner.new(agent: agent)
+runner = DecisionAgent::Testing::BatchTestRunner.new(agent)
 
-# Import from CSV or Excel
+# Import from CSV or Excel (context columns default to all except id/expected_*)
 importer = DecisionAgent::Testing::BatchTestImporter.new
-scenarios = importer.import_csv("test_data.csv", {
-  context_fields: ["credit_score", "amount"],
-  expected_fields: ["expected_decision"]
-})
+scenarios = importer.import_csv("test_data.csv")
 
 # Run batch test
-results = runner.run(scenarios: scenarios)
+results = runner.run(scenarios)
 
-puts "Total: #{results[:total]}"
-puts "Passed: #{results[:passed]}"
-puts "Failed: #{results[:failed]}"
-puts "Coverage: #{results[:coverage]}"
+stats = runner.statistics
+puts "Total: #{stats[:total]}"
+puts "Passed: #{stats[:successful]}"
+puts "Failed: #{stats[:failed]}"
+puts "Success rate: #{(stats[:success_rate] * 100).round(2)}%"
 ```
 
 **Features:**
@@ -382,19 +332,23 @@ See [Batch Testing Guide](docs/BATCH_TESTING.md) for complete documentation.
 Compare rule versions with statistical analysis:
 
 ```ruby
-require 'decision_agent/testing/ab_test_manager'
+require 'decision_agent/ab_testing/ab_test_manager'
 
-ab_manager = DecisionAgent::Testing::AbTestManager.new(version_manager: version_manager)
+ab_manager = DecisionAgent::ABTesting::ABTestManager.new(version_manager: version_manager)
 
 test = ab_manager.create_test(
   name: "loan_approval_v2",
-  champion_version: champion_version_id,
-  challenger_version: challenger_version_id,
-  traffic_split: 0.5
+  champion_version_id: champion_version_id,
+  challenger_version_id: challenger_version_id,
+  traffic_split: { champion: 90, challenger: 10 }
 )
 
-results = ab_manager.run_test(test_id: test.id, contexts: test_contexts)
-ab_manager.analyze_results(test_id: test.id)
+# Assign variant per request, then record decisions; when done, get results
+assignment = ab_manager.assign_variant(test_id: test.id, user_id: "user_123")
+# ... run agent with assignment[:version_id], then:
+ab_manager.record_decision(assignment_id: assignment[:assignment_id], decision: "approve", confidence: 0.9)
+
+results = ab_manager.get_results(test.id)
 ```
 
 **Features:**
@@ -430,7 +384,6 @@ See [A/B Testing Guide](docs/AB_TESTING.md) for complete documentation.
 ### Core Features
 - [Explainability Layer](docs/EXPLAINABILITY.md) - Machine-readable decision explanations with condition-level tracing
 - [Advanced Operators](docs/ADVANCED_OPERATORS.md) - String, numeric, date/time, collection, and geospatial operators
-- [Data Enrichment](docs/DATA_ENRICHMENT.md) - REST API data enrichment with caching and circuit breaker
 - [DMN Guide](docs/DMN_GUIDE.md) - Complete DMN 1.3 support guide
 - [DMN API Reference](docs/DMN_API.md) - DMN API documentation
 - [FEEL Reference](docs/FEEL_REFERENCE.md) - FEEL expression language reference
@@ -444,7 +397,7 @@ See [A/B Testing Guide](docs/AB_TESTING.md) for complete documentation.
 - [RBAC Quick Reference](docs/RBAC_QUICK_REFERENCE.md) - Quick reference for RBAC configuration
 - [Web UI](docs/WEB_UI.md) - Visual rule builder
 - [Web UI Setup](docs/WEB_UI_SETUP.md) - Setup guide
-- [Web UI Rails Integration](docs/WEB_UI_RAILS_INTEGRATION.md) - Mount in Rails/Rack apps
+- [Web UI Integration](docs/WEB_UI_INTEGRATION.md) - Mount in Rails, Sinatra, Hanami, and other Rack frameworks
 - [Monitoring & Analytics](docs/MONITORING_AND_ANALYTICS.md) - Real-time monitoring, metrics, and alerting
 - [Monitoring Architecture](docs/MONITORING_ARCHITECTURE.md) - System architecture and design
 - [Persistent Monitoring](docs/PERSISTENT_MONITORING.md) - Database storage for long-term analytics
@@ -454,6 +407,9 @@ See [A/B Testing Guide](docs/AB_TESTING.md) for complete documentation.
 - [Thread-Safety Implementation](docs/THREAD_SAFETY.md) - Technical implementation guide
 - [Benchmarks](benchmarks/README.md) - Comprehensive benchmark suite and performance testing
 
+### Development
+- [Development Setup](docs/DEVELOPMENT_SETUP.md) - Development environment setup, testing, and tools
+
 ### Reference
 - [API Contract](docs/API_CONTRACT.md) - Full API reference
 - [Changelog](docs/CHANGELOG.md) - Version history
@@ -478,7 +434,7 @@ See [Thread-Safety Guide](docs/THREAD_SAFETY.md) and [Performance Analysis](docs
 
 **Run Benchmarks:**
 ```bash
-# Run all benchmarks
+# Run all benchmarks (single Ruby version)
 rake benchmark:all
 
 # Run specific benchmarks
@@ -486,35 +442,34 @@ rake benchmark:basic      # Basic decision performance
 rake benchmark:threads    # Thread-safety and scalability
 rake benchmark:regression # Compare against baseline
 
+# Run benchmarks across all Ruby versions (3.0.7, 3.1.6, 3.2.5, 3.3.5)
+./scripts/benchmark_all_ruby_versions.sh
+
 # See [Benchmarks Guide](benchmarks/README.md) for complete documentation
 ```
 
 ### Latest Benchmark Results
 
-**Last Updated:** 2026-01-06T04:03:29Z
-
-#### Performance Comparison
+Run `rake benchmark:regression` to generate results for your environment. Example (Ruby 3.3, typical hardware):
 
-| Metric | Latest (2026-01-06) | Previous (2026-01-06) | Change |
-|--------|--------------------------------------------------|------------------------------------------------------|--------|
-| Basic Throughput | 8966.04 decisions/sec | 9751.42 decisions/sec | ↓ 8.05% (degraded) |
-| Basic Latency | 0.1115 ms | 0.1025 ms | ↑ 8.78% (degraded) |
-| Multi-threaded (50 threads) Throughput | 8560.69 decisions/sec | 8849.86 decisions/sec | ↓ 3.27% (degraded) |
-| Multi-threaded (50 threads) Latency | 0.1168 ms | 0.113 ms | ↑ 3.36% (degraded) |
+| Metric | Typical range |
+|--------|----------------|
+| Basic throughput | ~9,000+ decisions/sec |
+| Basic latency | ~0.1 ms |
+| Multi-threaded (50 threads) | ~8,500+ decisions/sec |
 
-**Environment:**
-- Ruby Version: 3.3.5
-- Hardware: x86_64
-- OS: Darwin
-- Git Commit: `aba46af5`
-
-> 💡 **Note:** Run `rake benchmark:regression` to generate new benchmark results. This section is automatically updated with the last 2 benchmark runs.
+> 💡 **Note:** See [Benchmarks Guide](benchmarks/README.md) and run `rake benchmark:all` or `rake benchmark:regression` for current numbers.
 ## Contributing
 
 1. Fork the repository
 2. Create a feature branch
-3. Add tests (maintain 90%+ coverage)
-4. Submit a pull request
+3. Set up development environment (see [Development Setup](docs/DEVELOPMENT_SETUP.md))
+4. Add tests (maintain 90%+ coverage)
+5. Run tests across all Ruby versions: `./scripts/test_all_ruby_versions.sh`
+6. Run benchmarks across all Ruby versions: `./scripts/benchmark_all_ruby_versions.sh`
+7. Submit a pull request
+
+See [Development Setup Guide](docs/DEVELOPMENT_SETUP.md) for detailed setup instructions, testing workflows, and development best practices.
 
 ## Support
 

data/lib/decision_agent/ab_testing/ab_test.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require "openssl"
+
 module DecisionAgent
   module ABTesting
     # Represents an A/B test configuration for comparing rule versions
@@ -41,7 +45,7 @@ module DecisionAgent
 
         if user_id
           # Consistent hashing: same user always gets same variant
-          hash_value = Digest::SHA256.hexdigest("#{@id}:#{user_id}").to_i(16)
+          hash_value = OpenSSL::Digest::SHA256.hexdigest("#{@id}:#{user_id}").to_i(16)
           percentage = hash_value % 100
         else
           # Random assignment

data/lib/decision_agent/ab_testing/ab_test_assignment.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module ABTesting
     # Tracks individual assignments of users/requests to A/B test variants

data/lib/decision_agent/ab_testing/ab_test_manager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "monitor"
 
 module DecisionAgent

data/lib/decision_agent/ab_testing/ab_testing_agent.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module ABTesting
     # Agent wrapper that adds A/B testing capabilities to the standard Agent

data/lib/decision_agent/ab_testing/storage/activerecord_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "active_record"
 
 module DecisionAgent
@@ -86,19 +88,6 @@ module DecisionAgent
         end
         # rubocop:enable Naming/PredicateMethod
 
-        # Get statistics from database
-        def get_test_statistics(test_id)
-          assignments = ::ABTestAssignmentModel.where(ab_test_id: test_id)
-
-          {
-            total_assignments: assignments.count,
-            champion_count: assignments.where(variant: "champion").count,
-            challenger_count: assignments.where(variant: "challenger").count,
-            with_decisions: assignments.where.not(decision_result: nil).count,
-            avg_confidence: assignments.where.not(confidence: nil).average(:confidence)&.to_f
-          }
-        end
-
         private
 
         def to_ab_test(record)

data/lib/decision_agent/ab_testing/storage/adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module ABTesting
     module Storage

data/lib/decision_agent/ab_testing/storage/memory_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "monitor"
 
 module DecisionAgent

data/lib/decision_agent/agent.rb

@@ -1,8 +1,12 @@
-require "digest"
+# frozen_string_literal: true
+
 require "json"
 require "json/canonicalization"
+require "openssl"
 
 module DecisionAgent
+  # Agent runs multiple evaluators over a context, scores their evaluations,
+  # and returns a single {Decision} with the chosen outcome and confidence.
   class Agent
     attr_reader :evaluators, :scoring_strategy, :audit_adapter
 
@@ -17,6 +21,10 @@ module DecisionAgent
       attr_reader :hash_cache, :hash_cache_mutex, :hash_cache_max_size
     end
 
+    # @param evaluators [Array<#evaluate>] Objects that respond to #evaluate(context, feedback:)
+    # @param scoring_strategy [Scoring::Base, nil] Strategy to score evaluations (default: WeightedAverage)
+    # @param audit_adapter [Audit::Base, nil] Adapter for recording decisions (default: NullAdapter)
+    # @param validate_evaluations [Boolean, nil] If true, validate evaluations; nil = validate unless production
     def initialize(evaluators:, scoring_strategy: nil, audit_adapter: nil, validate_evaluations: nil)
       @evaluators = Array(evaluators)
       @scoring_strategy = scoring_strategy || Scoring::WeightedAverage.new
@@ -30,6 +38,12 @@ module DecisionAgent
       @evaluators.freeze
     end
 
+    # Runs all evaluators on the context, scores results, and returns a single decision.
+    #
+    # @param context [Context, Hash] Input data; converted to {Context} if a Hash
+    # @param feedback [Hash] Optional feedback passed to each evaluator
+    # @return [Decision] The chosen decision with confidence, explanations, and audit payload
+    # @raise [NoEvaluationsError] when no evaluator returns a valid evaluation
     def decide(context:, feedback: {})
       ctx = context.is_a?(Context) ? context : Context.new(context)
 
@@ -87,7 +101,8 @@ module DecisionAgent
     def collect_evaluations(context, feedback)
       @evaluators.map do |evaluator|
         evaluator.evaluate(context, feedback: feedback)
-      rescue StandardError
+      rescue StandardError => e
+        warn "[DecisionAgent] Evaluator #{evaluator.class} failed: #{e.message}"
         nil
       end.compact
     end
@@ -100,20 +115,20 @@ module DecisionAgent
       explanations << "Decision: #{final_decision} (confidence: #{confidence.round(2)})"
 
       if matching_evals.size == 1
-        eval = matching_evals.first
-        explanations << "#{eval.evaluator_name}: #{eval.reason} (weight: #{eval.weight})"
+        evaluation = matching_evals.first
+        explanations << "#{evaluation.evaluator_name}: #{evaluation.reason} (weight: #{evaluation.weight})"
       elsif matching_evals.size > 1
         explanations << "Based on #{matching_evals.size} evaluators:"
-        matching_evals.each do |eval|
-          explanations << "  - #{eval.evaluator_name}: #{eval.reason} (weight: #{eval.weight})"
+        matching_evals.each do |evaluation|
+          explanations << "  - #{evaluation.evaluator_name}: #{evaluation.reason} (weight: #{evaluation.weight})"
         end
       end
 
       conflicting_evals = evaluations.reject { |e| e.decision == final_decision }
       if conflicting_evals.any?
         explanations << "Conflicting evaluations resolved by #{@scoring_strategy.class.name.split('::').last}:"
-        conflicting_evals.each do |eval|
-          explanations << "  - #{eval.evaluator_name}: suggested '#{eval.decision}' (weight: #{eval.weight})"
+        conflicting_evals.each do |evaluation|
+          explanations << "  - #{evaluation.evaluator_name}: suggested '#{evaluation.decision}' (weight: #{evaluation.weight})"
         end
       end
 
@@ -142,66 +157,49 @@ module DecisionAgent
       hashable = payload.slice(:context, :evaluations, :decision, :confidence, :scoring_strategy)
 
       # Use fast hash (MD5) as cache key to avoid expensive canonicalization on cache hits
-      # Optimized: Use direct JSON.to_json instead of recursive sorting for speed
       # The cache key doesn't need perfect determinism, just good enough to catch duplicates
-      # This avoids the expensive sort_hash_keys recursion on every call
+      # Use OpenSSL::Digest to avoid "Digest::Base cannot be directly inherited" on some Ruby/digest setups
       json_str = hashable.to_json
-      fast_key = Digest::MD5.hexdigest(json_str)
+      fast_key = OpenSSL::Digest::MD5.hexdigest(json_str)
 
       # Fast path: check cache without lock first (unsafe read, but acceptable for cache)
-      # This allows concurrent reads without mutex overhead
-      cache = self.class.hash_cache
-      cached_hash = cache[fast_key]
+      cached_hash = lookup_cached_hash(fast_key)
       return cached_hash if cached_hash
 
-      # Cache miss - compute canonical JSON (required for deterministic hashing)
-      # This is expensive, but only happens on cache misses
-      canonical = canonical_json(hashable)
-
-      # Compute SHA256 hash (also expensive, but only on cache misses)
-      computed_hash = Digest::SHA256.hexdigest(canonical)
+      # Cache miss - compute canonical JSON and hash
+      computed_hash = compute_canonical_hash(hashable)
 
       # Store in cache (thread-safe, with size limit)
-      # Only lock when we need to write
+      cache_hash(fast_key, computed_hash)
+
+      computed_hash
+    end
+
+    def lookup_cached_hash(fast_key)
+      self.class.hash_cache[fast_key]
+    end
+
+    def compute_canonical_hash(hashable)
+      canonical = canonical_json(hashable)
+      OpenSSL::Digest::SHA256.hexdigest(canonical)
+    end
+
+    def cache_hash(fast_key, computed_hash)
       self.class.hash_cache_mutex.synchronize do
         # Double-check after acquiring lock (another thread may have added it)
         return self.class.hash_cache[fast_key] if self.class.hash_cache[fast_key]
 
-        # Clear cache if it gets too large (simple FIFO eviction)
-        if self.class.hash_cache.size >= self.class.hash_cache_max_size
-          # Remove oldest 10% of entries (simple approximation)
-          keys_to_remove = self.class.hash_cache.keys.first(self.class.hash_cache_max_size / 10)
-          keys_to_remove.each { |key| self.class.hash_cache.delete(key) }
-        end
+        evict_cache_if_needed
         self.class.hash_cache[fast_key] = computed_hash
       end
-
-      computed_hash
     end
 
-    # Fast hash key generation using MD5 (much faster than canonical JSON + SHA256)
-    # Used as cache key to avoid expensive canonicalization on cache hits
-    # MD5 is sufficient for cache keys (collision resistance not critical, speed is)
-    def fast_hash_key(hashable)
-      # Create a deterministic string representation for hashing
-      # Use sorted JSON to ensure determinism (though not RFC 8785 canonical)
-      json_str = sort_hash_keys(hashable).to_json
-      Digest::MD5.hexdigest(json_str)
-    end
+    def evict_cache_if_needed
+      return unless self.class.hash_cache.size >= self.class.hash_cache_max_size
 
-    # Recursively sort hash keys for deterministic hashing
-    # This is faster than canonical JSON but still deterministic
-    # Note: This is still used by canonical_json indirectly, but fast_hash_key avoids it
-    def sort_hash_keys(obj)
-      case obj
-      when Hash
-        sorted = obj.sort.to_h
-        sorted.transform_values { |v| sort_hash_keys(v) }
-      when Array
-        obj.map { |v| sort_hash_keys(v) }
-      else
-        obj
-      end
+      # Remove oldest 10% of entries (simple FIFO eviction)
+      keys_to_remove = self.class.hash_cache.keys.first(self.class.hash_cache_max_size / 10)
+      keys_to_remove.each { |key| self.class.hash_cache.delete(key) }
     end
 
     # Uses RFC 8785 (JSON Canonicalization Scheme) for deterministic JSON serialization

data/lib/decision_agent/audit/adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Audit
     class Adapter

data/lib/decision_agent/audit/logger_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "logger"
 require "json"
 

data/lib/decision_agent/audit/null_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Audit
     class NullAdapter < Adapter

data/lib/decision_agent/auth/access_audit_logger.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "json"
 require_relative "../audit/adapter"
 

data/lib/decision_agent/auth/authenticator.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Auth
     class Authenticator

data/lib/decision_agent/auth/password_reset_manager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Auth
     class PasswordResetManager

data/lib/decision_agent/auth/password_reset_token.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "securerandom"
 
 module DecisionAgent

data/lib/decision_agent/auth/permission.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Auth
     class Permission

data/lib/decision_agent/auth/permission_checker.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Auth
     class PermissionChecker

data/lib/decision_agent/auth/rbac_adapter.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Auth
     # Base adapter interface for RBAC integration

data/lib/decision_agent/auth/rbac_config.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Auth
     # Configuration class for RBAC adapter

data/lib/decision_agent/auth/role.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Auth
     class Role

data/lib/decision_agent/auth/session.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "securerandom"
 
 module DecisionAgent

data/lib/decision_agent/auth/session_manager.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module DecisionAgent
   module Auth
     class SessionManager