decidim-decidim_awesome 0.11.4 → 0.12.3

data/lib/decidim/decidim_awesome/engine.rb

@@ -5,6 +5,8 @@ require "deface"
 require "decidim/core"
 require "decidim/decidim_awesome/awesome_helpers"
 require "decidim/decidim_awesome/menu"
+require "decidim/decidim_awesome/middleware/current_config"
+require "active_hashcash" if Decidim::DecidimAwesome.enabled?(:hashcash_signup, :hashcash_login)
 
 module Decidim
   module DecidimAwesome
@@ -17,12 +19,18 @@ module Decidim
       routes do
         get :required_authorizations, to: "required_authorizations#index"
         post :editor_images, to: "editor_images#create"
+        get "form_builder_i18n(/:lang)", to: "utils#form_builder_i18n", as: :form_builder_i18n
       end
 
       # Prepare a zone to create overrides
       # https://edgeguides.rubyonrails.org/engines.html#overriding-models-and-controllers
       # overrides
       config.to_prepare do
+        if DecidimAwesome.enabled?(:hashcash_signup, :hashcash_login)
+          # Add hashcash to signup and login
+          Decidim::Devise::SessionsController.include(Decidim::DecidimAwesome::NeedsHashcash)
+          Decidim::Devise::RegistrationsController.include(Decidim::DecidimAwesome::NeedsHashcash)
+        end
         # Include additional helpers globally
         ActiveSupport.on_load(:action_view) { include Decidim::DecidimAwesome::AwesomeHelpers }
         # Also for cells
@@ -47,11 +55,11 @@ module Decidim
                                    :validate_body_max_caps_percent,
                                    :validate_body_max_marks_together,
                                    :validate_body_start_with_caps)
-          Decidim::Proposals::ProposalWizardCreateStepForm.include(Decidim::DecidimAwesome::Proposals::ProposalWizardCreateStepFormOverride)
+          Decidim::Proposals::ProposalForm.include(Decidim::DecidimAwesome::Proposals::ProposalFormCustomizations)
         end
 
         if DecidimAwesome.enabled?(:proposal_custom_fields, :proposal_private_custom_fields)
-          Decidim::Proposals::ProposalWizardCreateStepForm.include(Decidim::DecidimAwesome::Proposals::ProposalFormOverride)
+          Decidim::Proposals::ProposalForm.include(Decidim::DecidimAwesome::Proposals::ProposalFormOverride)
           Decidim::Proposals::Admin::ProposalForm.include(Decidim::DecidimAwesome::Proposals::ProposalFormOverride)
           Decidim::Proposals::ProposalPresenter.include(Decidim::DecidimAwesome::Proposals::ProposalPresenterOverride)
           Decidim::Proposals::CreateProposal.include(Decidim::DecidimAwesome::Proposals::CreateProposalOverride)
@@ -67,7 +75,7 @@ module Decidim
           Decidim::System::RegisterOrganizationForm.include(Decidim::DecidimAwesome::System::OrganizationFormOverride)
           Decidim::System::UpdateOrganizationForm.include(Decidim::DecidimAwesome::System::OrganizationFormOverride)
           Decidim::System::UpdateOrganization.include(Decidim::DecidimAwesome::System::UpdateOrganizationOverride)
-          Decidim::System::RegisterOrganization.include(Decidim::DecidimAwesome::System::RegisterOrganizationOverride)
+          Decidim::System::CreateOrganization.include(Decidim::DecidimAwesome::System::CreateOrganizationOverride)
         end
 
         if DecidimAwesome.enabled?(:proposal_custom_fields, :proposal_private_custom_fields, :weighted_proposal_voting)
@@ -91,8 +99,8 @@ module Decidim
         # override user's admin property
         Decidim::User.include(Decidim::DecidimAwesome::UserOverride) if DecidimAwesome.enabled?(:scoped_admins)
 
-        if DecidimAwesome.enabled?(:menu, :content_block_main_menu)
-          Decidim::ContentBlocks::GlobalMenuCell.include(Decidim::DecidimAwesome::GlobalMenuCellOverride)
+        if DecidimAwesome.enabled?(:menu, :mobile_menu, :home_content_block_menu)
+          Decidim::ContentBlocks::GlobalMenuCell.include(Decidim::DecidimAwesome::GlobalMenuCellOverride) if DecidimAwesome.enabled?(:home_content_block_menu)
           Decidim::BreadcrumbHelper.include(Decidim::DecidimAwesome::BreadcrumbHelperOverride)
           Decidim::MenuPresenter.include(Decidim::DecidimAwesome::MenuPresenterOverride)
           Decidim::MenuItemPresenter.include(Decidim::DecidimAwesome::MenuItemPresenterOverride)
@@ -229,7 +237,7 @@ module Decidim
             component.settings(:global) do |settings|
               DecidimAwesome.hash_append!(
                 settings.attributes,
-                :can_accumulate_supports_beyond_threshold,
+                :can_accumulate_votes_beyond_threshold,
                 :awesome_voting_manifest,
                 Decidim::SettingsManifest::Attribute.new(
                   type: :select,
@@ -290,6 +298,8 @@ module Decidim
         Decidim.icons.register(name: "spy", icon: "spy-fill", category: "system", description: "", engine: :decidim_awesome)
         Decidim.icons.register(name: "forbid-line", icon: "forbid-line", category: "system", description: "", engine: :decidim_awesome)
         Decidim.icons.register(name: "file-settings-line", icon: "file-settings-line", category: "system", description: "", engine: :decidim_awesome)
+        Decidim.icons.register(name: "hashtag", icon: "hashtag", category: "system", description: "", engine: :decidim_awesome)
+        Decidim.icons.register(name: "smartphone", icon: "smartphone-line", category: "system", description: "", engine: :decidim_awesome)
       end
     end
   end

data/lib/decidim/decidim_awesome/menu.rb

@@ -4,162 +4,166 @@ module Decidim
   module DecidimAwesome
     class Menu
       class << self
-        def register_awesome_admin_menu!
-          Decidim.menu :awesome_admin_menu do |menu|
-            menu.add_item :editors,
-                          I18n.t("menu.editors", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.config_path(:editors),
-                          position: 1,
-                          icon_name: "editors-text",
-                          if: menus[:editors]
-
-            menu.add_item :proposals,
-                          I18n.t("menu.proposals", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.config_path(:proposals),
-                          position: 2,
-                          icon_name: "documents",
-                          if: menus[:proposals]
-
-            menu.add_item :surveys,
-                          I18n.t("menu.surveys", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.config_path(:surveys),
-                          position: 3,
-                          icon_name: "surveys",
-                          if: menus[:surveys]
-
-            menu.add_item :styles,
-                          I18n.t("menu.styles", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.config_path(:scoped_styles),
-                          position: 4,
-                          icon_name: "brush",
-                          if: menus[:styles],
-                          submenu: { target_menu: :custom_styles_submenu }
-
-            menu.add_item :custom_fields,
-                          I18n.t("menu.proposal_custom_fields", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.config_path(menus[:proposal_custom_fields] ? :proposal_custom_fields : :proposal_private_custom_fields),
-                          position: 5,
-                          icon_name: "layers",
-                          active: is_active_link?(decidim_admin_decidim_awesome.config_path(:proposal_custom_fields)) ||
-                                  is_active_link?(decidim_admin_decidim_awesome.config_path(:proposal_private_custom_fields)),
-                          if: menus[:custom_fields],
-                          submenu: { target_menu: :custom_fields_submenu }
-
-            menu.add_item :admins,
-                          I18n.t("menu.admins", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.config_path(:admins),
-                          position: 6,
-                          icon_name: "group-line",
-                          if: menus[:admins]
-
-            menu.add_item :menu_hacks,
-                          I18n.t("menu.menu_hacks", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.menu_hacks_path(menus[:menu_hacks_menu] ? :menu : :home_content_block_menu),
-                          position: 7,
-                          icon_name: "menu-line",
-                          if: menus[:menu_hacks],
-                          active: is_active_link?(decidim_admin_decidim_awesome.menu_hacks_path(:menu)) ||
-                                  is_active_link?(decidim_admin_decidim_awesome.menu_hacks_path(:home_content_block_menu)),
-                          submenu: { target_menu: :menu_hacks_submenu }
-
-            menu.add_item :custom_redirects,
-                          I18n.t("menu.custom_redirects", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.custom_redirects_path,
-                          position: 8,
-                          icon_name: "external-link-line",
-                          if: menus[:custom_redirects]
-
-            menu.add_item :livechat,
-                          I18n.t("menu.livechat", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.config_path(:livechat),
-                          position: 9,
-                          icon_name: "chat-1-line",
-                          if: menus[:livechat]
-
-            menu.add_item :verifications,
-                          I18n.t("menu.verifications", scope: "decidim.decidim_awesome.admin"),
-                          decidim_admin_decidim_awesome.config_path(:verifications),
-                          position: 10,
-                          icon_name: "fingerprint-line",
-                          if: menus[:verifications]
-
-            menu.add_item :maintenance,
-                          I18n.t("maintenance", scope: "decidim.decidim_awesome.admin.menu.maintenance"),
-                          decidim_admin_decidim_awesome.maintenance_path(:private_data),
-                          position: 11,
-                          icon_name: "tools-line",
-                          active: is_active_link?(decidim_admin_decidim_awesome.maintenance_path(:private_data)) ||
-                                  is_active_link?(decidim_admin_decidim_awesome.checks_maintenance_index_path),
-                          submenu: { target_menu: :maintenance_submenu }
+        def register_simple_entry(menu_registry, name, position, icon, options = {})
+          return if menus[name].blank?
+
+          Decidim.menu menu_registry do |menu|
+            i18n_key = options[:i18n_key].presence || "menu.#{name}"
+            extra = {}.tap do |hash|
+              hash[:submenu] = options[:submenu] if options[:submenu].present?
+              if options[:active].present?
+                hash[:active] = false
+                options[:active].each do |active_path|
+                  hash[:active] ||= is_active_link?(decidim_admin_decidim_awesome.send(active_path[0], *active_path[1..]))
+                end
+              end
+            end
+            path = main_path_for(name)
+            menu.add_item name,
+                          I18n.t(i18n_key, scope: "decidim.decidim_awesome.admin"),
+                          decidim_admin_decidim_awesome.send(path[0], path[1]),
+                          position:,
+                          icon_name: icon,
+                          **extra
           end
         end
 
+        def main_path_for(config_var)
+          case config_var.to_sym
+          when :styles
+            [:config_path, [menus[:styles]]]
+          when :custom_fields
+            [:config_path, [menus[:custom_fields]]]
+          when :menu_hacks
+            [:menu_hacks_path, [menus[:menu_hacks]]]
+          when :custom_redirects
+            [:custom_redirects_path, []]
+          when :maintenance
+            [:checks_path, []]
+          else
+            [:config_path, [config_var]]
+          end
+        end
+
+        def register_awesome_admin_menu!
+          register_simple_entry(:awesome_admin_menu, :editors, 1, "editors-text")
+          register_simple_entry(:awesome_admin_menu, :proposals, 2, "documents")
+          register_simple_entry(:awesome_admin_menu, :surveys, 3, "surveys")
+          register_simple_entry(:awesome_admin_menu, :styles, 4, "brush",
+                                submenu: { target_menu: :custom_styles_submenu },
+                                active: [[:config_path, :scoped_styles], [:config_path, :scoped_admin_styles]])
+
+          register_simple_entry(:awesome_admin_menu, :custom_fields, 5, "layers",
+                                i18n_key: "menu.proposal_custom_fields",
+                                submenu: { target_menu: :custom_fields_submenu },
+                                active: [[:config_path, :proposal_custom_fields], [:config_path, :proposal_private_custom_fields]])
+
+          register_simple_entry(:awesome_admin_menu, :admins, 6, "group-line")
+
+          register_simple_entry(:awesome_admin_menu, :menu_hacks, 7, "menu-line",
+                                submenu: { target_menu: :menu_hacks_submenu },
+                                active: [[:menu_hacks_path, :menu], [:menu_hacks_path, :mobile_menu], [:menu_hacks_path, :home_content_block_menu]])
+
+          register_simple_entry(:awesome_admin_menu, :custom_redirects, 8, "external-link-line")
+          register_simple_entry(:awesome_admin_menu, :livechat, 9, "chat-1-line")
+          register_simple_entry(:awesome_admin_menu, :verifications, 10, "fingerprint-line")
+
+          register_simple_entry(:awesome_admin_menu, :maintenance, 11, "tools-line",
+                                i18n_key: "menu.maintenance.maintenance",
+                                submenu: { target_menu: :maintenance_submenu },
+                                active: [[:private_data_path], [:hashcashes_path], [:checks_path]])
+        end
+
         def register_custom_fields_submenu!
           Decidim.menu :custom_fields_submenu do |menu|
-            menu.add_item :proposal_custom_fields,
-                          I18n.t("menu.title", scope: "decidim.decidim_awesome.admin.proposal_custom_fields"),
-                          decidim_admin_decidim_awesome.config_path(:proposal_custom_fields),
-                          position: 5.1,
-                          icon_name: "draft-line",
-                          if: menus[:proposal_custom_fields]
-
-            menu.add_item :proposal_private_custom_fields,
-                          I18n.t("proposal_private_custom_fields", scope: "decidim.decidim_awesome.admin.proposal_custom_fields"),
-                          decidim_admin_decidim_awesome.config_path(:proposal_private_custom_fields),
-                          position: 5.2,
-                          icon_name: "spy",
-                          if: menus[:proposal_private_custom_fields]
+            if menus[:proposal_custom_fields].present?
+              menu.add_item :proposal_custom_fields,
+                            I18n.t("menu.title", scope: "decidim.decidim_awesome.admin.proposal_custom_fields"),
+                            decidim_admin_decidim_awesome.config_path(:proposal_custom_fields),
+                            position: 5.1,
+                            icon_name: "draft-line"
+            end
+
+            if menus[:proposal_private_custom_fields].present?
+              menu.add_item :proposal_private_custom_fields,
+                            I18n.t("proposal_private_custom_fields", scope: "decidim.decidim_awesome.admin.proposal_custom_fields"),
+                            decidim_admin_decidim_awesome.config_path(:proposal_private_custom_fields),
+                            position: 5.2,
+                            icon_name: "spy"
+            end
           end
         end
 
         def register_custom_styles_submenu!
           Decidim.menu :custom_styles_submenu do |menu|
-            menu.add_item :scoped_styles,
-                          I18n.t("menu.title", scope: "decidim.decidim_awesome.admin.scoped_styles"),
-                          decidim_admin_decidim_awesome.config_path(:scoped_styles),
-                          position: 4.1,
-                          icon_name: "computer-line",
-                          if: config_enabled?(:scoped_styles)
-
-            menu.add_item :scoped_admin_styles,
-                          I18n.t("menu.title", scope: "decidim.decidim_awesome.admin.scoped_admin_styles"),
-                          decidim_admin_decidim_awesome.config_path(:scoped_admin_styles),
-                          position: 4.2,
-                          icon_name: "file-settings-line",
-                          if: config_enabled?(:scoped_admin_styles)
+            if menus[:scoped_styles].present?
+              menu.add_item :scoped_styles,
+                            I18n.t("menu.title", scope: "decidim.decidim_awesome.admin.scoped_styles"),
+                            decidim_admin_decidim_awesome.config_path(:scoped_styles),
+                            position: 4.1,
+                            icon_name: "computer-line"
+            end
+
+            if menus[:scoped_admin_styles].present?
+              menu.add_item :scoped_admin_styles,
+                            I18n.t("menu.title", scope: "decidim.decidim_awesome.admin.scoped_admin_styles"),
+                            decidim_admin_decidim_awesome.config_path(:scoped_admin_styles),
+                            position: 4.2,
+                            icon_name: "file-settings-line"
+            end
           end
         end
 
         def register_menu_hacks_submenu!
           Decidim.menu :menu_hacks_submenu do |menu|
-            menu.add_item :main_menu,
-                          I18n.t("menu.title", scope: "decidim.decidim_awesome.admin.menu_hacks.index"),
-                          decidim_admin_decidim_awesome.menu_hacks_path(:menu),
-                          position: 7.1,
-                          icon_name: "global-line",
-                          if: menus[:menu_hacks_menu]
-
-            menu.add_item :content_block_main_menu,
-                          I18n.t("home_content_block_menu.title", scope: "decidim.decidim_awesome.admin.menu_hacks.index"),
-                          decidim_admin_decidim_awesome.menu_hacks_path(:home_content_block_menu),
-                          position: 7.2,
-                          icon_name: "layout-masonry-line",
-                          if: menus[:menu_hacks_home_content_block_menu]
+            if menus[:menu_hacks_menu].present?
+              menu.add_item :main_menu,
+                            I18n.t("menu.title", scope: "decidim.decidim_awesome.admin.menu_hacks.index"),
+                            decidim_admin_decidim_awesome.menu_hacks_path(:menu),
+                            position: 7.1,
+                            icon_name: "global-line"
+            end
+
+            if menus[:menu_hacks_mobile_menu].present?
+              menu.add_item :mobile_menu,
+                            I18n.t("mobile_menu.title", scope: "decidim.decidim_awesome.admin.menu_hacks.index"),
+                            decidim_admin_decidim_awesome.menu_hacks_path(:mobile_menu),
+                            position: 7.2,
+                            icon_name: "smartphone"
+            end
+
+            if menus[:menu_hacks_home_content_block_menu].present?
+              menu.add_item :content_block_main_menu,
+                            I18n.t("home_content_block_menu.title", scope: "decidim.decidim_awesome.admin.menu_hacks.index"),
+                            decidim_admin_decidim_awesome.menu_hacks_path(:home_content_block_menu),
+                            position: 7.3,
+                            icon_name: "layout-masonry-line"
+            end
           end
         end
 
         def register_maintenance_admin_menu!
           Decidim.menu :maintenance_submenu do |menu|
-            menu.add_item :private_data,
-                          I18n.t("private_data", scope: "decidim.decidim_awesome.admin.menu.maintenance"),
-                          decidim_admin_decidim_awesome.maintenance_path(:private_data),
-                          position: 10,
-                          icon_name: "spy-line"
+            if config_enabled?(:proposal_private_custom_fields)
+              menu.add_item :private_data,
+                            I18n.t("private_data", scope: "decidim.decidim_awesome.admin.menu.maintenance"),
+                            decidim_admin_decidim_awesome.private_data_path,
+                            position: 10.1,
+                            icon_name: "spy-line"
+            end
+
+            if config_enabled?(:hashcash_signup, :hashcash_login)
+              menu.add_item :hashcash,
+                            I18n.t("hashcash", scope: "decidim.decidim_awesome.admin.menu.maintenance"),
+                            decidim_admin_decidim_awesome.hashcashes_path,
+                            position: 10.2,
+                            icon_name: "hashtag"
+            end
 
             menu.add_item :checks,
                           I18n.t("checks", scope: "decidim.decidim_awesome.admin.menu.maintenance"),
-                          decidim_admin_decidim_awesome.checks_maintenance_index_path,
-                          position: 10,
+                          decidim_admin_decidim_awesome.checks_path,
+                          position: 10.3,
                           icon_name: "pulse"
           end
         end
@@ -174,23 +178,32 @@ module Decidim
               :validate_body_min_length, :validate_body_max_caps_percent,
               :validate_body_max_marks_together, :validate_body_start_with_caps
             ),
-            surveys: config_enabled?(:auto_save_forms, :user_timezone),
-            styles: config_enabled?(:scoped_styles, :scoped_admin_styles),
+            surveys: config_enabled?(:auto_save_forms, :user_timezone, :hashcash_signup, :hashcash_login),
+            styles: first_enabled(:scoped_styles, :scoped_admin_styles),
             scoped_styles: config_enabled?(:scoped_styles),
             scoped_admin_styles: config_enabled?(:scoped_admin_styles),
-            custom_fields: config_enabled?(:proposal_custom_fields, :proposal_private_custom_fields),
+            custom_fields: first_enabled(:proposal_custom_fields, :proposal_private_custom_fields),
             proposal_custom_fields: config_enabled?(:proposal_custom_fields),
             proposal_private_custom_fields: config_enabled?(:proposal_private_custom_fields),
             admins: config_enabled?(:scoped_admins),
-            menu_hacks: config_enabled?(:menu, :home_content_block_menu),
+            menu_hacks: first_enabled(:menu, :mobile_menu, :home_content_block_menu),
             menu_hacks_menu: config_enabled?(:menu),
+            menu_hacks_mobile_menu: config_enabled?(:mobile_menu),
             menu_hacks_home_content_block_menu: config_enabled?(:home_content_block_menu),
             custom_redirects: config_enabled?(:custom_redirects),
             livechat: config_enabled?(:intergram_for_admins, :intergram_for_public),
-            verifications: config_enabled?(:force_authorization_after_login)
+            verifications: config_enabled?(:force_authorization_after_login),
+            maintenance: true
           }
         end
 
+        def first_enabled(*vars)
+          vars.each do |var|
+            return var if config_enabled?(var)
+          end
+          nil
+        end
+
         # ensure boolean value
         def config_enabled?(*vars)
           DecidimAwesome.enabled?(*vars)

data/lib/decidim/decidim_awesome/test/initializer.rb

@@ -17,6 +17,7 @@ Decidim::DecidimAwesome.configure do |config|
       :proposal_custom_fields,
       :proposal_private_custom_fields,
       :menu,
+      :mobile_menu,
       :home_content_block_menu,
       :scoped_admins,
       :custom_redirects,
@@ -31,7 +32,9 @@ Decidim::DecidimAwesome.configure do |config|
       :weighted_proposal_voting,
       :additional_proposal_sortings,
       :allow_limiting_amendments,
-      :proposal_private_custom_fields
+      :proposal_private_custom_fields,
+      :hashcash_signup,
+      :hashcash_login
     ].each do |conf|
       config.send("#{conf}=", :disabled)
     end

data/lib/decidim/decidim_awesome/test/shared_examples/box_label_editor_examples.rb

@@ -5,16 +5,16 @@ shared_examples "edits box label inline" do |test_case, key|
 
   it "updates the label when no changes" do
     link = find("[data-key=#{key}] a.awesome-auto-edit", match: :first)
-    expect(page).not_to have_field(class: "awesome-auto-edit")
+    expect(page).to have_no_field(class: "awesome-auto-edit")
     link.click
     expect(page).to have_field(class: "awesome-auto-edit")
     find("body").click
-    expect(page).not_to have_field(class: "awesome-auto-edit")
+    expect(page).to have_no_field(class: "awesome-auto-edit")
     link.click
     input = find("[data-key=#{key}] input.awesome-auto-edit")
     input.fill_in with: "A new làbel\n"
     sleep 1
-    expect(page).not_to have_field(class: "awesome-auto-edit")
+    expect(page).to have_no_field(class: "awesome-auto-edit")
     expect(page).to have_css("span.awesome-auto-edit[data-key=a_new_label]")
 
     click_link_or_button "Update configuration"
@@ -24,14 +24,14 @@ shared_examples "edits box label inline" do |test_case, key|
     when :fields
       expect(page).to have_content("Occupation")
       expect(page).to have_content("Street Sweeper")
-      expect(page).not_to have_content("Short Bio")
+      expect(page).to have_no_content("Short Bio")
     when :admins
-      expect(page).not_to have_content(user.name.to_s)
+      expect(page).to have_no_content(user.name.to_s)
       expect(page).to have_content(user2.name.to_s)
       expect(page).to have_content(user3.name.to_s)
     end
     expect(page).to have_css("span.awesome-auto-edit[data-key=a_new_label]")
-    expect(page).not_to have_css("span.awesome-auto-edit[data-key=#{key}]")
+    expect(page).to have_no_css("span.awesome-auto-edit[data-key=#{key}]")
   end
 
   it "updates the label with previous changes" do
@@ -48,16 +48,16 @@ shared_examples "edits box label inline" do |test_case, key|
     end
 
     link = find("[data-key=#{key}] a.awesome-auto-edit", match: :first)
-    expect(page).not_to have_field(class: "awesome-auto-edit")
+    expect(page).to have_no_field(class: "awesome-auto-edit")
     link.click
     expect(page).to have_field(class: "awesome-auto-edit")
     find("body").click
-    expect(page).not_to have_field(class: "awesome-auto-edit")
+    expect(page).to have_no_field(class: "awesome-auto-edit")
     link.click
     input = find("[data-key=#{key}] input.awesome-auto-edit")
     input.fill_in with: "A new làbel\n"
     sleep 1
-    expect(page).not_to have_field(class: "awesome-auto-edit")
+    expect(page).to have_no_field(class: "awesome-auto-edit")
     expect(page).to have_css("span.awesome-auto-edit[data-key=a_new_label]")
 
     click_link_or_button "Update configuration"
@@ -73,21 +73,21 @@ shared_examples "edits box label inline" do |test_case, key|
       expect(page).to have_content(user3.name.to_s)
     end
     expect(page).to have_css("span.awesome-auto-edit[data-key=a_new_label]")
-    expect(page).not_to have_css("span.awesome-auto-edit[data-key=#{key}]")
+    expect(page).to have_no_css("span.awesome-auto-edit[data-key=#{key}]")
   end
 
   it "updates the label with post changes" do
     link = find("[data-key=#{key}] a.awesome-auto-edit", match: :first)
-    expect(page).not_to have_field(class: "awesome-auto-edit")
+    expect(page).to have_no_field(class: "awesome-auto-edit")
     link.click
     expect(page).to have_field(class: "awesome-auto-edit")
     find("body").click
-    expect(page).not_to have_field(class: "awesome-auto-edit")
+    expect(page).to have_no_field(class: "awesome-auto-edit")
     link.click
     input = find("[data-key=#{key}] input.awesome-auto-edit")
     input.fill_in with: "A new làbel\n"
     sleep 1
-    expect(page).not_to have_field(class: "awesome-auto-edit")
+    expect(page).to have_no_field(class: "awesome-auto-edit")
     expect(page).to have_css("span.awesome-auto-edit[data-key=a_new_label]")
 
     case test_case
@@ -111,6 +111,6 @@ shared_examples "edits box label inline" do |test_case, key|
       expect(page).to have_content(user3.name.to_s)
     end
     expect(page).to have_css("span.awesome-auto-edit[data-key=a_new_label]")
-    expect(page).not_to have_css("span.awesome-auto-edit[data-key=#{key}]")
+    expect(page).to have_no_css("span.awesome-auto-edit[data-key=#{key}]")
   end
 end

data/lib/decidim/decidim_awesome/test/shared_examples/config_examples.rb

@@ -5,7 +5,7 @@ shared_examples "javascript config vars" do
     expect(page.body).to have_content("window.DecidimAwesome")
     expect(page.body).to have_content("window.DecidimAwesome.version")
     expect(page.body).to have_content("window.DecidimAwesome.editorUploaderPath")
-    expect(page.body).to have_content("window.DecidimAwesome.texts")
+    expect(page.body).to have_content("window.DecidimAwesome.i18n")
   end
 end
 
@@ -22,14 +22,13 @@ shared_examples "do not have menu link" do |item|
   let(:prefix) { "config/" }
   it "do not show the feature link" do
     within ".sidebar-menu" do
-      expect(page).not_to have_link(href: "/admin/decidim_awesome/#{prefix}#{item}")
+      expect(page).to have_no_link(href: "/admin/decidim_awesome/#{prefix}#{item}")
     end
   end
 end
 
 shared_examples "forbids disabled feature without redirect" do
   render_views
-  let(:feature) { :menu }
   let(:features) { [feature] }
   before do
     features.each do |feat|
@@ -46,7 +45,6 @@ end
 
 shared_examples "forbids disabled feature with redirect" do
   render_views
-  let(:feature) { :menu }
   let(:features) { [feature] }
   before do
     features.each do |feat|

data/lib/decidim/decidim_awesome/test/shared_examples/custom_fields_examples.rb

@@ -26,7 +26,7 @@ shared_examples "updates a box" do
     expect(page).to have_content("Full Name")
     expect(page).to have_content("Occupation")
     expect(page).to have_content("Street Sweeper")
-    expect(page).not_to have_content("Short Bio")
+    expect(page).to have_no_content("Short Bio")
 
     page.execute_script("$('.proposal_custom_fields_container[data-key=\"foo\"] .proposal_custom_fields_editor')[0].FormBuilder.actions.setData(#{data})")
     click_on "Update configuration"
@@ -34,8 +34,8 @@ shared_examples "updates a box" do
     sleep 2
     expect(page).to have_admin_callout("updated successfully")
     expect(page).to have_content("Full Name")
-    expect(page).not_to have_content("Occupation")
-    expect(page).not_to have_content("Street Sweeper")
+    expect(page).to have_no_content("Occupation")
+    expect(page).to have_no_content("Street Sweeper")
     expect(page).to have_content("Short Bio")
   end
 end
@@ -53,7 +53,7 @@ shared_examples "removes a box" do |name|
     expect(page).to have_content("Full Name")
     expect(page).to have_content("Occupation")
     expect(page).to have_content("Street Sweeper")
-    expect(page).not_to have_content("Short Bio")
+    expect(page).to have_no_content("Short Bio")
 
     within ".proposal_custom_fields_container[data-key=\"foo\"]" do
       accept_confirm { click_on "Remove this \"#{name}\" box" }
@@ -61,10 +61,10 @@ shared_examples "removes a box" do |name|
 
     sleep 2
     expect(page).to have_admin_callout("removed successfully")
-    expect(page).not_to have_content("Full Name")
+    expect(page).to have_no_content("Full Name")
     expect(page).to have_content("Occupation")
     expect(page).to have_content("Street Sweeper")
-    expect(page).not_to have_content("Short Bio")
+    expect(page).to have_no_content("Short Bio")
 
     expect(Decidim::DecidimAwesome::AwesomeConfig.find_by(organization:, var: "#{var_name}_foo")).not_to be_present
     expect(Decidim::DecidimAwesome::AwesomeConfig.find_by(organization:, var: "#{var_name}_bar")).to be_present
@@ -121,13 +121,13 @@ shared_examples "removes a constraint" do
     end
 
     within ".proposal_custom_fields_container[data-key=\"bar\"] .constraints-editor" do
-      expect(page).not_to have_content("Proposals")
+      expect(page).to have_no_content("Proposals")
     end
 
     visit decidim_admin_decidim_awesome.config_path("#{var_name}s")
 
     within ".proposal_custom_fields_container[data-key=\"bar\"] .constraints-editor" do
-      expect(page).not_to have_content("Proposals")
+      expect(page).to have_no_content("Proposals")
     end
 
     expect(Decidim::DecidimAwesome::AwesomeConfig.find_by(organization:, var: "#{var_name}_bar")).to be_present