decidim-decidim_awesome 0.10.3 → 0.11.1

data/app/cells/decidim/decidim_awesome/voting/voting_cards_proposal/show.erb

@@ -1,35 +1,40 @@
-<h4 class="heading4 vote-title"><%= title %></h4>
+<div class="flex flex-col justify-center awesome-voting-card">
+  <h4 class="heading4 vote-title mb-2" style="font-size:1.375rem;"><%= title %></h4>
 
-<div class="flex--sbc">
-  <%= vote_block_for(proposal, 3) %>
-  <%= vote_block_for(proposal, 2) %>
-  <%= vote_block_for(proposal, 1) %>
-</div>
+  <div class="flex flex-row gap-1.5 mt-4">
+    <%= vote_block_for(proposal, 3) %>
+    <%= vote_block_for(proposal, 2) %>
+    <%= vote_block_for(proposal, 1) %>
+  </div>
+
+  <% if component_settings.voting_cards_show_abstain? %>
+    <%= action_authorized_link_to :vote,
+                                  voted_for?(0) ? t("decidim.decidim_awesome.voting.voting_cards.abstained") : proposal.manifest.label_for(0),
+                                  proposal_vote_path(0),
+                                  link_options(0).merge({
+                                    title: t("decidim.decidim_awesome.voting.voting_cards.voting_for", proposal: sanitized_title, type: proposal.manifest.label_for(0)),
+                                    class: "button button__sm button__transparent-secondary mb-4 vote-action abstain-button #{classes_for(0)}"
+                                    }) %>
+  <% end %>
 
-<% if component_settings.voting_cards_show_abstain? %>
-  <%= action_authorized_link_to :vote,
-                                voted_for?(0) ? t("decidim.decidim_awesome.voting.voting_cards.abstained") : proposal.manifest.label_for(0),
-                                proposal_vote_path(0),
-                                link_options(0).merge({
-                                  title: t("decidim.decidim_awesome.voting.voting_cards.voting_for", proposal: sanitized_title, type: proposal.manifest.label_for(0)),
-                                  class: "button expanded vote-action abstain-button small #{classes_for(0)}"
-                                  }) %>
-<% end %>
+  <% if voted_for_any? && !current_settings.votes_blocked? %>
+    <p class="text-center" style="margin-bottom:1rem;">
+      <%= action_authorized_link_to :unvote,
+                                    t("decidim.decidim_awesome.voting.voting_cards.change_vote"),
+                                    proposal_vote_path(current_vote&.weight),
+                                    remote: true,
+                                    method: :delete,
+                                    id: "change-vote",
+                                    class: "change-vote-button vote-action font-semibold" %>
+    </p>
+  <% elsif proposal.maximum_votes_reached? && !proposal.can_accumulate_supports_beyond_threshold && current_component.participatory_space.can_participate?(current_user) %>
+    <p class="text-center"><%= t("decidim.proposals.proposals.vote_button.maximum_votes_reached") %></p>
+  <% elsif vote_limit_enabled? && remaining_votes_count_for(current_user) <= 0 %>
+    <p class="text-center"><%= t("decidim.proposals.proposals.vote_button.no_votes_remaining") %></p>
+  <% elsif current_settings.votes_blocked? || !current_component.participatory_space.can_participate?(current_user) %>
+    <p class="text-center"><%= t("decidim.proposals.proposals.vote_button.votes_blocked") %></p>
+  <% end %>
+
+</div>
 
-<% if voted_for_any? && !current_settings.votes_blocked? %>
-  <p class="text-center">
-    <%= action_authorized_link_to :unvote,
-                                  t("decidim.decidim_awesome.voting.voting_cards.change_vote"),
-                                  proposal_vote_path(current_vote&.weight),
-                                  remote: true,
-                                  method: :delete,
-                                  id: "change-vote",
-                                  class: "change-vote-button vote-action" %>
-  </p>
-<% elsif proposal.maximum_votes_reached? && !proposal.can_accumulate_supports_beyond_threshold && current_component.participatory_space.can_participate?(current_user) %>
-  <p class="text-center"><%= t("decidim.proposals.proposals.vote_button.maximum_votes_reached") %></p>
-<% elsif vote_limit_enabled? && remaining_votes_count_for(current_user) <= 0 %>
-  <p class="text-center"><%= t("decidim.proposals.proposals.vote_button.no_votes_remaining") %></p>
-<% elsif current_settings.votes_blocked? || !current_component.participatory_space.can_participate?(current_user) %>
-  <p class="text-center"><%= t("decidim.proposals.proposals.vote_button.votes_blocked") %></p>
-<% end %>
+<%= render :modal if current_component.settings.voting_cards_show_modal_help %>

data/app/cells/decidim/decidim_awesome/voting/voting_cards_proposal_cell.rb

@@ -12,11 +12,16 @@ module Decidim
 
         def vote_block_for(proposal, weight)
           render partial: "vote_block", locals: {
-            proposal: proposal,
-            weight: weight
+            proposal:,
+            weight:
           }
         end
 
+        def vote_instructions
+          translated_attribute(current_component.settings.voting_cards_instructions).presence || t("decidim.decidim_awesome.voting.voting_cards.default_instructions_html",
+                                                                                                   organization: current_organization.name)
+        end
+
         def proposal_votes(weight)
           model.weight_count(weight)
         end
@@ -30,7 +35,7 @@ module Decidim
         end
 
         def proposal_vote_path(weight)
-          proposal_proposal_vote_path(proposal_id: proposal.id, from_proposals_list: from_proposals_list, weight: weight)
+          proposal_proposal_vote_path(proposal_id: proposal.id, from_proposals_list:, weight:)
         end
 
         def link_options(weight)
@@ -68,7 +73,7 @@ module Decidim
             return true
           end
 
-          return true if vote_limit_enabled? && remaining_votes_count_for(current_user) <= 0
+          true if vote_limit_enabled? && remaining_votes_count_for(current_user) <= 0
         end
 
         def voted_for_any?

data/app/commands/concerns/decidim/decidim_awesome/admin/needs_constraint_helpers.rb

@@ -11,7 +11,7 @@ module Decidim
           subconfig = AwesomeConfig.find_or_initialize_by(var: "#{var}_#{@ident}", organization: @organization)
           @constraint = ConfigConstraint.create!(
             awesome_config: subconfig,
-            settings: settings
+            settings:
           )
         end
 

data/app/commands/concerns/decidim/decidim_awesome/proposals/create_proposal_override.rb

@@ -15,10 +15,10 @@ module Decidim
           alias_method :decidim_original_create_proposal, :create_proposal
 
           def create_proposal
-            decidim_original_create_proposal
+            created_proposal = decidim_original_create_proposal
             # Update the proposal with the private body, to
             # avoid tracebility on private fields.
-            @proposal.update_private_body!(form.private_body) if form.private_body.present?
+            created_proposal.update_private_body!(form.private_body) if form.private_body.present?
           end
         end
       end

data/app/commands/concerns/decidim/decidim_awesome/proposals/update_proposal_override.rb

@@ -15,8 +15,8 @@ module Decidim
 
           alias_method :decidim_original_update_draft, :update_draft
 
-          def update_draft
-            decidim_original_update_draft
+          def update_proposal
+            decidim_original_update_proposal
             update_private_field!
           end
         end

data/app/commands/decidim/decidim_awesome/admin/create_constraint.rb

@@ -18,7 +18,7 @@ module Decidim
         #
         # Returns nothing.
         def call
-          return broadcast(:invalid) if form.invalid?
+          return broadcast(:invalid, form.errors.full_messages.join(". ")) if form.invalid?
           return broadcast(:invalid) if attributes.blank?
 
           begin

data/app/commands/decidim/decidim_awesome/admin/destroy_custom_redirect.rb

@@ -11,7 +11,7 @@ module Decidim
         def initialize(item, organization)
           @item = item
           @organization = organization
-          @redirections = AwesomeConfig.find_by(var: :custom_redirects, organization: organization)
+          @redirections = AwesomeConfig.find_by(var: :custom_redirects, organization:)
         end
 
         # Executes the command. Broadcasts these events:

data/app/commands/decidim/decidim_awesome/admin/destroy_menu_hack.rb

@@ -11,7 +11,7 @@ module Decidim
         def initialize(item, menu_name, organization)
           @item = item
           @organization = organization
-          @menu = AwesomeConfig.find_by(var: menu_name, organization: organization)
+          @menu = AwesomeConfig.find_by(var: menu_name, organization:)
         end
 
         # Executes the command. Broadcasts these events:

data/app/commands/decidim/decidim_awesome/admin/rename_scope_label.rb

@@ -34,7 +34,7 @@ module Decidim
             end
           end
 
-          broadcast(:ok, { scope: scope, key: @text })
+          broadcast(:ok, { scope:, key: @text })
         rescue StandardError => e
           broadcast(:invalid, e.message)
         end

data/app/commands/decidim/decidim_awesome/admin/update_constraint.rb

@@ -18,7 +18,7 @@ module Decidim
         #
         # Returns nothing.
         def call
-          return broadcast(:invalid) if form.invalid?
+          return broadcast(:invalid, form.errors.full_messages.join(". ")) if form.invalid?
           return broadcast(:invalid) if attributes.blank?
 
           begin

data/app/commands/decidim/decidim_awesome/admin/update_custom_redirect.rb

@@ -38,8 +38,8 @@ module Decidim
         delegate :to_params, to: :form
 
         def url_exists?
-          return unless redirects
-          return unless redirects.value.is_a? Hash
+          return false unless redirects
+          return false unless redirects.value.is_a? Hash
 
           redirects.value[item.origin].present?
         end

data/app/commands/decidim/decidim_awesome/command.rb

@@ -2,13 +2,7 @@
 
 module Decidim
   module DecidimAwesome
-    # maintains compatibility with v0.26 which uses Rectify
-    if defined? ::Decidim::Command
-      class Command < ::Decidim::Command
-      end
-    else
-      class Command < ::Rectify::Command
-      end
+    class Command < ::Decidim::Command
     end
   end
 end

data/app/controllers/concerns/decidim/decidim_awesome/admin/maintenance_context.rb

@@ -26,7 +26,7 @@ module Decidim
             {
               "private_data" => {
                 title: I18n.t("private_data", scope: "decidim.decidim_awesome.admin.menu.maintenance"),
-                icon: "lock-locked",
+                icon: "spy-line",
                 path: decidim_admin_decidim_awesome.maintenance_path("private_data")
               },
               "checks" => {

data/app/controllers/concerns/decidim/decidim_awesome/admin_accountability/admin/filterable_helper.rb

@@ -13,13 +13,12 @@ module Decidim
           end
 
           def applied_filters_tags(i18n_ctx)
-            admin_role_type = PaperTrailVersion.safe_admin_role_type(params[:admin_role_type])
-            if global? && admin_role_type.present?
+            if global? && params[:admin_role_type].present?
               content_tag(:span, class: "label secondary") do
                 concat "#{i18n_filter_label(:admin_role_type, filterable_i18n_scope_from_ctx(i18n_ctx))}: "
-                concat t("decidim.decidim_awesome.admin.admin_accountability.admin_roles.#{admin_role_type}", default: admin_role_type)
+                concat t("decidim.decidim_awesome.admin.admin_accountability.admin_roles.#{params[:admin_role_type]}", default: params[:admin_role_type])
                 concat icon_link_to(
-                  "circle-x",
+                  "close-circle-line",
                   url_for(export_params.except(:admin_role_type)),
                   t("decidim.admin.actions.cancel"),
                   class: "action-icon--remove"

data/app/controllers/concerns/decidim/decidim_awesome/content_security_policy.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+module Decidim
+  module DecidimAwesome
+    module ContentSecurityPolicy
+      extend ActiveSupport::Concern
+
+      included do
+        after_action :append_awesome_csp_directives
+      end
+
+      private
+
+      def append_awesome_csp_directives
+        # this is necessary for custom fields
+        content_security_policy.append_csp_directive("font-src", "data:") if DecidimAwesome.enabled?(:proposal_custom_fields)
+        append_awesome_intergram_directives
+      end
+
+      def append_awesome_intergram_directives
+        return unless DecidimAwesome.enabled?(:intergram_for_admins) || DecidimAwesome.enabled?(:intergram_for_public)
+
+        intergram = URI.parse(DecidimAwesome.intergram_url)
+        if intergram.host && intergram.scheme
+          content_security_policy.append_csp_directive("script-src", "#{intergram.scheme}://#{intergram.host}")
+          content_security_policy.append_csp_directive("frame-src", "#{intergram.scheme}://#{intergram.host}")
+          # this script is in the intergram code, but does not look necessary to work
+          # content_security_policy.append_csp_directive("frame-src", "http://www.loadmill.com")
+          # content_security_policy.append_csp_directive("frame-src", "http://app.loadmill.com")
+        end
+      end
+    end
+  end
+end

data/app/controllers/concerns/decidim/decidim_awesome/not_found_redirect.rb

@@ -50,7 +50,7 @@ module Decidim
             destination = "#{destination}#{union}#{query}"
           end
 
-          return destination.strip if destination.present?
+          destination.strip if destination.present?
         end
       end
     end

data/app/controllers/concerns/decidim/decidim_awesome/proposals/orderable_override.rb

@@ -14,8 +14,6 @@ module Decidim
 
           private
 
-          alias_method :decidim_original_reorder, :reorder
-
           # read order from session if available
           def order
             @order ||= detect_order(session[:order]) || default_order
@@ -33,23 +31,38 @@ module Decidim
             end
           end
 
+          # rubocop:disable Metrics/CyclomaticComplexity
           def reorder(proposals)
-            title_by_locale = Arel.sql(proposals.sanitize_sql(["decidim_proposals_proposals.title->>? #{collation}", locale]))
-            title_by_machine_translation = Arel.sql(proposals.sanitize_sql(["decidim_proposals_proposals.title->'machine_translations'->>? #{collation}", locale]))
-            title_by_default_locale = Arel.sql(proposals.sanitize_sql(["decidim_proposals_proposals.title->>? #{collation}", default_locale]))
             case order
             when "az"
-              proposals.order(title_by_locale => :asc, title_by_machine_translation => :asc, title_by_default_locale => :asc)
+              proposals.order(Arel.sql("CONCAT(decidim_proposals_proposals.title->>'#{locale}',
+                                        decidim_proposals_proposals.title->'machine_translations'->>'#{locale}',
+                                        decidim_proposals_proposals.title->>'#{default_locale}') #{collation} ASC"))
             when "za"
-              proposals.order(title_by_locale => :desc, title_by_machine_translation => :desc, title_by_default_locale => :desc)
+              proposals.order(Arel.sql("CONCAT(decidim_proposals_proposals.title->>'#{locale}',
+                                        decidim_proposals_proposals.title->'machine_translations'->>'#{locale}',
+                                        decidim_proposals_proposals.title->>'#{default_locale}') #{collation} DESC"))
             when "supported_first"
               proposals.joins(my_votes_join).group(:id).order(Arel.sql("COUNT(decidim_proposals_proposal_votes.id) DESC"))
             when "supported_last"
               proposals.joins(my_votes_join).group(:id).order(Arel.sql("COUNT(decidim_proposals_proposal_votes.id) ASC"))
-            else
-              decidim_original_reorder(proposals)
+            when "most_commented"
+              proposals.left_joins(:comments).group(:id).order(Arel.sql("COUNT(decidim_comments_comments.id) DESC"))
+            when "most_endorsed"
+              proposals.order(endorsements_count: :desc)
+            when "most_followed"
+              proposals.left_joins(:follows).group(:id).order(Arel.sql("COUNT(decidim_follows.id) DESC"))
+            when "most_voted"
+              proposals.order(proposal_votes_count: :desc)
+            when "random"
+              proposals.order_randomly(random_seed)
+            when "recent"
+              proposals.order(published_at: :desc)
+            when "with_more_authors"
+              proposals.order(coauthorships_count: :desc)
             end
           end
+          # rubocop:enable Metrics/CyclomaticComplexity
 
           def collation
             @collation ||= begin

data/app/controllers/concerns/decidim/decidim_awesome/proposals/proposal_votes_controller_override.rb

@@ -13,7 +13,7 @@ module Decidim
           # rubocop:enable Rails/LexicallyScopedActionFilter
 
           def create
-            enforce_permission_to :vote, :proposal, proposal: proposal
+            enforce_permission_to(:vote, :proposal, proposal:)
             @from_proposals_list = params[:from_proposals_list] == "true"
 
             Decidim::Proposals::VoteProposal.call(proposal, current_user) do
@@ -27,7 +27,7 @@ module Decidim
                   proposal: Decidim::Proposals::Proposal.where(component: current_component)
                 ).map(&:proposal)
 
-                expose(proposals: proposals)
+                expose(proposals:)
                 render :update_buttons_and_counters
               end
 
@@ -47,7 +47,7 @@ module Decidim
           end
 
           def current_vote
-            @current_vote ||= Decidim::Proposals::ProposalVote.find_by(author: current_user, proposal: proposal)
+            @current_vote ||= Decidim::Proposals::ProposalVote.find_by(author: current_user, proposal:)
           end
 
           def vote_manifest

data/app/controllers/decidim/decidim_awesome/admin/admin_accountability_controller.rb

@@ -5,7 +5,7 @@ module Decidim
     module Admin
       class AdminAccountabilityController < DecidimAwesome::Admin::ApplicationController
         include NeedsAwesomeConfig
-        include AdminAccountability::Admin::Filterable
+        include Decidim::DecidimAwesome::AdminAccountability::Admin::Filterable
 
         helper_method :admin_actions, :collection, :export_params, :global?, :global_users_missing_date
 
@@ -20,9 +20,9 @@ module Decidim
         def export
           filters = export_params[:q]
 
-          ExportAdminActionsJob.perform_later(current_user,
-                                              params[:format].to_s,
-                                              admin_actions.ransack(filters).result.ids)
+          Decidim::DecidimAwesome::ExportAdminActionsJob.perform_later(current_user,
+                                                                       params[:format].to_s,
+                                                                       admin_actions.ransack(filters).result.ids)
 
           redirect_back fallback_location: decidim_admin_decidim_awesome.admin_accountability_path,
                         notice: t("decidim.decidim_awesome.admin.admin_accountability.exports.notice")
@@ -39,11 +39,11 @@ module Decidim
         end
 
         def space_role_actions
-          @space_role_actions ||= PaperTrailVersion.space_role_actions(current_organization)
+          @space_role_actions ||= Decidim::DecidimAwesome::PaperTrailVersion.space_role_actions(current_organization)
         end
 
         def admin_role_actions
-          @admin_role_actions ||= PaperTrailVersion.in_organization(current_organization).admin_role_actions(PaperTrailVersion.safe_admin_role_type(params[:admin_role_type]))
+          @admin_role_actions ||= Decidim::DecidimAwesome::PaperTrailVersion.in_organization(current_organization).admin_role_actions(params[:admin_role_type])
         end
 
         def export_params
@@ -61,7 +61,7 @@ module Decidim
           return unless global?
 
           @global_users_missing_date ||= begin
-            first_version = PaperTrailVersion.where(item_type: "Decidim::UserBaseEntity").last
+            first_version = Decidim::DecidimAwesome::PaperTrailVersion.where(item_type: "Decidim::UserBaseEntity").last
             first_user = Decidim::User.first
             first_version.created_at if first_user && first_version && (first_version.created_at > first_user.created_at + 1.second)
           end

data/app/controllers/decidim/decidim_awesome/admin/checks_controller.rb

@@ -34,27 +34,27 @@ module Decidim
         def head_addons(part)
           case part
           when :CSS
-            ['<%= stylesheet_pack_tag "decidim_decidim_awesome", media: "all" %>',
+            ['<%= append_stylesheet_pack_tag "decidim_decidim_awesome", media: "all" %>',
              '<%= render(partial: "layouts/decidim/decidim_awesome/custom_styles") if awesome_custom_styles %>'].join("\n")
           when :JavaScript
             ['<%= render partial: "layouts/decidim/decidim_awesome/awesome_config" %>',
-             '<%= javascript_pack_tag "decidim_decidim_awesome" %>',
-             '<%= javascript_pack_tag "decidim_decidim_awesome_custom_fields" if awesome_proposal_custom_fields %>'].join("\n")
+             '<%= append_javascript_pack_tag "decidim_decidim_awesome", defer: false %>',
+             '<%= append_javascript_pack_tag "decidim_decidim_awesome_custom_fields" if awesome_proposal_custom_fields %>'].join("\n")
           end
         end
 
         def admin_addons(part)
           case part
           when :CSS
-            '<%= stylesheet_pack_tag "decidim_admin_decidim_awesome", media: "all" %>'
+            '<%= append_stylesheet_pack_tag "decidim_admin_decidim_awesome", media: "all" %>'
           when :JavaScript
-            ['<%= javascript_pack_tag "decidim_admin_decidim_awesome", defer: false %>',
-             '<%= javascript_pack_tag "decidim_decidim_awesome_custom_fields" if awesome_proposal_custom_fields %>'].join("\n")
+            ['<%= append_javascript_pack_tag "decidim_admin_decidim_awesome", defer: false %>',
+             '<%= append_javascript_pack_tag "decidim_decidim_awesome_custom_fields" if awesome_proposal_custom_fields %>'].join("\n")
           end
         end
 
         def render_template(partial)
-          render_to_string(partial: partial)
+          render_to_string(partial:)
         rescue ActionView::Template::Error => e
           flash.now[:alert] = "Partial [#{partial}] has thrown an error: #{e.message}"
         end

data/app/controllers/decidim/decidim_awesome/admin/config_controller.rb

@@ -42,12 +42,12 @@ module Decidim
                 query = current_organization.users.order(name: :asc)
                 query = query.where("name ILIKE :term OR nickname ILIKE :term OR email ILIKE :term", term: "%#{term}%")
                 render json: query.all.collect { |u|
-                  {
-                    value: u.id,
-                    text: format_user_name(u),
-                    is_admin: u.read_attribute("admin")
-                  }
-                }
+                               {
+                                 value: u.id,
+                                 text: format_user_name(u),
+                                 is_admin: u.read_attribute("admin")
+                               }
+                             }
               else
                 render json: []
               end
@@ -91,14 +91,12 @@ module Decidim
           DecidimAwesome.config.keys
         end
 
-        # rubocop:disable Style/OpenStructUse
         def users_for(ids_list)
-          Decidim::User.where(id: ids_list).map { |user| OpenStruct.new(text: format_user_name(user), id: user.id) }
+          Decidim::User.where(id: ids_list).map { |user| [format_user_name(user), user.id, { data: { is_admin: user.read_attribute("admin") } }] }
         end
-        # rubocop:enable Style/OpenStructUse
 
         def format_user_name(user)
-          "<span class='#{"is-admin" if user.read_attribute("admin")}'>#{user.name} (@#{user.nickname} - #{user.email})</span>"
+          "#{user.name} (@#{user.nickname} - #{user.email})"
         end
       end
     end

data/app/controllers/decidim/decidim_awesome/admin/constraints_controller.rb

@@ -6,6 +6,7 @@ module Decidim
       # Constraints configuration controller for config keys
       class ConstraintsController < DecidimAwesome::Admin::ApplicationController
         include NeedsAwesomeConfig
+        include Decidim::Headers::HttpCachingDisabler
         helper ConfigConstraintsHelpers
 
         layout false
@@ -13,14 +14,14 @@ module Decidim
           render plain: "no permissions for #{constraint_key}" unless allowed_to? :edit_config, constraint_key
         end
 
-        def new
-          @form = form(ConstraintForm).from_params(filtered_params, setting: current_setting)
-        end
-
         def show
           @form = form(ConstraintForm).from_params(constraint.settings.merge(filtered_params))
         end
 
+        def new
+          @form = form(ConstraintForm).from_params(filtered_params, setting: current_setting)
+        end
+
         def create
           @form = form(ConstraintForm).from_params(params, setting: current_setting)
           CreateConstraint.call(@form) do
@@ -39,11 +40,11 @@ module Decidim
 
             on(:invalid) do |message|
               render json: {
-                id: params[:id],
-                key: current_setting.var,
-                message: I18n.t("decidim_awesome.admin.constraints.create.error", scope: "decidim"),
-                error: message
-              },
+                       id: params[:id],
+                       key: current_setting.var,
+                       message: I18n.t("decidim_awesome.admin.constraints.create.error", scope: "decidim"),
+                       error: message
+                     },
                      status: :unprocessable_entity
             end
           end
@@ -67,11 +68,11 @@ module Decidim
 
             on(:invalid) do |message|
               render json: {
-                id: params[:id],
-                key: constraint.awesome_config.var,
-                message: I18n.t("decidim_awesome.admin.constraints.update.error", scope: "decidim"),
-                error: message
-              },
+                       id: params[:id],
+                       key: constraint.awesome_config.var,
+                       message: I18n.t("decidim_awesome.admin.constraints.update.error", scope: "decidim"),
+                       error: message
+                     },
                      status: :unprocessable_entity
             end
           end
@@ -94,11 +95,11 @@ module Decidim
 
             on(:invalid) do |message|
               render json: {
-                id: params[:id],
-                key: constraint.awesome_config.var,
-                message: I18n.t("decidim_awesome.admin.constraints.destroy.error", scope: "decidim"),
-                error: message
-              },
+                       id: params[:id],
+                       key: constraint.awesome_config.var,
+                       message: I18n.t("decidim_awesome.admin.constraints.destroy.error", scope: "decidim"),
+                       error: message
+                     },
                      status: :unprocessable_entity
             end
           end

data/app/controllers/decidim/decidim_awesome/admin/custom_redirects_controller.rb

@@ -21,6 +21,10 @@ module Decidim
           @form = form(CustomRedirectForm).instance
         end
 
+        def edit
+          @form = form(CustomRedirectForm).from_model(redirect_item)
+        end
+
         def create
           @form = form(CustomRedirectForm).from_params(params)
           CreateCustomRedirect.call(@form) do
@@ -36,10 +40,6 @@ module Decidim
           end
         end
 
-        def edit
-          @form = form(CustomRedirectForm).from_model(redirect_item)
-        end
-
         def update
           @form = form(CustomRedirectForm).from_params(params)
           UpdateCustomRedirect.call(@form, redirect_item) do
@@ -61,7 +61,7 @@ module Decidim
               flash[:notice] = I18n.t("custom_redirects.destroy.success", scope: "decidim.decidim_awesome.admin")
             end
             on(:invalid) do |error|
-              flash[:alert] = I18n.t("custom_redirects.destroy.error", scope: "decidim.decidim_awesome.admin", error: error)
+              flash[:alert] = I18n.t("custom_redirects.destroy.error", scope: "decidim.decidim_awesome.admin", error:)
             end
           end
           redirect_to decidim_admin_decidim_awesome.custom_redirects_path
@@ -73,13 +73,11 @@ module Decidim
           origin, item = current_config.find { |origin, _| md5(origin) == params[:id] }
           raise ActiveRecord::RecordNotFound unless item
 
-          # rubocop:disable Style/OpenStructUse
           OpenStruct.new(
-            origin: origin,
+            origin:,
             destination: item["destination"],
             active: item["active"]
           )
-          # rubocop:enable Style/OpenStructUse
         end
 
         def current_config

data/app/controllers/decidim/decidim_awesome/admin/maintenance_controller.rb

@@ -16,7 +16,7 @@ module Decidim
         helper_method :collection, :resource, :present, :time_ago
 
         before_action do
-          enforce_permission_to :edit_config, :private_data, private_data: private_data
+          enforce_permission_to :edit_config, :private_data, private_data:
         end
 
         def show
@@ -64,7 +64,7 @@ module Decidim
         end
 
         def private_data_finder
-          @private_data_finder ||= PrivateDataFinder.new
+          @private_data ||= PrivateDataFinder.new
         end
 
         def time_ago