decidim-core 0.32.0.rc2 → 0.32.0.rc3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b4e8ed9025a083ab3351ad881448605343e89a1823e3616b250b9473a2c9bdb
-  data.tar.gz: a6b96945cdd6f5722d251d41b0576bccf3ff2aae1e4aa0c51e0ab47a9c257360
+  metadata.gz: 5c8c0eaf7af52859f34c0b152525144104d544b91f8a5ba49173b2f25530709c
+  data.tar.gz: c1d8019a4006489b276e3d2ca8c5c6f194890035369ab69a7c7e358376f16fae
 SHA512:
-  metadata.gz: 0ae197ee72cf96014bcb4ac200f53c19d0fe8d9bfffbcb32b266530a972b407a0f7dfd585b600d311830731231fb8a5ab96d740058f498120e30d41aa8aac17a
-  data.tar.gz: a526e1c79feb561a1cd2f90e0bba221301698ebb4df70dd1911de2685c705a2de703d42755904ddd2fd2b075ba8861eafa4f806490b5f86b69e8c45e6259bf18
+  metadata.gz: 88f9cdca14f469d2fe61ca88c3ba56f8e44586a951be4de8a3faa3f9de1d75b982f8b0db9023052470118f8f47c4d327eecf4687a568f636a18a6c85cfacd874
+  data.tar.gz: de42f147191cad92bd9b25c908a4526aaa317313e44603828b59ec0f40e9360f1a9cc8e046b64ed226b9c1585cdca4b213f271380e003d43936b813ebef6160f

data/app/cells/decidim/amendable/amend_button_card/show.erb

@@ -1,5 +1,5 @@
-<li role="menuitem" class="dropdown__item">
-  <%= action_authorized_link_to :amend, new_amend_path, resource: model, data: { "redirect_url" => new_amend_path }, id: "amend-button", class: "dropdown__button" do %>
+<li role="presentation" class="dropdown__item">
+  <%= action_authorized_link_to :amend, new_amend_path, resource: model, data: { "redirect_url" => new_amend_path }, id: "amend-button", class: "dropdown__button", role: "menuitem" do %>
     <span><%= t("button", scope: "decidim.amendments.amendable", model_name: nil) %></span>
     <%= icon "pencil-line" %>
   <% end %>

data/app/cells/decidim/card_metadata_cell.rb

@@ -29,7 +29,7 @@ module Decidim
       return unless show_space?
 
       {
-        text: decidim_escape_translated(participatory_space.title),
+        text: translated_attribute(participatory_space.title),
         icon: resource_type_icon_key(participatory_space.class),
         url: Decidim::ResourceLocatorPresenter.new(participatory_space).path
       }

data/app/cells/decidim/content_blocks/cta_settings_form/show.erb

@@ -4,6 +4,6 @@
   <%= settings_fields.translated :text_field, :description, label: t("decidim.content_blocks.cta_settings_form.description") %>
 <% end %>
 
-<% form.fields_for :images, form.object.images do |images_fields| %>
+<% form.fields_for :images, content_block.images_container do |images_fields| %>
   <%= images_fields.upload :background_image, label: t("decidim.content_blocks.cta_settings_form.background_image") %>
 <% end %>

data/app/cells/decidim/content_blocks/hero_settings_form/show.erb

@@ -14,7 +14,7 @@
   </div>
 <% end %>
 
-<% form.fields_for :images, form.object.images do |images_fields| %>
+<% form.fields_for :images, content_block.images_container do |images_fields| %>
   <div class="row column">
     <%= images_fields.upload :background_image, label: t(".background_image"), button_class: "button button__sm button__transparent-secondary" %>
   </div>

data/app/cells/decidim/content_blocks/highlighted_content_banner_settings_form/show.erb

@@ -20,7 +20,7 @@
   </div>
 <% end %>
 
-<% form.fields_for :images, form.object.images do |images_fields| %>
+<% form.fields_for :images, content_block.images_container do |images_fields| %>
   <div class="row column">
     <%= images_fields.upload :background_image, label: t(".background_image"), button_class: "button button__sm button__transparent-secondary" %>
   </div>

data/app/cells/decidim/content_blocks/participatory_space_hero_settings_form/show.erb

@@ -8,7 +8,7 @@
   </div>
 <% end %>
 
-<% form.fields_for :images, form.object.images do |images_fields| %>
+<% form.fields_for :images, content_block.images_container do |images_fields| %>
   <div class="row column">
     <%= images_fields.upload :background_image, label: t("decidim.content_blocks.cta_settings_form.background_image"), button_class: "button button__sm button__transparent-secondary" %>
   </div>

data/app/cells/decidim/content_blocks/static_page/section_settings_form/show.erb

@@ -1,3 +1,5 @@
 <% form.fields_for :settings, form.object.settings do |settings_fields| %>
-  <%= settings_fields.translated :editor, :content, label: %>
+  <div class="row column">
+    <%= settings_fields.translated :editor, :content, label: %>
+  </div>
 <% end %>

data/app/cells/decidim/content_blocks/static_page/summary_settings_form/show.erb

@@ -1,3 +1,5 @@
 <% form.fields_for :settings, form.object.settings do |settings_fields| %>
-  <%= settings_fields.translated :editor, :summary, label: %>
+  <div class="row column">
+    <%= settings_fields.translated :editor, :summary, label: %>
+  </div>
 <% end %>

data/app/cells/decidim/content_blocks/static_page/two_pane_section_settings_form/show.erb

@@ -1,4 +1,6 @@
 <% form.fields_for :settings, form.object.settings do |settings_fields| %>
-  <%= settings_fields.translated :editor, :left_column, label: label_left_column %>
-  <%= settings_fields.translated :editor, :right_column, label: label_right_column %>
+  <div class="row column">
+    <%= settings_fields.translated :editor, :left_column, label: label_left_column %>
+    <%= settings_fields.translated :editor, :right_column, label: label_right_column %>
+  </div>
 <% end %>

data/app/cells/decidim/resource_types_filter/show.erb

@@ -10,8 +10,8 @@
   </button>
   <ul id="dropdown-menu-resource">
     <% resource_types.each do |resource_type| %>
-      <li role="menuitem">
-        <%= link_to filter_url(resource_type[0]), class: "filter#{" is-active" if filter_param == resource_type[0]}" do %>
+      <li role="presentation">
+        <%= link_to filter_url(resource_type[0]), class: "filter#{" is-active" if filter_param == resource_type[0]}", role: "menuitem" do %>
           <span class="sr-only"><%= resource_type[1] %></span>
           <%= text_with_resource_icon(*resource_type) %>
         <% end %>

data/app/controllers/concerns/decidim/devise_controllers.rb

@@ -41,6 +41,10 @@ module Decidim
 
       layout "layouts/decidim/application"
 
+      # Ensure locale is set before Devise's own prepended callbacks and reset
+      # after the request finishes.
+      prepend_around_action :set_current_locale
+
       # Saves the location before loading each page so we can return to the
       # right page.
       before_action :store_current_location
@@ -58,6 +62,11 @@ module Decidim
 
         store_location_for(:user, redirect_url)
       end
+
+      def set_current_locale(&)
+        locale = Decidim::LocaleRouterDetector.new(request, params).locale
+        I18n.with_locale(locale, &)
+      end
     end
   end
 end

data/app/events/decidim/amendable/amendment_base_event.rb

@@ -3,7 +3,7 @@
 module Decidim::Amendable
   class AmendmentBaseEvent < Decidim::Events::SimpleEvent
     i18n_attributes :amendable_path, :amendable_type, :amendable_title,
-                    :emendation_path, :emendation_author_nickname, :emendation_author_path
+                    :emendation_path, :emendation_author_nickname, :emendation_author_name, :emendation_author_path
 
     def amendable_title
       @amendable_title ||= translated_attribute(amendable_resource.title)
@@ -33,6 +33,12 @@ module Decidim::Amendable
       @emendation_author_nickname ||= emendation_author.nickname
     end
 
+    def emendation_author_name
+      return unless emendation_resource
+
+      @emendation_author_name ||= emendation_author.name
+    end
+
     def emendation_author_path
       return unless emendation_resource
 

data/app/models/decidim/moderation.rb

@@ -32,7 +32,7 @@ module Decidim
     end
 
     def self.ransackable_attributes(_auth_object = nil)
-      %w(reported_id_string reported_content created_at)
+      %w(reported_id_string reported_content created_at report_count)
     end
 
     def self.ransackable_associations(_auth_object = nil)

data/app/models/decidim/participatory_space/member.rb

@@ -42,7 +42,7 @@ module Decidim
       def self.ransackable_attributes(auth_object = nil)
         return [] unless auth_object&.admin?
 
-        %w(name nickname email invitation_accepted_at last_sign_in_at invitation_sent_at role)
+        %w(name nickname email invitation_accepted_at last_sign_in_at invitation_sent_at role published)
       end
 
       def self.ransackable_associations(_auth_object = nil)

data/app/models/decidim/user_base_entity.rb

@@ -69,12 +69,27 @@ module Decidim
       Decidim::UserBaseEntity.joins(:follows).where(decidim_follows: { user: self }).blocked.exists?
     end
 
+    ransacker :role do
+      Arel.sql(%{CASE WHEN "decidim_users"."admin" = true THEN 'admin' ELSE cast("decidim_users"."roles" as text) END})
+    end
+
+    ransacker :user_moderation_report_count do
+      query = <<~SQL.squish
+        (
+            SELECT COALESCE(MAX(decidim_user_moderations.report_count), 0)
+            FROM decidim_user_moderations
+            WHERE decidim_user_moderations.decidim_user_id = decidim_users.id
+        )
+      SQL
+      Arel.sql(query)
+    end
+
     def self.ransackable_attributes(auth_object = nil)
-      base = %w(name email nickname last_sign_in_at)
+      base = %w(name email nickname last_sign_in_at created_at)
 
       return base unless auth_object&.admin?
 
-      base + %w(invitation_sent_at invitation_accepted_at officialized_at)
+      base + %w(invitation_sent_at invitation_accepted_at officialized_at role user_moderation_report_count)
     end
 
     def self.ransackable_associations(_auth_object = nil)

data/app/models/decidim/user_moderation.rb

@@ -19,7 +19,7 @@ module Decidim
     end
 
     def self.ransackable_attributes(_auth_object = nil)
-      []
+      %w(created_at report_count)
     end
 
     def self.ransackable_associations(_auth_object = nil)

data/app/packs/src/decidim/controllers/breadcrumb_truncate/breadcrumb_truncate.test.js

@@ -0,0 +1,230 @@
+/* global jest */
+import { Application } from "@hotwired/stimulus"
+import BreadcrumbTruncateController from "src/decidim/controllers/breadcrumb_truncate/controller"
+
+describe("BreadcrumbTruncateController", () => {
+  let application = null
+  let controller = null
+  let element = null
+  let textElement = null
+  let resizeObserverMock = null
+  let originalResizeObserver = null
+
+  const startController = () => new Promise((resolve) => {
+    setTimeout(() => {
+      controller = application.getControllerForElementAndIdentifier(element, "breadcrumb-truncate")
+      resolve()
+    }, 0)
+  })
+
+  beforeEach(() => {
+    originalResizeObserver = window.ResizeObserver
+    resizeObserverMock = {
+      observe: jest.fn(),
+      disconnect: jest.fn()
+    }
+
+    window.ResizeObserver = jest.fn().mockImplementation(() => resizeObserverMock)
+
+    document.body.innerHTML = `
+      <span data-controller="breadcrumb-truncate" class="truncate">
+        <span data-breadcrumb-truncate-target="text">Very long participatory space title example</span>
+      </span>
+    `
+
+    application = Application.start()
+    application.register("breadcrumb-truncate", BreadcrumbTruncateController)
+
+    element = document.querySelector('[data-controller="breadcrumb-truncate"]')
+    textElement = element.querySelector('[data-breadcrumb-truncate-target="text"]')
+
+    return startController()
+  })
+
+  afterEach(() => {
+    application.stop()
+    document.body.innerHTML = ""
+    window.ResizeObserver = originalResizeObserver
+    jest.restoreAllMocks()
+  })
+
+  it("keeps the full text when it fits", () => {
+    Reflect.defineProperty(element, "clientWidth", { configurable: true, value: 100 })
+    Reflect.defineProperty(element, "scrollWidth", { configurable: true, get: () => 80 })
+
+    controller.refresh()
+
+    expect(textElement.textContent).toBe("Very long participatory space title example")
+    expect(element.hasAttribute("title")).toBe(false)
+  })
+
+  it("truncates at the last fitting word and adds an ellipsis", () => {
+    Reflect.defineProperty(element, "clientWidth", { configurable: true, value: 100 })
+    Reflect.defineProperty(element, "scrollWidth", {
+      configurable: true,
+      get: () => (textElement.textContent.length > 16
+        ? 120
+        : 80)
+    })
+
+    controller.refresh()
+
+    expect(textElement.textContent).toBe("Very long...")
+    expect(element.getAttribute("title")).toBe("Very long participatory space title example")
+  })
+
+  it("falls back to character truncation for a single long word", () => {
+    textElement.textContent = "veeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeery"
+    controller.originalTexts = [textElement.textContent]
+
+    Reflect.defineProperty(element, "clientWidth", { configurable: true, value: 100 })
+    Reflect.defineProperty(element, "scrollWidth", {
+      configurable: true,
+      get: () => (textElement.textContent.length > 9
+        ? 120
+        : 80)
+    })
+
+    controller.refresh()
+
+    expect(textElement.textContent.endsWith("...")).toBe(true)
+    expect(textElement.textContent.includes(" ")).toBe(false)
+    expect(textElement.textContent.length).toBeGreaterThan(3)
+  })
+
+  it("disconnects the resize observer", () => {
+    controller.disconnect()
+
+    expect(resizeObserverMock.disconnect).toHaveBeenCalled()
+  })
+
+  it("does nothing when no text target exists", async () => {
+    document.body.innerHTML = "<nav data-controller=\"breadcrumb-truncate\"></nav>"
+
+    application.stop()
+    application = Application.start()
+    application.register("breadcrumb-truncate", BreadcrumbTruncateController)
+
+    element = document.querySelector('[data-controller="breadcrumb-truncate"]')
+
+    await startController()
+
+    expect(() => controller.refresh()).not.toThrow()
+  })
+
+  it("prioritizes truncating the widest item in group mode", async () => {
+    document.body.innerHTML = `
+      <nav data-controller="breadcrumb-truncate">
+        <span data-breadcrumb-truncate-target="item">
+          <span data-breadcrumb-truncate-target="text">Very long participatory space title example</span>
+        </span>
+        <span data-breadcrumb-truncate-target="item">
+          <span data-breadcrumb-truncate-target="text">Proposals</span>
+        </span>
+      </nav>
+    `
+
+    application.stop()
+    application = Application.start()
+    application.register("breadcrumb-truncate", BreadcrumbTruncateController)
+
+    element = document.querySelector('[data-controller="breadcrumb-truncate"]')
+    const itemElements = element.querySelectorAll('[data-breadcrumb-truncate-target="item"]')
+    const textElements = element.querySelectorAll('[data-breadcrumb-truncate-target="text"]')
+    const initialWidths = [150, 50]
+
+    Reflect.defineProperty(element, "clientWidth", { configurable: true, value: 100 })
+    Reflect.defineProperty(itemElements[0], "clientWidth", {
+      configurable: true,
+      get: () => Number.parseInt(itemElements[0].style.maxWidth || `${initialWidths[0]}`, 10)
+    })
+    Reflect.defineProperty(itemElements[1], "clientWidth", {
+      configurable: true,
+      get: () => Number.parseInt(itemElements[1].style.maxWidth || `${initialWidths[1]}`, 10)
+    })
+    Reflect.defineProperty(element, "scrollWidth", {
+      configurable: true,
+      get: () => Array.from(itemElements).reduce((sum, item) => sum + item.clientWidth, 0)
+    })
+    Reflect.defineProperty(itemElements[0], "scrollWidth", {
+      configurable: true,
+      get: () => (textElements[0].textContent.length > 16
+        ? 120
+        : 80)
+    })
+    Reflect.defineProperty(itemElements[1], "scrollWidth", {
+      configurable: true,
+      get: () => 50
+    })
+
+    await startController()
+    controller.refresh()
+
+    expect(textElements[0].textContent).not.toBe("Very long participatory space title example")
+    expect(textElements[0].textContent.endsWith("...")).toBe(true)
+    expect(textElements[1].textContent).toBe("Proposals")
+  })
+
+  it("preserves shorter deep breadcrumb labels while shrinking the longest one first", async () => {
+    document.body.innerHTML = `
+      <nav data-controller="breadcrumb-truncate">
+        <span data-breadcrumb-truncate-target="item">
+          <span data-breadcrumb-truncate-target="text">This is a very long title for a participatory process for a test</span>
+        </span>
+        <span data-breadcrumb-truncate-target="item">
+          <span data-breadcrumb-truncate-target="text">Debates</span>
+        </span>
+        <span data-breadcrumb-truncate-target="item">
+          <span data-breadcrumb-truncate-target="text">Debate made by a participant</span>
+        </span>
+      </nav>
+    `
+
+    application.stop()
+    application = Application.start()
+    application.register("breadcrumb-truncate", BreadcrumbTruncateController)
+
+    element = document.querySelector('[data-controller="breadcrumb-truncate"]')
+    const itemElements = element.querySelectorAll('[data-breadcrumb-truncate-target="item"]')
+    const textElements = element.querySelectorAll('[data-breadcrumb-truncate-target="text"]')
+
+    Reflect.defineProperty(element, "clientWidth", { configurable: true, value: 220 })
+
+    const initialWidths = [180, 56, 104]
+
+    itemElements.forEach((item, index) => {
+      Reflect.defineProperty(item, "clientWidth", {
+        configurable: true,
+        get: () => Number.parseInt(item.style.maxWidth || `${initialWidths[index]}`, 10)
+      })
+    })
+    Reflect.defineProperty(element, "scrollWidth", {
+      configurable: true,
+      get: () => Array.from(itemElements).reduce((sum, item) => sum + item.clientWidth, 0)
+    })
+
+    Reflect.defineProperty(itemElements[0], "scrollWidth", {
+      configurable: true,
+      get: () => (textElements[0].textContent.length > 18
+        ? 160
+        : 80)
+    })
+    Reflect.defineProperty(itemElements[1], "scrollWidth", {
+      configurable: true,
+      get: () => 56
+    })
+    Reflect.defineProperty(itemElements[2], "scrollWidth", {
+      configurable: true,
+      get: () => (textElements[2].textContent.length > 20
+        ? 120
+        : 96)
+    })
+
+    await startController()
+    controller.refresh()
+
+    expect(textElements[0].textContent.endsWith("...")).toBe(true)
+    expect(textElements[1].textContent).toBe("Debates")
+    expect(textElements[2].textContent).toBe("Debate made by a participant")
+  })
+})

data/app/packs/src/decidim/controllers/breadcrumb_truncate/controller.js

@@ -0,0 +1,172 @@
+import { Controller } from "@hotwired/stimulus"
+
+const ELLIPSIS = "..."
+const PREFERRED_MIN_WIDTH = 96
+const ABSOLUTE_MIN_WIDTH = 24
+
+export default class extends Controller {
+  static get targets() {
+    return ["item", "text"]
+  }
+
+  connect() {
+    this.originalTexts = this.textTargets.map((target) => target.textContent.trim())
+    this.refresh = this.refresh.bind(this)
+
+    this.resizeObserver = new ResizeObserver(() => this.refresh())
+    this.resizeObserver.observe(this.element)
+    window.addEventListener("resize", this.refresh)
+
+    this.refresh()
+  }
+
+  disconnect() {
+    this.resizeObserver?.disconnect()
+    window.removeEventListener("resize", this.refresh)
+  }
+
+  refresh() {
+    if (!this.hasTextTarget) {
+      return
+    }
+
+    if (this.hasItemTarget) {
+      this.refreshGroup()
+      return
+    }
+
+    this.truncateItem(this.element, this.textTarget, this.originalTexts[0])
+  }
+
+  refreshGroup() {
+    this.itemTargets.forEach((item, index) => this.resetItem(item, this.textTargets[index], this.originalTexts[index]))
+
+    if (this.element.clientWidth <= 0) {
+      return
+    }
+
+    if (!this.isOverflowing(this.element)) {
+      return
+    }
+
+    const candidates = this.itemTargets.map((item, index) => ({
+      item,
+      text: this.textTargets[index],
+      originalText: this.originalTexts[index],
+      width: item.scrollWidth
+    })).sort((left, right) => right.width - left.width)
+
+    candidates.forEach((candidate) => {
+      if (!this.isOverflowing(this.element)) {
+        return
+      }
+
+      this.shrinkCandidate(candidate, PREFERRED_MIN_WIDTH)
+
+      if (this.isOverflowing(this.element)) {
+        this.shrinkCandidate(candidate, ABSOLUTE_MIN_WIDTH)
+      }
+    })
+  }
+
+  shrinkCandidate(candidate, minimumWidth) {
+    const overflow = this.element.scrollWidth - this.element.clientWidth
+
+    if (overflow <= 0) {
+      return
+    }
+
+    const minWidth = Math.min(candidate.width, minimumWidth)
+    const shrinkableWidth = candidate.width - minWidth
+
+    if (shrinkableWidth <= 0) {
+      return
+    }
+
+    const reduction = Math.min(overflow, shrinkableWidth)
+    const nextWidth = candidate.width - reduction
+
+    candidate.item.style.flex = `0 1 ${nextWidth}px`
+    candidate.item.style.maxWidth = `${nextWidth}px`
+    candidate.item.style.minWidth = "0"
+
+    this.truncateItem(candidate.item, candidate.text, candidate.originalText)
+    candidate.width = nextWidth
+  }
+
+  resetItem(item, text, originalText) {
+    item.style.removeProperty("flex")
+    item.style.removeProperty("max-width")
+    item.style.removeProperty("min-width")
+    item.removeAttribute("title")
+    text.textContent = originalText
+  }
+
+  truncateItem(item, text, originalText) {
+    if (item.clientWidth <= 0) {
+      return
+    }
+
+    text.textContent = originalText
+
+    if (!this.isOverflowing(item)) {
+      item.removeAttribute("title")
+      return
+    }
+
+    const words = originalText.split(/\s+/).filter(Boolean)
+    let visibleText = ""
+
+    for (let index = 0; index < words.length; index += 1) {
+      let nextText = words[index]
+
+      if (visibleText) {
+        nextText = `${visibleText} ${words[index]}`
+      }
+
+      text.textContent = `${nextText}${ELLIPSIS}`
+
+      if (this.isOverflowing(item)) {
+        break
+      }
+
+      visibleText = nextText
+    }
+
+    if (!visibleText) {
+      visibleText = this.truncateSingleWord(item, text, words[0] || "")
+    }
+
+    if (visibleText === originalText) {
+      text.textContent = visibleText
+    } else {
+      text.textContent = `${visibleText}${ELLIPSIS}`
+    }
+
+    item.setAttribute("title", originalText)
+  }
+
+  truncateSingleWord(item, text, word) {
+    let visibleText = ""
+
+    for (let index = 0; index < word.length; index += 1) {
+      text.textContent = `${visibleText}${word[index]}${ELLIPSIS}`
+
+      if (this.isOverflowing(item)) {
+        break
+      }
+
+      visibleText += word[index]
+    }
+
+    if (!visibleText && word) {
+      return word[0]
+    }
+
+    return visibleText
+  }
+
+  isOverflowing(element) {
+    return element.scrollWidth > element.clientWidth
+  }
+}

data/app/packs/src/decidim/controllers/form_validator/form_validator.js

@@ -419,13 +419,13 @@ class FormValidator {
       return true;
     }
 
-    checkboxGroup.forEach((checkboxElement) => {
-      if (isValid) {
-        this.removeInputErrorClasses(checkboxElement);
-      } else {
+    if (isValid) {
+      this.removeCheckboxGroupErrorClasses(groupName);
+    } else {
+      checkboxGroup.forEach((checkboxElement) => {
         this.addInputErrorClasses(checkboxElement, ["required"]);
-      }
-    });
+      });
+    }
 
     return isValid;
   }

data/app/packs/src/decidim/controllers/form_validator/form_validator.test.js

@@ -1,4 +1,4 @@
-/* eslint max-lines: ["error", 690] */
+/* eslint max-lines: ["error", 712] */
 /* global jest */
 /**
  * @jest-environment jsdom
@@ -253,6 +253,28 @@ describe("FormValidator", () => {
       const isValidTwo = validatorInstance.validateCheckboxGroup("multiCheckboxes");
       expect(isValidTwo).toBe(true);
     });
+
+    it("should remove error classes once for the group, not per checkbox", () => {
+      formElement.innerHTML = `
+        <fieldset>
+          <input type="checkbox" id="cb-1" name="largeGroup" value="1" required>
+          <input type="checkbox" id="cb-2" name="largeGroup" value="2" required>
+          <input type="checkbox" id="cb-3" name="largeGroup" value="3" required>
+        </fieldset>
+        <button type="submit">Submit</button>
+      `;
+      validatorInstance = new FormValidator(formElement);
+      formElement.querySelector("#cb-1").checked = true;
+
+      const removeGroupSpy = jest.spyOn(validatorInstance, "removeCheckboxGroupErrorClasses");
+      const removeInputSpy = jest.spyOn(validatorInstance, "removeInputErrorClasses");
+
+      const isValid = validatorInstance.validateCheckboxGroup("largeGroup");
+
+      expect(isValid).toBe(true);
+      expect(removeGroupSpy).toHaveBeenCalledTimes(1);
+      expect(removeInputSpy).not.toHaveBeenCalled();
+    });
   });
 
   describe("Custom Validators", () => {