decidim-core 0.28.1 → 0.28.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 800e096eb86537caa7de18236fe0becf73b1c30ee38e4631888025b52e831f3a
-  data.tar.gz: 9f05dfffcd55fcc9d4e76163a4b98c5b7e851bbdbcfe317f9a9566cb73a142d9
+  metadata.gz: 524ec4d380f620c07119a6ccbee1b28408f6072799aa32cd74a1836f1ede5070
+  data.tar.gz: 4e1b60ce9a2cb9e340b0db3a22f66b326ade8f05cb8551352b39fe4198a06bbb
 SHA512:
-  metadata.gz: 97568f03aab3b39a4b75e98421a5b9e43f30f8f1c71b548478f0ee2f73c6303981643948289f9483d9cfbe71af47b872bf3e3c49d39009270e9e3ef72e55bf70
-  data.tar.gz: 8fa7ecb28d0d2e8097124330aced622ac52fc96d6cc8d6039e629c897d29af8f79366e8992107a9d8b89c88280c723b667b345ccbc643d2326303f376abd243a
+  metadata.gz: c8ff8135707ab3ae9aa1d483cd41d104385c079e8dcbd575c3c618ae05c524c345b340bd4b82c47eccf533dc98e187985ba76ddb2293332977449ed8af95b4b3
+  data.tar.gz: 9188473aa2d7c440f2aa773e9e08824b2c847f8a29a6d1d1ff75900e9a2fd325f860d80d8faad5d2498dc594f20b92ad9e8f7e6b98551ba9f68ffe24a879dcc1

data/app/cells/decidim/announcement/show.erb

@@ -5,7 +5,7 @@
     </div>
   <% end %>
 
-  <span class="flash__message">
+  <div class="flash__message">
     <%= text %>
-  </span>
+  </div>
 <% end %>

data/app/cells/decidim/author/show.erb

@@ -1,16 +1,16 @@
 <% data = has_tooltip? ? { tooltip: render(:profile_minicard).html_safe } : nil %>
-<div class="author" data-author>
-  <%= content_tag :div, class: "author__container#{" is-compact" if layout == :compact}", data: do %>
+<span class="author" data-author>
+  <%= content_tag :span, class: "author__container#{" is-compact" if layout == :compact}", data: do %>
     <% if layout == :compact %>
       <%= render :avatar %>
 
-      <div>
+      <span>
         <%= render :name %>
 
         <% context_actions.each do |action| %>
           <%= render action %>
         <% end %>
-      </div>
+      </span>
     <% elsif layout == :avatar %>
       <%= render :avatar %>
     <% else %>
@@ -24,4 +24,4 @@
       <%= render action %>
     <% end %>
   <% end %>
-</div>
+</span>

data/app/cells/decidim/card/show.erb

@@ -1,5 +1,5 @@
 <div class="py-4 space-y-2">
-  <a href="" class="text-lg text-secondary font-semibold hover:underline"><%= title %></a>
+  <a href="" class="text-lg text-secondary font-semibold hover:underline"><%= decidim_html_escape(title) %></a>
   <div class="flex items-center divide-x divide-gray-3">
    <% metadata.first(4).each do |item| %>
     <div class="flex items-center gap-1 px-4 lg:px-6 first:pl-0 last:pr-0 max-w-xs">

data/app/cells/decidim/card_metadata/show.erb

@@ -3,12 +3,12 @@
     <% hook_output = render_hook(item[:hook]) %>
     <% next if hook_output.blank? %>
 
-    <%= content_tag :span, data: item[:data_attributes] do %>
+    <%= content_tag :div, data: item[:data_attributes] do %>
       <%= icon item[:icon] if item[:icon].present? %>
       <%= hook_output %>
     <% end %>
   <% else %>
-    <%= content_tag :span, data: item[:data_attributes] do %>
+    <%= content_tag :div, data: item[:data_attributes] do %>
       <%= icon item[:icon] if item[:icon].present? %>
       <% if item[:text].present? %>
         <%= link_to_if enable_links? && item.has_key?(:url), item[:text], item[:url] %>

data/app/cells/decidim/data_consent/category.erb

@@ -2,7 +2,7 @@
   <div class="cookies__category-trigger">
     <label for="dc-<%= category[:slug] %>" class="cookies__category-toggle">
       <input
-        <%= %(checked="checked") if category[:mandatory] %>
+        <%== %(checked="checked") if category[:mandatory] %>
         id="dc-<%= category[:slug] %>"
         type="checkbox"
         name="<%= category[:slug] %>"

data/app/cells/decidim/nav_links/show.erb

@@ -1,10 +1,10 @@
 <div class="participatory-space__nav-container">
-  <button id="dropdown-trigger-participatory-space" data-component="dropdown" data-target="dropdown-menu-participatory-space" data-auto-close="true" data-disabled-md="true" data-scroll-to-menu="true">
+  <button id="dropdown-trigger-participatory-space" data-component="dropdown" data-target="dropdown-menu-participatory-space" data-auto-close="true" data-scroll-to-menu="true">
     <span><%= t("decidim.searches.filters.jump_to") %></span>
     <%= icon "arrow-down-s-line" %>
     <%= icon "arrow-up-s-line" %>
   </button>
-  <ul id="dropdown-menu-participatory-space" class="participatory-space__nav">
+  <ul id="dropdown-menu-participatory-space" class="participatory-space__nav" aria-hidden="true">
     <% model.each do |item| %>
       <li>
         <%= link_to item[:url], class: "participatory-space__nav-item" do %>

data/app/cells/decidim/notification/moderated.erb

@@ -0,0 +1,12 @@
+<div class="notification" data-notification>
+  <div class="notification__wrapper">
+    <div class="notification__time" title="<%= l(notification.created_at) %>"> <%= notification.created_at_in_words %></div>
+    <div class="notification__snippet">
+      <span class="notification__snippet-title text-gray"><%= t("decidim.notifications.show.moderated") %></span>
+    </div>
+  </div>
+  <%= link_to model, remote: true, method: :delete, class: "notification__button", data: { "notification-read": "" } do %>
+    <span class="sr-only md:not-sr-only"><%= t("mark_as_read", scope: "layouts.decidim.notifications_dashboard") %></span>
+    <%= icon "check-line", class: "fill-current" %>
+  <% end %>
+</div>

data/app/cells/decidim/notification_cell.rb

@@ -9,7 +9,11 @@ module Decidim
     include Decidim::SanitizeHelper
 
     def show
-      render :show
+      if notification.event_class_instance.try(:hidden_resource?)
+        render :moderated
+      else
+        render :show
+      end
     end
 
     def notification_title

data/app/cells/decidim/profile/details.erb

@@ -9,7 +9,7 @@
         <%= icon detail[:icon] %>
         <span>
           <% if detail[:url].present? %>
-            <%= link_to(detail[:url], detail[:text]) %>
+            <%= link_to(detail[:url], detail[:text], rel: "nofollow noopener noreferrer") %>
           <% else %>
             <%= detail[:text] %>
           <% end %>

data/app/cells/decidim/progress_bar/show.erb

@@ -7,7 +7,7 @@
   <%= content_tag :div, units_name_text, class: "progress-bar__units" if units_name %>
 
   <% if total != 0 %>
-    <div class="progress-bar" role="progressbar" tabindex="0" aria-label="<%= units_name.present? ? units_name_text : t("decidim.shared.progress") %>" aria-valuenow="<%= percentage %>" aria-valuemin="0" aria-valuetext="<%= percentage %> %" aria-valuemax="<%= total %>">
+    <div class="progress-bar" role="progressbar" aria-label="<%= units_name.present? ? units_name_text : t("decidim.shared.progress") %>" aria-valuenow="<%= number_with_precision(percentage, separator: ".", precision: 2) %>" aria-valuemin="0" aria-valuemax="100" aria-valuetext="<%= number_to_percentage(percentage, precision: 2) %>">
       <div style="width: <%= percentage %>%"></div>
     </div>
   <% end %>

data/app/cells/decidim/progress_bar_cell.rb

@@ -29,6 +29,8 @@ module Decidim
   #      total: 10,
   #    )
   class ProgressBarCell < Decidim::ViewModel
+    include ActionView::Helpers::NumberHelper
+
     private
 
     def element_id

data/app/cells/decidim/report_button/flag_modal.erb

@@ -34,11 +34,15 @@
               <%= f.check_box :hide,
                               label: t("decidim.shared.flag_modal.hide_content"),
                               include_hidden: false,
+                              id: hide_checkbox_id,
                               data: {
                                 label_action: t("decidim.shared.flag_modal.hide"),
                                 label_report: t("decidim.shared.flag_modal.report"),
                                 hide: "true"
-                              }, id: hide_checkbox_id %>
+                              },
+                              label_options: {
+                                for: hide_checkbox_id
+                              } %>
             <% end %>
           <% end %>
 

data/app/cells/decidim/resource_types_filter/show.erb

@@ -1,5 +1,5 @@
 <div id="<%= id %>" class="filter-container">
-  <button id="dropdown-trigger-resource" data-component="dropdown" data-target="dropdown-menu-resource" data-auto-close="true" data-disabled-md="true">
+  <button id="dropdown-trigger-resource" data-component="dropdown" data-target="dropdown-menu-resource" data-auto-close="true">
     <% resource_types.each do |resource_type| %>
       <span data-value="<%= resource_type[0] %>" class="<%= "is-active" if filter_param == resource_type[0] %>">
         <%= text_with_resource_icon(*resource_type) %>
@@ -8,7 +8,7 @@
     <%= icon "arrow-down-s-line" %>
     <%= icon "arrow-up-s-line" %>
   </button>
-  <%= filter_form_for filter, form_path, class: "new_filter", id: "dropdown-menu-resource" do |form| %>
+  <%= filter_form_for filter, form_path, :class => "new_filter", :id => "dropdown-menu-resource", "aria-hidden" => true do |form| %>
     <%= form.collection_radio_buttons(
           filter_param_key,
           resource_types,
@@ -16,7 +16,7 @@
           :last,
           { checked: filter_param }
         ) do |builder|
-            builder.label { builder.radio_button(class: "reset-defaults", hidden: true) + content_tag(:div, text_with_resource_icon(builder.value, builder.text), class: "filter") }
+            builder.label { builder.radio_button(class: "reset-defaults", hidden: true) + content_tag(:span, text_with_resource_icon(builder.value, builder.text), class: "filter") }
       end %>
   <% end %>
 </div>

data/app/cells/decidim/statistic/show.erb

@@ -1,7 +1,7 @@
 <div class="statistic <%= stat_dom_class %>" data-statistic>
-  <h3 class="statistic__title" title="<%= stat_title %>">
+  <span class="statistic__title" title="<%= stat_title %>">
     <%= stat_title %>
-  </h3>
+  </span>
   <span class="statistic__number">
     <%= stat_number %>
   </span>

data/app/cells/decidim/upload_modal/modal.erb

@@ -37,10 +37,10 @@
             <%= icon "upload-cloud-2-line", class: "w-8 h-8 text-gray fill-current" %>
             <%= t("decidim.forms.upload_help.dropzone") %>
           </span>
-          <button class="button button__sm button__secondary" data-select-file-button>
+          <label class="button button__sm button__secondary" for="files-<%= modal_id %>">
             <span><%= t("decidim.forms.upload.select_file") %></span>
             <%= icon "arrow-right-line", class: "fill-current" %>
-          </button>
+          </label>
         </div>
       </div>
     </div>
@@ -60,8 +60,7 @@
     <%= t("decidim.shared.confirm_modal.cancel") %>
   </button>
   <button type="button" class="button button__sm md:button__lg button__secondary" data-dropzone-save data-dialog-close="<%= modal_id %>" disabled>
-    <%= t("next", scope: "decidim.messaging.conversations.index") %>
-    <%= icon "arrow-right-line", class: "fill-current" %>
+    <%= t("save", scope: "decidim.forms.upload.labels") %>
   </button>
 </div>
 <% end %>

data/app/controllers/concerns/decidim/force_authentication.rb

@@ -17,7 +17,7 @@ module Decidim
     # Breaks the request lifecycle, if user is not authenticated.
     # Otherwise returns.
     def ensure_authenticated!
-      return true unless current_organization.force_users_to_authenticate_before_access_organization
+      return true unless current_organization&.force_users_to_authenticate_before_access_organization
 
       # Next stop: Check whether auth is ok
       unless user_signed_in?

data/app/controllers/concerns/decidim/use_organization_time_zone.rb

@@ -25,7 +25,7 @@ module Decidim
       #
       # Returns a String.
       def organization_time_zone
-        @organization_time_zone ||= current_organization.time_zone
+        @organization_time_zone ||= current_organization&.time_zone
       end
     end
   end

data/app/controllers/decidim/gamification/badges_controller.rb

@@ -9,6 +9,8 @@ module Decidim
         @badges = Decidim::Gamification.badges.sort_by(&:name)
       end
 
+      private
+
       def breadcrumb_item
         {
           label: t("decidim.gamification.badges.index.title"),

data/app/controllers/decidim/links_controller.rb

@@ -14,7 +14,8 @@ module Decidim
     rescue_from URI::InvalidURIError, with: :modal
 
     def new
-      headers["X-Robots-Tag"] = "noindex"
+      headers["X-Robots-Tag"] = "none"
+      headers["Link"] = %(<#{url_for}>; rel="canonical")
     end
 
     private
@@ -36,7 +37,19 @@ module Decidim
     end
 
     def external_url
-      @external_url ||= URI.parse(URI::Parser.new.escape(params[:external_url]))
+      @external_url ||= URI.parse(escape_url(params[:external_url]))
+    end
+
+    def escape_url(external_url)
+      before_fragment, fragment = external_url.split("#", 2)
+      escaped_before_fragment = URI::Parser.new.escape(before_fragment)
+
+      if fragment
+        escaped_fragment = URI::Parser.new.escape(fragment)
+        "#{escaped_before_fragment}##{escaped_fragment}"
+      else
+        escaped_before_fragment
+      end
     end
   end
 end

data/app/helpers/concerns/decidim/flash_helper_extensions.rb

@@ -106,9 +106,9 @@ module Decidim
       end
 
       def message(value)
-        return content_tag(:span, value, class: "flash__message flex items-center") unless value.is_a?(Hash)
+        return content_tag(:div, value, class: "flash__message flex items-center") unless value.is_a?(Hash)
 
-        content_tag(:span, class: "flash__message") do
+        content_tag(:div, class: "flash__message") do
           concat value[:title]
           concat content_tag(:span, value[:body], class: "flash__message-body")
         end

data/app/helpers/decidim/check_boxes_tree_helper.rb

@@ -16,8 +16,7 @@ module Decidim
         include_hidden: false,
         label_options: {
           "data-children-checkbox": parent_id,
-          value:,
-          class: "filter"
+          value:
         }
       }
       options.merge!(checkbox_options)

data/app/mailers/decidim/application_mailer.rb

@@ -7,23 +7,57 @@ module Decidim
     include LocalisedMailer
     include MultitenantAssetHost
     after_action :set_smtp
+    after_action :set_from
 
     default from: Decidim.config.mailer_sender
     layout "decidim/mailer"
 
     private
 
+    attr_reader :organization
+
     def set_smtp
-      return if @organization.nil? || @organization.smtp_settings.blank?
+      return if organization.nil? || organization.smtp_settings.blank? || organization.smtp_settings.except("from", "from_label", "from_email").all?(&:blank?)
 
-      mail.from = @organization.smtp_settings["from"].presence || mail.from
       mail.reply_to = mail.reply_to || Decidim.config.mailer_reply
       mail.delivery_method.settings.merge!(
-        address: @organization.smtp_settings["address"],
-        port: @organization.smtp_settings["port"],
-        user_name: @organization.smtp_settings["user_name"],
-        password: Decidim::AttributeEncryptor.decrypt(@organization.smtp_settings["encrypted_password"])
+        address: organization.smtp_settings["address"],
+        port: organization.smtp_settings["port"],
+        user_name: organization.smtp_settings["user_name"],
+        password: Decidim::AttributeEncryptor.decrypt(organization.smtp_settings["encrypted_password"])
       ) { |_k, o, v| v.presence || o }.compact_blank!
     end
+
+    def set_from
+      return if organization.nil?
+      return if already_defined_name_in_mail?(mail.from.first)
+
+      mail.from = sender
+    end
+
+    def sender
+      return Decidim.config.mailer_sender if return_mailer_sender?
+      return default_sender if organization.smtp_settings.blank?
+      return default_sender if organization.smtp_settings["from"].nil?
+      return default_sender if organization.smtp_settings["from"].empty?
+
+      smtp_settings_from = organization.smtp_settings["from"]
+      return smtp_settings_from if already_defined_name_in_mail?(smtp_settings_from)
+
+      email_address_with_name(smtp_settings_from, organization.name)
+    end
+
+    def default_sender
+      email_address_with_name(Decidim.config.mailer_sender, organization.name)
+    end
+
+    def already_defined_name_in_mail?(mail_address)
+      # if there is an space, there is already a name in the address
+      mail_address.match?(/ /)
+    end
+
+    def return_mailer_sender?
+      already_defined_name_in_mail?(Decidim.config.mailer_sender) && organization.smtp_settings.present?
+    end
   end
 end

data/app/packs/src/decidim/a11y.js

@@ -104,6 +104,20 @@ const createDropdown = (component) => {
     });
   }
 
+  // Disable focus on children elements so we can pass the AXE accessibility tests
+  const dropdownMenu = document.getElementById(dropdownOptions.dropdown);
+  if (dropdownMenu.getAttribute("aria-hidden") === "true") {
+    dropdownMenu.
+      querySelectorAll("a, input, button").
+      forEach((element) => { element.tabIndex = -1 })
+  }
+
+  component.addEventListener("click", () => {
+    dropdownMenu.
+      querySelectorAll("a, input, button").
+      forEach((element) => { element.tabIndex = 0 })
+  })
+
   Dropdowns.render(component.id, dropdownOptions);
 }
 

data/app/packs/src/decidim/abide_form_validator_fixer.js

@@ -0,0 +1,44 @@
+/**
+ * This script modifies the behavior of Abide form validation to address the issue of form validation errors
+ * appearing prematurely in input fields.
+ *
+ * The primary goal is to hide error messages until the input field loses focus.
+ */
+
+class AbideFormValidatorFixer {
+  initialize() {
+    const forms = document.querySelectorAll("main [data-live-validate='true']");
+
+    forms.forEach((form) => {
+      if (this.isElementVisible(form)) {
+        this.setupForm(form);
+      }
+    });
+  }
+
+  isElementVisible(element) {
+    return element.offsetParent !== null && getComputedStyle(element).display !== "none";
+  }
+
+  setupForm(form) {
+    const inputs = form.querySelectorAll("input");
+
+    inputs.forEach((input) => {
+      const errorElement = input.closest("label")?.querySelector(".form-error") || input.parentElement.querySelector(".form-error");
+      if (!errorElement) {
+        return;
+      }
+      form.removeAttribute("data-live-validate");
+      input.addEventListener("input", this.hideErrorElement.bind(this, errorElement));
+    });
+  }
+
+  hideErrorElement(errorElement) {
+    errorElement.classList.remove("is-visible");
+  }
+}
+
+document.addEventListener("DOMContentLoaded", () => {
+  const validatorFixer = new AbideFormValidatorFixer();
+  validatorFixer.initialize();
+});

data/app/packs/src/decidim/direct_uploads/upload_modal.js

@@ -154,20 +154,16 @@ export default class UploadModal {
     // Disabled save button when any children have data-state="error"
     this.saveButton.disabled = Array.from(files).filter(({ dataset: { state } }) => state === STATUS.ERROR).length > 0;
 
-    const dataSelectFileButton = this.emptyItems.querySelector("[data-select-file-button]");
-
     // Only allow to continue the upload when the multiple option is true (default: false)
     const continueUpload = !files.length || this.options.multiple
     this.input.disabled = !continueUpload
     if (continueUpload) {
       this.emptyItems.classList.remove("is-disabled");
-      dataSelectFileButton.removeAttribute("disabled");
+      this.emptyItems.querySelector("label").removeAttribute("disabled");
     } else {
       this.emptyItems.classList.add("is-disabled");
-      dataSelectFileButton.disabled = true;
+      this.emptyItems.querySelector("label").disabled = true;
     }
-
-    dataSelectFileButton.addEventListener("click", () => this.input.click());
   }
 
   createUploadItem(file, errors, opts = {}) {

data/app/packs/src/decidim/index.js

@@ -50,6 +50,7 @@ import "src/decidim/impersonation"
 import "src/decidim/gallery"
 import "src/decidim/direct_uploads/upload_field"
 import "src/decidim/data_consent"
+import "src/decidim/abide_form_validator_fixer"
 import "src/decidim/sw"
 
 // local deps that require initialization
@@ -90,6 +91,33 @@ window.Decidim = window.Decidim || {
 
 window.morphdom = morphdom
 
+// REDESIGN_PENDING: deprecated
+window.initFoundation = (element) => {
+  $(element).foundation();
+
+  // Fix compatibility issue with the `a11y-accordion-component` package that
+  // uses the `data-open` attribute to indicate the open state for the accordion
+  // trigger.
+  //
+  // In Foundation, these listeners are initiated on the document node always,
+  // regardless of the element for which foundation is initiated. Therefore, we
+  // need the document node here instead of the `element` passed to this
+  // function.
+  const $document = $(document);
+
+  $document.off("click.zf.trigger", window.Foundation.Triggers.Listeners.Basic.openListener);
+  $document.on("click.zf.trigger", "[data-open]", (ev, ...restArgs) => {
+    // Do not apply for the accordion triggers.
+    const accordion = ev.currentTarget?.closest("[data-component='accordion']");
+    if (accordion) {
+      return;
+    }
+
+    // Otherwise call the original implementation
+    Reflect.apply(window.Foundation.Triggers.Listeners.Basic.openListener, ev.currentTarget, [ev, ...restArgs]);
+  });
+};
+
 Rails.start()
 
 /**
@@ -104,7 +132,7 @@ const initializer = (element = document) => {
   window.focusGuard = window.focusGuard || new FocusGuard(document.body);
 
   // REDESIGN_PENDING: deprecated
-  $(element).foundation();
+  window.initFoundation(element);
 
   svg4everybody();
 

data/app/packs/stylesheets/decidim/_accordion.scss

@@ -4,10 +4,10 @@
 
 [data-component="accordion"]
   [id*="comment"][class="comment-reply"][aria-hidden="true"] {
-  display: block;
+  display: none;
 }
 
 [data-component="accordion"]
   [id*="comment"][class="comment-reply"][aria-hidden="false"] {
-  display: none;
+  display: block;
 }

data/app/packs/stylesheets/decidim/_cards.scss

@@ -134,7 +134,7 @@
     &-month,
     &-day,
     &-year {
-      @apply inline-flex items-center justify-evenly empty:[&>span]:hidden;
+      @apply inline-flex items-center justify-evenly empty:[&>div]:hidden;
     }
   }
 
@@ -143,7 +143,7 @@
   &__list-metadata {
     @apply mt-auto inline-flex flex-wrap gap-x-4 md:gap-0;
 
-    & > span {
+    & > div {
       @apply inline-flex items-center gap-1 px-0 md:px-6 border-gray-3 border-0 md:border-r first:pl-0 last:pr-0 last:border-r-0 text-sm text-gray-2;
 
       & > svg {

data/app/packs/stylesheets/decidim/_layout.scss

@@ -6,7 +6,7 @@
   }
 
   [data-content] {
-    @apply min-h-[60vh] relative flex flex-col;
+    @apply relative flex flex-col;
   }
 }
 
@@ -31,14 +31,14 @@
 }
 
 .layout-2col {
-  @apply md:grid grid-cols-12 container grow min-h-[60vh];
+  @apply md:grid grid-cols-12 container grow auto-rows-max;
 
   &__aside {
     @apply col-span-4 lg:col-span-3 md:pr-16 py-6 md:py-12 gap-6 md:gap-12 flex flex-col justify-between items-start md:justify-start before:content-[''] before:absolute before:top-0 before:left-0 before:h-full before:w-1/2 before:-z-10 md:before:bg-background;
   }
 
   &__main {
-    @apply col-span-8 lg:col-span-9 bg-white md:pl-16 py-6 md:py-12;
+    @apply col-span-8 lg:col-span-9 bg-white md:pl-16 py-6 md:py-12 min-h-[60vh];
   }
 
   &__reverse &__aside {

data/app/packs/stylesheets/decidim/_modal_update.scss

@@ -28,9 +28,7 @@
           @apply w-24 flex-none flex justify-center;
         }
 
-        img:not([src^="data:image"]):not(
-            [src^="data:application/octet-stream"]
-          ) {
+        img[src="data:,"] {
           @apply hidden;
         }
 

data/app/presenters/decidim/admin_log/organization_presenter.rb

@@ -26,7 +26,7 @@ module Decidim
 
       def settings_attributes_mapping
         {
-          name: :string,
+          name: :i18n,
           default_locale: :locale,
           reference_prefix: :string,
           twitter_handler: :string,

data/app/presenters/decidim/log/resource_presenter.rb

@@ -10,6 +10,8 @@ module Decidim
     # overwrite `BasePresenter#resource_presenter` to return your custom resource presenter.
     # The only requirement for custom renderers is that they should respond to `present`.
     class ResourcePresenter
+      include Decidim::SanitizeHelper
+
       # Public: Initializes the presenter.
       #
       # resource - An instance of a model that can be located by
@@ -65,7 +67,11 @@ module Decidim
       #
       # Returns an HTML-safe String.
       def present_resource_name
-        h.translated_attribute extra["title"]
+        if resource.present? && resource.respond_to?(:presenter) && resource.presenter.respond_to?(:title)
+          resource.presenter.title(html_escape: true)
+        else
+          decidim_escape_translated(extra["title"]).html_safe
+        end
       end
     end
   end

data/app/services/decidim/log/diff_changeset_calculator.rb

@@ -86,7 +86,7 @@ module Decidim
         locales.flat_map do |locale|
           previous_value = values.first.try(:[], locale)
           new_value = values.last.try(:[], locale)
-          if previous_value == new_value
+          if previous_value == new_value || (previous_value.nil? && new_value.blank?)
             nil
           else
             label = generate_label(attribute, locale)