debride 1.8.0 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9997dcf31c73430147cd74d4365cacc011a9ddf9
-  data.tar.gz: 0d52faa989d72642bfc90eb59efe69c1eb29bd85
+  metadata.gz: 6c48bfb811ddf65ebb59e059f86fdc044a6fee24
+  data.tar.gz: ca159205e89ef9ad140c609a54d5b9e1f5e5d9ab
 SHA512:
-  metadata.gz: '090808da18149228a64261245d549cb50fa78141b73428a913fe606b61f700bec4ada3de220c5b9ff01e48b1f15f94daa93a4296f570d8da65f6cea7bf53e124'
-  data.tar.gz: 73af8d47c93780a568590bc7bf34b4ff4df80dd6ce9e877d01347b232ca2907274b7d1cb4b090481a5aaab13e23f2e3575324a02e9f49c10bffb513c7817086b
+  metadata.gz: d50c5b8b1b7f9d93fcd749fbf54ed1498d0cf119e1cb69040d68613af87d3724b4bed9e3fdb542d81652da79379fa05b02b6e2f894de7c0f80c3f58440c1616d
+  data.tar.gz: a494099a812064e03a10f8ff6820a02321c9f36985df86b3dabeaf068c2feced7b9b7b91c70509c6e8edd215810042ac0ba1f1e950dfd38c312b3ab65b8959dd

checksums.yaml.gz.sig

@@ -1,2 +1 @@
-����⫤MdW�r
-�ߖ�t�!N��
+|��+S�s���p�S&�xRLs��\�ro�y�7��G}X1�q�S໅6?V+���q����-w�&��V8B���<�E��_� va2E��Qs�t�^����S�v�!X݈��oy�݆�|?���	���Y.V��4�;Xs���څ��<Аʹ�YvM�T�����Kq�!7 

data.tar.gz.sig

@@ -1,2 +1,2 @@
-����v�|	$����c������>�D{=�\�U��\���V�!�*�譡#߂��$�&W���9�фIt~�}����q�.�A�Vճ`RK��N�S�s
-tW������M�4�r&�pv�ZK�f�G�
=�����0x�K��Q!���	uz�(8�`�eE@�}8���S��u/-,��]LjJ�xn଑q�|#
+�Fc�;�eiBV[+�,j�ݎ
+�_C�'�g*D���XQ�~����P�����]l}խ�N�������g-�B��JO*��w��[/q$v�N}�ؑ�2E����U��e�@}H�Dw�C����)�^�t��u�ԯ�'F~�q�

data/History.rdoc

@@ -1,3 +1,15 @@
+=== 1.8.1 / 2017-11-29
+
+* 2 minor enhancements:
+
+  * Add basic support for jbuilder files. (d-mato)
+  * Added rails & whitelist example to readme. (TheRusskiy)
+
+* 2 bug fixes:
+
+  * Capture RegexpError and skip file. (mrdShinse)
+  * Fixed reporting of cdecl+const2 (eg X::Y = 42). (herwinw)
+
 === 1.8.0 / 2017-05-09
 
 * 1 minor enhancement:

data/README.rdoc

@@ -42,6 +42,21 @@ API), then you can whitelist it:
   MyClass
     bad_method                          lib/some/file.rb:20
   ...
+  
+Usage example for a typical rails application:
+  # dump rake routes into a file
+  % rake routes > routes.txt
+  # generate whitelist based on routes and usages from production log
+  % debride_rails_whitelist routes.txt log/production.log | sort -u > whitelist.txt
+  # add migration methods
+  % echo up >> whitelist.txt
+  % echo down >> whitelist.txt
+  % echo change >> whitelist.txt
+  # output debride report co standard output with the following options:
+  # ignore typical rails methods, 
+  # specify generated whitelist,
+  # run in current directory (".")
+  % debride --rails --whitelist whitelist.txt .
 
 You can also use regexps in your whitelist by delimiting them with //'s.
 

data/lib/debride.rb

@@ -22,7 +22,7 @@ end
 # A static code analyzer that points out possible dead methods.
 
 class Debride < MethodBasedSexpProcessor
-  VERSION = "1.8.0" # :nodoc:
+  VERSION = "1.8.1" # :nodoc:
   PROJECT = "debride"
 
   def self.load_plugins proj = PROJECT
@@ -50,7 +50,7 @@ class Debride < MethodBasedSexpProcessor
   end
 
   def self.file_extensions
-    %w[rb rake] + load_plugins
+    %w[rb rake jbuilder] + load_plugins
   end
 
   ##
@@ -108,7 +108,7 @@ class Debride < MethodBasedSexpProcessor
 
       rp = RubyParser.for_current_ruby rescue RubyParser.new
       rp.process(file, path, option[:timeout])
-    rescue Racc::ParseError => e
+    rescue Racc::ParseError, RegexpError => e
       warn "Parse Error parsing #{path}. Skipping."
       warn "  #{e.message}"
     rescue Timeout::Error
@@ -296,6 +296,9 @@ class Debride < MethodBasedSexpProcessor
 
   def process_cdecl exp # :nodoc:
     _, name, val = exp
+
+    name = name_to_string process name if Sexp === name
+
     process val
 
     signature = "#{klass_name}::#{name}"
@@ -307,6 +310,19 @@ class Debride < MethodBasedSexpProcessor
     exp
   end
 
+  def name_to_string exp
+    case exp.sexp_type
+    when :colon2 then
+      _, (_, lhs), rhs = exp
+      "#{lhs}::#{rhs}"
+    when :colon3 then
+      _, rhs = exp
+      "::#{rhs}"
+    else
+      raise "Not handled: #{exp.inspect}"
+    end
+  end
+
   def process_colon2 exp # :nodoc:
     _, lhs, name = exp
     process lhs

data/test/test_debride.rb

@@ -186,6 +186,26 @@ class TestDebride < Minitest::Test
     assert_process exp, ruby, :rails => true
   end
 
+  def test_cdecl_const2
+    ruby = <<-RUBY.strip
+      class Z
+        X::Y = 42
+      end
+    RUBY
+
+    assert_process [["Z", ["X::Y"]]], ruby
+  end
+
+  def test_cdecl_const3
+    ruby = <<-RUBY.strip
+      class Z
+        ::Y = 42
+      end
+    RUBY
+
+    assert_process [["Z", ["::Y"]]], ruby
+  end
+
   def test_method_send
     ruby = <<-RUBY.strip
       class Seattle

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: debride
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.1
 platform: ruby
 authors:
 - Ryan Davis
@@ -10,9 +10,9 @@ bindir: bin
 cert_chain:
 - |
   -----BEGIN CERTIFICATE-----
-  MIIDijCCAnKgAwIBAgIBATANBgkqhkiG9w0BAQUFADBFMRMwEQYDVQQDDApyeWFu
+  MIIDPjCCAiagAwIBAgIBAjANBgkqhkiG9w0BAQUFADBFMRMwEQYDVQQDDApyeWFu
   ZC1ydWJ5MRkwFwYKCZImiZPyLGQBGRYJemVuc3BpZGVyMRMwEQYKCZImiZPyLGQB
-  GRYDY29tMB4XDTE2MDkyNjAxNTczNVoXDTE3MDkyNjAxNTczNVowRTETMBEGA1UE
+  GRYDY29tMB4XDTE3MTEyMTIxMTExMFoXDTE4MTEyMTIxMTExMFowRTETMBEGA1UE
   AwwKcnlhbmQtcnVieTEZMBcGCgmSJomT8ixkARkWCXplbnNwaWRlcjETMBEGCgmS
   JomT8ixkARkWA2NvbTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCCAQoCggEBALda
   b9DCgK+627gPJkB6XfjZ1itoOQvpqH1EXScSaba9/S2VF22VYQbXU1xQXL/WzCkx
@@ -20,17 +20,16 @@ cert_chain:
   oOvjtt5P8+GSK9zLzxQP0gVLS/D0FmoE44XuDr3iQkVS2ujU5zZL84mMNqNB1znh
   GiadM9GHRaDiaxuX0cIUBj19T01mVE2iymf9I6bEsiayK/n6QujtyCbTWsAS9Rqt
   qhtV7HJxNKuPj/JFH0D2cswvzznE/a5FOYO68g+YCuFi5L8wZuuM8zzdwjrWHqSV
-  gBEfoTEGr7Zii72cx+sCAwEAAaOBhDCBgTAJBgNVHRMEAjAAMAsGA1UdDwQEAwIE
-  sDAdBgNVHQ4EFgQUR8V72Z3+v+2P9abCnL4wjx32T+EwIwYDVR0RBBwwGoEYcnlh
-  bmQtcnVieUB6ZW5zcGlkZXIuY29tMCMGA1UdEgQcMBqBGHJ5YW5kLXJ1YnlAemVu
-  c3BpZGVyLmNvbTANBgkqhkiG9w0BAQUFAAOCAQEAIGzgp0aZ2W9+v96ujmBcQHoC
-  buy0iU68MVj2VlxMyfr1KPZIh1OyhU4UO4zrkREcH8ML70v9cYHNvOd9oynRHnvC
-  l2tj/fD3YJ0AEkJxGrYwRWQmvMfC4bJ02bC1+rVOUIXXKp3+cUmiN4sTniof8VFo
-  bo/YYP4c7erpERa+9hrqygg6WQbJlk2YRlH3JXPFjmu869i2dcbR5ZLOAeEy+axH
-  E4oJcnPkJAr0rw504JGtlZtONZQblwmRJOIdXzolaE3NRGUzGVOUSptZppAKiavY
-  fO6tdKQc/5RfA8oQEkg8hrxA5PQSz4TOFJGLpFvIapEk6tMruQ0bHgkhr9auXg==
+  gBEfoTEGr7Zii72cx+sCAwEAAaM5MDcwCQYDVR0TBAIwADALBgNVHQ8EBAMCBLAw
+  HQYDVR0OBBYEFEfFe9md/r/tj/Wmwpy+MI8d9k/hMA0GCSqGSIb3DQEBBQUAA4IB
+  AQAfAXSQpsW7YSxd1csRtA/M4Zt0AMXFMd76GJ8Lgtg8G0+VFbdChRyDuDb0kPlW
+  h9QQX/YABfCW8vxmssbMGrP+VGBAn7BbdTcfTlgCWrvMX1uL5aRL74nA4urKXqdW
+  a0nP70K4958P3GffBdtE3KGkU5xstFnXGajxuBRnL66E15KU0BNehVxdG258bdPu
+  EKN6MqBPftFiev3tuwqDV11r2GquDpniYcT+Mi8/PgeAgVT/afBeVgbB3KaZeTRR
+  AhXhF6Wi2GTMezlj5jlI5XV7WsJUSwTp/YiVvcmT74ZaCRvexm6EnNhkrvJJ1Xeu
+  V+HB+LYYhXWitInO/eXxDrFB
   -----END CERTIFICATE-----
-date: 2017-05-09 00:00:00.000000000 Z
+date: 2017-11-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sexp_processor
@@ -147,7 +146,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Analyze code for potentially uncalled / dead methods, now with auto-removal.