debride 1.14.0 → 1.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3a714288d6ecf460fcc966b8affc300f4bfe72da8e7d955e1345d757fbe389e9
-  data.tar.gz: '0608d18319513d0193482b503def7a86b7fc1544dfffb1048849d74b0b0d1728'
+  metadata.gz: 77baff9dbc4bab278d0e6b6fe16772ecdce26b00c4c7b24469e0680f0d608c41
+  data.tar.gz: 885b6274f63f3d76c6a106543d28be50f177fcc6fa6adad7cf642c0b3ef7f0d8
 SHA512:
-  metadata.gz: c7faa53a9d8aaa8e1f6bb5673ac7619a357a34d75636eaaab43fc017814cac33805dcb0904385d19a4e1d32b95ccc6a01877083a379ee74e6c91847b4713e278
-  data.tar.gz: ec449e3d4d5bdae20271e58d54da4dce6050866e56493d68f7ce236bb7829e51f342185576c5a772ee6e140e1855557598bd9062c5b9cc6f4d2112ea3fc16ed7
+  metadata.gz: 421c0cb4b4aa45ed2e7897254549def50af4f4491a029676bcc7671aa026e8cda45b9774073eef8d3bffa15665f7df0466e1b6a68f236fc0b0c2ee12806461a5
+  data.tar.gz: 2cc4e04095596764513090fffe356835d3af36c192395dbe7753470801e623f826bf72c54371de30bf1d9006d4cf109809cffc1419e887607914623cc8a1bb82

data/History.rdoc

@@ -1,3 +1,18 @@
+=== 1.15.0 / 2026-01-02
+
+* 1 minor enhancement:
+
+  * Added process_hash to handle hash shortcut syntax in case it is a call. (TSMMark)
+
+* 6 bug fixes:
+
+  * Bump prism dependency to 1.7+.
+  * Load debride with require_relative in bin/debride.
+  * Minor fixes for prism 1.7 and ruby 4.0.
+  * Oops! Fixed --legacy option definition.
+  * Properly handle scope/alias_method with interoplation. (alagos)
+  * Removed prism patches now that they've been upstreamed.
+
 === 1.14.0 / 2025-12-11
 
 * 2 minor enhancements:

data/Rakefile

@@ -11,7 +11,7 @@ Hoe::add_include_dirs("../../sexp_processor/dev/lib",
                       "../../path_expander/dev/lib",
                       "lib")
 
-Hoe.plugin :isolate
+Hoe.plugin :isolate_binaries
 Hoe.plugin :seattlerb
 Hoe.plugin :rdoc
 Hoe.plugin :cov
@@ -21,7 +21,7 @@ Hoe.spec "debride" do
   license "MIT"
 
   dependency "sexp_processor", "~> 4.17"
-  dependency "prism",          "~> 1.5"
+  dependency "prism",          "~> 1.7"
   dependency "path_expander",  "~> 2.0"
 end
 

data/bin/debride

@@ -1,5 +1,5 @@
 #!/usr/bin/env -S ruby -w
 
-require "debride"
+require_relative "../lib/debride"
 
 Debride.run(ARGV).report

data/lib/debride.rb

@@ -3,6 +3,7 @@
 require "optparse"
 require "set"
 require "stringio"
+require "timeout"
 
 require "sexp_processor"
 require "path_expander"
@@ -10,13 +11,6 @@ require "path_expander"
 require "prism"
 require "prism/translation/ruby_parser"
 
-unless Prism::Translation::RubyParser.method_defined? :process then
-  class Prism::Translation::RubyParser # compatibility layer
-    def process(ruby, file, timeout=nil) =
-      Timeout.timeout(timeout) { parse ruby, file }
-  end
-end
-
 class NotRubyParser < Prism::Translation::RubyParser # compatibility layer
 end
 
@@ -24,7 +18,7 @@ end
 # A static code analyzer that points out possible dead methods.
 
 class Debride < MethodBasedSexpProcessor
-  VERSION = "1.14.0" # :nodoc:
+  VERSION = "1.15.0" # :nodoc:
   PROJECT = "debride"
 
   def self.load_plugins proj = PROJECT
@@ -108,8 +102,8 @@ class Debride < MethodBasedSexpProcessor
     end
 
     parser = option[:parser].new
-    parser.process(file, path, option[:timeout])
-  rescue Racc::ParseError, RegexpError => e
+    parser.process file, path, option[:timeout]
+  rescue RubyParser::SyntaxError, RegexpError => e
     warn "Parse Error parsing #{path}. Skipping."
     warn "  #{e.message}"
   rescue Timeout::Error
@@ -172,7 +166,7 @@ class Debride < MethodBasedSexpProcessor
         options[:minimum] = n
       end
 
-      opts.on "--legacy" "Use RubyParser for parsing." do
+      opts.on "--legacy", "Use RubyParser for parsing." do
         require "ruby_parser"
         option[:parser] = RubyParser
       end
@@ -349,27 +343,30 @@ class Debride < MethodBasedSexpProcessor
       end
     when *RAILS_MACRO_METHODS
       # s(:call, nil, :has_one, s(:lit, :has_one_relation), ...)
-      _, _, _, (_, name), * = sexp
+      _, _, _, name, * = sexp
 
       # try to detect route scope vs model scope
       if context.include? :module or context.include? :class then
-        file, line = sexp.file, sexp.line
-        record_method name, file, line
+        if string_like? name then
+          file, line = sexp.file, sexp.line
+          record_method name.last, file, line
+        end
       end
     when /_path$/ then
       method_name = method_name.to_s.delete_suffix("_path").to_sym if option[:rails]
     when /^deliver_/ then
       method_name = method_name.to_s.delete_prefix("deliver_").to_sym if option[:rails]
     when :alias_method then
+      # s(:call, nil, :alias_method, lhs, rhs)
       _, _, _, lhs, rhs = sexp
 
-      if Sexp === lhs and Sexp === rhs then
-        lhs = lhs.last
-        rhs = rhs.last
+      if string_like? lhs and string_like? rhs then
+        lhs = lhs.last.to_sym
+        rhs = rhs.last.to_sym
 
         record_method lhs, sexp.file, sexp.line
 
-        called << rhs
+        called << rhs # TODO: why?
       end
     end
 
@@ -380,6 +377,10 @@ class Debride < MethodBasedSexpProcessor
     sexp
   end
 
+  def string_like? s
+    Sexp === s and %i[lit str].include?(s.sexp_type)
+  end
+
   def process_alias exp
     _, (_, lhs), (_, rhs) = exp
 
@@ -482,6 +483,21 @@ class Debride < MethodBasedSexpProcessor
 
   alias process_safe_call process_call
 
+  def process_hash sexp
+    _, *pairs = sexp
+
+    pairs.each_slice 2 do |k, v|
+      if v.nil? && k.sexp_type == :lit then
+        called << k.last
+      else
+        process k
+        process v
+      end
+    end
+
+    sexp
+  end
+
   ##
   # Calculate the difference between known methods and called methods.
 

data/test/test_debride.rb

@@ -20,6 +20,7 @@ class TestDebride < Minitest::Test
                 :process_const,
                 :process_defn,
                 :process_defs,
+                :process_hash,
                 :process_op_asgn2,
                 :process_rb,
                 :process_safe_call,
@@ -46,13 +47,15 @@ class TestDebride < Minitest::Test
     assert_equal exp_arg, arg
   end
 
-  def assert_process exp, ruby, opts = {}
+  def assert_process exp, ruby, called:nil, **opts
     io = StringIO.new ruby
 
     debride = Debride.new opts
     debride.process debride.process_rb io
 
     assert_equal exp, debride.missing
+    assert_equal Set[*called], debride.called if called
+
     debride
   end
 
@@ -240,6 +243,40 @@ class TestDebride < Minitest::Test
     assert_process [], s
   end
 
+  def test_call__alias_method__symbol
+    ruby = <<~'RUBY'
+      class QuarterPounder
+        alias_method :get_x, :x
+      end
+    RUBY
+
+    exp = [["QuarterPounder", [:get_x]]]
+
+    assert_process exp, ruby, called:%i[x alias_method]
+  end
+
+  def test_call__alias_method__string
+    ruby = <<~'RUBY'
+      class QuarterPounder
+        alias_method "get_x", "x"
+      end
+    RUBY
+
+    exp = [["QuarterPounder", [:get_x]]]
+
+    assert_process exp, ruby, called:%i[x alias_method]
+  end
+
+  def test_call__alias_method__interpolated
+    ruby = <<~'RUBY'
+      class QuarterPounder
+        alias_method "get_#{integr}", integr
+      end
+    RUBY
+
+    assert_process [], ruby, called:%i[integr alias_method]
+  end
+
   def test_alias_method_chain
     ruby = <<-RUBY.strip
       class QuarterPounder
@@ -352,6 +389,42 @@ class TestDebride < Minitest::Test
     assert_process [], ruby
   end
 
+  def test_hash__shorthand
+    ruby = <<-RUBY.strip
+      class Seattle
+        def self.status
+          { raining: }
+        end
+
+        def self.raining
+          true
+        end
+      end
+
+      Seattle.status
+    RUBY
+
+    assert_process [], ruby
+  end
+
+  def test_hash__not_shorthand
+    ruby = <<-RUBY.strip
+      class Seattle
+        def self.status
+          { missing: }
+        end
+
+        def self.raining
+          true
+        end
+      end
+
+      Seattle.status
+    RUBY
+
+    assert_process [["Seattle", [:raining]]], ruby
+  end
+
   def test_safe_navigation_operator
     ruby = <<-RUBY.strip
       class Seattle
@@ -412,7 +485,7 @@ class TestDebride < Minitest::Test
   end
 
   def test_rails_dsl_macro_definitions
-    ruby = <<-RUBY.strip
+    ruby = <<~'RUBY'
       class RailsModel
         has_one :has_one_relation
         has_one :uncalled_has_one_relation
@@ -424,6 +497,9 @@ class TestDebride < Minitest::Test
         has_and_belongs_to_many :uncalled_has_and_belongs_to_many_relation
         scope :scope_method
         scope :uncalled_scope_method
+        scope :"interpolated_#{method}"
+        scope "another_#{method}"
+        scope "yet_another_#{method}".to_sym
 
         def instance_method_caller
           has_one_relation

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: debride
 version: !ruby/object:Gem::Version
-  version: 1.14.0
+  version: 1.15.0
 platform: ruby
 authors:
 - Ryan Davis
@@ -50,14 +50,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.5'
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: path_expander
   requirement: !ruby/object:Gem::Requirement
@@ -78,20 +78,20 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7'
+        version: '8'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -112,14 +112,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.3'
+        version: '4.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.3'
+        version: '4.5'
 description: Analyze code for potentially uncalled / dead methods, now with auto-removal.
 email:
 - ryand-ruby@zenspider.com