debmirrorapi 0.1.2 → 0.1.3

data/lib/debmirrorapi.rb

@@ -81,7 +81,7 @@ class DebmirrorApi < Sinatra::Base
     requested_mirror = params[:splat][0]
     requested_dist = params[:splat][1]
     requested_tag = params[:splat][2]
-    if params['version'] =~ /\d+/
+    if params['version']
       requested_tag_version = params['version']
     else
       body 'missing version in patch data'.to_json
@@ -91,6 +91,9 @@ class DebmirrorApi < Sinatra::Base
     tag_dir = File.join("/var/lib/debmirror/", requested_mirror, "dists", requested_dist)
     if mirror_list.include?(requested_mirror) and requested_dist !=~ /\/..\// and File.symlink?(requested_tag_file)
       requested_tag_version_file = File.join("/var/lib/debmirror/", requested_mirror, "dists", requested_dist, requested_tag_version)
+      if requested_tag_version !~ /^\d+$/
+        halt 405
+      end
       if File.exists?(requested_tag_version_file) and not File.symlink?(requested_tag_version_file)
         File.link(requested_tag_version_file, requested_tag_file)
         response = {}

data/spec/api_spec.rb

@@ -181,6 +181,13 @@ describe "Debmirror-API" do
       last_response.status.should == 405
     end
 
+    it "should respond with method not allowed if version is not an integer" do
+      File.stub(:exists?).with('/var/lib/debmirror/repo.percona.com/apt/dists/squeeze/20') { false }
+      patch '/tag/repo.percona.com/apt/dist/squeeze/stable', :version => '20i'
+      last_response.should_not be_ok
+      last_response.status.should == 405
+    end
+
     it "should respond with 404 if release_tag is not a valid tag" do
       patch '/tag/repo.percona.com/apt/dist/squeeze/bullshit', :version => 4
       last_response.should_not be_ok

data/spec/fixtures/mirror.index

@@ -0,0 +1,10 @@
+repo.percona.com/apt/debian/dists/squeeze
+downloads-distro.mongodb.org/repo/debian-sysvinit
+packages.vpn.jimdo-server.com/
+deb.theforeman.org/
+ftp.uk.debian.org/debian-backports
+security.debian.org/
+ftp.uk.debian.org/debian
+repo.percona.com/apt
+archive.debian.org/debian-archive/debian
+apt.newrelic.com/debian

data/spec/spec_helper.rb

@@ -0,0 +1,24 @@
+require 'simplecov'
+SimpleCov.start do
+  add_filter '/spec/'
+end
+
+require File.join(File.dirname(__FILE__), '..', 'lib', 'debmirrorapi.rb')
+require File.join(File.dirname(__FILE__), '..', 'lib', 'debmirrorapihelpers.rb')
+
+require 'rspec'
+require 'rack/test'
+
+# setup test environment
+set :environment, :test
+set :run, false
+set :raise_errors, true
+set :logging, false
+
+def app
+  DebmirrorApi
+end
+
+RSpec.configure do |config|
+  config.include Rack::Test::Methods
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: debmirrorapi
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-13 00:00:00.000000000 Z
+date: 2013-03-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sinatra
@@ -144,6 +144,8 @@ files:
 - config.ru
 - spec/api_spec.rb
 - spec/debmirrorapihelpers_spec.rb
+- spec/fixtures/mirror.index
+- spec/spec_helper.rb
 homepage: http://github.com/Jimdo/debmirror-api
 licenses: []
 post_install_message: 
@@ -171,3 +173,5 @@ summary: Simple API to provide an interface to debmirror.
 test_files:
 - spec/api_spec.rb
 - spec/debmirrorapihelpers_spec.rb
+- spec/fixtures/mirror.index
+- spec/spec_helper.rb