debitech_soap 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 612d31c258c331bf8992dc12ad8e1985b71d6632
-  data.tar.gz: cc3de7baad1153bc602b514e35cfbe27647a8a5e
+  metadata.gz: 27d41ad832b2eba41d08b3aa17b750a104fe92d9
+  data.tar.gz: e55ad817106d4bf04ffd0c84b9a3926aebc9119f
 SHA512:
-  metadata.gz: 0be2a047692d1fd006f5fda7e1cf00ed667169834c0149e1f32bb8edd0efbc036ab0fa3f8bdf6e63bed984cb74ce4421e1e30b8a9c41b274acdf4936f0d68774
-  data.tar.gz: dfd24f8a6b2f5e514dd2edc799e8795d26c0d560360658631d6cdad2d25ec7328fa160f46b3346e3d60eddf0319faeeca405f296077c6d46f333336a540be076
+  metadata.gz: 6e05d146e4c3f7ded0a9fc6fe19edfa3ce6c838368db5b1b58cca9b1600cec63d3510440f9064bfacdbb8d75d947ff4622ef0c805da924c82b53cec570f4b991
+  data.tar.gz: fcf23bc8f637d58d2d42bbd17c7f43576d462b5c888a3cf54beab2e92f6e91c5f2b4496526d56d6f3792cb829c1d44f976db7703fb9e94fccde2d97c1772065b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    debitech_soap (1.0.3)
+    debitech_soap (1.1.1)
       httpclient (>= 2.4.0)
       mumboe-soap4r (~> 1.5.8.4)
 
@@ -13,7 +13,7 @@ GEM
       thor (~> 0.14.6)
     guard-rspec (0.5.0)
       guard (>= 0.8.4)
-    httpclient (2.4.0)
+    httpclient (2.8.3)
     mumboe-soap4r (1.5.8.7)
       httpclient (>= 2.1.1)
     rake (0.9.2)
@@ -36,3 +36,6 @@ DEPENDENCIES
   guard-rspec
   rake
   rspec
+
+BUNDLED WITH
+   1.15.4

data/lib/debitech_soap/api.rb

@@ -40,6 +40,9 @@ module DebitechSoap
         @client = SOAP::WSDLDriverFactory.new(File.join(File.dirname(__FILE__), "../service.wsdl")).create_rpc_driver
       end
 
+      # Uncomment this line if you want to see the request and response printed to STDERR.
+      #@client.wiredump_dev = STDERR
+
       # Enable changing supported ciphers, for deprecation situations like http://tech.dibspayment.com/nodeaddpage/listofapprovedciphersuites.
       # This lets us easily experiment in development, and to do quick changes in production if we must.
       dibs_httpclient_ciphers = ENV["DIBS_HTTPCLIENT_CIPHERS"]
@@ -53,7 +56,21 @@ module DebitechSoap
 
     def valid_credentials?
       disable_stderr do
-        return_value(@client.checkSwedishPersNo(@api_credentials.merge({ :persNo => "5555555555" }))) == "true"
+        # We make a "refund" request, but we make sure to set the amount to 0 and to enter a verify ID that will never match a real one.
+        # Previously, we'd confirm credentials with the safer checkSwedishPersNo call, but that seems broken now (always returns false).
+        response_value = return_value(@client.refund(@api_credentials.merge({ :verifyID => -1, :amount => 0 })))
+        result_text = response_value.resultText
+
+        case result_text
+        when "error_transID_or_verifyID"
+          # The auth succeeded, but the refund (thankfully and intentionally) did not.
+          true
+        when "336 web_service_login_failed"
+          # The auth is wrong.
+          false
+        else
+          raise "Unexpected result text: #{result_text.inspect}"
+        end
       end
     end
 

data/lib/debitech_soap/version.rb

@@ -1,3 +1,3 @@
 module DebitechSoap
-  VERSION = "1.1.0"
+  VERSION = "1.2.0"
 end

data/spec/debitech_soap_spec.rb

@@ -35,23 +35,29 @@ describe DebitechSoap::API, "valid_credentials?" do
     SOAP::WSDLDriverFactory.stub!(:new).and_return(mock(Object, :create_rpc_driver => @client))
   end
 
-  it "should call checkSwedishPersNo with the credentials and a valid swedish social security number" do
-    @client.should_receive(:checkSwedishPersNo).with(:shopName => "merchant_name", :userName => "api_user_name",
-                                                     :password => "api_user_password", :persNo => "5555555555").
-                                                     and_return(mock(Object, :return => "true"))
+  it "should call 'refund' with the credentials and dummy values, returning true if we were authed but failed to refund" do
+    @client.should_receive(:refund).with(:shopName => "merchant_name", :userName => "api_user_name",
+                                                     :password => "api_user_password", :verifyID => -1, :amount => 0).
+                                                     and_return(mock(Object, :return => mock(Object, :resultText => "error_transID_or_verifyID")))
 
     api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
     api.valid_credentials?.should == true
   end
 
-  it "should return false if the service returns false" do
-    @client.stub!(:checkSwedishPersNo).and_return(mock(Object, :return => "false"))
+  it "should return false if the service returns an auth error" do
+    @client.stub!(:refund).and_return(mock(Object, :return => mock(Object, :resultText => "336 web_service_login_failed")))
     api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
     api.valid_credentials?.should == false
   end
 
+  it "raises if the service returns an unexpected result" do
+    @client.stub!(:refund).and_return(mock(Object, :return => mock(Object, :resultText => "let's have lunch")))
+    api = DebitechSoap::API.new(:merchant => "merchant_name", :username => "api_user_name", :password => "api_user_password")
+    expect { api.valid_credentials? }.to raise_error(%{Unexpected result text: "let's have lunch"})
+  end
+
   it "should work with Ruby 1.9 SOAP API" do
-    @client.stub!(:checkSwedishPersNo).and_return(mock(Object, :m_return => "true"))
+    @client.stub!(:refund).and_return(mock(Object, :m_return => mock(Object, :resultText => "error_transID_or_verifyID")))
     api = DebitechSoap::API.new
     api.valid_credentials?.should == true
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: debitech_soap
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Joakim Kolsjö
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-15 00:00:00.000000000 Z
+date: 2017-12-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpclient
@@ -143,8 +143,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A pure ruby way to make payments with DebiTech
-test_files: []
+test_files:
+- spec/debitech_soap_spec.rb