debitech_soap 0.0.4 → 0.0.5

data/CHANGELOG

@@ -1,3 +1,7 @@
+0.0.5
+
+Added timeout handling. Timeouts now return 403 so that you can retry.
+
 0.0.4
 
 Ruby 1.9 compability. Support for both the standard library soap implementation and soap4r.

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    debitech_soap (0.0.4)
+    debitech_soap (0.0.5)
       mumboe-soap4r (~> 1.5.8.4)
 
 GEM

data/README.markdown

@@ -46,7 +46,6 @@ Gotchas
 
 - We have only used the following methods in production: askIf3DSEnrolled, authorize3DS, authorize, subscribeAndSettle, checkSwedishPersNo, authorizeAndSettle.
 - The other methods should work, but have not been tested.
-- It does not handle timeouts as-is.
 
 API docs
 ----

data/debitech_soap.gemspec

@@ -6,7 +6,7 @@ Gem::Specification.new do |s|
   s.name        = "debitech_soap"
   s.version     = DebitechSoap::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.authors     = ["Joakim Kolsjö", 'Niklas Holmgren', 'Henrik Nyh']
+  s.authors     = ["Joakim Kolsjö", 'Niklas Holmgren', 'Henrik Nyh', 'Daniel Eriksson']
   s.email       = ["joakim.kolsjo@gmail.com", 'niklas.holmgren@bukowskis.com', 'henrik@barsoom.se']
   s.homepage    = "http://github.com/joakimk/debitech_soap"
   s.summary     = %q{A pure ruby way to make payments with DebiTech}

data/lib/debitech_soap.rb

@@ -67,10 +67,15 @@ module DebitechSoap
               args.each_with_index { |argument, i|
                 attributes[parameter_order[i].to_sym] = argument
               }
+            end            
+            begin
+              client_result = return_value(@client.send(api_signature(method).first.first, attributes))
+            rescue Timeout::Error
+              client_result = OpenStruct.new(:resultCode => 403, :resultText => "SOAP Timeout")
+              return return_data(client_result)
             end
-
-            return_data return_value(@client.send(api_signature(method).first.first, attributes))
-          end                                                             # end
+            return_data(client_result)
+          end
         end
       }
     end
@@ -88,7 +93,6 @@ module DebitechSoap
           hash[attribute.underscore] = result
         end
       }
-
       OpenStruct.new(hash)
     end
 

data/lib/debitech_soap/version.rb

@@ -1,3 +1,3 @@
 module DebitechSoap
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/debitech_soap_spec.rb

@@ -177,3 +177,19 @@ describe DebitechSoap::API, "calling a method with hash-style arguments" do
 
 end
 
+describe DebitechSoap::API, "handling exceptions" do
+
+  before do
+    @client = mock(Object)
+    SOAP::WSDLDriverFactory.stub!(:new).and_return(mock(Object, :create_rpc_driver => @client))
+  end
+
+  it "should catch Timeout::Error and return 403" do
+    api = DebitechSoap::API.new
+    @client.stub!("refund").and_raise(Timeout::Error)
+    result = api.refund(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra")
+    result.getResultCode.should == 403
+    result.getResultText.should == "SOAP Timeout"
+  end
+  
+end

metadata

@@ -1,18 +1,19 @@
 --- !ruby/object:Gem::Specification 
 name: debitech_soap
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: 
   segments: 
   - 0
   - 0
-  - 4
-  version: 0.0.4
+  - 5
+  version: 0.0.5
 platform: ruby
 authors: 
 - "Joakim Kolsj\xC3\xB6"
 - Niklas Holmgren
 - Henrik Nyh
+- Daniel Eriksson
 autorequire: 
 bindir: bin
 cert_chain: []