debitech_soap 0.0.3 → 0.0.4

data/.travis.yml

@@ -0,0 +1,3 @@
+rvm:
+  - ree
+

data/CHANGELOG

@@ -1,3 +1,7 @@
+0.0.4
+
+Ruby 1.9 compability. Support for both the standard library soap implementation and soap4r.
+
 0.0.3
 
 Added support for Java style method names.

data/Gemfile.lock

@@ -1,28 +1,37 @@
 PATH
   remote: .
   specs:
-    debitech_soap (0.0.2)
+    debitech_soap (0.0.4)
+      mumboe-soap4r (~> 1.5.8.4)
 
 GEM
   remote: http://rubygems.org/
   specs:
-    ZenTest (4.4.2)
-    autotest (4.4.6)
-      ZenTest (>= 4.4.1)
-    diff-lcs (1.1.2)
-    rspec (2.3.0)
-      rspec-core (~> 2.3.0)
-      rspec-expectations (~> 2.3.0)
-      rspec-mocks (~> 2.3.0)
-    rspec-core (2.3.1)
-    rspec-expectations (2.3.0)
+    diff-lcs (1.1.3)
+    guard (0.8.8)
+      thor (~> 0.14.6)
+    guard-rspec (0.5.0)
+      guard (>= 0.8.4)
+    httpclient (2.2.2)
+    mumboe-soap4r (1.5.8.4)
+      httpclient (>= 2.1.1)
+    rake (0.9.2)
+    rspec (2.7.0)
+      rspec-core (~> 2.7.0)
+      rspec-expectations (~> 2.7.0)
+      rspec-mocks (~> 2.7.0)
+    rspec-core (2.7.1)
+    rspec-expectations (2.7.0)
       diff-lcs (~> 1.1.2)
-    rspec-mocks (2.3.0)
+    rspec-mocks (2.7.0)
+    thor (0.14.6)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
-  autotest
   debitech_soap!
+  guard
+  guard-rspec
+  rake
   rspec

data/Guardfile

@@ -0,0 +1,5 @@
+guard 'rspec', :version => 2, :cli => "--color" do
+  watch(%r{^spec/.+_spec\.rb$})
+  watch(%r{^lib/(.+)\.rb$})     { |m| "spec" }
+end
+

data/README.markdown

@@ -1,11 +1,3 @@
-Work in progress!
-----
-
-This is **work in progress and not usable yet**. [Readme Driven Development](http://tom.preston-werner.com/2010/08/23/readme-driven-development.html)... 
-
-WIP docs below
-----
-
 This is a wrapper of the DebiTech SOAP API. It's intended to be API compatible with the DebiTech Java client but also supports a more developer friendly syntax :).
 
 Installing
@@ -49,13 +41,19 @@ Return data
 - Each attribute has serveral methods, for example "infoCode" can also be "getInfoCode" or "get_info_code".
 - If the return value is a number it will be converted to an integer.
 
+Gotchas
+----
+
+- We have only used the following methods in production: askIf3DSEnrolled, authorize3DS, authorize, subscribeAndSettle, checkSwedishPersNo, authorizeAndSettle.
+- The other methods should work, but have not been tested.
+- It does not handle timeouts as-is.
+
 API docs
 ----
 
 Get DIBSServerManual.pdf from the DIBS Manager.
 
-Known issues
+CI
 ----
 
-- Does not work with Ruby 1.9 (does not have "soap/wsdlDriver"). We have not been able to get "savon" to work.
-
+- DebitechSoap is continuously tested for compability with Ruby 1.9.3 (preview 1), Ruby 1.8.7 and JRuby 1.6.2.

data/debitech_soap.gemspec

@@ -6,14 +6,18 @@ Gem::Specification.new do |s|
   s.name        = "debitech_soap"
   s.version     = DebitechSoap::VERSION
   s.platform    = Gem::Platform::RUBY
-  s.authors     = ["Joakim Kolsjö", 'Niklas Holmgren']
-  s.email       = ["joakim.kolsjo@gmail.com", 'niklas.holmgren@bukowskis.com']
+  s.authors     = ["Joakim Kolsjö", 'Niklas Holmgren', 'Henrik Nyh']
+  s.email       = ["joakim.kolsjo@gmail.com", 'niklas.holmgren@bukowskis.com', 'henrik@barsoom.se']
   s.homepage    = "http://github.com/joakimk/debitech_soap"
   s.summary     = %q{A pure ruby way to make payments with DebiTech}
   s.description = %q{An implementation of the DebiTech Java API using pure ruby and the SOAP API.}
 
+  s.add_dependency "mumboe-soap4r", "~> 1.5.8.4"
+
+  s.add_development_dependency "rake"
   s.add_development_dependency 'rspec'
-  s.add_development_dependency 'autotest'
+  s.add_development_dependency "guard"
+  s.add_development_dependency "guard-rspec"
 
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")

data/lib/debitech_soap.rb

@@ -1,6 +1,5 @@
 require 'soap/wsdlDriver'
 require 'ostruct'
-require 'rubygems'
 require 'debitech_soap/string_extensions'
 
 module DebitechSoap
@@ -42,12 +41,19 @@ module DebitechSoap
 
     def valid_credentials?
       disable_stderr do
-        @client.checkSwedishPersNo(@api_credentials.merge({ :persNo => "555555-5555" })).return == "true"
+        return_value(@client.checkSwedishPersNo(@api_credentials.merge({ :persNo => "555555-5555" }))) == "true"
       end
     end
 
   private
 
+    # We use mumboe-soap4r for Ruby 1.9 compatibility, but if you use this library in 1.8 without using that lib
+    # (e.g. without bundle exec) then you might get the standard library SOAP lib instead.
+    # The standard library SOAP lib uses "return" here, and mumboe-soap4r uses "m_return".
+    def return_value(object)
+      object.respond_to?(:m_return) ? object.m_return : object.return
+    end
+
     def define_java_wrapper_methods!
       PARAMS.keys.flatten.each { |method|
         (class << self; self; end).class_eval do                          # Doc:
@@ -63,7 +69,7 @@ module DebitechSoap
               }
             end
 
-            return_data @client.send(api_signature(method).first.first, attributes).return
+            return_data return_value(@client.send(api_signature(method).first.first, attributes))
           end                                                             # end
         end
       }

data/lib/debitech_soap/version.rb

@@ -1,3 +1,3 @@
 module DebitechSoap
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/debitech_soap_spec.rb

@@ -12,6 +12,14 @@ class MockSoapResult
   end
 end
 
+class MockSoapResultRuby19
+  class MockReturn < MockSoapResult::MockReturn; end
+
+  def m_return
+    @return ||= MockReturn.new
+  end
+end
+
 describe DebitechSoap::API, "valid_credentials?" do
   
   before do
@@ -34,6 +42,12 @@ describe DebitechSoap::API, "valid_credentials?" do
     api.valid_credentials?.should == false
   end
 
+  it "should work with Ruby 1.9 SOAP API" do
+    @client.stub!(:checkSwedishPersNo).and_return(mock(Object, :m_return => "true"))
+    api = DebitechSoap::API.new
+    api.valid_credentials?.should == true
+  end
+
 end
 
 describe DebitechSoap::API, "calling a method with java-style arguments" do
@@ -118,6 +132,15 @@ describe DebitechSoap::API, "calling a method with java-style arguments" do
     result.resultCode.should == 0
   end
 
+  it "should work with Ruby 1.9 SOAP API" do
+    api = DebitechSoap::API.new
+    mock_soap_result = MockSoapResultRuby19.new
+    mock_soap_result.m_return.stub!(:resultCode).and_return("0")
+    @client.stub!("refund").and_return(mock_soap_result)
+    result = api.refund(1234567, 23456, 100, "extra")
+    result.resultCode.should == 0
+  end
+
 end
 
 describe DebitechSoap::API, "calling a method with hash-style arguments" do
@@ -143,5 +166,14 @@ describe DebitechSoap::API, "calling a method with hash-style arguments" do
     api.refund(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra").getResultText.should == "success"
   end
 
+  it "should work with Ruby 1.9 SOAP API" do
+    api = DebitechSoap::API.new
+    mock_soap_result = MockSoapResultRuby19.new
+    mock_soap_result.m_return.stub!(:resultText).and_return("success")
+    @client.stub!("refund").and_return(mock_soap_result)
+    result = api.refund(:verifyID => 1234567, :transID => 23456, :amount => 100, :extra => "extra")
+    result.getResultText.should == "success"
+  end
+
 end
 

metadata

@@ -1,28 +1,46 @@
 --- !ruby/object:Gem::Specification 
 name: debitech_soap
 version: !ruby/object:Gem::Version 
-  hash: 25
+  hash: 23
   prerelease: 
   segments: 
   - 0
   - 0
-  - 3
-  version: 0.0.3
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - "Joakim Kolsj\xC3\xB6"
 - Niklas Holmgren
+- Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
 
-date: 2011-01-27 00:00:00 +01:00
+date: 2011-10-24 00:00:00 +02:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
-  name: rspec
+  name: mumboe-soap4r
   prerelease: false
   requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ~>
+      - !ruby/object:Gem::Version 
+        hash: 95
+        segments: 
+        - 1
+        - 5
+        - 8
+        - 4
+        version: 1.5.8.4
+  type: :runtime
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: rake
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -32,11 +50,11 @@ dependencies:
         - 0
         version: "0"
   type: :development
-  version_requirements: *id001
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: autotest
+  name: rspec
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
@@ -46,11 +64,40 @@ dependencies:
         - 0
         version: "0"
   type: :development
-  version_requirements: *id002
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: guard
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id004
+- !ruby/object:Gem::Dependency 
+  name: guard-rspec
+  prerelease: false
+  requirement: &id005 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id005
 description: An implementation of the DebiTech Java API using pure ruby and the SOAP API.
 email: 
 - joakim.kolsjo@gmail.com
 - niklas.holmgren@bukowskis.com
+- henrik@barsoom.se
 executables: []
 
 extensions: []
@@ -60,13 +107,14 @@ extra_rdoc_files: []
 files: 
 - .gitignore
 - .rvmrc
+- .travis.yml
 - CHANGELOG
 - Gemfile
 - Gemfile.lock
+- Guardfile
 - LICENCE
 - README.markdown
 - Rakefile
-- autotest/discover.rb
 - debitech_soap.gemspec
 - lib/debitech_soap.rb
 - lib/debitech_soap/string_extensions.rb
@@ -102,7 +150,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.4.1
+rubygems_version: 1.5.3
 signing_key: 
 specification_version: 3
 summary: A pure ruby way to make payments with DebiTech

data/autotest/discover.rb

@@ -1 +0,0 @@
-Autotest.add_discovery { "rspec2" }